[PATCH v7 net-next 14/14] net: enetc: add loopback support for i.MX95 ENETC PF

2025-05-06 Thread Wei Fang
Add internal loopback support for i.MX95 ENETC PF, the default loopback mode is MAC level loopback, the MAC Tx data is looped back onto the Rx. The MAC interface runs at a fixed 1:8 ratio of NETC clock in MAC-level loopback mode, with no dependency on Tx clock. Signed-off-by: Wei Fang Reviewed

[PATCH v7 net-next 13/14] net: enetc: add VLAN filtering support for i.MX95 ENETC PF

2025-05-06 Thread Wei Fang
enetc_vlan_rx_del_vid(). In addition, the VLAN promiscuous mode will be enabled if VLAN filtering is disabled, which means that PF qualifies for reception of all VLAN tags. Signed-off-by: Wei Fang Reviewed-by: Vladimir Oltean --- .../net/ethernet/freescale/enetc/enetc4_hw.h | 4 +++ .../net/ethernet

[PATCH v7 net-next 12/14] net: enetc: move generic VLAN hash filter functions to enetc_pf_common.c

2025-05-06 Thread Wei Fang
v4. Currently, we just move these functions from enetc_pf.c to enetc_pf_common.c. Appropriate modifications will be made for ENETC4 in a subsequent patch. Signed-off-by: Wei Fang Reviewed-by: Vladimir Oltean --- .../net/ethernet/freescale/enetc/enetc_pf.c | 57

[PATCH v7 net-next 11/14] net: enetc: extract enetc_refresh_vlan_ht_filter()

2025-05-06 Thread Wei Fang
Extract the common function enetc_refresh_vlan_ht_filter() from enetc_sync_vlan_ht_filter() so that it can be reused by the ENETC v4 PF and VF drivers in the future. Signed-off-by: Wei Fang Reviewed-by: Vladimir Oltean --- .../net/ethernet/freescale/enetc/enetc_pf.c | 20

[PATCH v7 net-next 10/14] net: enetc: enable RSS feature by default

2025-05-06 Thread Wei Fang
improved when then network is enabled. Signed-off-by: Wei Fang Acked-by: Vladimir Oltean --- drivers/net/ethernet/freescale/enetc/enetc.c | 31 ++- .../freescale/enetc/enetc_pf_common.c | 4 ++- .../net/ethernet/freescale/enetc/enetc_vf.c | 4 ++- 3 files changed, 23

[PATCH v7 net-next 09/14] net: enetc: change enetc_set_rss() to void type

2025-05-06 Thread Wei Fang
Actually enetc_set_rss() does not need a return value, so change its type to void. Signed-off-by: Wei Fang Reviewed-by: Vladimir Oltean --- drivers/net/ethernet/freescale/enetc/enetc.c | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) diff --git a/drivers/net/ethernet/freescale/enetc

[PATCH v7 net-next 08/14] net: enetc: add RSS support for i.MX95 ENETC PF

2025-05-06 Thread Wei Fang
interfaces are compatible with i.MX95. So it's time to add RSS support to i.MX95 ENETC PF. Signed-off-by: Wei Fang Reviewed-by: Vladimir Oltean --- drivers/net/ethernet/freescale/enetc/enetc.c | 5 +- drivers/net/ethernet/freescale/enetc/enetc.h | 2 + .../net/ethernet/freescale/enetc/enetc4

[PATCH v7 net-next 07/14] net: enetc: make enetc_set_rss_key() reusable

2025-05-06 Thread Wei Fang
Since the offset of the RSS key registers of i.MX95 ENETC is different from that of LS1028A, so add enetc_get_rss_key_base() to get the base offset for the different chips, so that enetc_set_rss_key() can be reused for this trivial thing. Signed-off-by: Wei Fang Reviewed-by: Vladimir Oltean

[PATCH v7 net-next 06/14] net: enetc: add set/get_rss_table() hooks to enetc_si_ops

2025-05-06 Thread Wei Fang
Since i.MX95 ENETC (v4) uses NTMP 2.0 to manage the RSS table, which is different from LS1028A ENETC (v1). In order to reuse some functions related to the RSS table, so add .get_rss_table() and .set_rss_table() hooks to enetc_si_ops. Signed-off-by: Wei Fang Reviewed-by: Vladimir Oltean

[PATCH v7 net-next 05/14] net: enetc: add debugfs interface to dump MAC filter

2025-05-06 Thread Wei Fang
memory and needs to be read through command BD ring. In order to facilitate debugging, added a debugfs interface to get the relevant information about MAC filter. Signed-off-by: Wei Fang Reviewed-by: Vladimir Oltean --- drivers/net/ethernet/freescale/enetc/Makefile | 1 + drivers/net/ethernet

[PATCH v7 net-next 04/14] net: enetc: add MAC filtering for i.MX95 ENETC PF

2025-05-06 Thread Wei Fang
will be supported in subsequent patches. Signed-off-by: Wei Fang Reviewed-by: Vladimir Oltean --- drivers/net/ethernet/freescale/enetc/enetc.h | 3 + .../net/ethernet/freescale/enetc/enetc4_hw.h | 8 + .../net/ethernet/freescale/enetc/enetc4_pf.c | 260 ++ .../net/ethernet

[PATCH v7 net-next 03/14] net: enetc: move generic MAC filtering interfaces to enetc-core

2025-05-06 Thread Wei Fang
. In order to add the MAC address filtering support for the ENETC v4 PF driver and VF driver in the future, the relevant generic interfaces are moved to the enetc-core driver. This lays the basis for i.MX95 ENETC PF and VFs to support MAC address filtering. Signed-off-by: Wei Fang Reviewed-by

[PATCH v7 net-next 02/14] net: enetc: add command BD ring support for i.MX95 ENETC

2025-05-06 Thread Wei Fang
software processing logic is also different. So add enetc4_setup_cbdr() and enetc4_teardown_cbdr() for ENETC v4 drivers. Signed-off-by: Wei Fang Reviewed-by: Vladimir Oltean --- drivers/net/ethernet/freescale/enetc/enetc.h | 9 - .../net/ethernet/freescale/enetc/enetc4_pf.c | 39

[PATCH v7 net-next 01/14] net: enetc: add initial netc-lib driver to support NTMP

2025-05-06 Thread Wei Fang
-based generic interfaces for ENETC and NETC Switch drivers. Currently, it only supports the configurations of some tables. Interfaces such as tc flower and debugfs will be added in the future. Signed-off-by: Wei Fang Reviewed-by: Vladimir Oltean --- MAINTAINERS

[PATCH v7 net-next 00/14] Add more features for ENETC v4 - round 2

2025-05-06 Thread Wei Fang
...@nxp.com/ v6 Link: https://lore.kernel.org/imx/20250428105657.3283130-1-wei.f...@nxp.com/ v7 changes: 1. Replace debugfs_remove_recursive() with debugfs_remove() 2. Collect tags --- Wei Fang (14): net: enetc: add initial netc-lib driver to support NTMP net: enetc: add command BD ring support

RE: [PATCH v6 net-next 05/14] net: enetc: add debugfs interface to dump MAC filter

2025-04-29 Thread Wei Fang
> [Some people who received this message don't often get email from > ti...@kernel.org. Learn why this is important at > https://aka.ms/LearnAboutSenderIdentification ] > > On Mon, Apr 28, 2025 at 6:19 AM Wei Fang wrote: > > +void enetc_remove_d

[PATCH v6 net-next 14/14] net: enetc: add loopback support for i.MX95 ENETC PF

2025-04-28 Thread Wei Fang
Add internal loopback support for i.MX95 ENETC PF, the default loopback mode is MAC level loopback, the MAC Tx data is looped back onto the Rx. The MAC interface runs at a fixed 1:8 ratio of NETC clock in MAC-level loopback mode, with no dependency on Tx clock. Signed-off-by: Wei Fang --- v5, v6

[PATCH v6 net-next 13/14] net: enetc: add VLAN filtering support for i.MX95 ENETC PF

2025-04-28 Thread Wei Fang
enetc_vlan_rx_del_vid(). In addition, the VLAN promiscuous mode will be enabled if VLAN filtering is disabled, which means that PF qualifies for reception of all VLAN tags. Signed-off-by: Wei Fang --- v5 changes 1. Remove set_si_vlan_hash_filter() hook 2. Refator enetc_set_vlan_ht_filter() and rename it to

[PATCH v6 net-next 12/14] net: enetc: move generic VLAN hash filter functions to enetc_pf_common.c

2025-04-28 Thread Wei Fang
v4. Currently, we just move these functions from enetc_pf.c to enetc_pf_common.c. Appropriate modifications will be made for ENETC4 in a subsequent patch. Signed-off-by: Wei Fang --- v5 changes Remove set_si_vlan_hash_filter() hook v6: no changes --- .../net/ethernet/freescale/enetc/enetc_pf.c

[PATCH v6 net-next 11/14] net: enetc: extract enetc_refresh_vlan_ht_filter()

2025-04-28 Thread Wei Fang
Extract the common function enetc_refresh_vlan_ht_filter() from enetc_sync_vlan_ht_filter() so that it can be reused by the ENETC v4 PF and VF drivers in the future. Signed-off-by: Wei Fang --- v5: New patch v6: no changes --- .../net/ethernet/freescale/enetc/enetc_pf.c | 20

[PATCH v6 net-next 10/14] net: enetc: enable RSS feature by default

2025-04-28 Thread Wei Fang
improved when then network is enabled. Signed-off-by: Wei Fang --- v5 changes: Just rebase it based on patch 9. v6: no changes --- drivers/net/ethernet/freescale/enetc/enetc.c | 31 ++- .../freescale/enetc/enetc_pf_common.c | 4 ++- .../net/ethernet/freescale/enetc/enetc_vf.c

[PATCH v6 net-next 09/14] net: enetc: change enetc_set_rss() to void type

2025-04-28 Thread Wei Fang
Actually enetc_set_rss() does not need a return value, so change its type to void. Signed-off-by: Wei Fang Acked-by: Vladimir Oltean --- v5 changes: New patch, suggested by Vladimir v6: no changes --- drivers/net/ethernet/freescale/enetc/enetc.c | 4 +--- 1 file changed, 1 insertion(+), 3

[PATCH v6 net-next 08/14] net: enetc: add RSS support for i.MX95 ENETC PF

2025-04-28 Thread Wei Fang
interfaces are compatible with i.MX95. So it's time to add RSS support to i.MX95 ENETC PF. Signed-off-by: Wei Fang --- v5 changes: 1. Add comments for enetc4_get_rxnfc() 2. Modify enetc4_set_rss_table() and enetc4_get_rss_table() v6: no changes --- drivers/net/ethernet/freescale/enetc/enetc.c

[PATCH v6 net-next 07/14] net: enetc: make enetc_set_rss_key() reusable

2025-04-28 Thread Wei Fang
Since the offset of the RSS key registers of i.MX95 ENETC is different from that of LS1028A, so add enetc_get_rss_key_base() to get the base offset for the different chips, so that enetc_set_rss_key() can be reused for this trivial thing. Signed-off-by: Wei Fang --- v5 changes: Add

[PATCH v6 net-next 06/14] net: enetc: add set/get_rss_table() hooks to enetc_si_ops

2025-04-28 Thread Wei Fang
Since i.MX95 ENETC (v4) uses NTMP 2.0 to manage the RSS table, which is different from LS1028A ENETC (v1). In order to reuse some functions related to the RSS table, so add .get_rss_table() and .set_rss_table() hooks to enetc_si_ops. Signed-off-by: Wei Fang --- v5, v6: no changes --- drivers

[PATCH v6 net-next 05/14] net: enetc: add debugfs interface to dump MAC filter

2025-04-28 Thread Wei Fang
memory and needs to be read through command BD ring. In order to facilitate debugging, added a debugfs interface to get the relevant information about MAC filter. Signed-off-by: Wei Fang --- v5 changes: 1. Replace is_en() with str_enabled_disabled() 2. Remove superfluous "Show" in the

[PATCH v6 net-next 04/14] net: enetc: add MAC filtering for i.MX95 ENETC PF

2025-04-28 Thread Wei Fang
will be supported in subsequent patches. Signed-off-by: Wei Fang --- v5 changes: 1. Refactor enetc4_pf_set_si_mac_promisc() 2. Split enetc4_pf_set_si_mac_hash_filter() into enetc4_pf_set_si_uc_hash_filter() and enetc4_pf_set_si_mc_hash_filter() 3. Rename enetc4_pf_wq_task_init() to

[PATCH v6 net-next 03/14] net: enetc: move generic MAC filtering interfaces to enetc-core

2025-04-28 Thread Wei Fang
. In order to add the MAC address filtering support for the ENETC v4 PF driver and VF driver in the future, the relevant generic interfaces are moved to the enetc-core driver. This lays the basis for i.MX95 ENETC PF and VFs to support MAC address filtering. Signed-off-by: Wei Fang Reviewed-by

[PATCH v6 net-next 02/14] net: enetc: add command BD ring support for i.MX95 ENETC

2025-04-28 Thread Wei Fang
software processing logic is also different. So add enetc4_setup_cbdr() and enetc4_teardown_cbdr() for ENETC v4 drivers. Signed-off-by: Wei Fang --- v5 changes: 1. Remove setup_cbdr() and teardown_cbdr() hooks 2. Rename enetc4_init_ntmp_priv() to enetc4_init_ntmp_user() 3. Modify the commit message

[PATCH v6 net-next 00/14] Add more features for ENETC v4 - round 2

2025-04-28 Thread Wei Fang
...@nxp.com/ --- Wei Fang (14): net: enetc: add initial netc-lib driver to support NTMP net: enetc: add command BD ring support for i.MX95 ENETC net: enetc: move generic MAC filtering interfaces to enetc-core net: enetc: add MAC filtering for i.MX95 ENETC PF net: enetc: add debugfs interface

[PATCH v6 net-next 01/14] net: enetc: add initial netc-lib driver to support NTMP

2025-04-28 Thread Wei Fang
-based generic interfaces for ENETC and NETC Switch drivers. Currently, it only supports the configurations of some tables. Interfaces such as tc flower and debugfs will be added in the future. Signed-off-by: Wei Fang --- v5 changes: 1. Add the change of MAINTAINERS to this patch 2. Rename

RE: [PATCH v5 net-next 04/14] net: enetc: add MAC filtering for i.MX95 ENETC PF

2025-04-20 Thread Wei Fang
> On Fri, Apr 11, 2025 at 05:57:42PM +0800, Wei Fang wrote: > > static const struct enetc_pf_ops enetc4_pf_ops = { > > .set_si_primary_mac = enetc4_pf_set_si_primary_mac, > > .get_si_primary_mac = enetc4_pf_get_si_primary_mac, > > @@ -303,12 +489,55 @@ static

RE: [PATCH v5 net-next 02/14] net: enetc: add command BD ring support for i.MX95 ENETC

2025-04-18 Thread Wei Fang
> -Original Message- > From: Vladimir Oltean > Sent: 2025年4月18日 21:25 > To: Wei Fang > Cc: Claudiu Manoil ; Vladimir Oltean > ; Clark Wang ; > andrew+net...@lunn.ch; da...@davemloft.net; eduma...@google.com; > k...@kernel.org; pab...@redhat.com; christophe

RE: [PATCH v5 net-next 01/14] net: enetc: add initial netc-lib driver to support NTMP

2025-04-18 Thread Wei Fang
> I see this is "Changes requested", so here are some more nitpicks from me. > > On Fri, Apr 11, 2025 at 05:57:39PM +0800, Wei Fang wrote: > > Some NETC functionality is controlled using control messages sent to the > > hardware using BD ring interface with 32B

RE: [PATCH v5 net-next 04/14] net: enetc: add MAC filtering for i.MX95 ENETC PF

2025-04-15 Thread Wei Fang
> -Original Message- > From: Jakub Kicinski > Sent: 2025年4月16日 11:43 > To: Wei Fang > Cc: Claudiu Manoil ; Vladimir Oltean > ; Clark Wang ; > andrew+net...@lunn.ch; da...@davemloft.net; eduma...@google.com; > pab...@redhat.com; christophe.le...@csgroup.eu; net...@

RE: [PATCH v5 net-next 06/14] net: enetc: add set/get_rss_table() hooks to enetc_si_ops

2025-04-15 Thread Wei Fang
> On 4/11/25 11:57 AM, Wei Fang wrote: > > Since i.MX95 ENETC (v4) uses NTMP 2.0 to manage the RSS table, which > > is different from LS1028A ENETC (v1). In order to reuse some functions > > related to the RSS table, so add .get_rss_table() and .set_rss_table() >

[PATCH v5 net-next 13/14] net: enetc: add VLAN filtering support for i.MX95 ENETC PF

2025-04-11 Thread Wei Fang
enetc_vlan_rx_del_vid(). In addition, the VLAN promiscuous mode will be enabled if VLAN filtering is disabled, which means that PF qualifies for reception of all VLAN tags. Signed-off-by: Wei Fang --- v5 changes 1. Remove set_si_vlan_hash_filter() hook 2. Refator enetc_set_vlan_ht_filter() and rename it to

[PATCH v5 net-next 14/14] net: enetc: add loopback support for i.MX95 ENETC PF

2025-04-11 Thread Wei Fang
Add internal loopback support for i.MX95 ENETC PF, the default loopback mode is MAC level loopback, the MAC Tx data is looped back onto the Rx. The MAC interface runs at a fixed 1:8 ratio of NETC clock in MAC-level loopback mode, with no dependency on Tx clock. Signed-off-by: Wei Fang --- v5: no

[PATCH v5 net-next 12/14] net: enetc: move generic VLAN hash filter functions to enetc_pf_common.c

2025-04-11 Thread Wei Fang
v4. Currently, we just move these functions from enetc_pf.c to enetc_pf_common.c. Appropriate modifications will be made for ENETC4 in a subsequent patch. Signed-off-by: Wei Fang --- v5 changes Remove set_si_vlan_hash_filter() hook --- .../net/ethernet/freescale/enetc/enetc_pf.c | 57

[PATCH v5 net-next 09/14] net: enetc: change enetc_set_rss() to void type

2025-04-11 Thread Wei Fang
Actually enetc_set_rss() does not need a return value, so change its type to void. Signed-off-by: Wei Fang Acked-by: Vladimir Oltean --- v5 changes: New patch, suggested by Vladimir --- drivers/net/ethernet/freescale/enetc/enetc.c | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) diff

[PATCH v5 net-next 11/14] net: enetc: extract enetc_refresh_vlan_ht_filter()

2025-04-11 Thread Wei Fang
Extract the common function enetc_refresh_vlan_ht_filter() from enetc_sync_vlan_ht_filter() so that it can be reused by the ENETC v4 PF and VF drivers in the future. Signed-off-by: Wei Fang --- v5 changes New patch --- .../net/ethernet/freescale/enetc/enetc_pf.c | 20 --- 1

[PATCH v5 net-next 10/14] net: enetc: enable RSS feature by default

2025-04-11 Thread Wei Fang
improved when then network is enabled. Signed-off-by: Wei Fang --- v5 changes: Just rebase it based on patch 9. --- drivers/net/ethernet/freescale/enetc/enetc.c | 31 ++- .../freescale/enetc/enetc_pf_common.c | 4 ++- .../net/ethernet/freescale/enetc/enetc_vf.c | 4 ++- 3

[PATCH v5 net-next 08/14] net: enetc: add RSS support for i.MX95 ENETC PF

2025-04-11 Thread Wei Fang
interfaces are compatible with i.MX95. So it's time to add RSS support to i.MX95 ENETC PF. Signed-off-by: Wei Fang --- 1. Add comments for enetc4_get_rxnfc() 2. Modify enetc4_set_rss_table() and enetc4_get_rss_table() --- drivers/net/ethernet/freescale/enetc/enetc.c | 5 +- drivers/net/eth

[PATCH v5 net-next 07/14] net: enetc: make enetc_set_rss_key() reusable

2025-04-11 Thread Wei Fang
Since the offset of the RSS key registers of i.MX95 ENETC is different from that of LS1028A, so add enetc_get_rss_key_base() to get the base offset for the different chips, so that enetc_set_rss_key() can be reused for this trivial thing. Signed-off-by: Wei Fang --- drivers/net/ethernet

[PATCH v5 net-next 06/14] net: enetc: add set/get_rss_table() hooks to enetc_si_ops

2025-04-11 Thread Wei Fang
Since i.MX95 ENETC (v4) uses NTMP 2.0 to manage the RSS table, which is different from LS1028A ENETC (v1). In order to reuse some functions related to the RSS table, so add .get_rss_table() and .set_rss_table() hooks to enetc_si_ops. Signed-off-by: Wei Fang --- v5 changes: Add

[PATCH v5 net-next 04/14] net: enetc: add MAC filtering for i.MX95 ENETC PF

2025-04-11 Thread Wei Fang
will be supported in subsequent patches. Signed-off-by: Wei Fang --- v5 changes: 1. Refactor enetc4_pf_set_si_mac_promisc() 2. Split enetc4_pf_set_si_mac_hash_filter() into enetc4_pf_set_si_uc_hash_filter() and enetc4_pf_set_si_mc_hash_filter() 3. Rename enetc4_pf_wq_task_init() to

[PATCH v5 net-next 05/14] net: enetc: add debugfs interface to dump MAC filter

2025-04-11 Thread Wei Fang
memory and needs to be read through command BD ring. In order to facilitate debugging, added a debugfs interface to get the relevant information about MAC filter. Signed-off-by: Wei Fang --- v5 changes: 1. Replace is_en() with str_enabled_disabled() 2. Remove superfluous "Show" in the

[PATCH v5 net-next 01/14] net: enetc: add initial netc-lib driver to support NTMP

2025-04-11 Thread Wei Fang
tc flower and debugfs will be added in the future. Signed-off-by: Wei Fang --- v5 changes: 1. Add the change of MAINTAINERS to this patch 2. Rename ntmp_fill_request_headr() to ntmp_fill_request_hdr() 3. Split ntmp_rsst_query_or_update_entry() into ntmp_rsst_query_or_update_entry() and

[PATCH v5 net-next 03/14] net: enetc: move generic MAC filtering interfaces to enetc-core

2025-04-11 Thread Wei Fang
. In order to add the MAC address filtering support for the ENETC v4 PF driver and VF driver in the future, the relevant generic interfaces are moved to the enetc-core driver. This lays the basis for i.MX95 ENETC PF and VFs to support MAC address filtering. Signed-off-by: Wei Fang --- v5 changes

[PATCH v5 net-next 02/14] net: enetc: add command BD ring support for i.MX95 ENETC

2025-04-11 Thread Wei Fang
software processing logic is also different. So add enetc4_setup_cbdr() and enetc4_teardown_cbdr() for ENETC v4 drivers. Signed-off-by: Wei Fang --- v5 changes: 1. Remove setup_cbdr() and teardown_cbdr() hooks 2. Rename enetc4_init_ntmp_priv() to enetc4_init_ntmp_user() 3. Modify the commit message

[PATCH v5 net-next 00/14] Add more features for ENETC v4 - round 2

2025-04-11 Thread Wei Fang
: https://lore.kernel.org/imx/20250113082245.2332775-1-wei.f...@nxp.com/ v3 Link: https://lore.kernel.org/imx/20250304072201.1332603-1-wei.f...@nxp.com/ v4 Link: https://lore.kernel.org/imx/20250311053830.1516523-1-wei.f...@nxp.com/ --- Wei Fang (14): net: enetc: add initial netc-lib driver to

RE: [PATCH v4 net-next 11/14] net: enetc: move generic VLAN hash filter functions to enetc_pf_common.c

2025-03-18 Thread Wei Fang
> On Tue, Mar 11, 2025 at 01:38:27PM +0800, Wei Fang wrote: > > Since the VLAN hash filter of ENETC v1 and v4 is the basically same, the > > only difference is the offset of the VLAN hash filter registers. So, the > > .set_si_vlan_hash_filter() hook is added to struct enetc_

RE: [PATCH v4 net-next 04/14] net: enetc: add MAC filter for i.MX95 ENETC PF

2025-03-18 Thread Wei Fang
> > + > > +static void enetc4_pf_set_si_mac_hash_filter(struct enetc_hw *hw, int si, > > +int type, u64 hash) > > +{ > > + if (type == UC) { > > + enetc_port_wr(hw, ENETC4_PSIUMHFR0(si), lower_32_bits(hash)); > > + enetc_port_wr(hw, ENET

RE: [PATCH v4 net-next 08/14] net: enetc: add RSS support for i.MX95 ENETC PF

2025-03-18 Thread Wei Fang
> On Tue, Mar 18, 2025 at 06:47:11AM +0200, Wei Fang wrote: > > > These rxnfc commands seem implemented identically to the corresponding > > > subset from enetc_get_rxnfc(). Rather than duplicating those, could you > > > rather return -EOPNOTSUPP for the unsupporte

RE: [PATCH v4 net-next 04/14] net: enetc: add MAC filter for i.MX95 ENETC PF

2025-03-18 Thread Wei Fang
> On Tue, Mar 18, 2025 at 05:19:51AM +0200, Wei Fang wrote: > > You are right, but I'm afraid of the Coverity will report an issue, because > > the > > pf->mac_list and pf->num_mfe are protected by the mac_list_lock in other > > functions. And enetc4_pf_dest

RE: [PATCH v4 net-next 14/14] MAINTAINERS: add new file ntmp.h to ENETC driver

2025-03-17 Thread Wei Fang
> On Tue, Mar 11, 2025 at 01:38:30PM +0800, Wei Fang wrote: > > Add new file ntmp.h. to ENETC driver. > > > > Signed-off-by: Wei Fang > > --- > > MAINTAINERS | 1 + > > 1 file changed, 1 insertion(+) > > > > diff --git a/MAINTAINERS b/MAIN

RE: [PATCH v4 net-next 10/14] net: enetc: move generic VLAN filter interfaces to enetc-core

2025-03-17 Thread Wei Fang
> On Tue, Mar 11, 2025 at 01:38:26PM +0800, Wei Fang wrote: > > For ENETC, each SI has a corresponding VLAN hash table. That is to say, > > both PF and VFs can support VLAN filter. However, currently only ENETC v1 > > PF driver supports VLAN filter. In order to make i.MX95 ENE

RE: [PATCH v4 net-next 06/14] net: enetc: add set/get_rss_table() to enetc_si_ops

2025-03-17 Thread Wei Fang
> On Tue, Mar 11, 2025 at 01:38:22PM +0800, Wei Fang wrote: > > diff --git a/drivers/net/ethernet/freescale/enetc/enetc_vf.c > b/drivers/net/ethernet/freescale/enetc/enetc_vf.c > > index d7d9a720069b..072e5b40a199 100644 > > --- a/drivers/net/ethernet/freescale/enetc/enet

RE: [PATCH v4 net-next 09/14] net: enetc: enable RSS feature by default

2025-03-17 Thread Wei Fang
> On Tue, Mar 11, 2025 at 01:38:25PM +0800, Wei Fang wrote: > > Receive side scaling (RSS) is a network driver technology that enables > > the efficient distribution of network receive processing across > > multiple CPUs in multiprocessor systems. Therefore, it is better

RE: [PATCH v4 net-next 07/14] net: enetc: make enetc_set_rss_key() reusable

2025-03-17 Thread Wei Fang
> On Tue, Mar 11, 2025 at 01:38:23PM +0800, Wei Fang wrote: > > Since the offset of the RSS key registers of i.MX95 ENETC is different > > from that of LS1028A, so add enetc_get_rss_key_base() to get the base > > offset for the different chips, so that enetc_set_rss_key()

RE: [PATCH v4 net-next 08/14] net: enetc: add RSS support for i.MX95 ENETC PF

2025-03-17 Thread Wei Fang
> On Tue, Mar 11, 2025 at 01:38:24PM +0800, Wei Fang wrote: > > diff --git a/drivers/net/ethernet/freescale/enetc/enetc.h > b/drivers/net/ethernet/freescale/enetc/enetc.h > > index a3ce324c716c..ecf79338cd79 100644 > > --- a/drivers/net/ethernet/freescale/enetc/enetc

RE: [PATCH v4 net-next 05/14] net: enetc: add debugfs interface to dump MAC filter

2025-03-17 Thread Wei Fang
> On Tue, Mar 11, 2025 at 01:38:21PM +0800, Wei Fang wrote: > > diff --git a/drivers/net/ethernet/freescale/enetc/enetc4_debugfs.c > > b/drivers/net/ethernet/freescale/enetc/enetc4_debugfs.c > > new file mode 100644 > > index ..3a660c80344a > > --

RE: [PATCH v4 net-next 01/14] net: enetc: add initial netc-lib driver to support NTMP

2025-03-17 Thread Wei Fang
> On Mon, Mar 17, 2025 at 11:55:26AM +0200, Wei Fang wrote: > > Actually I did this is the original version, I mean in downstream kernel 6.6 > > tree. I add a "ntmp_mfe" in ntmp.h like below > > > > struct ntmp_mfe { > > u8 mac[ETH_ALEN]; &g

RE: [PATCH v4 net-next 01/14] net: enetc: add initial netc-lib driver to support NTMP

2025-03-17 Thread Wei Fang
> On Fri, Mar 14, 2025 at 03:48:21PM +0200, Wei Fang wrote: > > > I mean, I was just suggesting to group the macros with the macros, and > > > the struct fields with the struct fields. Mixing them together looks a > > > bit messy to me. Even worse in the defini

RE: [PATCH v4 net-next 03/14] net: enetc: move generic MAC filterng interfaces to enetc-core

2025-03-17 Thread Wei Fang
> title: s/filterng/filtering/ > > On Tue, Mar 11, 2025 at 01:38:19PM +0800, Wei Fang wrote: > > Although only ENETC PF can access the MAC address filter table, the table > > entries can specify MAC address filtering for one or more SIs based on > > SI_BITMAP, whic

RE: [PATCH v3 net-next 04/13] net: enetc: add MAC filter for i.MX95 ENETC PF

2025-03-15 Thread Wei Fang
> On 3/4/25 8:21 AM, Wei Fang wrote: > > +static void enetc_mac_list_del_matched_entries(struct enetc_pf *pf, u16 > si_bit, > > + struct enetc_mac_addr *mac, > > + int mac_cn

RE: [PATCH v4 net-next 02/14] net: enetc: add command BD ring support for i.MX95 ENETC

2025-03-14 Thread Wei Fang
> On Fri, Mar 14, 2025 at 06:51:06AM +0200, Wei Fang wrote: > > > I don't understand the need for si->ops->setup_cbdr() and > > > si->ops->teardown_cbdr()? > > > Doesn't every call site know which kind of SI it is dealing with, and > >

RE: [PATCH v4 net-next 01/14] net: enetc: add initial netc-lib driver to support NTMP

2025-03-14 Thread Wei Fang
Best Regards, Wei Fang > -Original Message- > From: Vladimir Oltean > On Fri, Mar 14, 2025 at 05:38:18AM +0200, Wei Fang wrote: > > > > + __le16 update_act; > > > > + u8 dbg_opt; > > > > + u8 tblv_qact; > &g

RE: [PATCH v4 net-next 02/14] net: enetc: add command BD ring support for i.MX95 ENETC

2025-03-13 Thread Wei Fang
> On Tue, Mar 11, 2025 at 01:38:18PM +0800, Wei Fang wrote: > > The command BD ring is used to configure functionality where the > > underlying resources may be shared between different entities or being > > too large to configure using direct registers (such as lookup tables)

RE: [PATCH v4 net-next 01/14] net: enetc: add initial netc-lib driver to support NTMP

2025-03-13 Thread Wei Fang
> On Tue, Mar 11, 2025 at 01:38:17PM +0800, Wei Fang wrote: > > +int ntmp_rsst_query_or_update_entry(struct netc_cbdrs *cbdrs, u32 *table, > > + int count, bool query) > > +{ > > + struct ntmp_dma_buf data = {.dev = cbdrs->dma_dev};

RE: [PATCH v4 net-next 00/14] Add more feautues for ENETC v4 - round 2

2025-03-13 Thread Wei Fang
> On Tue, Mar 11, 2025 at 01:38:16PM +0800, Wei Fang wrote: > > This patch set adds the following features. > > 1. Compared with ENETC v1, the formats of tables and command BD of ENETC > > v4 have changed significantly, and the two are not compatible. Therefore, > > i

[PATCH v4 net-next 13/14] net: enetc: add loopback support for i.MX95 ENETC PF

2025-03-11 Thread Wei Fang
Add internal loopback support for i.MX95 ENETC PF, the default loopback mode is MAC level loopback, the MAC Tx data is looped back onto the Rx. The MAC interface runs at a fixed 1:8 ratio of NETC clock in MAC-level loopback mode, with no dependency on Tx clock. Signed-off-by: Wei Fang

[PATCH v4 net-next 08/14] net: enetc: add RSS support for i.MX95 ENETC PF

2025-03-11 Thread Wei Fang
interfaces are compatible with i.MX95. So it's time to add RSS support to i.MX95 ENETC PF. Signed-off-by: Wei Fang --- drivers/net/ethernet/freescale/enetc/enetc.c | 5 +-- drivers/net/ethernet/freescale/enetc/enetc.h | 2 + .../net/ethernet/freescale/enetc/enetc4_pf.c | 11 + .../net/eth

[PATCH v4 net-next 09/14] net: enetc: enable RSS feature by default

2025-03-11 Thread Wei Fang
improved when then network is enabled. Signed-off-by: Wei Fang --- drivers/net/ethernet/freescale/enetc/enetc.c | 35 ++- .../freescale/enetc/enetc_pf_common.c | 4 ++- .../net/ethernet/freescale/enetc/enetc_vf.c | 4 ++- 3 files changed, 25 insertions(+), 18 deletions

[PATCH v4 net-next 04/14] net: enetc: add MAC filter for i.MX95 ENETC PF

2025-03-11 Thread Wei Fang
will be supported in subsequent patches. Signed-off-by: Wei Fang --- drivers/net/ethernet/freescale/enetc/enetc.h | 2 + .../net/ethernet/freescale/enetc/enetc4_hw.h | 8 + .../net/ethernet/freescale/enetc/enetc4_pf.c | 422 +- .../net/ethernet/freescale/enetc/enetc_hw.h

[PATCH v4 net-next 12/14] net: enetc: add VLAN filtering support for i.MX95 ENETC PF

2025-03-11 Thread Wei Fang
Add VLAN hash filter support for i.MX95 ENETC PF. If VLAN filtering is disabled, then VLAN promiscuous mode will be enabled, which means that PF qualifies for reception of all VLAN tags. Signed-off-by: Wei Fang --- .../net/ethernet/freescale/enetc/enetc4_hw.h | 4 .../net/ethernet

[PATCH v4 net-next 05/14] net: enetc: add debugfs interface to dump MAC filter

2025-03-11 Thread Wei Fang
memory and needs to be read through command BD ring. In order to facilitate debugging, added a debugfs interface to get the relevant information about MAC filter. Signed-off-by: Wei Fang --- drivers/net/ethernet/freescale/enetc/Makefile | 1 + drivers/net/ethernet/freescale/enetc/enetc.h | 1 + ..

[PATCH v4 net-next 01/14] net: enetc: add initial netc-lib driver to support NTMP

2025-03-10 Thread Wei Fang
tc flower and debugfs will be added in the future. Signed-off-by: Wei Fang --- drivers/net/ethernet/freescale/enetc/Kconfig | 8 + drivers/net/ethernet/freescale/enetc/Makefile | 3 + drivers/net/ethernet/freescale/enetc/ntmp.c | 458 ++ .../ethernet/freescale/enetc

[PATCH v4 net-next 03/14] net: enetc: move generic MAC filterng interfaces to enetc-core

2025-03-10 Thread Wei Fang
PF and VFs. This lays the basis for i.MX95 ENETC PF and VFs to support MAC address filtering. Signed-off-by: Wei Fang --- drivers/net/ethernet/freescale/enetc/enetc.c | 36 ++ drivers/net/ethernet/freescale/enetc/enetc.h | 17 +++ .../net/ethernet/freescale/enetc/enetc_pf.c

[PATCH v4 net-next 14/14] MAINTAINERS: add new file ntmp.h to ENETC driver

2025-03-10 Thread Wei Fang
Add new file ntmp.h. to ENETC driver. Signed-off-by: Wei Fang --- MAINTAINERS | 1 + 1 file changed, 1 insertion(+) diff --git a/MAINTAINERS b/MAINTAINERS index 7078199fcebf..e259b659eadb 100644 --- a/MAINTAINERS +++ b/MAINTAINERS @@ -9174,6 +9174,7 @@ F: Documentation/devicetree

[PATCH v4 net-next 07/14] net: enetc: make enetc_set_rss_key() reusable

2025-03-10 Thread Wei Fang
Since the offset of the RSS key registers of i.MX95 ENETC is different from that of LS1028A, so add enetc_get_rss_key_base() to get the base offset for the different chips, so that enetc_set_rss_key() can be reused for this trivial. Signed-off-by: Wei Fang --- drivers/net/ethernet/freescale

[PATCH v4 net-next 11/14] net: enetc: move generic VLAN hash filter functions to enetc_pf_common.c

2025-03-10 Thread Wei Fang
filter functions enetc_vlan_rx_add_vid() and enetc_vlan_rx_del_vid() are moved to enetc_pf_common.c. Signed-off-by: Wei Fang --- .../net/ethernet/freescale/enetc/enetc_pf.c | 34 ++- .../net/ethernet/freescale/enetc/enetc_pf.h | 1 + .../freescale/enetc/enetc_pf_common.c

[PATCH v4 net-next 10/14] net: enetc: move generic VLAN filter interfaces to enetc-core

2025-03-10 Thread Wei Fang
easier to add VLAN filter support for i.MX95 ENETC later. Signed-off-by: Wei Fang --- drivers/net/ethernet/freescale/enetc/enetc.c | 25 ++ drivers/net/ethernet/freescale/enetc/enetc.h | 6 +++ .../net/ethernet/freescale/enetc/enetc_pf.c | 46 +-- .../net/ethernet

[PATCH v4 net-next 06/14] net: enetc: add set/get_rss_table() to enetc_si_ops

2025-03-10 Thread Wei Fang
Since i.MX95 ENETC (v4) uses NTMP 2.0 to manage the RSS table, which is different from LS1028A ENETC (v1). In order to reuse some functions related to the RSS table, so add .get_rss_table() and .set_rss_table() hooks to enetc_si_ops. Signed-off-by: Wei Fang --- drivers/net/ethernet/freescale

[PATCH v4 net-next 02/14] net: enetc: add command BD ring support for i.MX95 ENETC

2025-03-10 Thread Wei Fang
, and teardown_cbdr() is used to free the command BD ring. Signed-off-by: Wei Fang --- drivers/net/ethernet/freescale/enetc/enetc.h | 27 +++-- .../net/ethernet/freescale/enetc/enetc4_pf.c | 47 +++- .../net/ethernet/freescale/enetc/enetc_cbdr.c | 55 +-- .../net

[PATCH v4 net-next 00/14] Add more feautues for ENETC v4 - round 2

2025-03-10 Thread Wei Fang
RSS support for i.MX95 ENETC PF", one is "net: enetc: add set/get_rss_table() to enetc_si_ops", the other one is "net: enetc: make enetc_set_rss_key() reusable" 5. Remove patch "net: enetc: check if the RSS hfunc is toeplitz" from this patch set. --- W

RE: [PATCH v3 net-next 01/13] net: enetc: add initial netc-lib driver to support NTMP

2025-03-07 Thread Wei Fang
> On Sat, 8 Mar 2025 02:05:35 +0000 Wei Fang wrote: > > > > On Tue, 4 Mar 2025 15:21:49 +0800 Wei Fang wrote: > > > hm..., there are some interfaces of netc-lib are used in common .c > > > files in downstream, so I used "ifdef" in downstream. Now for the

RE: [PATCH v3 net-next 01/13] net: enetc: add initial netc-lib driver to support NTMP

2025-03-07 Thread Wei Fang
> > On Tue, 4 Mar 2025 15:21:49 +0800 Wei Fang wrote: > > > +config NXP_NETC_LIB > > > + tristate "NETC Library" > > > > Remove the string after "tristate", the user should not be prompted > > to make a choice for this, since the cons

RE: [PATCH v3 net-next 01/13] net: enetc: add initial netc-lib driver to support NTMP

2025-03-07 Thread Wei Fang
> On Tue, 4 Mar 2025 15:21:49 +0800 Wei Fang wrote: > > +config NXP_NETC_LIB > > + tristate "NETC Library" > > Remove the string after "tristate", the user should not be prompted > to make a choice for this, since the consumers "select&qu

[PATCH v3 net-next 01/13] net: enetc: add initial netc-lib driver to support NTMP

2025-03-03 Thread Wei Fang
tc flower and debugfs will be added in the future. Signed-off-by: Wei Fang --- drivers/net/ethernet/freescale/enetc/Kconfig | 11 + drivers/net/ethernet/freescale/enetc/Makefile | 3 + drivers/net/ethernet/freescale/enetc/ntmp.c | 458 ++ .../ethernet/freescale/enetc

[PATCH v3 net-next 06/13] net: enetc: add RSS support for i.MX95 ENETC PF

2025-03-03 Thread Wei Fang
enetc_set_rss_key() and enetc_get_rss_key() can be reused for this trivial. Signed-off-by: Wei Fang --- drivers/net/ethernet/freescale/enetc/enetc.c | 7 +- drivers/net/ethernet/freescale/enetc/enetc.h | 6 +- .../net/ethernet/freescale/enetc/enetc4_pf.c | 22 +++--- .../net/ethernet/freescale/enetc

[PATCH v3 net-next 13/13] MAINTAINERS: add new file ntmp.h to ENETC driver

2025-03-03 Thread Wei Fang
Add new file ntmp.h. to ENETC driver. Signed-off-by: Wei Fang --- MAINTAINERS | 1 + 1 file changed, 1 insertion(+) diff --git a/MAINTAINERS b/MAINTAINERS index 7078199fcebf..e259b659eadb 100644 --- a/MAINTAINERS +++ b/MAINTAINERS @@ -9174,6 +9174,7 @@ F: Documentation/devicetree

[PATCH v3 net-next 12/13] net: enetc: add loopback support for i.MX95 ENETC PF

2025-03-03 Thread Wei Fang
Add internal loopback support for i.MX95 ENETC PF, the default loopback mode is MAC level loopback, the MAC Tx data is looped back onto the Rx. The MAC interface runs at a fixed 1:8 ratio of NETC clock in MAC-level loopback mode, with no dependency on Tx clock. Signed-off-by: Wei Fang

[PATCH v3 net-next 11/13] net: enetc: add VLAN filtering support for i.MX95 ENETC PF

2025-03-03 Thread Wei Fang
Add VLAN hash filter support for i.MX95 ENETC PF. If VLAN filtering is disabled, then VLAN promiscuous mode will be enabled, which means that PF qualifies for reception of all VLAN tags. Signed-off-by: Wei Fang --- .../net/ethernet/freescale/enetc/enetc4_hw.h | 4 .../net/ethernet

[PATCH v3 net-next 10/13] net: enetc: move generic VLAN hash filter functions to enetc_pf_common.c

2025-03-03 Thread Wei Fang
filter functions enetc_vlan_rx_add_vid() and enetc_vlan_rx_del_vid() are moved to enetc_pf_common.c. Signed-off-by: Wei Fang --- .../net/ethernet/freescale/enetc/enetc_pf.c | 34 ++- .../net/ethernet/freescale/enetc/enetc_pf.h | 1 + .../freescale/enetc/enetc_pf_common.c

[PATCH v3 net-next 08/13] net: enetc: enable RSS feature by default

2025-03-03 Thread Wei Fang
improved when then network is enabled. Signed-off-by: Wei Fang --- drivers/net/ethernet/freescale/enetc/enetc.c | 35 ++- .../freescale/enetc/enetc_pf_common.c | 4 ++- .../net/ethernet/freescale/enetc/enetc_vf.c | 4 ++- 3 files changed, 25 insertions(+), 18 deletions

[PATCH v3 net-next 09/13] net: enetc: move generic VLAN filter interfaces to enetc-core

2025-03-03 Thread Wei Fang
easier to add VLAN filter support for i.MX95 ENETC later. Signed-off-by: Wei Fang --- drivers/net/ethernet/freescale/enetc/enetc.c | 25 ++ drivers/net/ethernet/freescale/enetc/enetc.h | 6 +++ .../net/ethernet/freescale/enetc/enetc_pf.c | 46 +-- .../net/ethernet

[PATCH v3 net-next 07/13] net: enetc: check if the RSS hfunc is toeplitz

2025-03-03 Thread Wei Fang
Both ENETC v1 and ENETC v4 only support the toeplitz algorithm for RSS, so add a check for RSS hfunc. Signed-off-by: Wei Fang --- drivers/net/ethernet/freescale/enetc/enetc_ethtool.c | 7 +++ 1 file changed, 7 insertions(+) diff --git a/drivers/net/ethernet/freescale/enetc/enetc_ethtool.c

[PATCH v3 net-next 05/13] net: enetc: add debugfs interface to dump MAC filter

2025-03-03 Thread Wei Fang
memory and needs to be read through command BD ring. In order to facilitate debugging, added a debugfs interface to get the relevant information about MAC filter. Signed-off-by: Wei Fang --- drivers/net/ethernet/freescale/enetc/Makefile | 1 + drivers/net/ethernet/freescale/enetc/enetc.h | 1 + ..

[PATCH v3 net-next 04/13] net: enetc: add MAC filter for i.MX95 ENETC PF

2025-03-03 Thread Wei Fang
will be supported in subsequent patches. Signed-off-by: Wei Fang --- drivers/net/ethernet/freescale/enetc/enetc.h | 2 + .../net/ethernet/freescale/enetc/enetc4_hw.h | 8 + .../net/ethernet/freescale/enetc/enetc4_pf.c | 418 +- .../net/ethernet/freescale/enetc/enetc_hw.h

  1   2   >