> On Tue, Mar 11, 2025 at 01:38:25PM +0800, Wei Fang wrote: > > Receive side scaling (RSS) is a network driver technology that enables > > the efficient distribution of network receive processing across > > multiple CPUs in multiprocessor systems. Therefore, it is better to > > enable RSS by default so that the CPU load can be balanced and network > > performance can be improved when then network is enabled. > > s/then network/the network/ > > > > > Signed-off-by: Wei Fang <wei.f...@nxp.com> > > --- > > drivers/net/ethernet/freescale/enetc/enetc.c | 35 ++++++++++--------- > > .../freescale/enetc/enetc_pf_common.c | 4 ++- > > .../net/ethernet/freescale/enetc/enetc_vf.c | 4 ++- > > 3 files changed, 25 insertions(+), 18 deletions(-) > > > > diff --git a/drivers/net/ethernet/freescale/enetc/enetc.c > > b/drivers/net/ethernet/freescale/enetc/enetc.c > > index 5b5e65ac8fab..8583ac9f7b9e 100644 > > --- a/drivers/net/ethernet/freescale/enetc/enetc.c > > +++ b/drivers/net/ethernet/freescale/enetc/enetc.c > > @@ -2420,6 +2420,22 @@ static void enetc_set_lso_flags_mask(struct > enetc_hw *hw) > > enetc_wr(hw, ENETC4_SILSOSFMR1, 0); > > } > > > > +static int enetc_set_rss(struct net_device *ndev, int en) > > Can you please add a preliminary patch which converts this function's > prototype > to:
Okay, I can add such a patch in this patch set. > > static void enetc_set_rss(struct net_device *ndev, bool en) ? > > After you do that please feel free to add my tag and keep it in future patch > submissions: > > Acked-by: Vladimir Oltean <vladimir.olt...@nxp.com> > > I don't see downsides to enabling RX hashing by default.