> On Tue, Mar 11, 2025 at 01:38:26PM +0800, Wei Fang wrote: > > For ENETC, each SI has a corresponding VLAN hash table. That is to say, > > both PF and VFs can support VLAN filter. However, currently only ENETC v1 > > PF driver supports VLAN filter. In order to make i.MX95 ENETC (v4) PF and > > VF drivers also support VLAN filter, some related macros are moved from > > enetc_pf.h to enetc.h, and the related structure variables are moved from > > enetc_pf to enetc_si. > > > > Besides, enetc_vid_hash_idx() as a generic function is moved to enetc.c. > > Extract enetc_refresh_vlan_ht_filter() from enetc_sync_vlan_ht_filter() > > so that it can be shared by PF and VF drivers. This will make it easier > > to add VLAN filter support for i.MX95 ENETC later. > > > > Signed-off-by: Wei Fang <wei.f...@nxp.com> > > --- > > In this and the next patch, can you please separate the code movement > from the logical changes? It makes review much more difficult. With the > similar observation that, as in the case of MAC filtering, VSIs don't > yet support VLAN filtering, so the movement of the hash table structures > from per-PF to per-SI is currently premature. So I expect to see that > part removed from the next revision.
Okay, I will keep vlan_ht_filter in struct enetc_pf, and move common interfaces to enetc_pf_common.c.
