> On Tue, Mar 11, 2025 at 01:38:27PM +0800, Wei Fang wrote: > > Since the VLAN hash filter of ENETC v1 and v4 is the basically same, the > > only difference is the offset of the VLAN hash filter registers. So, the > > .set_si_vlan_hash_filter() hook is added to struct enetc_pf_ops to set > > the registers of the corresponding platform. > > For the RSS hash key register, you added a function which retrieves the > register base. For the VLAN hash filter, you add ops. Same problem, > different solutions?
I thought it was a bit different, because we have a 'si' parameter, anyway, I think it is fine to remove this ops and use the same way as RSS.
