> I see this is "Changes requested", so here are some more nitpicks from me. > > On Fri, Apr 11, 2025 at 05:57:39PM +0800, Wei Fang wrote: > > Some NETC functionality is controlled using control messages sent to the > > hardware using BD ring interface with 32B descriptor similar to transmit > > BD ring used on ENETC. This BD ring interface is referred to as command > > BD ring. It is used to configure functionality where the underlying > > resources may be shared between different entities or being too large to > > configure using direct registers. Therefore, a messaging protocol called > > NETC Table Management Protocol (NTMP) is provided for exchanging > > configuration and management information between the software and the > > hardware using the command BD ring interface. > > > > For i.MX95, NTMP has been upgraded to version 2.0, which is incompatible > > with LS1028A, because the message formats have been changed. > > Can you please add one more sentence clarifying that the LS1028A > management protocol has been retroactively named NTMP 1.0 and its > implementation is in enetc_cbdr.c and enetc_tsn.c? The driver, like new > NETC documentation, refers to NTMP 2.0 as simply "NTMP". >
Okay, but enetc_tsn.c is only existed in downstream, so it will not be added here.
