> title: s/filterng/filtering/ > > On Tue, Mar 11, 2025 at 01:38:19PM +0800, Wei Fang wrote: > > Although only ENETC PF can access the MAC address filter table, the table > > entries can specify MAC address filtering for one or more SIs based on > > SI_BITMAP, which means that the table also supports MAC address filtering > > for VFs. > > > > Currently, only the ENETC v1 PF driver supports MAC address filtering. In > > order to add the MAC address filtering support for the ENETC v4 PF driver > > and VF driver in the future, the relevant generic interfaces are moved to > > the enetc-core driver. At the same time, the struct enetc_mac_filter is > > moved from enetc_pf to enetc_si, because enetc_si is a structure shared by > > PF and VFs. This lays the basis for i.MX95 ENETC PF and VFs to support > > MAC address filtering. > > > > Signed-off-by: Wei Fang <wei.f...@nxp.com> > > --- > > For this series I don't see any VF implementation of ndo_set_rx_mode(). > I don't think you have to move struct enetc_mac_filter from struct enetc_pf > to struct enetc_si, so please don't do that until there is a justification > for it that is contained in the same patch set, and the two can be > evaluated together.
Okay, I will keep them in "struct enetc_pf". :) > > Moving enetc_add_mac_addr_ht_filter() and enetc_reset_mac_addr_filter() > to enetc.c seems fine.
