Re: [PATCH] NULL terminate the pci_device_ids in pasemi_edac

2007-10-18 Thread Olof Johansson
On Fri, Oct 19, 2007 at 03:07:22PM +1000, Stephen Rothwell wrote: > Fixes: > drivers/edac/pasemi_edac: struct pci_device_id is 32 bytes. The last of 1 is: > 0x00 0x00 0x19 0x59 0x00 0x00 0xa0 0x0a 0xff 0xff 0xff 0xff 0xff 0xff 0xff > 0xff > 0x00 0x00 0x00 0x00 0x00 0x00 0x00 0x00 0x00 0x00 0x00 0

Re: [PATCH 1/2] qemu platform, v2

2007-10-18 Thread Rob Landley
On Thursday 18 October 2007 12:29:08 pm Grant Likely wrote: > On 10/18/07, Milton Miller <[EMAIL PROTECTED]> wrote: > > If we say only some boards or ports are special and need to build then > > I would vote for shipping asm files. If we think we need to build any > > random embedded platform with

Re: [PATCH] synchronize_irq needs a barrier

2007-10-18 Thread Herbert Xu
On Fri, Oct 19, 2007 at 02:26:54PM +1000, Benjamin Herrenschmidt wrote: > > I think a simple smp_mb(); here after foo = 1; is enough, which means > basically just having an smp_mp(); inside napi_synchronize(), before > the test_bit(). Or do I miss something ? Yes I think you're right. In this cas

Re: Merge dtc

2007-10-18 Thread Milton Miller
On Oct 18, 2007, at 8:45 PM, David Gibson wrote: > On Thu, Oct 18, 2007 at 09:59:26PM +0200, Sam Ravnborg wrote: >> On Thu, Oct 18, 2007 at 12:49:54PM -0500, Milton Miller wrote: >>> On Tue Oct 16 15:02:17 EST 2007, David Gibson wrote: >>> This very large patch incorporates a copy of dtc into

Re: [NET]: Fix possible dev_deactivate race condition

2007-10-18 Thread David Miller
From: Herbert Xu <[EMAIL PROTECTED]> Date: Fri, 19 Oct 2007 13:36:24 +0800 > [NET]: Fix possible dev_deactivate race condition > > The function dev_deactivate is supposed to only return when > all outstanding transmissions have completed. Unfortunately > it is possible for store operations in th

[NET]: Fix possible dev_deactivate race condition

2007-10-18 Thread Herbert Xu
On Fri, Oct 19, 2007 at 12:20:25PM +0800, Herbert Xu wrote: > > In fact this bug exists elsewhere too. For example, the network > stack does this in net/sched/sch_generic.c: > > /* Wait for outstanding qdisc_run calls. */ > while (test_bit(__LINK_STATE_QDISC_RUNNING, &dev->state)) >

Re: Merge dtc

2007-10-18 Thread Milton Miller
On Oct 18, 2007, at 8:30 PM, David Gibson wrote: > On Thu, Oct 18, 2007 at 12:49:54PM -0500, Milton Miller wrote: >> On Tue Oct 16 15:02:17 EST 2007, David Gibson wrote: >>> Too big for the list, full patch at >>> http://ozlabs.org/~dgibson/home/merge-dtc.patch+ >> >> So split it up. The obviou

[PATCH] NULL terminate the pci_device_ids in pasemi_edac

2007-10-18 Thread Stephen Rothwell
Fixes: drivers/edac/pasemi_edac: struct pci_device_id is 32 bytes. The last of 1 is: 0x00 0x00 0x19 0x59 0x00 0x00 0xa0 0x0a 0xff 0xff 0xff 0xff 0xff 0xff 0xff 0xff 0x00 0x00 0x00 0x00 0x00 0x00 0x00 0x00 0x00 0x00 0x00 0x00 0x00 0x00 0x00 0x00 FATAL: drivers/edac/pasemi_edac: struct pci_device_id

Re: [PATCH] synchronize_irq needs a barrier

2007-10-18 Thread Benjamin Herrenschmidt
On Fri, 2007-10-19 at 12:48 +0800, Herbert Xu wrote: > [IRQ]: Fix synchronize_irq races with IRQ handler > > As it is some callers of synchronize_irq rely on memory barriers > to provide synchronisation against the IRQ handlers. For example, > the tg3 driver does > > tp->irq_sync = 1; >

Re: [PATCH] synchronize_irq needs a barrier

2007-10-18 Thread Nick Piggin
On Friday 19 October 2007 13:28, Herbert Xu wrote: > Nick Piggin <[EMAIL PROTECTED]> wrote: > >> First of all let's agree on some basic assumptions: > >> > >> * A pair of spin lock/unlock subsumes the effect of a full mb. > > > > Not unless you mean a pair of spin lock/unlock as in > > 2 spin lock/

Re: [PATCH v6 4/9] add platform support for MPC837x MDS board

2007-10-18 Thread Stephen Rothwell
On Fri, 19 Oct 2007 11:56:34 +0800 "Li Yang-r58472" <[EMAIL PROTECTED]> wrote: > > is included in now. Do you think it should be > included explicitly? Yes. It may not be included by linux/of.h in the future. (My general opinion is that if you use something, you should explictly include the f

Re: [PATCH] synchronize_irq needs a barrier

2007-10-18 Thread Herbert Xu
On Fri, Oct 19, 2007 at 12:20:25PM +0800, Herbert Xu wrote: > > That's why I think this patch is in fact the only one that > solves all the races in this thread. The case that it solves > which the lock/unlock patch does not is the one where action > flows downwards past the clearing of IRQ_INPROG

Re: [PATCH] synchronize_irq needs a barrier

2007-10-18 Thread Benjamin Herrenschmidt
> What may happen is that action can either float upwards to give > > spin_lock > action > set IRQ_INPROGRESS > spin_unlock > > spin_lock > clear IRQ_INPROGRESS > spin_unlock > > or it can float downwards to give > > spin_lock > set IRQ_INP

Re: [PATCH] synchronize_irq needs a barrier

2007-10-18 Thread Benjamin Herrenschmidt
On Fri, 2007-10-19 at 12:20 +0800, Herbert Xu wrote: > > That's why I think this patch is in fact the only one that > solves all the races in this thread. The case that it solves > which the lock/unlock patch does not is the one where action > flows downwards past the clearing of IRQ_INPROGRESS.

Re: [PATCH] synchronize_irq needs a barrier

2007-10-18 Thread Benjamin Herrenschmidt
> The whole lock/set IRQ_INPROGRESS/unlock path can then only happen > before the locked section above, in which case we see and wait nicely > and all is good, or after, in which case the store to foo will be > visible to the IRQ handler as it will be ordered with the unlock in the > code above.

Re: [PATCH] synchronize_irq needs a barrier

2007-10-18 Thread Herbert Xu
On Thu, Oct 18, 2007 at 08:26:45PM -0700, Linus Torvalds wrote: > > > On Thu, 18 Oct 2007, Linus Torvalds wrote: > > > > I *think* it should work with something like > > > > for (;;) { > > smp_rmb(); > > if (!spin_is_locked(&desc->lock)) { > > smp_

Re: [PATCH] synchronize_irq needs a barrier

2007-10-18 Thread Benjamin Herrenschmidt
> > repeat: > /* Optimistic, no-locking loop */ > while (desc->status & IRQ_INPROGRESS) > cpu_relax(); > > /* Ok, that indicated we're done: double-check carefully */ > spin_lock_irqsave(&desc->lock, flags); >

RE: [PATCH v6 4/9] add platform support for MPC837x MDS board

2007-10-18 Thread Li Yang-r58472
> -Original Message- > From: Stephen Rothwell [mailto:[EMAIL PROTECTED] > Sent: Friday, October 19, 2007 8:43 AM > To: Li Yang-r58472 > Cc: [EMAIL PROTECTED]; [EMAIL PROTECTED]; > linuxppc-dev@ozlabs.org > Subject: Re: [PATCH v6 4/9] add platform support for MPC837x MDS board > > +static

Re: powerpc 440 monitor program

2007-10-18 Thread David Gibson
On Fri, Oct 19, 2007 at 11:32:33AM +0800, Bai Shuwei wrote: > all, > hi, when I boot my system, there are no output on the screen. > I choice the framebuffer and my monitor card is ATI PAGE 128 PCI, qt/e GUI. > When i compile the kernel, the boot logo and aty 128fb has be compiled into > kernel

powerpc 440 monitor program

2007-10-18 Thread Bai Shuwei
all, hi, when I boot my system, there are no output on the screen. I choice the framebuffer and my monitor card is ATI PAGE 128 PCI, qt/e GUI. When i compile the kernel, the boot logo and aty 128fb has be compiled into kernel patched with videoboot, and x86emu. The video parameters set: vi

Re: [PATCH] synchronize_irq needs a barrier

2007-10-18 Thread Herbert Xu
Nick Piggin <[EMAIL PROTECTED]> wrote: > >> First of all let's agree on some basic assumptions: >> >> * A pair of spin lock/unlock subsumes the effect of a full mb. > > Not unless you mean a pair of spin lock/unlock as in > 2 spin lock/unlock pairs (4 operations). > > *X = 10; > spin_lock(&lock)

Re: [PATCH] synchronize_irq needs a barrier

2007-10-18 Thread Linus Torvalds
On Thu, 18 Oct 2007, Linus Torvalds wrote: > > I *think* it should work with something like > > for (;;) { > smp_rmb(); > if (!spin_is_locked(&desc->lock)) { > smp_rmb(); > if (!(desc->status & IRQ_INPROGRESS) >

Re: [PATCH] [POWERPC] powerpc: Add -mno-spe for ARCH=powerpc builds

2007-10-18 Thread Kumar Gala
On Oct 18, 2007, at 6:19 PM, Paul Mackerras wrote: > Kumar Gala writes: > >> Signed-off-by: Kumar Gala <[EMAIL PROTECTED]> > > Your commit message doesn't give any reason why you are doing this, or > any explanation of what goes wrong without it. In fact, the commit > message is completely empty

Re: [PATCH] synchronize_irq needs a barrier

2007-10-18 Thread Nick Piggin
On Friday 19 October 2007 12:32, Herbert Xu wrote: > First of all let's agree on some basic assumptions: > > * A pair of spin lock/unlock subsumes the effect of a full mb. Not unless you mean a pair of spin lock/unlock as in 2 spin lock/unlock pairs (4 operations). *X = 10; spin_lock(&lock); /*

Re: [PATCH] synchronize_irq needs a barrier

2007-10-18 Thread Linus Torvalds
On Fri, 19 Oct 2007, Herbert Xu wrote: > > In other words I think this patch is great :) Hey, I appreciate it, but I do think that the "spinlock only to immediately unlock it again" is pretty horrid. I'm convinced that there should be some way to do this without actually taking the lock. I *t

Re: [PATCH] synchronize_irq needs a barrier

2007-10-18 Thread Herbert Xu
On Thu, Oct 18, 2007 at 04:39:59PM -0700, Linus Torvalds wrote: > > Basic notion: the only thing that serializes the IRQ_INPROGRESS flag is > the descriptor lock. And we don't have to (or even want to!) hold it while > waiting for the thing, but we want to *have*held*it* in between whatever > we

[PATCH v2] [2/2] powerpc: Switch to generic WARN_ON()/BUG_ON()

2007-10-18 Thread Olof Johansson
[POWERPC] Switch to generic WARN_ON()/BUG_ON() Not using the ppc-specific WARN_ON/BUG_ON constructs actually saves about 4K text on a ppc64_defconfig. The main reason seems to be that prepping the arguments to the conditional trap instructions is more work than just doing a compare and branch. Si

Re: [PATCH v2 3/4] Implement clockevents driver for powerpc

2007-10-18 Thread Paul Mackerras
Sergei Shtylyov writes: > And now you have incomplete read_persistent_clock() implementation for I don't see anything incomplete about it. If you do, feel free to post a patch. > example, god knows why it was preferred to mine -- well, it also implemented Your most recent post of your pa

Re: Freescale Interrupt enabling

2007-10-18 Thread David Gibson
On Thu, Oct 18, 2007 at 08:41:35AM -0600, Alan Bennett wrote: > We were developing with Linux 2.6.10 and a Planetcore boot loader, > however, recent work has us up and running with 2.6.23+ and U-boot > 1.2.0. However, we are now running into a few challenges regarding > the differences. > > Our d

Re: Merge dtc

2007-10-18 Thread David Gibson
On Thu, Oct 18, 2007 at 09:59:26PM +0200, Sam Ravnborg wrote: > On Thu, Oct 18, 2007 at 12:49:54PM -0500, Milton Miller wrote: > > On Tue Oct 16 15:02:17 EST 2007, David Gibson wrote: > > > > >This very large patch incorporates a copy of dtc into the kernel > > >source, in arch/powerpc/boot/dtc-sr

Re: Merge dtc

2007-10-18 Thread David Gibson
On Thu, Oct 18, 2007 at 12:49:54PM -0500, Milton Miller wrote: > On Tue Oct 16 15:02:17 EST 2007, David Gibson wrote: > > > This very large patch incorporates a copy of dtc into the kernel > > source, in arch/powerpc/boot/dtc-src. This means that dtc is no > > longer an external dependency to bui

Re: [PATCH v5 9/9] add MPC837x MDS board default device tree

2007-10-18 Thread David Gibson
On Thu, Oct 18, 2007 at 06:16:20PM +0800, Li Yang wrote: > Signed-off-by: Li Yang <[EMAIL PROTECTED]> > --- > diff --git a/arch/powerpc/boot/dts/mpc8377_mds.dts > b/arch/powerpc/boot/dts/mpc8377_mds.dts > new file mode 100644 > index 000..8530de6 > --- /dev/null > +++ b/arch/powerpc/boot/dts/m

Re: [PATCH v3 2/2] [POWERPC] MPC8568E-MDS: add support for flash

2007-10-18 Thread Anton Vorontsov
On Thu, Oct 18, 2007 at 02:58:25PM -0500, Kumar Gala wrote: [...] > > + > > + [EMAIL PROTECTED],0 { > > + #address-cells = <1>; > > + #size-cells = <1>; > > + compatible = "Spansion,S29GL256N11TFIV2O", "cfi-flash"; > > +

Re: [PATCH v6 4/9] add platform support for MPC837x MDS board

2007-10-18 Thread Stephen Rothwell
On Thu, 18 Oct 2007 23:04:02 +0800 Li Yang <[EMAIL PROTECTED]> wrote: > > +++ b/arch/powerpc/platforms/83xx/mpc837x_mds.c > +static void __init mpc837x_mds_setup_arch(void) > +{ > +#ifdef CONFIG_PCI > + struct device_node *np; > +#endif > + > + if (ppc_md.progress) > + ppc_md.pr

Re: [PATCH] [POWERPC] ucc_geth: Eliminate compile warnings

2007-10-18 Thread David Miller
From: Emil Medve <[EMAIL PROTECTED]> Date: Thu, 18 Oct 2007 17:15:13 -0500 > drivers/net/ucc_geth.c: In function 'ucc_geth_startup': > drivers/net/ucc_geth.c:2614: warning: assignment makes integer from pointer > without a cast > drivers/net/ucc_geth.c:2651: warning: assignment makes integer from

Re: [PATCH v2 3/4] Implement clockevents driver for powerpc

2007-10-18 Thread Paul Mackerras
Sergei Shtylyov writes: > > What problem do you see arising from this? > > Timers firing too early. Only if the minimum interrupt latency is less than 1 decrementer tick. That seems pretty unlikely to me unless you have a very slow timebase frequency. In fact what we should program the dec

[PATCH] [POWERPC] ucc_geth: Eliminate compile warnings

2007-10-18 Thread Emil Medve
drivers/net/ucc_geth.c: In function 'ucc_geth_startup': drivers/net/ucc_geth.c:2614: warning: assignment makes integer from pointer without a cast drivers/net/ucc_geth.c:2651: warning: assignment makes integer from pointer without a cast Signed-off-by: Emil Medve <[EMAIL PROTECTED]> --- This pa

Re: [PATCH] synchronize_irq needs a barrier

2007-10-18 Thread Benjamin Herrenschmidt
> So how about something like this (untested! not necessarily very well > thought through either!) > > Basic notion: the only thing that serializes the IRQ_INPROGRESS flag is > the descriptor lock. And we don't have to (or even want to!) hold it while > waiting for the thing, but we want to *h

Re: [PATCH] synchronize_irq needs a barrier

2007-10-18 Thread Linus Torvalds
On Fri, 19 Oct 2007, Benjamin Herrenschmidt wrote: > > I agree and you can see that in fact, we don't have enough barrier on > the other side since spin_unlock doesn't prevent subsequent loads from > crossing a previous store... > > I wonder if that's worth trying to address, adding a barrier i

Building zImage

2007-10-18 Thread Siva Prasad
Hi, When I tried to build zImage (make zImage V=1) based on the 2.6.19 kernel for 8641HPCN board, I got the following error... make -f scripts/Makefile.build obj=lib make -f /export/beavis/work/sprasad/2.6.19/linux-2.6.19/scripts/Makefile.modpost vmlinux scripts/mod/modpost -m -o /export/beavi

Re: [PATCH] ppc44x: support for 256K PAGE_SIZE

2007-10-18 Thread Paul Mackerras
Yuri Tikhonov writes: > The following patch adds support for 256KB PAGE_SIZE on ppc44x-based boards. > The applications to be run on the kernel with 256KB PAGE_SIZE have to be > built using the modified version of binutils, where the MAXPAGESIZE > definition is set to 0x4 (as opposite to st

Re: [PATCH] [POWERPC] powerpc: Add -mno-spe for ARCH=powerpc builds

2007-10-18 Thread Paul Mackerras
Kumar Gala writes: > Signed-off-by: Kumar Gala <[EMAIL PROTECTED]> Your commit message doesn't give any reason why you are doing this, or any explanation of what goes wrong without it. In fact, the commit message is completely empty. :) Please resubmit with a decent commit message. Paul. _

Re: [PATCH] synchronize_irq needs a barrier

2007-10-18 Thread Benjamin Herrenschmidt
On Thu, 2007-10-18 at 15:52 -0700, Linus Torvalds wrote: > > On Fri, 19 Oct 2007, Benjamin Herrenschmidt wrote: > > > > The barrier would guarantee that ioc->active (and in fact the write to > > the chip too above) are globally visible > > No, it doesn't really guarantee that. > > The thing is

Re: [PATCH] synchronize_irq needs a barrier

2007-10-18 Thread Linus Torvalds
On Fri, 19 Oct 2007, Benjamin Herrenschmidt wrote: > > The barrier would guarantee that ioc->active (and in fact the write to > the chip too above) are globally visible No, it doesn't really guarantee that. The thing is, there is no such thing as "globally visible". There is a "ordering of vi

Re: qe: add ability to upload QE firmware

2007-10-18 Thread Timur Tabi
Jerry Van Baren wrote: > We seem to be a little conflicted over whether it is an upload or a > download. ;-) Not me. To the host == download From the host == upload ___ Linuxppc-dev mailing list Linuxppc-dev@ozlabs.org https://ozlabs.org/mailman/l

Re: qe: add ability to upload QE firmware

2007-10-18 Thread Jerry Van Baren
Timur Tabi wrote: > Define the layout of a binary blob that contains a QE firmware and > instructions > on how to upload it. Add function qe_upload_microcode() to parse the blob > and perform the actual upload. Fully define 'struct rsp' in immap_qe.h to > include the actual RISC Special Register

Re: driver using device trees, irqs, powerpc

2007-10-18 Thread Grant Likely
On 10/18/07, Alan Bennett <[EMAIL PROTECTED]> wrote: > Need help adding new driver to supports a custom FPGA. Is there a > good driver that anyone would recommend I can look at that is fully > functional, works with 2.6.23 (powerpc style) and is described within > a device tree? > > Bonus points:

driver using device trees, irqs, powerpc

2007-10-18 Thread Alan Bennett
Need help adding new driver to supports a custom FPGA. Is there a good driver that anyone would recommend I can look at that is fully functional, works with 2.6.23 (powerpc style) and is described within a device tree? Bonus points: uses freescale interrupts (timers/irq's from mpc 82xx/etc...)

Re: [PATCH] synchronize_irq needs a barrier

2007-10-18 Thread Benjamin Herrenschmidt
On Thu, 2007-10-18 at 22:56 +0800, Herbert Xu wrote: > Benjamin Herrenschmidt <[EMAIL PROTECTED]> wrote: > > > > Take a real life example: > > > > drivers/message/fusion/mptbase.c > > > >/* Disable interrupts! */ > >CHIPREG_WRITE32(&ioc->chip->IntMask, 0x); > > > >

[PATCH] [POWERPC] powerpc: Add -mno-spe for ARCH=powerpc builds

2007-10-18 Thread Kumar Gala
Signed-off-by: Kumar Gala <[EMAIL PROTECTED]> --- arch/powerpc/Makefile |3 +++ 1 files changed, 3 insertions(+), 0 deletions(-) diff --git a/arch/powerpc/Makefile b/arch/powerpc/Makefile index 4e16534..bd87626 100644 --- a/arch/powerpc/Makefile +++ b/arch/powerpc/Makefile @@ -107,6 +107,9 @@

Re: [PATCH] synchronize_irq needs a barrier

2007-10-18 Thread Benjamin Herrenschmidt
On Thu, 2007-10-18 at 22:35 +0800, Herbert Xu wrote: > Benjamin Herrenschmidt <[EMAIL PROTECTED]> wrote: > > > > Note that some kind of read barrier or compiler barrier should be needed > > regardless, or we are just not sync'ing with anything at all (we may > > have loaded the value ages ago and

Re: [PATCH 2/2] bootwrapper: Bail from script if any command fails

2007-10-18 Thread Grant Likely
On 10/16/07, David Gibson <[EMAIL PROTECTED]> wrote: > On Tue, Oct 16, 2007 at 03:31:07PM -0600, Grant Likely wrote: > > From: Grant Likely <[EMAIL PROTECTED]> > > > > Add the 'set -e' command to the wrapper script so that if any command > > fails then the script will automatically exit > > Ah.. th

[PATCH] phy/bitbang: missing MODULE_LICENSE

2007-10-18 Thread Randy Dunlap
From: Randy Dunlap <[EMAIL PROTECTED]> Missing MODULE_LICENSE(), loading this module taints the kernel. Signed-off-by: Randy Dunlap <[EMAIL PROTECTED]> --- drivers/net/phy/mdio-bitbang.c |2 ++ 1 file changed, 2 insertions(+) --- linux-2.6.23-git7.orig/drivers/net/phy/mdio-bitbang.c +++ lin

Re: Merge dtc

2007-10-18 Thread Sam Ravnborg
On Thu, Oct 18, 2007 at 12:49:54PM -0500, Milton Miller wrote: > On Tue Oct 16 15:02:17 EST 2007, David Gibson wrote: > > >This very large patch incorporates a copy of dtc into the kernel > >source, in arch/powerpc/boot/dtc-src. This means that dtc is no > >longer an external dependency to build

Re: [PATCH v3 1/2] [POWERPC] MPC8568E-MDS: create localbus node

2007-10-18 Thread Kumar Gala
On Oct 18, 2007, at 1:00 PM, Anton Vorontsov wrote: > This patch creates localbus node, moves bcsr into it, and adds > localbus to the probe path. > > Signed-off-by: Anton Vorontsov <[EMAIL PROTECTED]> why two patches for lbus and flash to lbus? - k

Re: [PATCH v3 2/2] [POWERPC] MPC8568E-MDS: add support for flash

2007-10-18 Thread Kumar Gala
On Oct 18, 2007, at 1:01 PM, Anton Vorontsov wrote: > MPC8568E-MDS have 1 32MB Spansion x16 CFI flash chip. Let's use it. > > Signed-off-by: Anton Vorontsov <[EMAIL PROTECTED]> > --- > arch/powerpc/boot/dts/mpc8568mds.dts | 34 +++ > ++- > 1 files changed, 33 inser

Re: qe: add ability to upload QE firmware

2007-10-18 Thread Anton Vorontsov
On Thu, Oct 18, 2007 at 02:02:38PM -0500, Timur Tabi wrote: > Anton Vorontsov wrote: >>> + if (firmware->length == (length + sizeof(u32))) { >>> + /* Length is valid, and there's a CRC */ >>> + crc = be32_to_cpu(*((__be32 *) ((void *) firmware + length))); >> Spaces are not ne

[PATCH] trivial - QUICC UCC driver - remove buggy and unused vdbg macro

2007-10-18 Thread Joe Perches
remove buggy and unused vdbg macro Signed-off-by: Joe Perches <[EMAIL PROTECTED]> diff --git a/drivers/net/ucc_geth_mii.c b/drivers/net/ucc_geth_mii.c index df884f0..a4b481c 100644 --- a/drivers/net/ucc_geth_mii.c +++ b/drivers/net/ucc_geth_mii.c @@ -46,13 +46,6 @@ #include "ucc_geth_mii.h" #in

Re: [PATCH v3 0/4] FEC - fast ethernet controller for mpc52xx

2007-10-18 Thread Jeff Garzik
Grant Likely wrote: > On 10/15/07, Jeff Garzik <[EMAIL PROTECTED]> wrote: >> Domen Puncer wrote: >>> Hello! >>> >>> If there are no objections, I would like to get this merged >>> when bestcomm goes in (any time now?). >>> >>> It's split into four parts: >>> 1 - device tree >>> 2 - small bestcomm c

Re: [PATCH 2/2] Use of_get_pci_dev_node() in axon_msi.c

2007-10-18 Thread Linas Vepstas
On Thu, Oct 18, 2007 at 11:27:23AM +1000, Michael Ellerman wrote: > > It does what pci_device_to_OF_node() does, but in the right way. > > The plan is to remove pci_device_to_OF_node() once all the callers have > been converted to properly handle the refcounting. Oh. Yes. well, of course, then

RE: [PATCH v3] Device tree bindings for Xilinx devices

2007-10-18 Thread Stephen Neuendorffer
> -Original Message- > From: [EMAIL PROTECTED] [mailto:[EMAIL PROTECTED] On > Behalf Of Grant Likely > Sent: Thursday, October 18, 2007 11:13 AM > To: Stephen Neuendorffer > Cc: linuxppc-dev@ozlabs.org; Wolfgang Reissnegger; Leonid; > [EMAIL PROTECTED]; Josh Boyer; Arnd Bergmann > Subj

Re: [PATCH v2 3/4] [POWERPC] Add restart support for mpc52xx based platforms

2007-10-18 Thread Marian Balakowicz
Grant Likely wrote: > On 10/18/07, Marian Balakowicz <[EMAIL PROTECTED]> wrote: >> Add common helper routines: mpc52xx_map_wdt() and mpc52xx_restart(). >> >> This patch relies on Sascha Hauer's patch published in: >> http://patchwork.ozlabs.org/linuxppc/patch?id=8910. > > By 'relies', do you mean

Re: qe: add ability to upload QE firmware

2007-10-18 Thread Timur Tabi
Anton Vorontsov wrote: >> +if (firmware->length == (length + sizeof(u32))) { >> +/* Length is valid, and there's a CRC */ >> +crc = be32_to_cpu(*((__be32 *) ((void *) firmware + length))); > > Spaces are not needed after "(__be32 *)" and "(void *)". The whole > construc

[PATCH v2 4/4] [POWERPC] Enable restart support for lite5200 board

2007-10-18 Thread Marian Balakowicz
Signed-off-by: Marian Balakowicz <[EMAIL PROTECTED]> --- arch/powerpc/platforms/52xx/lite5200.c |4 1 files changed, 4 insertions(+), 0 deletions(-) diff --git a/arch/powerpc/platforms/52xx/lite5200.c b/arch/powerpc/platforms/52xx/lite5200.c index 65b7ae4..25d2bfa 100644 --- a/arch/po

Re: qe: add ability to upload QE firmware

2007-10-18 Thread Anton Vorontsov
On Thu, Oct 18, 2007 at 10:08:25AM -0500, Timur Tabi wrote: > Define the layout of a binary blob that contains a QE firmware and > instructions > on how to upload it. Add function qe_upload_microcode() to parse the blob > and perform the actual upload. Fully define 'struct rsp' in immap_qe.h to

Re: [PATCH v2 3/4] [POWERPC] Add restart support for mpc52xx based platforms

2007-10-18 Thread Grant Likely
On 10/18/07, Marian Balakowicz <[EMAIL PROTECTED]> wrote: > Add common helper routines: mpc52xx_map_wdt() and mpc52xx_restart(). > > This patch relies on Sascha Hauer's patch published in: > http://patchwork.ozlabs.org/linuxppc/patch?id=8910. By 'relies', do you mean "depends on" or "was derived f

[PATCH v2 3/4] [POWERPC] Add restart support for mpc52xx based platforms

2007-10-18 Thread Marian Balakowicz
Add common helper routines: mpc52xx_map_wdt() and mpc52xx_restart(). This patch relies on Sascha Hauer's patch published in: http://patchwork.ozlabs.org/linuxppc/patch?id=8910. Signed-off-by: Marian Balakowicz <[EMAIL PROTECTED]> Signed-off-by: Sascha Hauer <[EMAIL PROTECTED]> --- arch/powerpc/

[PATCH v2 2/4] [POWERPC] Update device tree binding for mpc5200 gpt

2007-10-18 Thread Marian Balakowicz
Add 'fsl,' prefix to 'compatible' property for gpt nodes. Add 'fsl,' prefix to empty, GPT0 specific 'has-wdt' property. Signed-off-by: Marian Balakowicz <[EMAIL PROTECTED]> --- .../powerpc/mpc52xx-device-tree-bindings.txt |4 ++- arch/powerpc/boot/dts/lite5200.dts | 2

[PATCH v2 1/4] [POWERPC] Add mpc52xx_find_and_map_path(), refactor utility functions

2007-10-18 Thread Marian Balakowicz
Add helper routine mpc52xx_find_and_map_path(). Extract common code to mpc52xx_map_node() and refactor mpc52xx_find_and_map(). Signed-off-by: Jan Wrobel <[EMAIL PROTECTED]> Reviewed-by: Grant Likely <[EMAIL PROTECTED]> --- arch/powerpc/platforms/52xx/mpc52xx_common.c | 21 +

[PATCH v2 0/4] [POWERPC] MPC5200: update gpt binding, add restart support

2007-10-18 Thread Marian Balakowicz
Here's the second version of MPC5200 patches, please review. Thanks! [POWERPC] Enable restart support for lite5200 board [POWERPC] Add restart support for mpc52xx based platforms [POWERPC] Update device tree binding for mpc5200 gpt [POWERPC] Add mpc52xx_find_and_map_path(), refactor utility functi

Re: [PATCH v3] Device tree bindings for Xilinx devices

2007-10-18 Thread Grant Likely
On 10/18/07, Stephen Neuendorffer <[EMAIL PROTECTED]> wrote: > > > -Original Message- > > From: Grant Likely [mailto:[EMAIL PROTECTED] > > Sent: Thursday, October 18, 2007 10:23 AM > > To: linuxppc-dev@ozlabs.org; Stephen Neuendorffer; Wolfgang > > Reissnegger; Leonid; [EMAIL PROTECTED]; Jo

[PATCH v3 2/2] [POWERPC] MPC8568E-MDS: add support for flash

2007-10-18 Thread Anton Vorontsov
MPC8568E-MDS have 1 32MB Spansion x16 CFI flash chip. Let's use it. Signed-off-by: Anton Vorontsov <[EMAIL PROTECTED]> --- arch/powerpc/boot/dts/mpc8568mds.dts | 34 +- 1 files changed, 33 insertions(+), 1 deletions(-) diff --git a/arch/powerpc/boot/dts/mpc8568m

[PATCH v3 1/2] [POWERPC] MPC8568E-MDS: create localbus node

2007-10-18 Thread Anton Vorontsov
This patch creates localbus node, moves bcsr into it, and adds localbus to the probe path. Signed-off-by: Anton Vorontsov <[EMAIL PROTECTED]> --- arch/powerpc/boot/dts/mpc8568mds.dts | 14 +++--- arch/powerpc/platforms/85xx/mpc85xx_mds.c |1 + 2 files changed, 12 insertions(+),

RE: [PATCH v3] Device tree bindings for Xilinx devices

2007-10-18 Thread Stephen Neuendorffer
> -Original Message- > From: Grant Likely [mailto:[EMAIL PROTECTED] > Sent: Thursday, October 18, 2007 10:23 AM > To: linuxppc-dev@ozlabs.org; Stephen Neuendorffer; Wolfgang > Reissnegger; Leonid; [EMAIL PROTECTED]; Josh > Boyer; Arnd Bergmann > Subject: [PATCH v3] Device tree bindings

Re: Merge dtc

2007-10-18 Thread Milton Miller
On Tue Oct 16 15:02:17 EST 2007, David Gibson wrote: > This very large patch incorporates a copy of dtc into the kernel > source, in arch/powerpc/boot/dtc-src. This means that dtc is no > longer an external dependency to build kernels with configurations > which need a dtb file. > > Signed-off-by

Re: [PATCH 1/2] qemu platform, v2

2007-10-18 Thread Grant Likely
On 10/18/07, Milton Miller <[EMAIL PROTECTED]> wrote: > On Oct 18, 2007, at 4:59 AM, Matt Sealey wrote: > > Which begs the question; why cloning? > > > > Why can't development be MOVED to in-kernel? > > Because we don't put userspace testsuites there for one. > > And its a stand alone tool and shou

[PATCH v3] Device tree bindings for Xilinx devices

2007-10-18 Thread Grant Likely
From: Grant Likely <[EMAIL PROTECTED]> Signed-off-by: Grant Likely <[EMAIL PROTECTED]> --- Documentation/powerpc/booting-without-of.txt | 264 ++ 1 files changed, 264 insertions(+), 0 deletions(-) diff --git a/Documentation/powerpc/booting-without-of.txt b/Documentatio

Re: [PATCH 1/2] qemu platform, v2

2007-10-18 Thread Milton Miller
On Oct 18, 2007, at 4:59 AM, Matt Sealey wrote: > Grant Likely wrote: >> On 9/30/07, David Gibson <[EMAIL PROTECTED]> wrote: >>> On Fri, Sep 28, 2007 at 06:53:28PM +0200, Segher Boessenkool wrote: >>> >>> I'm working on merging dtc into the kernel tree instead. >> I'm kind of late to this party; bu

Re: qe: add ability to upload QE firmware

2007-10-18 Thread Timur Tabi
Timur Tabi wrote: > Define the layout of a binary blob that contains a QE firmware and > instructions > on how to upload it. Add function qe_upload_microcode() to parse the blob > and perform the actual upload. Fully define 'struct rsp' in immap_qe.h to > include the actual RISC Special Register

Re: [PATCH v6 2/9] ipic: add new interrupts introduced by new chip

2007-10-18 Thread Kumar Gala
On Oct 18, 2007, at 10:29 AM, Li Yang-r58472 wrote: >> -Original Message- >> From: Kumar Gala [mailto:[EMAIL PROTECTED] >> Sent: Thursday, October 18, 2007 10:57 PM >> To: Li Yang-r58472 >> Cc: [EMAIL PROTECTED]; linuxppc-dev@ozlabs.org >> Subject: Re: [PATCH v6 2/9] ipic: add new interru

RE: [PATCH v6 2/9] ipic: add new interrupts introduced by new chip

2007-10-18 Thread Li Yang-r58472
> -Original Message- > From: Kumar Gala [mailto:[EMAIL PROTECTED] > Sent: Thursday, October 18, 2007 10:57 PM > To: Li Yang-r58472 > Cc: [EMAIL PROTECTED]; linuxppc-dev@ozlabs.org > Subject: Re: [PATCH v6 2/9] ipic: add new interrupts > introduced by new chip > > > On Oct 18, 2007, at 1

Re: [PATCH v2 3/4] Implement clockevents driver for powerpc

2007-10-18 Thread Sergei Shtylyov
Hello. Paul Mackerras wrote: >>>Tony started from an earlier patch by John Stultz, not from your >>>patches. >>Well, that I can believe, yet the clockevents patch has traces of my >>former work, and looking at read_persisitent_time() it looks suspiciously >>close to my version too... > The

RE: [PATCH v6 resend 9/9] add MPC837x MDS board default device tree

2007-10-18 Thread Li Yang-r58472
> -Original Message- > From: Kumar Gala [mailto:[EMAIL PROTECTED] > Sent: Thursday, October 18, 2007 11:02 PM > To: Li Yang-r58472 > Cc: [EMAIL PROTECTED]; linuxppc-dev@ozlabs.org > Subject: Re: [PATCH v6 resend 9/9] add MPC837x MDS board > default device tree > > > On Oct 18, 2007, at

qe: add ability to upload QE firmware

2007-10-18 Thread Timur Tabi
Define the layout of a binary blob that contains a QE firmware and instructions on how to upload it. Add function qe_upload_microcode() to parse the blob and perform the actual upload. Fully define 'struct rsp' in immap_qe.h to include the actual RISC Special Registers. Signed-off-by: Timur Tabi

Re: [PATCH v6 resend 9/9] add MPC837x MDS board default device tree

2007-10-18 Thread Kumar Gala
On Oct 18, 2007, at 10:09 AM, Li Yang wrote: > Signed-off-by: Li Yang <[EMAIL PROTECTED]> > --- > Fix a typo in previous one. > > arch/powerpc/boot/dts/mpc8377_mds.dts | 282 ++ > + > arch/powerpc/boot/dts/mpc8378_mds.dts | 264 ++ > +++ >

Re: [PATCH v6 3/9] add Freescale SerDes PHY support

2007-10-18 Thread Kumar Gala
On Oct 18, 2007, at 10:04 AM, Li Yang wrote: > The SerDes(serializer/deserializer) PHY block is a new SoC block used > in Freescale chips to support multiple serial interfaces, such as PCI > Express, SGMII, SATA. > > Signed-off-by: Li Yang <[EMAIL PROTECTED]> > --- > arch/powerpc/platforms/Kconf

[PATCH v6 resend 9/9] add MPC837x MDS board default device tree

2007-10-18 Thread Li Yang
Signed-off-by: Li Yang <[EMAIL PROTECTED]> --- Fix a typo in previous one. arch/powerpc/boot/dts/mpc8377_mds.dts | 282 +++ arch/powerpc/boot/dts/mpc8378_mds.dts | 264 + arch/powerpc/boot/dts/mpc8379_mds.dts | 300 +++

Re: [PATCH v6 9/9] add MPC837x MDS board default device tree

2007-10-18 Thread Kumar Gala
On Oct 18, 2007, at 10:04 AM, Li Yang wrote: > Signed-off-by: Li Yang <[EMAIL PROTECTED]> > --- > arch/powerpc/boot/dts/mpc8377_mds.dts | 282 ++ > + > arch/powerpc/boot/dts/mpc8378_mds.dts | 264 ++ > +++ > arch/powerpc/boot/dts/mpc8379_md

Re: [PATCH] synchronize_irq needs a barrier

2007-10-18 Thread Herbert Xu
Benjamin Herrenschmidt <[EMAIL PROTECTED]> wrote: > > Take a real life example: > > drivers/message/fusion/mptbase.c > >/* Disable interrupts! */ >CHIPREG_WRITE32(&ioc->chip->IntMask, 0x); > >ioc->active = 0; >synchronize_irq(pdev->irq); > > And we aren't

Re: [PATCH v6 2/9] ipic: add new interrupts introduced by new chip

2007-10-18 Thread Kumar Gala
On Oct 18, 2007, at 10:04 AM, Li Yang wrote: > These interrupts are introduced by the latest Freescale SoC such as > MPC837x. The patch also adds comment to interrupts. > > Signed-off-by: Li Yang <[EMAIL PROTECTED]> > --- > arch/powerpc/sysdev/ipic.c | 224 + >

[PATCH v6 9/9] add MPC837x MDS board default device tree

2007-10-18 Thread Li Yang
Signed-off-by: Li Yang <[EMAIL PROTECTED]> --- arch/powerpc/boot/dts/mpc8377_mds.dts | 282 +++ arch/powerpc/boot/dts/mpc8378_mds.dts | 264 + arch/powerpc/boot/dts/mpc8379_mds.dts | 300 + 3 files changed,

[PATCH v6 8/9] add MPC837x MDS default kernel configuration

2007-10-18 Thread Li Yang
Signed-off-by: Li Yang <[EMAIL PROTECTED]> --- arch/powerpc/configs/mpc837x_mds_defconfig | 878 1 files changed, 878 insertions(+), 0 deletions(-) create mode 100644 arch/powerpc/configs/mpc837x_mds_defconfig diff --git a/arch/powerpc/configs/mpc837x_mds_defconfig

[PATCH v6 7/9] ipic: clean up unsupported ack operations

2007-10-18 Thread Li Yang
IPIC controller doesn't support ack operations. The pending registers are read-only. The patch removes ack operations which are not needed. Signed-off-by: Li Yang <[EMAIL PROTECTED]> --- arch/powerpc/sysdev/ipic.c | 40 ++-- 1 files changed, 2 insertions(+)

[PATCH v6 6/9] add documentation for SerDes nodes

2007-10-18 Thread Li Yang
Signed-off-by: Li Yang <[EMAIL PROTECTED]> --- Documentation/powerpc/booting-without-of.txt | 29 ++ 1 files changed, 29 insertions(+), 0 deletions(-) diff --git a/Documentation/powerpc/booting-without-of.txt b/Documentation/powerpc/booting-without-of.txt index 8d49942.

[PATCH v6 5/9] add documentation for SATA nodes

2007-10-18 Thread Li Yang
Signed-off-by: Li Yang <[EMAIL PROTECTED]> --- Documentation/powerpc/booting-without-of.txt | 32 ++ 1 files changed, 32 insertions(+), 0 deletions(-) diff --git a/Documentation/powerpc/booting-without-of.txt b/Documentation/powerpc/booting-without-of.txt index a96e853.

[PATCH v6 4/9] add platform support for MPC837x MDS board

2007-10-18 Thread Li Yang
The MPC837x MDS is a new member of Freescale MDS reference system. Signed-off-by: Li Yang <[EMAIL PROTECTED]> --- arch/powerpc/platforms/83xx/Kconfig | 12 arch/powerpc/platforms/83xx/Makefile |1 + arch/powerpc/platforms/83xx/mpc837x_mds.c | 103 +++

[PATCH v6 3/9] add Freescale SerDes PHY support

2007-10-18 Thread Li Yang
The SerDes(serializer/deserializer) PHY block is a new SoC block used in Freescale chips to support multiple serial interfaces, such as PCI Express, SGMII, SATA. Signed-off-by: Li Yang <[EMAIL PROTECTED]> --- arch/powerpc/platforms/Kconfig |3 + arch/powerpc/sysdev/Makefile |1 + ar

[PATCH v6 2/9] ipic: add new interrupts introduced by new chip

2007-10-18 Thread Li Yang
These interrupts are introduced by the latest Freescale SoC such as MPC837x. The patch also adds comment to interrupts. Signed-off-by: Li Yang <[EMAIL PROTECTED]> --- arch/powerpc/sysdev/ipic.c | 224 ++-- arch/powerpc/sysdev/ipic.h |7 +- include/asm

[PATCH v6 1/9] add e300c4 entry to cputable

2007-10-18 Thread Li Yang
Signed-off-by: Li Yang <[EMAIL PROTECTED]> --- arch/powerpc/kernel/cputable.c | 13 - 1 files changed, 12 insertions(+), 1 deletions(-) diff --git a/arch/powerpc/kernel/cputable.c b/arch/powerpc/kernel/cputable.c index d3fb7d0..03b973f 100644 --- a/arch/powerpc/kernel/cputable.c +++

Re: [PATCH v2 3/4] Implement clockevents driver for powerpc

2007-10-18 Thread Sergei Shtylyov
Paul Mackerras wrote: >>BTW, while fixing that for classic PPC, but you've broke it for 40x / >> book >>E CPU which interrupt at 0. Congratulations. :-) > What problem do you see arising from this? Timers firing too early. > Paul. WBR, Sergei

  1   2   >