From: Emil Medve <[EMAIL PROTECTED]> Date: Thu, 18 Oct 2007 17:15:13 -0500
> drivers/net/ucc_geth.c: In function 'ucc_geth_startup': > drivers/net/ucc_geth.c:2614: warning: assignment makes integer from pointer > without a cast > drivers/net/ucc_geth.c:2651: warning: assignment makes integer from pointer > without a cast > > Signed-off-by: Emil Medve <[EMAIL PROTECTED]> It only kills the warning on 32-bit systems, the cast is wrong either way. > ugeth->tx_bd_ring_offset[j] = > - kmalloc((u32) (length + align), GFP_KERNEL); > + (u32)kmalloc(length + align, GFP_KERNEL); > > if (ugeth->tx_bd_ring_offset[j] != 0) > ugeth->p_tx_bd_ring[j] = Pointers can be up to "unsigned long" in size, therefore that is the minimal amount of storage you need to store them into if they are needed in integer form for some reason. Any cast from pointer to integer like this is a huge red flag. _______________________________________________ Linuxppc-dev mailing list Linuxppc-dev@ozlabs.org https://ozlabs.org/mailman/listinfo/linuxppc-dev
