Re: [PATCH v2 1/2] vdpa/mlx5: Set speed and duplex of vDPA devices to UNKNOWN

2024-09-03 Thread Nelson, Shannon
On 9/3/2024 10:15 AM, Carlos Bilbao wrote: From: Carlos Bilbao Initialize the speed and duplex fields in virtio_net_config to UNKNOWN. This is needed because mlx5_vdpa vDPA devicess currently do not support the VIRTIO_NET_F_SPEED_DUPLEX feature which reports speed and duplex. Add needed helper

Re: [PATCH] vdpa/mlx5: Fix invalid mr resource destroy

2024-08-27 Thread Nelson, Shannon
On 8/27/2024 9:08 AM, Dragos Tatulea wrote: Certain error paths from mlx5_vdpa_dev_add() can end up releasing mr resources which never got initialized in the first place. This patch adds the missing check in mlx5_vdpa_destroy_mr_resources() to block releasing non-initialized mr resources. Refe

Re: [PATCH] vdpa/mlx5: Use random MAC address when no nic vport MAC set

2024-08-27 Thread Nelson, Shannon
On 8/27/2024 9:02 AM, Dragos Tatulea wrote: When the vdpa device is configured without a specific MAC address, the vport MAC address is used. However, this address can be 0 which prevents the driver from properly configuring the MPFS and breaks steering. The solution is to simply generate a ran

Re: [PATCH -next] vdpa: Remove unused declarations

2024-08-19 Thread Nelson, Shannon
On 8/19/2024 7:09 AM, Yue Haibing wrote: There is no caller and implementation in tree. Signed-off-by: Yue Haibing --- drivers/vdpa/ifcvf/ifcvf_base.h | 3 --- drivers/vdpa/pds/cmds.h | 1 - 2 files changed, 4 deletions(-) diff --git a/drivers/vdpa/ifcvf/ifcvf_base.h b/drivers/vdp

RE: [PATCH v6] i40e: Look up MAC address in Open Firmware or IDPROM

2015-11-05 Thread Nelson, Shannon
> From: David Miller [mailto:da...@davemloft.net] > Sent: Thursday, November 05, 2015 8:29 AM > > From: Sowmini Varadhan > Date: Thu, 5 Nov 2015 11:28:31 -0500 > > > On (11/05/15 11:05), David Miller wrote: > >> From: David Miller > >> Date: Thu, 05 Nov 2015 10:31:26 -0500 (EST) > >> > >> > I'l

RE: [PATCH v6] i40e: Look up MAC address in Open Firmware or IDPROM

2015-11-04 Thread Nelson, Shannon
> From: Sowmini Varadhan [mailto:sowmini.varad...@oracle.com] > Sent: Wednesday, November 04, 2015 3:21 PM > > This is the i40e equivalent of commit c762dff24c06 ("ixgbe: Look up MAC > address in Open Firmware or IDPROM"). > > As with that fix, attempt to look up the MAC address in Open Firmware

RE: [PATCH v5] i40e: Look up MAC address in Open Firmware or IDPROM

2015-11-04 Thread Nelson, Shannon
> From: Sowmini Varadhan [mailto:sowmini.varad...@oracle.com] > Sent: Wednesday, November 04, 2015 11:40 AM > > > This is the i40e equivalent of commit c762dff24c06 ("ixgbe: Look up MAC > address in Open Firmware or IDPROM"). > > As with that fix, attempt to look up the MAC address in Open Firmw

RE: [PATCH v5] i40e: Look up MAC address in Open Firmware or IDPROM

2015-11-04 Thread Nelson, Shannon
> From: Andy Shevchenko [mailto:andy.shevche...@gmail.com] > Sent: Wednesday, November 04, 2015 11:59 AM > > On Wed, Nov 4, 2015 at 9:39 PM, Sowmini Varadhan > wrote: > > > > This is the i40e equivalent of commit c762dff24c06 ("ixgbe: Look up MAC > > address in Open Firmware or IDPROM"). [...]

RE: [PATCH v4 RFC net] i40e: Look up MAC address in Open Firmware or IDPROM

2015-11-02 Thread Nelson, Shannon
> -Original Message- > From: Sowmini Varadhan [mailto:sowmini.varad...@oracle.com] > Sent: Sunday, November 01, 2015 8:25 AM > > This is the i40e equivalent of commit c762dff24c06 ("ixgbe: Look up MAC > address in Open Firmware or IDPROM"). > > As with that fix, attempt to look up the M

RE: [PATCH v3 net] i40e: Look up MAC address in Open Firmware or IDPROM

2015-11-01 Thread Nelson, Shannon
> -Original Message- > From: Sowmini Varadhan [mailto:sowmini.varad...@oracle.com] > Sent: Sunday, November 01, 2015 8:24 AM > [...] > So I figured out why it all "seemed to work" - my test env had another > obscure init process that was marking the link promiscuous. I guess > that was

RE: [PATCH v3 net] i40e: Look up MAC address in Open Firmware or IDPROM

2015-10-30 Thread Nelson, Shannon
> -Original Message- > From: Sowmini Varadhan [mailto:sowmini.varad...@oracle.com] > Sent: Friday, October 30, 2015 12:25 PM > > On (10/30/15 18:57), Nelson, Shannon wrote: > > > > > > > > Going along with this being the equivalent of the ixgbe pa

RE: [PATCH v3 net] i40e: Look up MAC address in Open Firmware or IDPROM

2015-10-30 Thread Nelson, Shannon
> -Original Message- > From: Sowmini Varadhan [mailto:sowmini.varad...@oracle.com] > Sent: Friday, October 30, 2015 11:37 AM > To: > Subject: Re: [PATCH v3 net] i40e: Look up MAC address in Open Firmware or > IDPROM > > On (10/30/15 18:28), Nelson, Shannon wrote:

RE: [PATCH v3 net] i40e: Look up MAC address in Open Firmware or IDPROM

2015-10-30 Thread Nelson, Shannon
> -Original Message- > From: Sowmini Varadhan [mailto:sowmini.varad...@oracle.com] > Sent: Friday, October 30, 2015 8:04 AM > To: > Subject: [PATCH v3 net] i40e: Look up MAC address in Open Firmware or IDPROM > > > This is the i40e equivalent of commit c762dff24c06 ("ixgbe: Look up MAC >

RE: [PATCH] intel: i40e: fix confused code

2015-10-20 Thread Nelson, Shannon
> -Original Message- > From: Rasmus Villemoes [mailto:li...@rasmusvillemoes.dk] > Sent: Saturday, October 17, 2015 1:58 PM > Subject: [PATCH] intel: i40e: fix confused code > > This code is pretty confused. The variable name 'bytes_not_copied' > clearly indicates that the programmer knew t

RE: [PATCH] intel: i40e: fix confused code

2015-10-20 Thread Nelson, Shannon
> From: Rasmus Villemoes [mailto:li...@rasmusvillemoes.dk] > Sent: Tuesday, October 20, 2015 12:22 AM > > On Mon, Oct 19 2015, "Nelson, Shannon" wrote: > > >> From: Rasmus Villemoes [mailto:li...@rasmusvillemoes.dk] > >> Sent: Saturday, October 17, 201

RE: [PATCH] intel: i40e: fix confused code

2015-10-19 Thread Nelson, Shannon
> From: Rasmus Villemoes [mailto:li...@rasmusvillemoes.dk] > Sent: Saturday, October 17, 2015 1:58 PM > Subject: [PATCH] intel: i40e: fix confused code > > This code is pretty confused. The variable name 'bytes_not_copied' > clearly indicates that the programmer knew the semantics of > copy_{to,fr

RE: [E1000-devel] [PATCH 0/4] i40e: Neatening and object size reductions

2013-09-03 Thread Nelson, Shannon
> -Original Message- > From: Joe Perches [mailto:j...@perches.com] > Sent: Tuesday, September 03, 2013 6:31 PM > > On Wed, 2013-09-04 at 01:00 +, Nelson, Shannon wrote: > > Hi Shannon. > > > > -Original Message- > From: Joe Perches

RE: [E1000-devel] [PATCH 0/4] i40e: Neatening and object size reductions

2013-09-03 Thread Nelson, Shannon
> -Original Message- > From: Joe Perches [mailto:j...@perches.com] > Sent: Friday, August 30, 2013 4:06 PM > > Just some potential cleanings... > i40e: Whitespace cleaning Hmmm, we hadn't noticed the new experimental "--fix" option before. There are a lot of good suggestions there, b

RE: ioatdma Self-test copy timeout

2008-02-19 Thread Nelson, Shannon
>-Original Message- >From: Tomas Hlavacek [mailto:[EMAIL PROTECTED] >Sent: Sunday, February 17, 2008 6:22 PM >To: Nelson, Shannon; linux-kernel@vger.kernel.org >Subject: ioatdma Self-test copy timeout > >Short description: In 2.6.25-rc2 ioatdma driver fails to >

RE: [RFC v3 4/7] dmaengine: Add slave DMA interface

2008-02-19 Thread Nelson, Shannon
>From: Haavard Skinnemoen [mailto:[EMAIL PROTECTED] >Sent: Monday, February 18, 2008 5:30 AM >To: Nelson, Shannon >Cc: Haavard Skinnemoen; Williams, Dan J; >linux-kernel@vger.kernel.org; David Brownell; >[EMAIL PROTECTED]; Francis Moreau; Paul Mundt; Vladimir A. >B

RE: [RFC v3 4/7] dmaengine: Add slave DMA interface

2008-02-15 Thread Nelson, Shannon
>From: Haavard Skinnemoen [mailto:[EMAIL PROTECTED] >Sent: Friday, February 15, 2008 1:53 AM >To: Haavard Skinnemoen >Cc: Williams, Dan J; linux-kernel@vger.kernel.org; Nelson, >Shannon; David Brownell; [EMAIL PROTECTED]; Francis >Moreau; Paul Mundt; Vladimir A. Barinov; Pier

RE: [PATCH][I/OAT]: Remove duplicate assignation in dma_skb_copy_datagram_iovec

2008-02-13 Thread Nelson, Shannon
>-Original Message- >From: Brice Goglin [mailto:[EMAIL PROTECTED] >Sent: Wednesday, February 13, 2008 1:05 PM >To: Nelson, Shannon; Williams, Dan J >Cc: Leech, Christopher; LKML >Subject: [PATCH][I/OAT]: Remove duplicate assignation in >dma_skb_copy_datagram_iov

RE: [PATCH 2/4] async_tx: fix multiple dependency submission

2008-02-13 Thread Nelson, Shannon
>-Original Message- >From: Williams, Dan J >Sent: Tuesday, February 12, 2008 11:03 PM >To: linux-kernel@vger.kernel.org >Cc: [EMAIL PROTECTED]; Nelson, Shannon; [EMAIL PROTECTED]; >[EMAIL PROTECTED] >Subject: [PATCH 2/4] async_tx: fix multiple dependency submis

RE: [PATCH 3/4] async_tx: kill ->device_dependency_added

2008-02-13 Thread Nelson, Shannon
>-Original Message- >From: Williams, Dan J >Sent: Tuesday, February 12, 2008 11:03 PM >To: linux-kernel@vger.kernel.org >Cc: [EMAIL PROTECTED]; Nelson, Shannon; [EMAIL PROTECTED]; >[EMAIL PROTECTED] >Subject: [PATCH 3/4] async_tx: kill ->device_dependency_added

RE: IOATDMA: driver oopses on request_irq()

2008-01-17 Thread Nelson, Shannon
>-Original Message- >From: Chuck Ebbert [mailto:[EMAIL PROTECTED] >Sent: Thursday, January 17, 2008 4:01 PM >To: Nelson, Shannon >Cc: linux-kernel >Subject: IOATDMA: driver oopses on request_irq() > >https://bugzilla.redhat.com/show_bug.cgi?id=311991 >

RE: [PATCH 2/4] async_tx: kill tx_set_src and tx_set_dest methods

2008-01-04 Thread Nelson, Shannon
>From: Williams, Dan J > >The tx_set_src and tx_set_dest methods were originally >implemented to allow >an array of addresses to be passed down from async_xor to the dmaengine >driver while minimizing stack overhead. Removing these methods allows >drivers to have all transaction parameters avail

RE: [PATCH 3/4] async_tx: replace 'int_en' with operation preparationflags

2008-01-04 Thread Nelson, Shannon
>From: Williams, Dan J > >Pass a full set of flags to drivers' per-operation 'prep' routines. >Currently the only flag passed is DMA_PREP_INTERRUPT. The >expectation is >that arch-specific async_tx_find_channel() implementations can >exploit this >capability to find the best channel for an oper

RE: [2.6 patch] #if 0 dma_async_memcpy_buf_to_buf()

2008-01-01 Thread Nelson, Shannon
>From: Alan Cox [mailto:[EMAIL PROTECTED] >Sent: Tuesday, January 01, 2008 6:26 AM >To: Adrian Bunk >Cc: Nelson, Shannon; Williams, Dan J; linux-kernel@vger.kernel.org >Subject: Re: [2.6 patch] #if 0 dma_async_memcpy_buf_to_buf() > >On Tue, 1 Jan 2008 15:49:24 +0200 >Adria

RE: [PATCH] drivers/dma/ioat_dma.c: inlining failed

2007-12-14 Thread Nelson, Shannon
>-Original Message- >From: S.Çağlar Onur [mailto:[EMAIL PROTECTED] >Sent: Friday, December 14, 2007 11:45 AM >To: linux-kernel@vger.kernel.org >Cc: Nelson, Shannon >Subject: [PATCH] drivers/dma/ioat_dma.c: inlining failed > >Hi; > >After commit 7bb67c14fd

RE: [PATCH v2] dmaengine: Simple DMA memcpy test client

2007-12-14 Thread Nelson, Shannon
>From: Olof Johansson [mailto:[EMAIL PROTECTED] >Sent: Thursday, December 13, 2007 7:32 PM >To: Haavard Skinnemoen >Cc: Nelson, Shannon; Williams, Dan J; >linux-kernel@vger.kernel.org; Sam Ravnborg >Subject: Re: [PATCH v2] dmaengine: Simple DMA memcpy test client > >On Fr

RE: [PATCH] dmaengine: Simple DMA memcpy test client

2007-11-20 Thread Nelson, Shannon
>-Original Message- >From: Haavard Skinnemoen [mailto:[EMAIL PROTECTED] > >This client tests DMA memcpy using various lengths and various offsets >into the source and destination buffers. It will initialize both >buffers with a know pattern and verify that the DMA engine copies the >reques

Re: [PATCH][RT] 2.6.24-rc2-rt1 drivers/dma/ioat_dma.c compile fix

2007-11-16 Thread Nelson, Shannon
On Nov 16, 2007 3:57 AM, Sven-Thorsten Dietrich <[EMAIL PROTECTED]> wrote: > Compile fix for new code in -rc2. > > I'm not positive about the insertion point... > > Subject: compile error fix (needs review) > > RT changes __list_splice to require prev and next pointers. > > This changes the use

RE: [PATCH] DMA: Fix broken device refcounting

2007-10-29 Thread Nelson, Shannon
>From: Williams, Dan J >On Sat, 2007-10-27 at 06:49 -0700, Haavard Skinnemoen wrote: >> On Fri, 26 Oct 2007 09:36:17 -0700 >> Dan Williams <[EMAIL PROTECTED]> wrote: >> >> > @@ -221,7 +220,6 @@ void dma_chan_cleanup(struct kref *kref) >> > { >> > struct dma_chan *chan = container_of(kref,

RE: [PATCH] DMA: Fix broken device refcounting

2007-10-26 Thread Nelson, Shannon
>-Original Message- >From: Nelson, Shannon >Sent: Friday, October 26, 2007 10:00 AM >To: 'Haavard Skinnemoen' >Cc: Williams, Dan J; linux-kernel@vger.kernel.org; >[EMAIL PROTECTED] >Subject: RE: [PATCH] DMA: Fix broken device refcounting > >-- > &

RE: [PATCH] DMA: Fix broken device refcounting

2007-10-26 Thread Nelson, Shannon
>From: Haavard Skinnemoen [mailto:[EMAIL PROTECTED] > >When a DMA device is unregistered, its reference count is decremented >twice for each channel: Once dma_class_dev_release() and once in >dma_chan_cleanup(). This may result in the DMA device driver's >remove() function completing before all ch

RE: [PATCH] Remove bogus default y for DMAR and NET_DMA

2007-10-24 Thread Nelson, Shannon
>From: Jeff Garzik [mailto:[EMAIL PROTECTED] > >Andi Kleen wrote: >> Index: linux-2.6.24-rc1-hack/arch/x86_64/Kconfig >> === >> --- linux-2.6.24-rc1-hack.orig/arch/x86_64/Kconfig >> +++ linux-2.6.24-rc1-hack/arch/x86_64/Kconfig >> @@

RE: [PATCH] DMA: Correct invalid assumptions in the Kconfig text

2007-10-24 Thread Nelson, Shannon
>From: Haavard Skinnemoen [mailto:[EMAIL PROTECTED] >Subject: [PATCH] DMA: Correct invalid assumptions in the Kconfig text > >This patch corrects what I hope are invalid assumptions about the DMA >engine layer: Not only Intel(R) hardware can do DMA, and DMA can be >used for other things than memcp

RE: [PATCH] I/OAT: Add support for version 2 of ioatdma device

2007-10-23 Thread Nelson, Shannon
>From: Andrew Morton [mailto:[EMAIL PROTECTED] >On Fri, 19 Oct 2007 00:20:25 -0700 >Shannon Nelson <[EMAIL PROTECTED]> wrote: > >> Add support for version 2 of the ioatdma device. This device handles >> the descriptor chain and DCA services slightly differently: >> - Instead of moving the dma de

RE: [PATCH 5/5] I/OAT: Add completion callback for async_tx interface use

2007-10-17 Thread Nelson, Shannon
>From: David Miller [mailto:[EMAIL PROTECTED] > >From: Andrew Morton <[EMAIL PROTECTED]> >Date: Wed, 17 Oct 2007 17:44:38 -0700 > >> On Wed, 17 Oct 2007 17:14:39 -0700 >> Shannon Nelson <[EMAIL PROTECTED]> wrote: >> >> > + tx->callback = (void *)ioat_dma_test_callback; >> >> and when I remove t

RE: [PATCH 5/5] I/OAT: Add completion callback for async_tx interface use

2007-10-17 Thread Nelson, Shannon
>From: Andrew Morton [mailto:[EMAIL PROTECTED] > >On Wed, 17 Oct 2007 17:14:39 -0700 >Shannon Nelson <[EMAIL PROTECTED]> wrote: [...] >> +static dma_async_tx_callback ioat_dma_test_callback(void >*dma_async_param) >> +{ >> +printk(KERN_ERR "ioatdma: ioat_dma_test_callback(0x%04llx)\n", >> +

RE: [PATCH 4/5] I/OAT: Tighten descriptor setup performance

2007-10-17 Thread Nelson, Shannon
>-Original Message- >From: Andrew Morton [mailto:[EMAIL PROTECTED] > >On Wed, 17 Oct 2007 17:14:33 -0700 >Shannon Nelson <[EMAIL PROTECTED]> wrote: > >> The change to the async_tx interface cost this driver some >performance by >> spreading the descriptor setup across several functions,

RE: [PATCH] drivers/pci, drivers/dma: kill unused vars

2007-10-15 Thread Nelson, Shannon
>-Original Message- >From: Jeff Garzik [mailto:[EMAIL PROTECTED] >Sent: Saturday, October 13, 2007 12:07 PM >To: Andrew Morton; Linus Torvalds >Cc: LKML; Greg KH; Nelson, Shannon; Williams, Dan J >Subject: [PATCH] drivers/pci, drivers/dma: kill unused vars > > &

RE: [PATCH 2.6.23-rc7 1/3] async_tx: usage documentation and developernotes

2007-09-21 Thread Nelson, Shannon
>From: Williams, Dan J >Sent: Thursday, September 20, 2007 6:28 PM >To: linux-kernel@vger.kernel.org; [EMAIL PROTECTED]; >[EMAIL PROTECTED] >Cc: [EMAIL PROTECTED]; [EMAIL PROTECTED]; >[EMAIL PROTECTED]; Nelson, Shannon >Subject: [PATCH 2.6.23-rc7 1/3] async_tx: usag

RE: [PATCH] Remove an unused variable from the Intel I/OAT DMA engine driver

2007-09-17 Thread Nelson, Shannon
>-Original Message- >From: Jesper Juhl [mailto:[EMAIL PROTECTED] >Sent: Sunday, September 16, 2007 2:32 PM >To: linux-kernel@vger.kernel.org >Cc: Nelson, Shannon; Leech, Christopher; Jesper Juhl >Subject: [PATCH] Remove an unused variable from the Intel >I/

RE: [PATCH 5/5] Add DMA engine driver for Freescale MPC85xx processors.

2007-09-11 Thread Nelson, Shannon
>From: Scott Wood [mailto:[EMAIL PROTECTED] >Sent: Tuesday, September 11, 2007 7:20 AM >To: Zhang Wei-r63237 >Cc: Nelson, Shannon; [EMAIL PROTECTED]; >[EMAIL PROTECTED]; Williams, Dan J; linux-kernel@vger.kernel.org >Subject: Re: [PATCH 5/5] Add DMA engine driver for F

FW: [-mm patch] drivers/dma/ioat_dma.c: make 3 functions static

2007-09-10 Thread Nelson, Shannon
> From: Adrian Bunk [mailto:[EMAIL PROTECTED] > Sent: Sunday, September 09, 2007 1:25 PM > To: Andrew Morton; Nelson, Shannon; Williams, Dan J > Cc: linux-kernel@vger.kernel.org > Subject: [-mm patch] drivers/dma/ioat_dma.c: make 3 functions static > Thanks Adrian, sln >On

RE: [PATCH 5/5] Add DMA engine driver for Freescale MPC85xx processors.

2007-09-07 Thread Nelson, Shannon
>From: Zhang Wei [mailto:[EMAIL PROTECTED] >Sent: Friday, September 07, 2007 3:54 AM >To: [EMAIL PROTECTED]; Nelson, Shannon >Cc: linux-kernel@vger.kernel.org; [EMAIL PROTECTED]; >[EMAIL PROTECTED]; Zhang Wei; Ebony Zhu >Subject: [PATCH 5/5] Add DMA engine driver for F

RE: [PATCH -mm] [RFC] IOAT: Add support for version 2 of ioatdma device

2007-09-07 Thread Nelson, Shannon
>From: Andy Whitcroft [mailto:[EMAIL PROTECTED] > >Those two look suspect to checkpatch, and I have to agree with it. > >WARNING: Trailing semicolon indicates no statements, indent implies >otherwise >#346: FILE: drivers/dma/ioat_dma.c:168: >+ if (--cnt == 0); >+

RE: [PATCH v2 -mm 7/7] I/OAT: Add DCA services

2007-08-24 Thread Nelson, Shannon
Randy Dunlap [mailto:[EMAIL PROTECTED] > >On Thu, 23 Aug 2007 17:15:27 -0700 Shannon Nelson wrote: > [...] >> + >> +/* THIS STUFF NEEDS TO LIVE SOMEWHERE ELSE */ >> +#define X86_FEATURE_DCA (4*32+18) /* Direct Cache Access */ >> +/* / THIS STUFF NEEDS TO LIVE SOMEWHERE ELSE */ > >Yes, feature

RE: [PATCH v2 -mm 5/7] I/OAT: Add support for MSI and MSI-X

2007-08-24 Thread Nelson, Shannon
Randy Dunlap [mailto:[EMAIL PROTECTED] > >On Thu, 23 Aug 2007 17:15:17 -0700 Shannon Nelson wrote: > >> Add support for MSI and MSI-X interrupt handling, including >the ability >> to choose the desired interrupt method. >> >> Signed-off-by: Shannon Nelson <[EMAIL PROTECTED]> >> Acked-by: David S

RE: [PATCH v2 -mm 4/7] I/OAT: Split PCI startup from DMA handling code

2007-08-24 Thread Nelson, Shannon
Randy Dunlap [mailto:[EMAIL PROTECTED] > >On Thu, 23 Aug 2007 17:15:12 -0700 Shannon Nelson wrote: > >> Split the general PCI startup from the DMA handling code in order to >> prepare for adding support for DCA services and future >versions of the >> ioatdma device. >> >> Signed-off-by: Shannon

RE: [PATCH v2 -mm 6/7] DCA: Add Direct Cache Access driver

2007-08-24 Thread Nelson, Shannon
Randy Dunlap [mailto:[EMAIL PROTECTED] > >On Thu, 23 Aug 2007 17:15:22 -0700 Shannon Nelson wrote: > >> Signed-off-by: Shannon Nelson <[EMAIL PROTECTED]> >> Acked-by: David S. Miller <[EMAIL PROTECTED]> >> --- >> >> drivers/Kconfig |2 + >> drivers/Makefile|1 >> drivers

RE: [PATCH v2 -mm 3/7] I/OAT: code cleanup from checkpatch output

2007-08-24 Thread Nelson, Shannon
Randy Dunlap [mailto:[EMAIL PROTECTED] >Sent: Thursday, August 23, 2007 10:39 PM >To: Nelson, Shannon >Cc: [EMAIL PROTECTED]; linux-kernel@vger.kernel.org; >[EMAIL PROTECTED] >Subject: Re: [PATCH v2 -mm 3/7] I/OAT: code cleanup from >checkpatch output > >On Thu, 23

RE: [PATCH -mm] IOAT: fix for UP use of cpu_physical_id()

2007-08-20 Thread Nelson, Shannon
>-Original Message- >From: H. Peter Anvin [mailto:[EMAIL PROTECTED] >Sent: Monday, August 20, 2007 3:27 PM >To: Nelson, Shannon >Cc: [EMAIL PROTECTED]; linux-kernel@vger.kernel.org; >[EMAIL PROTECTED]; [EMAIL PROTECTED]; Luck, Tony >Subject: Re: [PATCH -mm] IO

RE: [-mm PATCH] DMA engine kconfig improvements (rev2)

2007-08-17 Thread Nelson, Shannon
>From: Adrian Bunk [mailto:[EMAIL PROTECTED] >Sent: Thursday, August 16, 2007 5:48 PM >To: Nelson, Shannon >Cc: [EMAIL PROTECTED]; linux-kernel@vger.kernel.org; >Williams, Dan J; [EMAIL PROTECTED] >Subject: Re: [-mm PATCH] DMA engine kconfig improvements (rev2) > >On Th

RE: [-mm patch] DMA engine kconfig improvements

2007-08-15 Thread Nelson, Shannon
>From: Adrian Bunk [mailto:[EMAIL PROTECTED] >Sent: Wednesday, July 25, 2007 10:26 PM >To: Andrew Morton; Nelson, Shannon >Cc: linux-kernel@vger.kernel.org >Subject: [-mm patch] DMA engine kconfig improvements > >On Wed, Jul 25, 2007 at 04:03:04AM -0700, Andrew Morton wr

[GIT PATCH] I/OAT: Add support for DCA - Direct Cache Access

2007-07-26 Thread Nelson, Shannon
Linus, In order to include support for DCA (Direct Cache Access) from IOAT, please pull from my git tree at git://lost.foo-projects.org/~sln/linux-2.6 dma-upstream This will update the drivers as shown below. These were orignially posted and Ack'd last week. http://marc.info/?l=linux-ker

RE: [PATCH -mm] dma: INTEL_IOATDMA build fix

2007-07-25 Thread Nelson, Shannon
Satyam Sharma [mailto:[EMAIL PROTECTED] > >Make CONFIG_INTEL_IOATDMA select CONFIG_DCA because it uses code >exported from said dependency: > ># CONFIG_DCA is not set >CONFIG_INTEL_IOATDMA=m > >ERROR: "alloc_dca_provider" [drivers/dma/ioatdma.ko] undefined! >ERROR: "register_dca_provider" [drivers

RE: __unsafe() usage

2007-07-23 Thread Nelson, Shannon
Rusty Russell [mailto:[EMAIL PROTECTED] >> If this is true, and since the MOD_INC_USE_COUNT compat code is long >> gone, shouldn't we be able to completely remove __unsafe() and the >> struct member "unsafe"? > >Yes, indeed, something like this: >== >Remove "unsafe" from module struct > >Adrian

RE: drivers/dma/ioatdma.c - address of '__this_module' will always evaluate as 'true' , warning

2007-07-23 Thread Nelson, Shannon
Gabriel C [mailto:[EMAIL PROTECTED] >Nelson, Shannon wrote: >> Gabriel C [mailto:[EMAIL PROTECTED] >>> Hi, >>> >>> I got this warning on current git using gcc 4.2.1 : >>> >>> ... >>> >>> drivers/dma/ioatdma.c: In function &#

RE: drivers/dma/ioatdma.c - address of '__this_module' will always evaluate as 'true' , warning

2007-07-23 Thread Nelson, Shannon
Gabriel C [mailto:[EMAIL PROTECTED] > >Hi, > >I got this warning on current git using gcc 4.2.1 : > >... > >drivers/dma/ioatdma.c: In function 'ioat_init_module': >drivers/dma/ioatdma.c:816: warning: the address of >'__this_module' will always evaluate as 'true' Can you forward a copy of your .c

RE: DMA Engine vs. DMA Transfer API

2007-07-22 Thread Nelson, Shannon
Clifford Wolf [mailto:[EMAIL PROTECTED] > >Hi Shannon, hi lkml, Hi Clifford, >I'm writing a driver for the built-in DMA controller of the Freescale >MPC8349E PowerPC based microcontroller. Unfortunately the DMA-Engine >API seams to be the totally wrong thing for that since this >DMA controller

RE: [PATCH 5/7] I/OAT: Add support for MSI and MSI-X

2007-07-20 Thread Nelson, Shannon
Manu Abraham [mailto:[EMAIL PROTECTED] > >Ok. Thanks for clearing it up. So the idea would be that if >pci_enable_msix() for "n" number of messages failed, then settle down >for 1 message, which is equivalent to MSI mode > yep - To unsubscribe from this list: send the line "unsubscribe linux-kern

RE: [PATCH 5/7] I/OAT: Add support for MSI and MSI-X

2007-07-20 Thread Nelson, Shannon
Manu Abraham [mailto:[EMAIL PROTECTED] >Sorry for being not clear. What i was asking is thus: > >A device that has legacy interrupts and MSI-X. I was thinking that if >MSI-X failed one should fall back to MSI mode (single message), that's >what i was assuming. > >In such a case, i do enable MSI-X

RE: [PATCH 5/7] I/OAT: Add support for MSI and MSI-X

2007-07-20 Thread Nelson, Shannon
Roland Dreier [mailto:[EMAIL PROTECTED] > >OK, let's try to avoid going off into the weeds here. In the context >of the specific patch that this thread started with, is there any >point in having both "msix-single-vector" and "msi" interrupt support? Some versions of this hardware support MSI-X

RE: [PATCH 6/7] DCA: Add Direct Cache Access driver

2007-07-20 Thread Nelson, Shannon
David Miller [mailto:[EMAIL PROTECTED] > >> +static spinlock_t dca_lock; > ... >> +spin_lock_init(&dca_lock); > >It's easier to use DEFINE_SPINLOCK(). > Thanks - I'll adjust that in a future patch. sln -- == Mr. Shannon Nelso

RE: [PATCH 4/7] I/OAT: Split PCI startup from DMA handling code

2007-07-20 Thread Nelson, Shannon
Andrey Panin [mailto:[EMAIL PROTECTED] > >Why this driver lacks MODULE_DEVICE_TABLE() ? Is it >intentionaly omitted ? Hmmm - good catch. It has been missing for a long time in the code. I'll double check with the original developer to see if it was left out on purpose and probably add it in a l

[PATCH] Add entries to MAINTAINERS for I/OAT and DMAENGINE

2007-07-11 Thread Nelson, Shannon
Add entries to MAINTAINERS for I/OAT and DMAENGINE Signed-off-by: Shannon Nelson <[EMAIL PROTECTED]> diff --git a/MAINTAINERS b/MAINTAINERS index 151f4ef..e27b807 100644 --- a/MAINTAINERS +++ b/MAINTAINERS @@ -1277,6 +1277,12 @@ M: [EMAIL PROTECTED] L: [EMAIL PROTECTED] S: Mainta

RE: [RFC][PATCH] DMA: Expand dmaengine implementation for more DMACs

2007-07-11 Thread Nelson, Shannon
Dan Williams [mailto:[EMAIL PROTECTED] >On 7/3/07, Peter Pearse <[EMAIL PROTECTED]> wrote: >> Hi, >> >> The existing DMAC used by the dmaengine API (Intel IOAT) assumes all >> possible clients can use any available DMA channel. >> >> Some other DMACs restrict particular peripherals to >particular

RE: -mm merge plans for 2.6.23 - ioat/dma engine

2007-07-10 Thread Nelson, Shannon
Andrew Morton [mailto:[EMAIL PROTECTED] > >I am presently pulling >git://lost.foo-projects.org/~cleech/linux-2.6#master >into -mm. > >Will you be taking over the IOAT git tree? If so, please send me a >suitable git URL when it's ready. I'll be getting there Real Soon Now. The transition seems

RE: -mm merge plans for 2.6.23 - ioat/dma engine

2007-07-10 Thread Nelson, Shannon
Kok, Auke wrote: >Andrew Morton wrote: >> git-ioat-vs-git-md-accel.patch >> ioat-warning-fix.patch >> fix-i-oat-for-kexec.patch >> >> I don't seem to be able to get rid of these. Chris Leech >appears to have >> vanished. > >Chris is a moving target. Thankfully we have Shannon Nelson >taking