>From: David Miller [mailto:[EMAIL PROTECTED] > >From: Andrew Morton <[EMAIL PROTECTED]> >Date: Wed, 17 Oct 2007 17:44:38 -0700 > >> On Wed, 17 Oct 2007 17:14:39 -0700 >> Shannon Nelson <[EMAIL PROTECTED]> wrote: >> >> > + tx->callback = (void *)ioat_dma_test_callback; >> >> and when I remove this cast I get >> >> drivers/dma/ioat_dma.c: In function 'ioat_dma_self_test': >> drivers/dma/ioat_dma.c:718: warning: assignment from >incompatible pointer type >> >> because ioat_dma_test_callback isn't void-returning. >Something is wrong >> here. I assume that ioat_dma_test_callback() should just be >> void-returning? > >In fact this might crash on systems that conditionally pop >return values based upon whether the function is void or not. >
Yep - thanks. That's my misuse of Dan's dma_async_tx_callback typedef. sln - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
