>-----Original Message----- >From: H. Peter Anvin [mailto:[EMAIL PROTECTED] >Sent: Monday, August 20, 2007 3:27 PM >To: Nelson, Shannon >Cc: [EMAIL PROTECTED]; linux-kernel@vger.kernel.org; >[EMAIL PROTECTED]; [EMAIL PROTECTED]; Luck, Tony >Subject: Re: [PATCH -mm] IOAT: fix for UP use of cpu_physical_id() > >Shannon Nelson wrote: >> Make sure we can use cpu_physical_id() even when compiled for >> uni-processor. >> >> diff --git a/drivers/dma/ioat_dca.c b/drivers/dma/ioat_dca.c >> index c3a500b..b1af49c 100644 >> --- a/drivers/dma/ioat_dca.c >> +++ b/drivers/dma/ioat_dca.c >> @@ -25,6 +25,14 @@ >> #include <linux/smp.h> >> #include <linux/interrupt.h> >> #include <linux/dca.h> >> + >> +// either a kernel change is needed, or we need something >like this in kernel >> +#ifndef CONFIG_SMP >> +#include <asm/smp.h> >> +#undef cpu_physical_id >> +#define cpu_physical_id(cpu) (cpuid_ebx(1) >> 24) >> +#endif >> + > >This value should probably be cached. Executing cpuid to get a static >value seems like a bad idea.
Yeah, this whole cpu_physical_id() gizmo needs to be fixed so it is actually usable for non-SMP configurations. Unfortunately, I'm not the guy to do it. sln -- ====================================================================== Mr. Shannon Nelson LAN Access Division, Intel Corp. [EMAIL PROTECTED] I don't speak for Intel (503) 712-7659 Parents can't afford to be squeamish. - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
