Randy Dunlap [mailto:[EMAIL PROTECTED] >Sent: Thursday, August 23, 2007 10:39 PM >To: Nelson, Shannon >Cc: [EMAIL PROTECTED]; linux-kernel@vger.kernel.org; >[EMAIL PROTECTED] >Subject: Re: [PATCH v2 -mm 3/7] I/OAT: code cleanup from >checkpatch output > >On Thu, 23 Aug 2007 17:15:06 -0700 Shannon Nelson wrote: > >> Take care of a bunch of little code nits in ioatdma files >> >> Signed-off-by: Shannon Nelson <[EMAIL PROTECTED]> >> Acked-by: David S. Miller <[EMAIL PROTECTED]> >> --- >> >> drivers/dma/ioat_dma.c | 200 >+++++++++++++++++++++++++++--------------------- >> 1 files changed, 111 insertions(+), 89 deletions(-) >> >> diff --git a/drivers/dma/ioat_dma.c b/drivers/dma/ioat_dma.c >> index 55227d4..9a4d154 100644 >> --- a/drivers/dma/ioat_dma.c >> +++ b/drivers/dma/ioat_dma.c > >> - printk(KERN_INFO "Intel(R) I/OAT DMA Engine found, %d channels\n", >> - device->common.chancnt); >> + printk(KERN_INFO " " >> + "ioatdma: Intel(R) I/OAT DMA Engine found, %d channels\n", >> + device->common.chancnt); >> >> err = ioat_self_test(device); >> if (err) > >> @@ -764,7 +784,8 @@ err_set_dma_mask: >> pci_disable_device(pdev); >> err_enable_device: >> >> - printk(KERN_ERR "Intel(R) I/OAT DMA Engine initialization failed\n"); >> + printk(KERN_INFO " " >> + "ioatdma: Intel(R) I/OAT DMA Engine initialization failed\n"); >> >> return err; >> } > >What's with these (KERN_INFO " " > "...more strings"); >??
These are admittedly not the smartest move, but they are replaced later in the patch-set. sln -- ====================================================================== Mr. Shannon Nelson LAN Access Division, Intel Corp. [EMAIL PROTECTED] I don't speak for Intel (503) 712-7659 Parents can't afford to be squeamish. - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/