> -// OD 09.01.2003 #i6467# - adjust view shell option to the same as for
> print
> +// adjust view shell option to the same as for print
We generally want to leave the #iX#-style comments around, as they
point to the publicly accessible OpenOffice.org issue tracker. OTOH, the
#X#
On Sat, Jan 29, 2011 at 03:50:37PM +0100, Soeren Moeller wrote:
> Hi
>
> In our effort of replacing deprecated data types from tools/ by std::
> types we would like to use gprof for profiling (to choose the right
> data types). But unfortunately, we don't know to set the -pg flag,
export ENVCFLAG
On Tue, Feb 01, 2011 at 10:47:38AM +, Michael Meeks wrote:
>
> Shouldn't be impossibly hard to add some simple filtering to that for
> built-in / bundled extensions that would hide most of them from people
> and default to not showing bundled extensions.
>
> I'll add an easy hack
Hi, Peter,
> +/*
> + * FLABridge provides some obscure attribute mangling to wordml2000
> import/export filters.
> + * In the long run, you might want to replace this with an XSLT
> extension function.
> + */
> +class FLABridge : public WeakImplHelper1< DocumentHandlerAdapter
On Thu, Feb 03, 2011 at 12:42:41AM +0100, Kenneth Venken wrote:
> Hi,
>
> this patch replaces all occurrences of DBG_ASSERT with OSL_ENSURE in
> dbacces.
Thanks. In addition, I changed several
#ifdef DBG_UTIL
lines enclosing declarations of variables/functions accessed in the
debug macros to
#
On Wed, Feb 02, 2011 at 08:46:07PM +0900, Suguru Hirahara wrote:
> Hi,
>
> please review this one. changes are available under LGPLv3+ / MPL.
>
I reverted the hunks removing "@author OD" from class/function
descriptions. I think we do not want to remove these.
D.
___
On Thu, Feb 03, 2011 at 01:41:19AM -0700, Tor Lillqvist wrote:
> > Thanks. In addition, I changed several
> > #ifdef DBG_UTIL
> > lines enclosing declarations of variables/functions accessed in the
> > debug macros to
> > #if OSL_DEBUG_LEVEL > 0
>
> Is that something we can/should do in general ev
On Fri, Feb 04, 2011 at 09:03:55PM +0100, Francois Tigeot wrote:
> Hi,
>
> LibreOffice does not build with a stock libtextcat.
>
> The official version seems to be freezed in time (last update is dated
> from 2003) and I understand the need to patch it (and add e.g. utf8
> support), but the chang
On Sun, Feb 06, 2011 at 06:57:00PM -0500, Arno Teigseth wrote:
> Hi
>
> This might be a corner case, but I have this problem:
>
> To not have to go through the "import template" process every time I
> change a template, I symlinked it. So,
Is there any reason why you cannot just import the templ
On Mon, Feb 07, 2011 at 02:10:13AM -0500, Arno Teigseth wrote:
> On Mon, 2011-02-07 at 07:44 +0100, David Tardon wrote:
> > ... exists yet, it just points to a nonexistent file. LibO sees the
> > (symlink) file, so it doesn't allow to import a template with the same
> > n
On Sat, Feb 05, 2011 at 05:20:29PM -0500, Antoine Proulx wrote:
> Hi,
>
> Here's a patch who removes bogus comments. It's released under the
> LGPLv3+ / MPL.
>
> Antoine
>
Hi, Antoine,
bug references like #XX# point to private Sun bugtracker, therefore
they are of no value to us (as opposi
On Sat, Feb 05, 2011 at 11:45:47PM +0100, Wilhelm Pflüger wrote:
> Attached please find some changes to make tests in ure/sal work.
>
> One test fails and breaks the build though - if this is unwanted you may
> revert the change to ure/sal/prj/build.lst. (This is not exactly what is
> intended by
On Sun, Feb 06, 2011 at 09:42:46PM +0100, Xisco Faulí wrote:
> -} section[SECTIONS];
> +} section[SECTIONS] = NULL;
This is false alarm. The struct has default constructor, so the elements
of the array are initialized properly.
> +delete [] level;
This is wrong, because Outli
Forgot to mark as PUSHED.
D.
___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice
On Sat, Feb 05, 2011 at 11:32:18PM +0100, Wilhelm Pflüger wrote:
> Find attached changes to lib-gui/comphelper to get some tests working
> again.
> These patches are LGPLv3+/MPL.
>
> This is my first contribution in this project - so don't hesitate with
> critics if its not the common procedure.
On Sun, Apr 24, 2011 at 02:43:44PM +0200, Andreas Radke wrote:
> [ build LNK ] Library/vbaobj.uno.so
> [ build CXX ] sw/source/ui/utlui/textcontrolcombo
> [ build CXX ] sw/source/ui/utlui/tmplctrl
> [ build CUT ] sc_ucalc
> [ build CXX ] sw/source/ui/utlui/uiitems
> `.L121' referenced in section
>
Hi,
could someone sign-off this small patch?
D.
___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice
On Sun, May 22, 2011 at 01:12:38AM -0500, Norbert Thiebaud wrote:
> On Sun, May 22, 2011 at 1:02 AM, David Tardon wrote:
> > Hi,
> >
> > could someone sign-off this small patch?
>
> David, it would be easier if you actually attach the patch :-)
I
On Tue, May 10, 2011 at 10:17:19AM +0200, Chr. Rossmanith wrote:
> Hi,
> >> (what stands Stt for?)
> once again: Stt means what? The answer might help to understand
> what's going on in that method.
Start :) I guess the original developer of the code wanted to save some
typing...
D.
On Mon, May 23, 2011 at 07:46:52AM -0500, Norbert Thiebaud wrote:
> On Mon, May 23, 2011 at 4:36 AM, David Tardon wrote:
> > On Sun, May 22, 2011 at 01:12:38AM -0500, Norbert Thiebaud wrote:
> >> On Sun, May 22, 2011 at 1:02 AM, David Tardon wrote:
> >> > Hi,
> &
On Sun, May 22, 2011 at 11:41:31AM +0200, Jacek Wolszczak wrote:
> Hi,
>
> I am sending links to patches uploaded to dropbox. I wasn't sure if 1MB
> of attachments would be welcome here.
>
> http://dl.dropbox.com/u/174726/patches/0001-Replace-DBG_-with-OSL_-in-calc-chart2.patch
> http://dl.dropbo
On Sun, May 22, 2011 at 11:41:31AM +0200, Jacek Wolszczak wrote:
> Hi,
>
> I am sending links to patches uploaded to dropbox. I wasn't sure if 1MB
> of attachments would be welcome here.
The patches are good, except:
1. I changed
-#ifdef DBG_UTIL
+#if OSL_DEBUG_LEVEL > 1
to
-#ifdef DBG_UTIL
On Mon, May 30, 2011 at 09:57:16AM +0200, Andor E wrote:
> Hello,
> I'm trying to debug an issue with bookmarks in the Writer import
> filter. Right now my biggest problem is, that I don't know how to get
> information from the UNO reference objects. The import filter uses
> cursors and text ranges
On Tue, May 31, 2011 at 10:27:19AM +0100, Michael Meeks wrote:
> that works. I believe this is just a cut/paste error from dr, and we
> want this instead:
>
> +PTR_CAST(BasicCollection,pVar) == pCollection )
>
> I'll commit that, and wait for screams.
Moreover, I think th
On Mon, Jun 06, 2011 at 12:40:56PM +0200, Cedric Bosdonnat wrote:
> Hi all,
>
> On Mon, 2011-05-23 at 12:55 +0200, Cedric Bosdonnat wrote:
> > That bug was badly fixed (by me) quite some times ago. Here is a correct
> > fix (why did I add that code at all ?). Could you review it and push it
> > in
On Tue, Jun 07, 2011 at 10:48:36PM +0200, Jacek Wolszczak wrote:
> Hi,
>
> BTW, does anyone use DBG_PROFSTART and DBG_PROFSTOP or could these be
> removed altogether?
They are used for profiling. I do not know if anyone here knows about
their existence, so it might well be the simplest thing to r
Hi all,
could someone review commit 01096e7487d9e60fcd24eea8131b650588845f2b in
libs-core for 3.4?
It fixes the following crash scenario:
1. create new presentation
2. press F11 to open stylist
3. right click on a style and click on Modify
4. press Esc (or click Cancel)
5. press F11
It does not
On Sun, Jun 19, 2011 at 09:48:39PM -0700, Joseph Powers wrote:
> I'm sending the patch for review; not because it needs a lot but just to have
> someone verify that the memory was leaking and needs to be fixed.
It has been pushed already, so adding PUSHED to summary.
>
> Current fixes:
> 1. XPr
On Wed, Jul 13, 2011 at 11:15:33PM -0400, Kohei Yoshida wrote:
> Hi there,
>
> I'd like to update mdds to 0.5.3 for the -3-4 branch and preferably the
> -3-4-2 branch as well. The attached patches would make that happen.
>
> That should improve the performance issue raised in
>
> https://bugs.f
On Mon, Jul 18, 2011 at 12:28:55PM -0400, Kohei Yoshida wrote:
> On Mon, 2011-07-18 at 11:47 -0400, Kohei Yoshida wrote:
> > On Mon, 2011-07-18 at 10:25 -0400, Kohei Yoshida wrote:
> >
> > > I'd also
> > > like to push this to the -3-4 branch, but let me just do a quick test on
> > > ODS import of
On Mon, Jul 18, 2011 at 05:33:56PM -0700, Mike Eberdt wrote:
> Hi Christian,
>
> On 07/18/11 04:56, Christian Lohmaier wrote:
> >
> >Hi MIke, *,
> >
> >On Fri, Jul 15, 2011 at 9:34 PM, Mike Eberdt wrote:
> >>
> >>Configure.in eventually gets parsed by /bin/sh, and on Free/Net/OpenBSD
> >>/bin/sh
On Tue, Jul 19, 2011 at 04:29:32PM +0530, Muthu Subramanian K wrote:
> Hi,
>
> +if( maCurrCell.mnSharedId >= 0 )
> +{
> +Reference< XFormulaTokens > xTokens( maCurrCell.mxCell,
> UNO_QUERY_THROW );
> +ExtCellFormulaContext aContext( *this, xTokens,
> maCur
On Tue, Jul 19, 2011 at 02:35:42PM +0200, Markus Mohrhard wrote:
> Hello David,
>
> I think the original version should be safe. Our formula api can't deal with
> broken documents during import especially the oox import can't deal with
> errors of any kinds in formulas. But a broken document won't
On Tue, Jul 19, 2011 at 02:56:04PM -0400, Kohei Yoshida wrote:
> Hi there,
>
> I'd like to have the following commit
>
> http://cgit.freedesktop.org/libreoffice/calc/commit/?id=8da78944e7c4fcae9ae40bea7162898d20db6329
>
> cherry-picked to -3-4 and -3-4-2 in order to fix
>
> https://bugs.freedes
On Wed, Jul 20, 2011 at 11:53:49PM +0200, Thorsten Behrens wrote:
> Hi *,
>
> master has a fix for a mis-typed base class for the
> SfxViewEventHint, unfortunately hidden in merge commit
> libs-core:d3a999619524001821bdc438cac275c441efad9b - which
> effectively prevents a set of document events to
On Mon, Oct 11, 2010 at 11:08:31PM +0200, julien wrote:
> Le 10/10/2010 22:31, julien a écrit :
> I changed the line :
>
> $checkdll "$@"
> by
> gdb $checkdll "$@"
>
There is the problem: this line should be
gdb --args $checkdll "$@"
D.
___
LibreOffi
On Thu, Oct 14, 2010 at 09:33:45AM +0100, Caolán McNamara wrote:
> On Thu, 2010-10-14 at 08:37 +0200, Thomas Klausner wrote:
> > On Wed, Oct 13, 2010 at 05:25:59PM +0200, Thomas Klausner wrote:
> > > I don't see my CFLAGS nor CPPFLAGS, which would make it find boost, in
> > > the gcc arguments.
> >
On Thu, Oct 14, 2010 at 09:11:26AM +0100, Caolán McNamara wrote:
> On Wed, 2010-10-13 at 22:34 +0200, Jacek Wolszczak wrote:
> > http://wiki.services.openoffice.org/wiki/Debug_Levels.
> >
> > Some additional questions. What should I replace DBG_ERROR with?
>
> Hmm, DBG_ERROR takes no condition,
On Sun, Oct 17, 2010 at 06:50:52PM +1300, Luke Symes wrote:
> This patch removes dead code and fixes a few comments in the code for the
> dbase driver in the libs-core repository.
Thanks! Pushed.
D.
___
LibreOffice mailing list
LibreOffice@lists.freedes
On Fri, Oct 15, 2010 at 06:48:34PM +0200, Thomas Klausner wrote:
> On Fri, Oct 15, 2010 at 01:22:46PM +0200, David Tardon wrote:
> > There is ENVCFLAGS for flags to add to $CC and ENVCFLAGSCXX for flags
> > to add to $CXX .
>
> That's a very good tip, thank you.
>
&
On Sun, Oct 17, 2010 at 08:04:27PM +1300, Luke Symes wrote:
> This patch cleans up miscellaneous dead code in libs-core/connectivity/*.
Thanks! Pushed.
D.
___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailma
On Sun, Oct 17, 2010 at 09:46:26PM +0200, Miklos Vajna wrote:
> Hi David,
>
> Your recent commit which removed solenv/inc/sc.mk and
> solenv/inc/scpre.mk in bootstrap.git breaks the build of sc here.
>
> Given that the change is in makefile.mk files, tinderbox won't notice
> it, I assume. ;)
>
On Mon, Oct 18, 2010 at 11:54:32AM +0200, Kenneth Venken wrote:
> Hi,
>
> this patch replaces all hits for "sizeof.*/.*sizeof.*\[" with
> SAL_N_ELEMENTS in libs-gui.
>
> -- Kenneth
Thanks! Pushed.
D.
___
LibreOffice mailing list
LibreOffice@lists.free
On Mon, Oct 18, 2010 at 12:18:23PM +0200, Kenneth Venken wrote:
> Hi,
>
> patches replace sizeof/sizeof[0] with SAL_N_ELEMENTS in testing and sdk
>
> -- Kenneth
Thanks! Pushed.
D.
___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://l
On Tue, Oct 19, 2010 at 09:42:17PM +0200, Kenneth Venken wrote:
> hi,
>
> these patches will replace the last occurrences of
> sizeof(foo)/sizeof(foo[0]) with SAL_N_ELEMENTS(foo)
>
> -- Kenneth
Hi,
I pushed sal_n_elements.libs-gui.diff and sal_n_elements.ure.diff. The
changes the other two do s
On Wed, Oct 20, 2010 at 07:29:56AM +0200, David Tardon wrote:
> On Tue, Oct 19, 2010 at 09:42:17PM +0200, Kenneth Venken wrote:
> > hi,
> >
> > these patches will replace the last occurrences of
> > sizeof(foo)/sizeof(foo[0]) with SAL_N_ELEMENTS(foo)
> >
>
On Mon, Nov 01, 2010 at 09:24:09AM +, Caolán McNamara wrote:
> On Sun, 2010-10-31 at 23:04 -0500, Norbert Thiebaud wrote:
> > ::osl::MutexGuard aSolarGuard (::osl::Mutex::getGlobalMutex());
> > Paint(rEvent.UpdateRect);
>
> > I'm thinking I should change this guard with a SolarMutexGua
On Tue, Nov 02, 2010 at 08:50:55AM +0100, Gert Faller wrote:
> Hi,
>
> a little bit more...
>
Pushed, thanks!
D.
___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice
On Tue, Nov 02, 2010 at 03:10:49PM +0100, Sebastian Spaeth wrote:
> Commit cab7e33c4ff6067486b745ebfc0b37ed1d6d18b7 broke parentheses. Fixing
>
Hi,
you're too late :) Caolan has already fixed it.
D.
___
LibreOffice mailing list
LibreOffice@lists.freed
On Thu, Nov 04, 2010 at 09:54:20PM +0100, Gert Faller wrote:
> Hi,
>
> here are some in 'libs-core'.
>
> Regards.
>
Thanks! I removed some changes
* in BasicManager::SetGlobalUNOConstant, because the variable is function
parameter, not a string constant.
* in ModuleContainer_Impl::getByName,
On Mon, Nov 08, 2010 at 08:10:51PM -0600, Jordan Ayers wrote:
> Miscellaneous cleanup to build.pl. Mostly removal of dead code, with
> a few spelling / German->English fixes.
>
> LGPLv3+/MPL
>
Pushed, thanks!
D.
___
LibreOffice mailing list
LibreOffi
On Tue, Nov 09, 2010 at 03:11:40PM -0500, Kevin Hunter wrote:
> At 12:44pm -0500 Tue, 09 Nov 2010, Kevin Hunter wrote:
> >Here are four more patch conversions from createFromAscii to
> >RTL_CONST... applied against:
> >
> >basebmp/
> >binfilter/
> >bridges/
> >connectivity/
>
> I apologize, I temp
On Tue, Nov 09, 2010 at 09:30:22PM +0100, Joost Eekhoorn wrote:
> Is it correct to have the RTL_CONSTASCII_USTRINGPARAM directly in the *.hxx
> file.
> If so, why not do that also at other places?
>
> MPL 1.1 / GPLv3+ / LGPLv3+
>
> Joost
Pushed, thanks!
D.
__
On Tue, Nov 09, 2010 at 10:24:20PM +, Wols Lists wrote:
> Cheers,
> Wol
Looks fine. Pushed.
> From cb03ee788ea81661ae83ae611806c6050d16af57 Mon Sep 17 00:00:00 2001
> -// use keys and indexes for excat postioning
Would that mean positioning of a dead cat (aka ex-parrot)? :-D
D.
Hi all,
just a heads up: recently I was working on removing the script providers
for BeanShell, JavaScript and Python from standard installation, as they
are only marginally useful and (at least on Fedora) require quite a slew
of dependencies. So, from now on, they are available as plain extension
On Wed, Nov 10, 2010 at 12:54:32PM +, Wols Lists wrote:
> Cheers,
> Wol
Pushed.
D.
___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice
On Wed, Nov 10, 2010 at 02:16:20PM +0100, Gert Faller wrote:
> Hi,
>
> some more...
>
> Regards.
>
Pushed, with several changes from
rtl::OUString foo = rtl::OUString(RTL_CONSTASCII_USTRINGPARAM("blah"));
or
rtl::OUString foo(rtl::OUString(RTL_CONSTASCII_USTRINGPARAM("blah")));
to
rtl::OUS
On Wed, Nov 10, 2010 at 11:53:07PM +0100, julien wrote:
> Hello,
>
> The patch contains only the removing of comments. I haven't removed 1
> line of comment because i don't know what "Wieder raus" mean.
Pushed.
> I would have like to remove a warning too since during compilation, I
> got this :
And now once more with PUSHED in subject...
D.
___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice
On Thu, Nov 11, 2010 at 09:55:02AM +0100, Thorsten Behrens wrote:
> Hi,
>
> following is a list of current QA practices I'm aware of:
>
> Current
> ===
>
> New bugs come in, get assigned to the
> libreoffice-b...@lists.freedesktop.org bug alias (throw me a mail if
> you want to be added ther
On Thu, Nov 11, 2010 at 06:03:31PM -0300, Santiago Alessandri wrote:
> Hi!
>
> I'm attaching the patch for changing the use of createFromAscii
> with RTL_CONSTASCII_USTRINGPARAM in the directories:
> /dbaccess/source/shared/
> /dbaccess/source/ui/app/
> /dbaccess/source/ui/browser/
> /dbaccess/sou
On Thu, Nov 11, 2010 at 07:45:53PM +0100, Julien Nabet wrote:
> Hello,
>
> Here's a patch for calc/sc/source/ui (except unoobj previously sent).
>
> Julien.
> (LGPLv3+ / MPL)
Good, but I changed lines like
rtl::OUString foo = rtl::OUString(RTL_CONSTASCII_STRINGPARAM("foo"));
to
rtl::OUString
On Fri, Nov 12, 2010 at 12:50:37PM +0500, Alexander O. Anisimov wrote:
> Hi all,
>
> patch is in attachment
>
> .''`. With best regards,
> : :' : Alexander Anisimov
> `. `' JID alenyas...@gmail.com
> `- Debian - when you have better things to do than fixing systems
Wonderful! Keep them com
On Thu, Nov 11, 2010 at 06:45:45PM +0100, Julien Nabet wrote:
> Hello,
>
> Here's a patch for calc/sc/source/ui/unoobj
>
> Julien.
> (LGPLv3+ / MPL)
Pushed. Again, it's better to initialize strings as
rtl::OUString foo(RTL_CONSTASCII_USTRINGPARAM("foo"));
instead of
rtl::OUString foo = rtl::O
On Fri, Nov 12, 2010 at 07:44:28PM +0100, Gert Faller wrote:
> Hi,
>
> another patch for libs-core.
>
> Regards.
>
>
Pushed, thanks!
D.
___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libr
On Fri, Nov 12, 2010 at 11:22:06PM +0100, Julien Nabet wrote:
> Hello,
>
> Here's a small patch as there was only 1 file in the starmath part
> which needed modifications.
>
> Julien.
> (LGPLv3+ / MPL)
Pushed, thanks!
D.
___
LibreOffice mailing list
L
On Sat, Nov 13, 2010 at 12:41:34AM +0100, Julien Nabet wrote:
> Hello,
>
> Here's a less small patch for the sw part.
>
> Julien.
> (LGPLv3+ / MPL)
Pushed with one change:
String(::rtl::OUString(RTL_CONSTASCII_USTRINGPARAM(""))) -> String() .
D.
___
L
On Sat, Nov 13, 2010 at 12:52:48AM +0100, Julien Nabet wrote:
> Hello,
>
> Here's again a small patch for the last changes to do that I've seen
> in Impress.
>
> Julien.
> (LGPLv3+ / MPL)
Pushed.
D.
___
LibreOffice mailing list
LibreOffice@lists.freed
On Sat, Nov 13, 2010 at 12:14:49PM -0300, Santiago Alessandri wrote:
> I'm sending two patches, the first is the main one and the latter is
> because, i'm ashamed to say, i've made some mistakes and realised after
> commiting.
> So i corrected them, commited again and prepared the new patch.
>
We
On Sat, Nov 13, 2010 at 12:53:43PM -0300, Santiago Alessandri wrote:
> With this patch I think there are no more misuses of createFromAscii in the
> base repository.
>
> It is released under MPL 1.1 / GPLv3+ / LGPLv3+
>
> --
> Santiago Alessandri
Pushed, thanks!
D.
On Sat, Nov 13, 2010 at 09:43:18PM +0100, Joost Eekhoorn wrote:
> MPL 1.1 / GPLv3+ / LGPLv3+
>
> Joost
Pushed.
D.
___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice
On Sat, Nov 13, 2010 at 10:44:36PM +0100, Julien Nabet wrote:
> Hello,
>
> Here's again a small patch for the last changes to do that I've seen
> in libs-core/connectivity
>
> Julien.
> (LGPLv3+ / MPL)
Pushed. I have changed two lines:
-::rtl::OUStringBuffer sVal= (::rtl::OUStringBuffer)
::rtl
On Sun, Nov 14, 2010 at 12:52:39PM +0100, Gert Faller wrote:
> Hi,
>
> I get a build error in sw :
> with : 'sw/source/filter/rtf/rtffly.cxx' 1311 error:
> 'PictPropertyNameValuePairs' has not been declared
>
> PictPropertyNameValuePairs is only a typedef in '
> libs-core/editeng/inc/editeng/svxr
On Sun, Nov 14, 2010 at 08:03:42PM +0100, Pierre-André Jacquod wrote:
> regards
> MPL/ GPLv3+ / LGPLv3+
> pjacquod
I changed all lines like
rtl::OUString foo = rtl::OUString(RTL_CONSTASCII_USTRINGPARAM("foo"))
to
rtl::OUString foo(RTL_CONSTASCII_USTRINGPARAM("foo"))
D.
On Sun, Nov 14, 2010 at 08:32:31PM +0100, Joost Eekhoorn wrote:
> MPL 1.1 / GPLv3+ / LGPLv3+
> (Hope 13e patch on the 13 has no mistakes in it:) )
>
> Joost
Thanks, pushed.
D.
___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.
On Sun, Nov 14, 2010 at 09:36:08PM +0100, Pierre-André Jacquod wrote:
> regards
> MPL/ GPLv3+ / LGPLv3+
> pjacquod
>
Again, I changed lines like
rtl::OUString foo = rtl::OUString(RTL_CONSTASCII_USTRINGPARAM("foo"))
to
rtl::OUString foo(RTL_CONSTASCII_USTRINGPARAM("foo"))
D.
__
On Sun, Nov 14, 2010 at 10:57:57PM +0100, Julien Nabet wrote:
> Hello,
>
> Here's a patch (LGPLv3+ / MPL) for
> libs-core/connectivity/source/drivers/adabas/
Pushed.
>
> Concerning the file connectivity/source/drivers/adabas/Buser.cxx, in
> the function :
> ::rtl::OUString OAdabasUser::getPrivi
On Sun, Nov 14, 2010 at 07:44:30PM -0300, Júlio Hoffimann wrote:
> Hi,
>
> I was looking Starmath code and see a new indentation style:
>
> */* vim:set shiftwidth=4 softtabstop=4 expandtab: */*
> *
> *
> This will be the preferred style for LibreOffice project?
Yes, this is the preferred style.
On Mon, Nov 15, 2010 at 01:05:43PM -0800, Kayo Hamid wrote:
> Hello, please can someone review this? I do not known exactly what I need to
> remove or not, so I'll known a bit more after someone reviewing it.
> So I'll be able to clean better and at once.
>
I pushed it. Nice big chunk of dead co
On Tue, Nov 16, 2010 at 10:34:41AM +0100, Giuseppe Castagno wrote:
> Hi all,
>
> per subject, with a pull -r from this morning (CET), compiling sw with:
> build -P2 debug=true
>
Try pull again; commit f19fb8630f6dbf4b525bdd4ba775f05bb9d7e1a0 should
fix this.
D.
_
On Tue, Nov 16, 2010 at 05:22:48PM +0100, Giuseppe Castagno wrote:
> Tor Lillqvist wrote:
> >>Now what it's the right flag to use to surround a debug specific
> >>code: OSL_DEBUG_LEVEL > 1 or DBG_UTIL ?
> >
> >I recently did a build with --enable-dbgutil so that it would use the
> >debugging C++ l
On Sun, Feb 06, 2011 at 11:10:07PM +0100, Wilhelm Pflüger wrote:
> More reanimated tests. The osl/file part is not satisfying. I had to
> switch off some tests in osl_old_test_file.cxx. Maybe it is not worth to
> keep it.
>
> These patches are LGPLv3+/MPL.
>
Nice work! I have a couple of comment
On Tue, Feb 08, 2011 at 09:16:54AM +0100, David Tardon wrote:
> On Sun, Feb 06, 2011 at 11:10:07PM +0100, Wilhelm Pflüger wrote:
> > More reanimated tests. The osl/file part is not satisfying. I had to
> > switch off some tests in osl_old_test_file.cxx. Maybe it is not worth
On Mon, Feb 07, 2011 at 09:22:50PM +0100, Dietmar wrote:
> I am having an issue with my extension Borderliner written in Java. It
> works fine with Oracle OOo, but does not with Go-OO and LO.
Yes, we know already: https://bugs.freedesktop.org/show_bug.cgi?id=33397 .
D.
___
On Mon, Feb 07, 2011 at 09:30:47PM +0100, Christoph Herzog wrote:
> From c70749b0ae94c606f87398b36f7a8a4aa4ae9fb1 Mon Sep 17 00:00:00 2001
> From: Christoph Herzog
> Date: Mon, 7 Feb 2011 21:20:16 +0100
> Subject: [PATCH] Corrected typo in names of four swriter classes
>
> Checked for the misspel
On Mon, Feb 07, 2011 at 10:20:55PM +0100, Rob Snelders wrote:
> Hi,
>
> Here is a small patch which translates the comments in the
> eventattacher from German to English
>
Thanks, pushed!
D.
___
LibreOffice mailing list
LibreOffice@lists.freedesktop.o
On Sun, Feb 13, 2011 at 11:22:41AM +0100, Jean-Baptiste Faure wrote:
> I did "make dev-install" to try the result. No problem although I wonder
> why this command did not install the bundled extensions.
> Is there some option to add to do a complete installation ?
You can always "install" them by
On Sun, Feb 13, 2011 at 09:26:47PM +, Caolán McNamara wrote:
> caolanm->dtardon: Which reminds me, when i did this I didn't seem to get
> the python, beanshell, rhino scripting extensions (not that I really
> want the beanshell, rhino ones, but I did want the python one)
I probably forgot to a
On Sun, Feb 13, 2011 at 11:40:17PM +, Rafael Dominguez wrote:
> Well the patch is related to sw, tab entries in Insert->Indexes and Tables
> -> Indexes and Tables.
Looks good on a glance, but lifetime of the ptrs seem to be bound to
that of the container, so I suggest using boost::ptr_vector i
On Sun, Feb 13, 2011 at 08:42:42PM +0100, Christina Roßmanith wrote:
> diff --git a/svtools/source/config/menuoptions.cxx
> b/svtools/source/config/menuoptions.cxx
> index a12f1e0..4e814a7 100644
> --- a/svtools/source/config/menuoptions.cxx
> +++ b/svtools/source/config/menuoptions.cxx
> @@ -62,
On Wed, Feb 16, 2011 at 07:56:06AM +0100, David Tardon wrote:
> On Sun, Feb 13, 2011 at 08:42:42PM +0100, Christina Roßmanith wrote:
>
> > diff --git a/svtools/source/config/menuoptions.cxx
> > b/svtools/source/config/menuoptions.cxx
> > index a12f1e0..4e814a7 100644
On Thu, Feb 17, 2011 at 03:27:08AM -0500, Kevin Hunter wrote:
> Hullo List,
>
> A simpleton patch removing unused variables in writer/uno.
>
Good catch, thanks!
D.
___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop
On Wed, Feb 16, 2011 at 12:48:14PM +0100, David Tardon wrote:
> On Wed, Feb 16, 2011 at 07:56:06AM +0100, David Tardon wrote:
> > On Sun, Feb 13, 2011 at 08:42:42PM +0100, Christina Roßmanith wrote:
> >
> > > diff --git a/svtools/source/config/menuoptions.cxx
>
On Wed, Feb 16, 2011 at 10:29:34PM +0100, Christina Roßmanith wrote:
> Hi David,
>
> Am 16.02.2011 07:56, schrieb David Tardon:
> >On Sun, Feb 13, 2011 at 08:42:42PM +0100, Christina Roßmanith wrote:
> >
> >>diff --git a/svtools/source/config/menuoptions.cx
On Thu, Feb 17, 2011 at 04:14:35AM -0500, Kevin Hunter wrote:
> Hullo List,
>
> Simpleton patch to remove a redundant if-block.
Looks reasonable, pushed.
D.
___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mai
On Thu, Feb 17, 2011 at 11:29:53AM +, Michael Meeks wrote:
> Hi Julien,
>
> On Tue, 2011-02-15 at 22:22 +0100, Julien Nabet wrote:
> > Here is small patch to close the tracker 32552 (alt key opens "File"-menu).
>
> I wonder how this interacts / complements:
>
> commit ba110ce308ac66d56
On Tue, Feb 15, 2011 at 10:22:07PM +0100, Julien Nabet wrote:
> Hello,
>
> Here is small patch to close the tracker 32552 (alt key opens "File"-menu).
> I removed the block quoted in the comments, it compiles but I didn't
> test it. I use Gnome and so Gtk on my Debian.
Hi,
in that case you most
On Mon, Feb 14, 2011 at 10:20:27AM +0100, David Tardon wrote:
> On Sun, Feb 13, 2011 at 09:26:47PM +, Caolán McNamara wrote:
> > caolanm->dtardon: Which reminds me, when i did this I didn't seem to get
> > the python, beanshell, rhino scripting extensions (not tha
On Thu, Feb 17, 2011 at 11:36:27PM +0100, Jan Holesovsky wrote:
> The main thing that I changed was that in some cases you used
> vector<...>::iterator it = another_iterator + 1; This is not correct,
> operator+() is not defined on std::vector, so the result might be not
> what you'd expect; simil
On Tue, Feb 22, 2011 at 07:59:52PM +0100, Pierre-André Jacquod wrote:
> for applying, I would propose:
> git am
> which takes over user / date / commit message from the send message.
> Should we generally use the
> --signoff
> option in order to let a trace of who has pushed this?
git already trac
301 - 400 of 3285 matches
Mail list logo