Re: [Libreoffice] [PUSHED] cleanup on writer

2011-01-30 Thread David Tardon
> -// OD 09.01.2003 #i6467# - adjust view shell option to the same as for > print > +// adjust view shell option to the same as for print We generally want to leave the #iX#-style comments around, as they point to the publicly accessible OpenOffice.org issue tracker. OTOH, the #X#

Re: [Libreoffice] How to use gprof on LibO?

2011-01-31 Thread David Tardon
On Sat, Jan 29, 2011 at 03:50:37PM +0100, Soeren Moeller wrote: > Hi > > In our effort of replacing deprecated data types from tools/ by std:: > types we would like to use gprof for profiling (to choose the right > data types). But unfortunately, we don't know to set the -pg flag, export ENVCFLAG

Re: [Libreoffice] over-long extensions manager list ...

2011-02-01 Thread David Tardon
On Tue, Feb 01, 2011 at 10:47:38AM +, Michael Meeks wrote: > > Shouldn't be impossibly hard to add some simple filtering to that for > built-in / bundled extensions that would hide most of them from people > and default to not showing bundled extensions. > > I'll add an easy hack

Re: [Libreoffice] [Fwd: [PATCH] new De-Java-ised flat XML export]

2011-02-02 Thread David Tardon
Hi, Peter, > +/* > + * FLABridge provides some obscure attribute mangling to wordml2000 > import/export filters. > + * In the long run, you might want to replace this with an XSLT > extension function. > + */ > +class FLABridge : public WeakImplHelper1< DocumentHandlerAdapter

Re: [Libreoffice] [PATCH] [PUSHED] DBG_ASSERT -> OSL_ENSURE (dbaccess)

2011-02-03 Thread David Tardon
On Thu, Feb 03, 2011 at 12:42:41AM +0100, Kenneth Venken wrote: > Hi, > > this patch replaces all occurrences of DBG_ASSERT with OSL_ENSURE in > dbacces. Thanks. In addition, I changed several #ifdef DBG_UTIL lines enclosing declarations of variables/functions accessed in the debug macros to #

Re: [Libreoffice] [PATCH] [PUSHED] Remove comments (writer)

2011-02-03 Thread David Tardon
On Wed, Feb 02, 2011 at 08:46:07PM +0900, Suguru Hirahara wrote: > Hi, > > please review this one. changes are available under LGPLv3+ / MPL. > I reverted the hunks removing "@author OD" from class/function descriptions. I think we do not want to remove these. D. ___

Re: [Libreoffice] [PATCH] [PUSHED] DBG_ASSERT -> OSL_ENSURE (dbaccess)

2011-02-03 Thread David Tardon
On Thu, Feb 03, 2011 at 01:41:19AM -0700, Tor Lillqvist wrote: > > Thanks. In addition, I changed several > > #ifdef DBG_UTIL > > lines enclosing declarations of variables/functions accessed in the > > debug macros to > > #if OSL_DEBUG_LEVEL > 0 > > Is that something we can/should do in general ev

Re: [Libreoffice] libtextcat patches

2011-02-04 Thread David Tardon
On Fri, Feb 04, 2011 at 09:03:55PM +0100, Francois Tigeot wrote: > Hi, > > LibreOffice does not build with a stock libtextcat. > > The official version seems to be freezed in time (last update is dated > from 2003) and I understand the need to patch it (and add e.g. utf8 > support), but the chang

Re: [Libreoffice] template "missing"

2011-02-06 Thread David Tardon
On Sun, Feb 06, 2011 at 06:57:00PM -0500, Arno Teigseth wrote: > Hi > > This might be a corner case, but I have this problem: > > To not have to go through the "import template" process every time I > change a template, I symlinked it. So, Is there any reason why you cannot just import the templ

Re: [Libreoffice] template "missing"

2011-02-07 Thread David Tardon
On Mon, Feb 07, 2011 at 02:10:13AM -0500, Arno Teigseth wrote: > On Mon, 2011-02-07 at 07:44 +0100, David Tardon wrote: > > ... exists yet, it just points to a nonexistent file. LibO sees the > > (symlink) file, so it doesn't allow to import a template with the same > > n

Re: [Libreoffice] [PATCH] [PUSHED] Remove bogus comments

2011-02-07 Thread David Tardon
On Sat, Feb 05, 2011 at 05:20:29PM -0500, Antoine Proulx wrote: > Hi, > > Here's a patch who removes bogus comments. It's released under the > LGPLv3+ / MPL. > > Antoine > Hi, Antoine, bug references like #XX# point to private Sun bugtracker, therefore they are of no value to us (as opposi

Re: [Libreoffice] EasyHacks: Make existing tests work (ure/sal)

2011-02-07 Thread David Tardon
On Sat, Feb 05, 2011 at 11:45:47PM +0100, Wilhelm Pflüger wrote: > Attached please find some changes to make tests in ure/sal work. > > One test fails and breaks the build though - if this is unwanted you may > revert the change to ure/sal/prj/build.lst. (This is not exactly what is > intended by

Re: [Libreoffice] [PUSHED] Fix cppcheck errors and warnings

2011-02-07 Thread David Tardon
On Sun, Feb 06, 2011 at 09:42:46PM +0100, Xisco Faulí wrote: > -} section[SECTIONS]; > +} section[SECTIONS] = NULL; This is false alarm. The struct has default constructor, so the elements of the array are initialized properly. > +delete [] level; This is wrong, because Outli

Re: [Libreoffice] [PUSHED] EasyHacks: Make existing tests work (ure/sal)

2011-02-07 Thread David Tardon
Forgot to mark as PUSHED. D. ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice

Re: [Libreoffice] [PATCH] [PUSHED] EasyHacks: Make existing tests work

2011-02-07 Thread David Tardon
On Sat, Feb 05, 2011 at 11:32:18PM +0100, Wilhelm Pflüger wrote: > Find attached changes to lib-gui/comphelper to get some tests working > again. > These patches are LGPLv3+/MPL. > > This is my first contribution in this project - so don't hesitate with > critics if its not the common procedure.

Re: [Libreoffice] build breaks on i686

2011-05-18 Thread David Tardon
On Sun, Apr 24, 2011 at 02:43:44PM +0200, Andreas Radke wrote: > [ build LNK ] Library/vbaobj.uno.so > [ build CXX ] sw/source/ui/utlui/textcontrolcombo > [ build CXX ] sw/source/ui/utlui/tmplctrl > [ build CUT ] sc_ucalc > [ build CXX ] sw/source/ui/utlui/uiitems > `.L121' referenced in section >

[Libreoffice] [REVIEW] build with system bsh breaks

2011-05-21 Thread David Tardon
Hi, could someone sign-off this small patch? D. ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice

Re: [Libreoffice] [REVIEW] build with system bsh breaks

2011-05-23 Thread David Tardon
On Sun, May 22, 2011 at 01:12:38AM -0500, Norbert Thiebaud wrote: > On Sun, May 22, 2011 at 1:02 AM, David Tardon wrote: > > Hi, > > > > could someone sign-off this small patch? > > David, it would be easier if you actually attach the patch :-) I

Re: [Libreoffice] Duplicate code: SwDoc::SplitDoc

2011-05-23 Thread David Tardon
On Tue, May 10, 2011 at 10:17:19AM +0200, Chr. Rossmanith wrote: > Hi, > >> (what stands Stt for?) > once again: Stt means what? The answer might help to understand > what's going on in that method. Start :) I guess the original developer of the code wanted to save some typing... D.

Re: [Libreoffice] [REVIEWED] build with system bsh breaks

2011-05-24 Thread David Tardon
On Mon, May 23, 2011 at 07:46:52AM -0500, Norbert Thiebaud wrote: > On Mon, May 23, 2011 at 4:36 AM, David Tardon wrote: > > On Sun, May 22, 2011 at 01:12:38AM -0500, Norbert Thiebaud wrote: > >> On Sun, May 22, 2011 at 1:02 AM, David Tardon wrote: > >> > Hi, > &

Re: [Libreoffice] [PATCH] [IN PROGRESS] Replace DBG_ stuff in calc with OSL_ equivalents

2011-05-24 Thread David Tardon
On Sun, May 22, 2011 at 11:41:31AM +0200, Jacek Wolszczak wrote: > Hi, > > I am sending links to patches uploaded to dropbox. I wasn't sure if 1MB > of attachments would be welcome here. > > http://dl.dropbox.com/u/174726/patches/0001-Replace-DBG_-with-OSL_-in-calc-chart2.patch > http://dl.dropbo

Re: [Libreoffice] [PATCH] [PUSHED] Replace DBG_ stuff in calc with OSL_ equivalents

2011-05-26 Thread David Tardon
On Sun, May 22, 2011 at 11:41:31AM +0200, Jacek Wolszczak wrote: > Hi, > > I am sending links to patches uploaded to dropbox. I wasn't sure if 1MB > of attachments would be welcome here. The patches are good, except: 1. I changed -#ifdef DBG_UTIL +#if OSL_DEBUG_LEVEL > 1 to -#ifdef DBG_UTIL

Re: [Libreoffice] Debugging UNO references in gdb

2011-05-30 Thread David Tardon
On Mon, May 30, 2011 at 09:57:16AM +0200, Andor E wrote: > Hello, > I'm trying to debug an issue with bookmarks in the Writer import > filter. Right now my biggest problem is, that I don't know how to get > information from the UNO reference objects. The import filter uses > cursors and text ranges

Re: [Libreoffice] Warning in basic/source/runtime/runtime.cxx

2011-05-31 Thread David Tardon
On Tue, May 31, 2011 at 10:27:19AM +0100, Michael Meeks wrote: > that works. I believe this is just a cut/paste error from dr, and we > want this instead: > > +PTR_CAST(BasicCollection,pVar) == pCollection ) > > I'll commit that, and wait for screams. Moreover, I think th

Re: [Libreoffice] [REVIEWED] Complete fix for fdo#32684

2011-06-07 Thread David Tardon
On Mon, Jun 06, 2011 at 12:40:56PM +0200, Cedric Bosdonnat wrote: > Hi all, > > On Mon, 2011-05-23 at 12:55 +0200, Cedric Bosdonnat wrote: > > That bug was badly fixed (by me) quite some times ago. Here is a correct > > fix (why did I add that code at all ?). Could you review it and push it > > in

Re: [Libreoffice] [PATCH] Replace DBG_ with OSL in writer and remove debug.hxx

2011-06-27 Thread David Tardon
On Tue, Jun 07, 2011 at 10:48:36PM +0200, Jacek Wolszczak wrote: > Hi, > > BTW, does anyone use DBG_PROFSTART and DBG_PROFSTOP or could these be > removed altogether? They are used for profiling. I do not know if anyone here knows about their existence, so it might well be the simplest thing to r

[Libreoffice] [REVIEW] avoid overwriting stack

2011-06-30 Thread David Tardon
Hi all, could someone review commit 01096e7487d9e60fcd24eea8131b650588845f2b in libs-core for 3.4? It fixes the following crash scenario: 1. create new presentation 2. press F11 to open stylist 3. right click on a style and click on Modify 4. press Esc (or click Cancel) 5. press F11 It does not

Re: [Libreoffice] [PATCH] [PUSHED] Replace List with std::vector<>

2011-07-01 Thread David Tardon
On Sun, Jun 19, 2011 at 09:48:39PM -0700, Joseph Powers wrote: > I'm sending the patch for review; not because it needs a lot but just to have > someone verify that the memory was leaking and needs to be fixed. It has been pushed already, so adding PUSHED to summary. > > Current fixes: > 1. XPr

Re: [Libreoffice] [REVIEW 3-4] [PUSHED 3-4] Update mdds to 0.5.3

2011-07-14 Thread David Tardon
On Wed, Jul 13, 2011 at 11:15:33PM -0400, Kohei Yoshida wrote: > Hi there, > > I'd like to update mdds to 0.5.3 for the -3-4 branch and preferably the > -3-4-2 branch as well. The attached patches would make that happen. > > That should improve the performance issue raised in > > https://bugs.f

Re: [Libreoffice] [PATCH][REVIEW][PUSHED 3-4] SetNamedRanges speedup fdo#35357

2011-07-18 Thread David Tardon
On Mon, Jul 18, 2011 at 12:28:55PM -0400, Kohei Yoshida wrote: > On Mon, 2011-07-18 at 11:47 -0400, Kohei Yoshida wrote: > > On Mon, 2011-07-18 at 10:25 -0400, Kohei Yoshida wrote: > > > > > I'd also > > > like to push this to the -3-4 branch, but let me just do a quick test on > > > ODS import of

Re: [Libreoffice] [PATCH] Work around a bash-ism in configure.in

2011-07-18 Thread David Tardon
On Mon, Jul 18, 2011 at 05:33:56PM -0700, Mike Eberdt wrote: > Hi Christian, > > On 07/18/11 04:56, Christian Lohmaier wrote: > > > >Hi MIke, *, > > > >On Fri, Jul 15, 2011 at 9:34 PM, Mike Eberdt wrote: > >> > >>Configure.in eventually gets parsed by /bin/sh, and on Free/Net/OpenBSD > >>/bin/sh

Re: [Libreoffice] Review Request: fdo#39023 for 3.4.* branch

2011-07-19 Thread David Tardon
On Tue, Jul 19, 2011 at 04:29:32PM +0530, Muthu Subramanian K wrote: > Hi, > > +if( maCurrCell.mnSharedId >= 0 ) > +{ > +Reference< XFormulaTokens > xTokens( maCurrCell.mxCell, > UNO_QUERY_THROW ); > +ExtCellFormulaContext aContext( *this, xTokens, > maCur

Re: [Libreoffice] Review Request: fdo#39023 for 3.4.* branch

2011-07-19 Thread David Tardon
On Tue, Jul 19, 2011 at 02:35:42PM +0200, Markus Mohrhard wrote: > Hello David, > > I think the original version should be safe. Our formula api can't deal with > broken documents during import especially the oox import can't deal with > errors of any kinds in formulas. But a broken document won't

Re: [Libreoffice] [REVIEW][PUSHED 3-4] Fix for fdo#39236

2011-07-19 Thread David Tardon
On Tue, Jul 19, 2011 at 02:56:04PM -0400, Kohei Yoshida wrote: > Hi there, > > I'd like to have the following commit > > http://cgit.freedesktop.org/libreoffice/calc/commit/?id=8da78944e7c4fcae9ae40bea7162898d20db6329 > > cherry-picked to -3-4 and -3-4-2 in order to fix > > https://bugs.freedes

Re: [Libreoffice] [REVIEW][PUSHED 3-4] Fix wrong RTTI baseclass for SfxViewEventHint

2011-07-20 Thread David Tardon
On Wed, Jul 20, 2011 at 11:53:49PM +0200, Thorsten Behrens wrote: > Hi *, > > master has a fix for a mis-typed base class for the > SfxViewEventHint, unfortunately hidden in merge commit > libs-core:d3a999619524001821bdc438cac275c441efad9b - which > effectively prevents a set of document events to

Re: [Libreoffice] Error Building, vcl segmentation fault

2010-10-11 Thread David Tardon
On Mon, Oct 11, 2010 at 11:08:31PM +0200, julien wrote: > Le 10/10/2010 22:31, julien a écrit : > I changed the line : > > $checkdll "$@" > by > gdb $checkdll "$@" > There is the problem: this line should be gdb --args $checkdll "$@" D. ___ LibreOffi

Re: [Libreoffice] C{,PP}FLAGS ignored in sal

2010-10-15 Thread David Tardon
On Thu, Oct 14, 2010 at 09:33:45AM +0100, Caolán McNamara wrote: > On Thu, 2010-10-14 at 08:37 +0200, Thomas Klausner wrote: > > On Wed, Oct 13, 2010 at 05:25:59PM +0200, Thomas Klausner wrote: > > > I don't see my CFLAGS nor CPPFLAGS, which would make it find boost, in > > > the gcc arguments. > >

Re: [Libreoffice] [LibreOffice][Patch] Replace ASSERT and DBG_ASSERT with OSL_ENSURE + some translations, comment removal

2010-10-15 Thread David Tardon
On Thu, Oct 14, 2010 at 09:11:26AM +0100, Caolán McNamara wrote: > On Wed, 2010-10-13 at 22:34 +0200, Jacek Wolszczak wrote: > > http://wiki.services.openoffice.org/wiki/Debug_Levels. > > > > Some additional questions. What should I replace DBG_ERROR with? > > Hmm, DBG_ERROR takes no condition,

Re: [Libreoffice] [PATCH] Remove dead code from dbase driver.

2010-10-16 Thread David Tardon
On Sun, Oct 17, 2010 at 06:50:52PM +1300, Luke Symes wrote: > This patch removes dead code and fixes a few comments in the code for the > dbase driver in the libs-core repository. Thanks! Pushed. D. ___ LibreOffice mailing list LibreOffice@lists.freedes

Re: [Libreoffice] C{,PP}FLAGS ignored in sal

2010-10-17 Thread David Tardon
On Fri, Oct 15, 2010 at 06:48:34PM +0200, Thomas Klausner wrote: > On Fri, Oct 15, 2010 at 01:22:46PM +0200, David Tardon wrote: > > There is ENVCFLAGS for flags to add to $CC and ENVCFLAGSCXX for flags > > to add to $CXX . > > That's a very good tip, thank you. > &

Re: [Libreoffice] [PATCH] More dead code removal under connectivity

2010-10-17 Thread David Tardon
On Sun, Oct 17, 2010 at 08:04:27PM +1300, Luke Symes wrote: > This patch cleans up miscellaneous dead code in libs-core/connectivity/*. Thanks! Pushed. D. ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailma

Re: [Libreoffice] [PATCH] Fix sc build

2010-10-17 Thread David Tardon
On Sun, Oct 17, 2010 at 09:46:26PM +0200, Miklos Vajna wrote: > Hi David, > > Your recent commit which removed solenv/inc/sc.mk and > solenv/inc/scpre.mk in bootstrap.git breaks the build of sc here. > > Given that the change is in makefile.mk files, tinderbox won't notice > it, I assume. ;) >

Re: [Libreoffice] [PATCH] SAL_N_ELEMENTS for libs-gui

2010-10-18 Thread David Tardon
On Mon, Oct 18, 2010 at 11:54:32AM +0200, Kenneth Venken wrote: > Hi, > > this patch replaces all hits for "sizeof.*/.*sizeof.*\[" with > SAL_N_ELEMENTS in libs-gui. > > -- Kenneth Thanks! Pushed. D. ___ LibreOffice mailing list LibreOffice@lists.free

Re: [Libreoffice] [PATCH] SAL_N_ELEMENTS in testing and sdk

2010-10-18 Thread David Tardon
On Mon, Oct 18, 2010 at 12:18:23PM +0200, Kenneth Venken wrote: > Hi, > > patches replace sizeof/sizeof[0] with SAL_N_ELEMENTS in testing and sdk > > -- Kenneth Thanks! Pushed. D. ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://l

Re: [Libreoffice] [PATCH] final SAL_N_ELEMENTS

2010-10-19 Thread David Tardon
On Tue, Oct 19, 2010 at 09:42:17PM +0200, Kenneth Venken wrote: > hi, > > these patches will replace the last occurrences of > sizeof(foo)/sizeof(foo[0]) with SAL_N_ELEMENTS(foo) > > -- Kenneth Hi, I pushed sal_n_elements.libs-gui.diff and sal_n_elements.ure.diff. The changes the other two do s

Re: [Libreoffice] [PATCH] final SAL_N_ELEMENTS

2010-10-19 Thread David Tardon
On Wed, Oct 20, 2010 at 07:29:56AM +0200, David Tardon wrote: > On Tue, Oct 19, 2010 at 09:42:17PM +0200, Kenneth Venken wrote: > > hi, > > > > these patches will replace the last occurrences of > > sizeof(foo)/sizeof(foo[0]) with SAL_N_ELEMENTS(foo) > > >

Re: [Libreoffice] suspect code in extentions/sdext/source/presenter/PresenterClock.cxx

2010-11-01 Thread David Tardon
On Mon, Nov 01, 2010 at 09:24:09AM +, Caolán McNamara wrote: > On Sun, 2010-10-31 at 23:04 -0500, Norbert Thiebaud wrote: > > ::osl::MutexGuard aSolarGuard (::osl::Mutex::getGlobalMutex()); > > Paint(rEvent.UpdateRect); > > > I'm thinking I should change this guard with a SolarMutexGua

Re: [Libreoffice] (no subject)

2010-11-02 Thread David Tardon
On Tue, Nov 02, 2010 at 08:50:55AM +0100, Gert Faller wrote: > Hi, > > a little bit more... > Pushed, thanks! D. ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice

Re: [Libreoffice] [PATCH] sc: fix parenthesis mixup

2010-11-02 Thread David Tardon
On Tue, Nov 02, 2010 at 03:10:49PM +0100, Sebastian Spaeth wrote: > Commit cab7e33c4ff6067486b745ebfc0b37ed1d6d18b7 broke parentheses. Fixing > Hi, you're too late :) Caolan has already fixed it. D. ___ LibreOffice mailing list LibreOffice@lists.freed

Re: [Libreoffice] [PUSHED] Easy Hacks : RTL_CONSTASCII_USTRINGPARAM in libs-core 1

2010-11-05 Thread David Tardon
On Thu, Nov 04, 2010 at 09:54:20PM +0100, Gert Faller wrote: > Hi, > > here are some in 'libs-core'. > > Regards. > Thanks! I removed some changes * in BasicManager::SetGlobalUNOConstant, because the variable is function parameter, not a string constant. * in ModuleContainer_Impl::getByName,

Re: [Libreoffice] [PUSHED] build.pl dead code, spelling fixes

2010-11-09 Thread David Tardon
On Mon, Nov 08, 2010 at 08:10:51PM -0600, Jordan Ayers wrote: > Miscellaneous cleanup to build.pl. Mostly removal of dead code, with > a few spelling / German->English fixes. > > LGPLv3+/MPL > Pushed, thanks! D. ___ LibreOffice mailing list LibreOffi

Re: [Libreoffice] [PUSHED] 4 patches of rtl goodness

2010-11-09 Thread David Tardon
On Tue, Nov 09, 2010 at 03:11:40PM -0500, Kevin Hunter wrote: > At 12:44pm -0500 Tue, 09 Nov 2010, Kevin Hunter wrote: > >Here are four more patch conversions from createFromAscii to > >RTL_CONST... applied against: > > > >basebmp/ > >binfilter/ > >bridges/ > >connectivity/ > > I apologize, I temp

Re: [Libreoffice] [PUSHED] RTL_CONSTASCII_USTRINGPARAM in svx

2010-11-09 Thread David Tardon
On Tue, Nov 09, 2010 at 09:30:22PM +0100, Joost Eekhoorn wrote: > Is it correct to have the RTL_CONSTASCII_USTRINGPARAM directly in the *.hxx > file. > If so, why not do that also at other places? > > MPL 1.1 / GPLv3+ / LGPLv3+ > > Joost Pushed, thanks! D. __

Re: [Libreoffice] [PUSHED] more spelling mistakes, dead code removal for Base

2010-11-09 Thread David Tardon
On Tue, Nov 09, 2010 at 10:24:20PM +, Wols Lists wrote: > Cheers, > Wol Looks fine. Pushed. > From cb03ee788ea81661ae83ae611806c6050d16af57 Mon Sep 17 00:00:00 2001 > -// use keys and indexes for excat postioning Would that mean positioning of a dead cat (aka ex-parrot)? :-D D.

[Libreoffice] script providers as extensions

2010-11-10 Thread David Tardon
Hi all, just a heads up: recently I was working on removing the script providers for BeanShell, JavaScript and Python from standard installation, as they are only marginally useful and (at least on Fedora) require quite a slew of dependencies. So, from now on, they are available as plain extension

Re: [Libreoffice] [PUSHED] Another bunch of misc spelling mistakes, translations, code removal for Base

2010-11-10 Thread David Tardon
On Wed, Nov 10, 2010 at 12:54:32PM +, Wols Lists wrote: > Cheers, > Wol Pushed. D. ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice

Re: [Libreoffice] RTL_CONSTASCII_USTRINGPARAM in libs-core 5

2010-11-10 Thread David Tardon
On Wed, Nov 10, 2010 at 02:16:20PM +0100, Gert Faller wrote: > Hi, > > some more... > > Regards. > Pushed, with several changes from rtl::OUString foo = rtl::OUString(RTL_CONSTASCII_USTRINGPARAM("blah")); or rtl::OUString foo(rtl::OUString(RTL_CONSTASCII_USTRINGPARAM("blah"))); to rtl::OUS

Re: [Libreoffice] [Patch] + Question about compilation warning on sd/source/ui/view/drviewsj.cxx

2010-11-10 Thread David Tardon
On Wed, Nov 10, 2010 at 11:53:07PM +0100, julien wrote: > Hello, > > The patch contains only the removing of comments. I haven't removed 1 > line of comment because i don't know what "Wieder raus" mean. Pushed. > I would have like to remove a warning too since during compilation, I > got this :

Re: [Libreoffice] [PUSHED] + Question about compilation warning on sd/source/ui/view/drviewsj.cxx

2010-11-10 Thread David Tardon
And now once more with PUSHED in subject... D. ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice

Re: [Libreoffice] [QA] Existing practice & open questions

2010-11-11 Thread David Tardon
On Thu, Nov 11, 2010 at 09:55:02AM +0100, Thorsten Behrens wrote: > Hi, > > following is a list of current QA practices I'm aware of: > > Current > === > > New bugs come in, get assigned to the > libreoffice-b...@lists.freedesktop.org bug alias (throw me a mail if > you want to be added ther

Re: [Libreoffice] [PUSHED] Replaced createFromAscii with RTL_CONSTASCII_USTRINGPARAM in /dbaccess/source/ in base repo

2010-11-11 Thread David Tardon
On Thu, Nov 11, 2010 at 06:03:31PM -0300, Santiago Alessandri wrote: > Hi! > > I'm attaching the patch for changing the use of createFromAscii > with RTL_CONSTASCII_USTRINGPARAM in the directories: > /dbaccess/source/shared/ > /dbaccess/source/ui/app/ > /dbaccess/source/ui/browser/ > /dbaccess/sou

Re: [Libreoffice] [PUSHED] RTL_CONSTASCII_USTRINGPARAM for calc_ui

2010-11-11 Thread David Tardon
On Thu, Nov 11, 2010 at 07:45:53PM +0100, Julien Nabet wrote: > Hello, > > Here's a patch for calc/sc/source/ui (except unoobj previously sent). > > Julien. > (LGPLv3+ / MPL) Good, but I changed lines like rtl::OUString foo = rtl::OUString(RTL_CONSTASCII_STRINGPARAM("foo")); to rtl::OUString

Re: [Libreoffice] [PUSHED] Remove bogus comments in libs-gui

2010-11-12 Thread David Tardon
On Fri, Nov 12, 2010 at 12:50:37PM +0500, Alexander O. Anisimov wrote: > Hi all, > > patch is in attachment > > .''`. With best regards, > : :' : Alexander Anisimov > `. `' JID alenyas...@gmail.com > `- Debian - when you have better things to do than fixing systems Wonderful! Keep them com

Re: [Libreoffice] [PATCH] RTL_CONSTASCII_USTRINGPARAM for calc_unoobj

2010-11-12 Thread David Tardon
On Thu, Nov 11, 2010 at 06:45:45PM +0100, Julien Nabet wrote: > Hello, > > Here's a patch for calc/sc/source/ui/unoobj > > Julien. > (LGPLv3+ / MPL) Pushed. Again, it's better to initialize strings as rtl::OUString foo(RTL_CONSTASCII_USTRINGPARAM("foo")); instead of rtl::OUString foo = rtl::O

Re: [Libreoffice] [PUSHED] Easy Hacks : RTL_CONSTASCII_USTRINGPARAM in libs-core 6

2010-11-13 Thread David Tardon
On Fri, Nov 12, 2010 at 07:44:28PM +0100, Gert Faller wrote: > Hi, > > another patch for libs-core. > > Regards. > > Pushed, thanks! D. ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libr

Re: [Libreoffice] [PUSHED] RTL_CONSTASCII_USTRINGPARAM for writer_starmath

2010-11-13 Thread David Tardon
On Fri, Nov 12, 2010 at 11:22:06PM +0100, Julien Nabet wrote: > Hello, > > Here's a small patch as there was only 1 file in the starmath part > which needed modifications. > > Julien. > (LGPLv3+ / MPL) Pushed, thanks! D. ___ LibreOffice mailing list L

Re: [Libreoffice] [PUSHED] RTL_CONSTASCII_USTRINGPARAM for writer_sw

2010-11-13 Thread David Tardon
On Sat, Nov 13, 2010 at 12:41:34AM +0100, Julien Nabet wrote: > Hello, > > Here's a less small patch for the sw part. > > Julien. > (LGPLv3+ / MPL) Pushed with one change: String(::rtl::OUString(RTL_CONSTASCII_USTRINGPARAM(""))) -> String() . D. ___ L

Re: [Libreoffice] [PUSHED] RTL_CONSTASCII_USTRINGPARAM for impress

2010-11-13 Thread David Tardon
On Sat, Nov 13, 2010 at 12:52:48AM +0100, Julien Nabet wrote: > Hello, > > Here's again a small patch for the last changes to do that I've seen > in Impress. > > Julien. > (LGPLv3+ / MPL) Pushed. D. ___ LibreOffice mailing list LibreOffice@lists.freed

Re: [Libreoffice] [PATCH] Replaced createFromAscii with RTL_CONSTASCII_USTRINGPARAM in all /dbaccess/in base repo

2010-11-13 Thread David Tardon
On Sat, Nov 13, 2010 at 12:14:49PM -0300, Santiago Alessandri wrote: > I'm sending two patches, the first is the main one and the latter is > because, i'm ashamed to say, i've made some mistakes and realised after > commiting. > So i corrected them, commited again and prepared the new patch. > We

Re: [Libreoffice] [PUSH] Replaced createFromAscii with RTL_CONSTASCII_USTRINGPARAM in base repo

2010-11-13 Thread David Tardon
On Sat, Nov 13, 2010 at 12:53:43PM -0300, Santiago Alessandri wrote: > With this patch I think there are no more misuses of createFromAscii in the > base repository. > > It is released under MPL 1.1 / GPLv3+ / LGPLv3+ > > -- > Santiago Alessandri Pushed, thanks! D.

Re: [Libreoffice] [PUSHED] RTL_CONSTASCII_USTRINGPARAM in svx

2010-11-13 Thread David Tardon
On Sat, Nov 13, 2010 at 09:43:18PM +0100, Joost Eekhoorn wrote: > MPL 1.1 / GPLv3+ / LGPLv3+ > > Joost Pushed. D. ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice

Re: [Libreoffice] [PUSHED] RTL_CONSTASCII_USTRINGPARAM for libs-core/connectivity

2010-11-14 Thread David Tardon
On Sat, Nov 13, 2010 at 10:44:36PM +0100, Julien Nabet wrote: > Hello, > > Here's again a small patch for the last changes to do that I've seen > in libs-core/connectivity > > Julien. > (LGPLv3+ / MPL) Pushed. I have changed two lines: -::rtl::OUStringBuffer sVal= (::rtl::OUStringBuffer) ::rtl

Re: [Libreoffice] SW build error

2010-11-14 Thread David Tardon
On Sun, Nov 14, 2010 at 12:52:39PM +0100, Gert Faller wrote: > Hi, > > I get a build error in sw : > with : 'sw/source/filter/rtf/rtffly.cxx' 1311 error: > 'PictPropertyNameValuePairs' has not been declared > > PictPropertyNameValuePairs is only a typedef in ' > libs-core/editeng/inc/editeng/svxr

Re: [Libreoffice] [PUSHED] RTL_CONSTASCII_USTRINGPARAM in components - customize

2010-11-14 Thread David Tardon
On Sun, Nov 14, 2010 at 08:03:42PM +0100, Pierre-André Jacquod wrote: > regards > MPL/ GPLv3+ / LGPLv3+ > pjacquod I changed all lines like rtl::OUString foo = rtl::OUString(RTL_CONSTASCII_USTRINGPARAM("foo")) to rtl::OUString foo(RTL_CONSTASCII_USTRINGPARAM("foo")) D.

Re: [Libreoffice] [PUSHED] RTL_CONSTASCII_USTRINGPARAM in svx

2010-11-14 Thread David Tardon
On Sun, Nov 14, 2010 at 08:32:31PM +0100, Joost Eekhoorn wrote: > MPL 1.1 / GPLv3+ / LGPLv3+ > (Hope 13e patch on the 13 has no mistakes in it:) ) > > Joost Thanks, pushed. D. ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.

Re: [Libreoffice] [PUSHED] RTL_CONSTASCII_USTRINGPARAM cleaning in components - dialogs

2010-11-14 Thread David Tardon
On Sun, Nov 14, 2010 at 09:36:08PM +0100, Pierre-André Jacquod wrote: > regards > MPL/ GPLv3+ / LGPLv3+ > pjacquod > Again, I changed lines like rtl::OUString foo = rtl::OUString(RTL_CONSTASCII_USTRINGPARAM("foo")) to rtl::OUString foo(RTL_CONSTASCII_USTRINGPARAM("foo")) D. __

Re: [Libreoffice] [PUSHED] + question RTL_CONSTASCII_USTRINGPARAM for libs-core/connectivity/source/drivers/adabas/

2010-11-14 Thread David Tardon
On Sun, Nov 14, 2010 at 10:57:57PM +0100, Julien Nabet wrote: > Hello, > > Here's a patch (LGPLv3+ / MPL) for > libs-core/connectivity/source/drivers/adabas/ Pushed. > > Concerning the file connectivity/source/drivers/adabas/Buser.cxx, in > the function : > ::rtl::OUString OAdabasUser::getPrivi

Re: [Libreoffice] Preferred indentation for LibreOffice

2010-11-14 Thread David Tardon
On Sun, Nov 14, 2010 at 07:44:30PM -0300, Júlio Hoffimann wrote: > Hi, > > I was looking Starmath code and see a new indentation style: > > */* vim:set shiftwidth=4 softtabstop=4 expandtab: */* > * > * > This will be the preferred style for LibreOffice project? Yes, this is the preferred style.

Re: [Libreoffice] [PUSHED] Clean code at writer [source/core/layout]

2010-11-15 Thread David Tardon
On Mon, Nov 15, 2010 at 01:05:43PM -0800, Kayo Hamid wrote: > Hello, please can someone review this? I do not known exactly what I need to > remove or not, so I'll known a bit more after someone reviewing it. > So I'll be able to clean better and at once. > I pushed it. Nice big chunk of dead co

Re: [Libreoffice] Problem building sw (writer) in debug mode under Linux

2010-11-16 Thread David Tardon
On Tue, Nov 16, 2010 at 10:34:41AM +0100, Giuseppe Castagno wrote: > Hi all, > > per subject, with a pull -r from this morning (CET), compiling sw with: > build -P2 debug=true > Try pull again; commit f19fb8630f6dbf4b525bdd4ba775f05bb9d7e1a0 should fix this. D. _

Re: [Libreoffice] [PUSHED] Re: Problem building sw (writer) in debug mode under Linux

2010-11-16 Thread David Tardon
On Tue, Nov 16, 2010 at 05:22:48PM +0100, Giuseppe Castagno wrote: > Tor Lillqvist wrote: > >>Now what it's the right flag to use to surround a debug specific > >>code: OSL_DEBUG_LEVEL > 1 or DBG_UTIL ? > > > >I recently did a build with --enable-dbgutil so that it would use the > >debugging C++ l

Re: [Libreoffice] [libreoffice] [PUSHED] EasyHacks: Reanimating more tests in ure/sal

2011-02-08 Thread David Tardon
On Sun, Feb 06, 2011 at 11:10:07PM +0100, Wilhelm Pflüger wrote: > More reanimated tests. The osl/file part is not satisfying. I had to > switch off some tests in osl_old_test_file.cxx. Maybe it is not worth to > keep it. > > These patches are LGPLv3+/MPL. > Nice work! I have a couple of comment

Re: [Libreoffice] [libreoffice] [PUSHED] EasyHacks: Reanimating more tests in ure/sal

2011-02-08 Thread David Tardon
On Tue, Feb 08, 2011 at 09:16:54AM +0100, David Tardon wrote: > On Sun, Feb 06, 2011 at 11:10:07PM +0100, Wilhelm Pflüger wrote: > > More reanimated tests. The osl/file part is not satisfying. I had to > > switch off some tests in osl_old_test_file.cxx. Maybe it is not worth

Re: [Libreoffice] issue with Borderline structure

2011-02-08 Thread David Tardon
On Mon, Feb 07, 2011 at 09:22:50PM +0100, Dietmar wrote: > I am having an issue with my extension Borderliner written in Java. It > works fine with Oracle OOo, but does not with Go-OO and LO. Yes, we know already: https://bugs.freedesktop.org/show_bug.cgi?id=33397 . D. ___

Re: [Libreoffice] [PATCH] [PUSHED] Corrected typo in names of four swriter classes

2011-02-08 Thread David Tardon
On Mon, Feb 07, 2011 at 09:30:47PM +0100, Christoph Herzog wrote: > From c70749b0ae94c606f87398b36f7a8a4aa4ae9fb1 Mon Sep 17 00:00:00 2001 > From: Christoph Herzog > Date: Mon, 7 Feb 2011 21:20:16 +0100 > Subject: [PATCH] Corrected typo in names of four swriter classes > > Checked for the misspel

Re: [Libreoffice] [PUSHED] patch lib-core/eventattacher

2011-02-08 Thread David Tardon
On Mon, Feb 07, 2011 at 10:20:55PM +0100, Rob Snelders wrote: > Hi, > > Here is a small patch which translates the comments in the > eventattacher from German to English > Thanks, pushed! D. ___ LibreOffice mailing list LibreOffice@lists.freedesktop.o

Re: [Libreoffice] compilation and bundled extensions

2011-02-14 Thread David Tardon
On Sun, Feb 13, 2011 at 11:22:41AM +0100, Jean-Baptiste Faure wrote: > I did "make dev-install" to try the result. No problem although I wonder > why this command did not install the bundled extensions. > Is there some option to add to do a complete installation ? You can always "install" them by

Re: [Libreoffice] compilation and bundled extensions

2011-02-14 Thread David Tardon
On Sun, Feb 13, 2011 at 09:26:47PM +, Caolán McNamara wrote: > caolanm->dtardon: Which reminds me, when i did this I didn't seem to get > the python, beanshell, rhino scripting extensions (not that I really > want the beanshell, rhino ones, but I did want the python one) I probably forgot to a

Re: [Libreoffice] [PATCH] DECLARE_LIST(TOXControlList, Control*) to std::vector in sw.

2011-02-14 Thread David Tardon
On Sun, Feb 13, 2011 at 11:40:17PM +, Rafael Dominguez wrote: > Well the patch is related to sw, tab entries in Insert->Indexes and Tables > -> Indexes and Tables. Looks good on a glance, but lifetime of the ptrs seem to be bound to that of the container, so I suggest using boost::ptr_vector i

Re: [Libreoffice] [PATCH] [PUSHED] fixed spelling menues -> menus

2011-02-15 Thread David Tardon
On Sun, Feb 13, 2011 at 08:42:42PM +0100, Christina Roßmanith wrote: > diff --git a/svtools/source/config/menuoptions.cxx > b/svtools/source/config/menuoptions.cxx > index a12f1e0..4e814a7 100644 > --- a/svtools/source/config/menuoptions.cxx > +++ b/svtools/source/config/menuoptions.cxx > @@ -62,

Re: [Libreoffice] [PATCH] [PUSHED] fixed spelling menues -> menus

2011-02-16 Thread David Tardon
On Wed, Feb 16, 2011 at 07:56:06AM +0100, David Tardon wrote: > On Sun, Feb 13, 2011 at 08:42:42PM +0100, Christina Roßmanith wrote: > > > diff --git a/svtools/source/config/menuoptions.cxx > > b/svtools/source/config/menuoptions.cxx > > index a12f1e0..4e814a7 100644

Re: [Libreoffice] [PATCH] [PUSHED] unused variable in writer/uno

2011-02-17 Thread David Tardon
On Thu, Feb 17, 2011 at 03:27:08AM -0500, Kevin Hunter wrote: > Hullo List, > > A simpleton patch removing unused variables in writer/uno. > Good catch, thanks! D. ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop

Re: [Libreoffice] [PATCH] [PUSHED] fixed spelling menues -> menus

2011-02-17 Thread David Tardon
On Wed, Feb 16, 2011 at 12:48:14PM +0100, David Tardon wrote: > On Wed, Feb 16, 2011 at 07:56:06AM +0100, David Tardon wrote: > > On Sun, Feb 13, 2011 at 08:42:42PM +0100, Christina Roßmanith wrote: > > > > > diff --git a/svtools/source/config/menuoptions.cxx >

Re: [Libreoffice] [PATCH] [PUSHED] fixed spelling menues -> menus

2011-02-17 Thread David Tardon
On Wed, Feb 16, 2011 at 10:29:34PM +0100, Christina Roßmanith wrote: > Hi David, > > Am 16.02.2011 07:56, schrieb David Tardon: > >On Sun, Feb 13, 2011 at 08:42:42PM +0100, Christina Roßmanith wrote: > > > >>diff --git a/svtools/source/config/menuoptions.cx

Re: [Libreoffice] [PATCH] [PUSHED] redundant pointer check

2011-02-17 Thread David Tardon
On Thu, Feb 17, 2011 at 04:14:35AM -0500, Kevin Hunter wrote: > Hullo List, > > Simpleton patch to remove a redundant if-block. Looks reasonable, pushed. D. ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mai

Re: [Libreoffice] [REVIEW] fdo#32552 (alt key opens "File"-menu)

2011-02-17 Thread David Tardon
On Thu, Feb 17, 2011 at 11:29:53AM +, Michael Meeks wrote: > Hi Julien, > > On Tue, 2011-02-15 at 22:22 +0100, Julien Nabet wrote: > > Here is small patch to close the tracker 32552 (alt key opens "File"-menu). > > I wonder how this interacts / complements: > > commit ba110ce308ac66d56

Re: [Libreoffice] [REVIEW] [PUSHED] fdo#32552 (alt key opens "File"-menu)

2011-02-17 Thread David Tardon
On Tue, Feb 15, 2011 at 10:22:07PM +0100, Julien Nabet wrote: > Hello, > > Here is small patch to close the tracker 32552 (alt key opens "File"-menu). > I removed the block quoted in the comments, it compiles but I didn't > test it. I use Gnome and so Gtk on my Debian. Hi, in that case you most

Re: [Libreoffice] compilation and bundled extensions

2011-02-17 Thread David Tardon
On Mon, Feb 14, 2011 at 10:20:27AM +0100, David Tardon wrote: > On Sun, Feb 13, 2011 at 09:26:47PM +, Caolán McNamara wrote: > > caolanm->dtardon: Which reminds me, when i did this I didn't seem to get > > the python, beanshell, rhino scripting extensions (not tha

Re: [Libreoffice] [PUSHED] Re: [PATCH] DECLARE_LIST(TOXControlList, Control*) to std::vector in sw.

2011-02-18 Thread David Tardon
On Thu, Feb 17, 2011 at 11:36:27PM +0100, Jan Holesovsky wrote: > The main thing that I changed was that in some cases you used > vector<...>::iterator it = another_iterator + 1; This is not correct, > operator+() is not defined on std::vector, so the result might be not > what you'd expect; simil

Re: [Libreoffice] Patch handling guideline

2011-02-22 Thread David Tardon
On Tue, Feb 22, 2011 at 07:59:52PM +0100, Pierre-André Jacquod wrote: > for applying, I would propose: > git am > which takes over user / date / commit message from the send message. > Should we generally use the > --signoff > option in order to let a trace of who has pushed this? git already trac

<    1   2   3   4   5   6   7   8   9   10   >