On Sun, Jun 19, 2011 at 09:48:39PM -0700, Joseph Powers wrote: > I'm sending the patch for review; not because it needs a lot but just to have > someone verify that the memory was leaking and needs to be fixed.
It has been pushed already, so adding PUSHED to summary. > > Current fixes: > 1. XPropertyList::Clear() looks like it has a memory leek; so I fixed it. Yes, it has, but it does not matter as the function is not used anywhere. Nitpick: if you fixed it, why did you not use it in the destructor? Another (sligtly bigger) nitpick: why did you not use boost::ptr_vector? > 2. I thinking that once pBmpList is a vector<> I should cleanup the > constructors that pass initial size and resize values. Definitely. > 3. I'm noticing that several methods have extra parameters that aren't used. > Should I include a patch to clean them up also? Why not... Just be careful with virtual functions. D. _______________________________________________ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
