On Tue, Nov 16, 2010 at 05:22:48PM +0100, Giuseppe Castagno wrote: > Tor Lillqvist wrote: > >>Now what it's the right flag to use to surround a debug specific > >>code: OSL_DEBUG_LEVEL > 1 or DBG_UTIL ? > > > >I recently did a build with --enable-dbgutil so that it would use the > >debugging C++ library on Windows. (As such that was mostly useless, it > >didn't help me find the cause of the problem I was seeing.) > > > >(I did not use --enable-debug or any debug=x options to individual build > >commands, which would have set OSL_DEBUG_LEVEL, too.) > > > >That build revealed several places in the code where as far as I could see > >there was a mixup between these two things and I got compilation errors. I > >fixed things up so that my --enable-dbgutil build compiled and linked. But > >it is entirely possible that this then broken stuff for a build with just > >--enable-debug or debug=true but not --enable-dbgutil. > > > >>I confess I'm a little confused :-). > > > >So am I, and disgusted. I am not sure at all that we really want to keep > >this distinction between --enable-dbgutil and --enable-debug (and then there > >is also --enable-symbols) in LibreOffice. Nobody understands it. > > I added a patch that should refine the work started by tml and others > re: DBG_UTIL <-> OSL_DEBUG_LEVEL mixup. > > The patch changes some of the DBG_UTIL to OSL_DEBUG_LEVEL, so they won't > break the build with debug=true. > > Though a couple of warning popped up while building in debug mode. > > beppec56. >
Pushed, thanks! D. _______________________________________________ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
