On Sun, Feb 13, 2011 at 11:40:17PM +0000, Rafael Dominguez wrote:
> Well the patch is related to sw, tab entries in Insert->Indexes and Tables
> -> Indexes and Tables.

Looks good on a glance, but lifetime of the ptrs seem to be bound to
that of the container, so I suggest using boost::ptr_vector instead of
plain std::vector. That would mean that manual deletion of removed items
is no longer necessary.

D.
_______________________________________________
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice

Reply via email to