[kopete-devel] Review Request: kopete chatmemberlistmodel enhancement

2009-10-16 Thread cyberbeat
eviewboard.kde.org/r/1862/s/228/ Thanks, Cyberbeat ___ kopete-devel mailing list kopete-devel@kde.org https://mail.kde.org/mailman/listinfo/kopete-devel

Re: [kopete-devel] Review Request: kopete chatmemberlistmodel enhancement

2009-10-20 Thread cyberbeat
check, if the contact is already in the memberslistmodel, but that would make it more intelligent as it should be? I don't understand why the "addContact" method in chatsession is so complicated. What cases have to have such special treatment? - Cyberbeat --

Re: [kopete-devel] Review Request: kopete chatmemberlistmodel enhancement

2009-10-21 Thread cyberbeat
> On None, Cyberbeat wrote: > > I am not confident with this solution anymore. It is too slow for large chatrooms ( > 100 people): - swiching tabs in chatwindow is slow, even if I optimize the initial fill of the modell with an n*log(n) algorithm/structure - changing online-statu

Re: [kopete-devel] Review Request: kopete chatmemberlistmodel enhancement

2009-10-27 Thread cyberbeat
.cpp 1035610 Diff: http://reviewboard.kde.org/r/1862/diff Testing --- works for me with IRC, ICQ,.. Screenshots --- IRC with sorted members http://reviewboard.kde.org/r/1862/s/228/ Thanks, Cyberbeat ___ kopete-devel mailing list k

Re: [kopete-devel] Review Request: kopete chatmemberlistmodel enhancement

2009-10-30 Thread cyberbeat
petechatsession.h 1035610 /branches/KDE/4.3/kdenetwork/kopete/libkopete/kopetechatsession.cpp 1035610 Diff: http://reviewboard.kde.org/r/1862/diff Testing --- works for me with IRC, ICQ,.. Screenshots --- IRC with sorted members http://reviewboard.kde.org/r/1862/s/

kopete always connects with empty password for protocols with blank passwords allowed, even if password is saved in config

2010-03-20 Thread cyberbeat
Hi, could someone take a short look on this bug https://bugs.kde.org/show_bug.cgi?id=229611 posted by me? Am I right, that this behaviour is wrong? Should I fix it in svn and backport to 4.4 branch? Volker ___ kopete-devel mailing list kopete-devel@k

Review Request: Add audacious support for kopete now listening plugin

2010-05-11 Thread cyberbeat
trunk/KDE/kdenetwork/kopete/plugins/nowlistening/nowlisteningpreferences.cpp 1125620 Diff: http://reviewboard.kde.org/r/3955/diff Testing --- works for me Thanks, Cyberbeat ___ kopete-devel mailing list kopete-devel@kde.org https://mail.kde.

Re: Review Request: Add audacious support for kopete now listening plugin

2010-05-11 Thread cyberbeat
gplugin.cpp 1125620 /trunk/KDE/kdenetwork/kopete/plugins/nowlistening/nowlisteningpreferences.cpp 1125620 Diff: http://reviewboard.kde.org/r/3955/diff Testing --- works for me Thanks, Cyberbeat ___ kopete-devel mailing list kopete

Re: Review Request: Add audacious support for kopete now listening plugin

2010-05-12 Thread cyberbeat
tring declaration from line 81 and use > > > > const QString newTrack = ... > > > > here. thanks for the reviews. I changed most of the things, but did not change the dbus-used-types. I commited the feature. - Cyberbeat -

Re: Now listening plugin: Support for all media player supporting the MPRIS player standard

2010-05-23 Thread cyberbeat
It should be easy to make a plugin for now-listening with more general code. in many of the plugins the mpris dbus interface is already used and the code of them is nearly identical. I am not sure if there exists a dbus interface to query all available players. If not there should be a config fi

Re: Now listening plugin: Support for all media player supporting the MPRIS player standard

2010-05-24 Thread cyberbeat
> Take a look at the Source code of the KMess nowlistening feature: > http://kmess.svn.sourceforge.net/viewvc/kmess/branches/kmess/kmess-2.0.x/src/utils/nowlisteningclient.cpp?revision=6021&view=markup > (Starting from Line 221) > > I think this is what you need/want/meant :-P yes, thanks. this

Review Request: replace all special mpris player nowlistening-plugins with a general one and add mpd support

2010-05-25 Thread cyberbeat
audacious. MPD not tested. Perhaps someone who uses mpd could test please? MPD seems difficult to setup. Thanks, Cyberbeat ___ kopete-devel mailing list kopete-devel@kde.org https://mail.kde.org/mailman/listinfo/kopete-devel

Re: Review Request: replace all special mpris player nowlistening-plugins with a general one and add mpd support

2010-05-25 Thread cyberbeat
I used some files attached from to bug report for mpd support, but adapted these to official libmpdclient. I replaced only those plugins, who used a mpris-dbus-connection before. - Cyberbeat --- This is an automatically generated e-m

Re: Review Request: replace all special mpris player nowlistening-plugins with a general one and add mpd support

2010-07-21 Thread cyberbeat
/nowlistening/nowlisteningpreferences.cpp 1130643 Diff: http://reviewboard.kde.org/r/4151/diff Testing --- Tested mpris support with audacious. MPD not tested. Perhaps someone who uses mpd could test please? MPD seems difficult to setup. Thanks, Cyberbeat

Re: Review Request: replace all special mpris player nowlistening-plugins with a general one and add mpd support

2010-07-21 Thread cyberbeat
/nowlisteningpreferences.cpp 1130643 Diff: http://reviewboard.kde.org/r/4151/diff Testing (updated) --- Tested mpris support with audacious. Thanks, Cyberbeat ___ kopete-devel mailing list kopete-devel@kde.org https://mail.kde.org/mailman/listinfo

Review Request: Sets global status message instead of setting it for each account.

2010-09-14 Thread cyberbeat
/nowlisteningplugin.cpp 1175313 Diff: http://svn.reviewboard.kde.org/r/5344/diff Testing --- Works for me now again for global status. And the accounts status messages are updated automatically by kopete it seems :) Thanks, Cyberbeat ___ kopete-devel mailing

Re: Some ideas

2010-09-16 Thread cyberbeat
Hi, please let me also share my view: sometimes it is really desirable to have two people be connected with kopete temporarily in one desktop session, and this is what I would expect from multiple "identities" to solve. > I know, handling all of your accounts at once is the whole point of KDE.

Re: Review Request: Statistics: batch status updated on exit into a single transaction.

2010-10-15 Thread cyberbeat
patch). Thanks for your work, the plugin gets more usable now. - Cyberbeat On 2010-10-14 14:44:26, Luca Tettamanti wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > http://svn.reviewboard.kd

Re: Review Request: Fix user_is_typing_message notifications

2011-03-02 Thread cyberbeat
it? - Cyberbeat On Sept. 16, 2010, 2:20 p.m., Igor Poboiko wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > http://svn.reviewboard.kd

Re: GSoC 2011 Kopete Ideas

2011-03-12 Thread cyberbeat
What about an IRC plugin (based on libircclient-qt)? I had started one a while ago, but never finished it enough to submit it as official kopete protocol. Volker ___ kopete-devel mailing list kopete-devel@kde.org https://mail.kde.org/mailman/listinfo/ko

Re: IRC protocol

2011-04-05 Thread cyberbeat
Hi, I think the bugzilla page gives a good overview of the current state: https://bugs.kde.org/show_bug.cgi?id=167884 I have a partially working irc plugin on kde-apps.org, but never improved it further. Volker Am Dienstag, 5. April 2011 schrieb kopete-devel-requ...@kde.org: > Message: 1 > D

Could the maintainer of jabber protocol have a look at this bug..

2011-09-26 Thread cyberbeat
Hi, I have commented on this bug "Kopete does not remember manually given nick-names" https://bugs.kde.org/show_bug.cgi?id=274175 and proposed a patch (to remove some code, which overwrites the manually entered nickname). I am not sure, if this is ok. Volker __

Review Request: Fix overwrite of manually chosen nicknames

2011-11-08 Thread cyberbeat
/jabber/jabberbasecontact.cpp 1263246 Diff: http://svn.reviewboard.kde.org/r/6823/diff/diff Testing --- I used kopete several weeks with icq, jabber, msn protocol together with my patch, and did not notice any problems. The wrong behaviour is fixed. Thanks, Cyberbeat

Re: Review Request: Bugs in pidgin history import for kopete

2011-11-09 Thread cyberbeat
e time :) (probably next sunday). > Is it a bad sign that your review request is pending now since over one > year? Is there nobody to commit it? I really would like to see this patch going into trunk - Cyberbeat --- This is an

Re: Review Request: Fix overwrite of manually chosen nicknames

2011-11-09 Thread cyberbeat
;custom display name", which is also only returned, if c) is the ressource. If I understood something wrong, please explain to me :-) - Cyberbeat --- This is an automatically generated e-mail. To reply, visit: http://svn.reviewboa

Re: Review Request: Fix overwrite of manually chosen nicknames

2011-11-10 Thread cyberbeat
he "Bugs" field in the request incorrectly. It must > contain just the bug ID, not the whole URL. > > Cyberbeat wrote: > I don't think, that I disable updating of nicknames of contacts from > jabber server. > > To explain the problem from the GUI perspect

Re: Review Request: Fix overwrite of manually chosen nicknames

2011-11-15 Thread cyberbeat
tem.name() should be false, right ? > > > > > > I did not mean this patch to be committed this way. I only would like to discuss, if this block of code should be deleted. For testing this is the most easy way to reach this. I don't understand what you m

Re: Review Request: Fix overwrite of manually chosen nicknames

2011-11-24 Thread cyberbeat
he "Bugs" field in the request incorrectly. It must > contain just the bug ID, not the whole URL. > > Cyberbeat wrote: > I don't think, that I disable updating of nicknames of contacts from > jabber server. > > To explain the problem from the GUI perspect

Re: Review Request: Fix overwrite of manually chosen nicknames

2011-11-24 Thread cyberbeat
he "Bugs" field in the request incorrectly. It must > contain just the bug ID, not the whole URL. > > Cyberbeat wrote: > I don't think, that I disable updating of nicknames of contacts from > jabber server. > > To explain the problem from the GUI perspect

Re: Review Request: Fix overwrite of manually chosen nicknames

2011-11-24 Thread cyberbeat
he "Bugs" field in the request incorrectly. It must > contain just the bug ID, not the whole URL. > > Cyberbeat wrote: > I don't think, that I disable updating of nicknames of contacts from > jabber server. > > To explain the problem from the GUI perspect

Re: Review Request: Fix overwrite of manually chosen nicknames

2011-11-24 Thread cyberbeat
, Cyberbeat ___ kopete-devel mailing list kopete-devel@kde.org https://mail.kde.org/mailman/listinfo/kopete-devel

Re: Review Request: Fix overwrite of manually chosen nicknames

2011-11-26 Thread cyberbeat
he "Bugs" field in the request incorrectly. It must > contain just the bug ID, not the whole URL. > > Cyberbeat wrote: > I don't think, that I disable updating of nicknames of contacts from > jabber server. > > To explain the problem from the GUI perspect

Review Request: This adds a context option "rename" to contacts and allows to change the custom displayname inline. In combination with a shortcut (typically F2) a very comfortable way to quickly rena

2011-12-03 Thread cyberbeat
peteitemdelegate.cpp 1265679 /trunk/KDE/kdenetwork/kopete/kopete/kopeteui.rc 1265679 Diff: http://svn.reviewboard.kde.org/r/6848/diff/diff Testing --- I used this for a few days, and it seems to work :-) Thanks, Cyberbeat ___ kopete-devel maili

Re: Review Request: This adds a context option "rename" to contacts and allows to change the custom displayname inline. In combination with a shortcut (typically F2) a very comfortable way to quickly

2011-12-03 Thread cyberbeat
etwork/kopete/kopete/contactlist/kopeteitemdelegate.cpp 1265679 /trunk/KDE/kdenetwork/kopete/kopete/kopeteui.rc 1265679 Diff: http://svn.reviewboard.kde.org/r/6848/diff/diff Testing --- I used this for a few days, and it seems to work :-)

Re: Review Request: Fix overwrite of manually chosen nicknames

2011-12-03 Thread cyberbeat
. Thanks, Cyberbeat ___ kopete-devel mailing list kopete-devel@kde.org https://mail.kde.org/mailman/listinfo/kopete-devel

Re: Review Request: Fix overwrite of manually chosen nicknames

2011-12-03 Thread cyberbeat
he "Bugs" field in the request incorrectly. It must > contain just the bug ID, not the whole URL. > > Cyberbeat wrote: > I don't think, that I disable updating of nicknames of contacts from > jabber server. > > To explain the problem from the GUI perspect

Re: Review Request: This adds a context option "rename" to contacts and allows to change the custom displayname inline. In combination with a shortcut (typically F2) a very comfortable way to quickly

2011-12-03 Thread cyberbeat
this dead commented code. oops, forgot to delete some comments and debug lines.. - Cyberbeat --- This is an automatically generated e-mail. To reply, visit: http://svn.reviewboard.kde.org/r/6848/#review10510

Re: Review Request: Fix overwrite of manually chosen nicknames

2011-12-12 Thread cyberbeat
he "Bugs" field in the request incorrectly. It must > contain just the bug ID, not the whole URL. > > Cyberbeat wrote: > I don't think, that I disable updating of nicknames of contacts from > jabber server. > > To explain the problem from the GUI perspect

Re: Review Request: This adds a context option "rename" to contacts and allows to change the custom displayname inline. In combination with a shortcut (typically F2) a very comfortable way to quickly

2011-12-12 Thread cyberbeat
> On Dec. 3, 2011, 2 p.m., Pali Rohár wrote: > > besides the dead lines and debug-output (which I will remove in a second revision), is this change ok? does it work for you? - Cyberbeat --- This is an automatically generat

Re: Review Request: Fix overwrite of manually chosen nicknames

2012-01-05 Thread cyberbeat
he "Bugs" field in the request incorrectly. It must > contain just the bug ID, not the whole URL. > > Cyberbeat wrote: > I don't think, that I disable updating of nicknames of contacts from > jabber server. > > To explain the problem from the GUI perspect

Re: Review Request: This adds a context option "rename" to contacts and allows to change the custom displayname inline. In combination with a shortcut (typically F2) a very comfortable way to quickly

2012-01-05 Thread cyberbeat
DE/kdenetwork/kopete/kopete/contactlist/kopeteitemdelegate.cpp 1271881 /trunk/KDE/kdenetwork/kopete/kopete/kopeteui.rc 1271881 Diff: http://svn.reviewboard.kde.org/r/6848/diff/diff Testing --- I used this for a few days, and it seems to work :-)

Re: Review Request: This adds a context option "rename" to contacts and allows to change the custom displayname inline. In combination with a shortcut (typically F2) a very comfortable way to quickly

2012-01-05 Thread cyberbeat
DE/kdenetwork/kopete/kopete/contactlist/kopeteitemdelegate.cpp 1271881 /trunk/KDE/kdenetwork/kopete/kopete/kopeteui.rc 1271881 Diff: http://svn.reviewboard.kde.org/r/6848/diff/diff Testing --- I used this for a few days, and it seems to work :-)

Re: Review Request: This adds a context option "rename" to contacts and allows to change the custom displayname inline. In combination with a shortcut (typically F2) a very comfortable way to quickly

2012-01-05 Thread cyberbeat
f so then please change them to tabs to comply with > > the coding style. The same for the lines below. I fixed your issues - Cyberbeat --- This is an automatically generated e-mail. To reply, visit: http:

Re: Review Request: This adds a context option "rename" to contacts and allows to change the custom displayname inline. In combination with a shortcut (typically F2) a very comfortable way to quickly

2012-01-09 Thread cyberbeat
istview.cpp 1271881 Diff: http://svn.reviewboard.kde.org/r/6848/diff/diff Testing --- I used this for a few days, and it seems to work :-) Thanks, Cyberbeat ___ kopete-devel mailing list kopete-devel@kde.org https://mail.kde.org/mailman/listinfo/kopete-devel

Re: Review Request: This adds a context option "rename" to contacts and allows to change the custom displayname inline. In combination with a shortcut (typically F2) a very comfortable way to quickly

2012-01-18 Thread cyberbeat
last mentioned annoyance seems to be gone, perhaps because of a qt-update. - Cyberbeat On Jan. 9, 2012, 5:28 p.m., Cyberbeat wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > http://svn.reviewboa

Re: Patches for Kopete on reviewboard

2012-02-26 Thread cyberbeat
> > I'm trying to configure Kopete to work with Oracle Beehive > > (Jabber/XMPP). When I try to connect I get a toaster notification that > > says, "There was an error authenticating with the server. Login failed > > with unknown reason." For the jabber protocol, there exists a context menu "xml c

Review Request: Add support for mpris2 in nowlistening-plugin

2012-05-30 Thread cyberbeat
/plugins/nowlistening/nowlisteningplugin.cpp 1297322 /trunk/KDE/kdenetwork/kopete/plugins/nowlistening/nowlisteningpreferences.cpp 1297322 Diff: http://svn.reviewboard.kde.org/r/6960/diff/ Testing --- works for me (banshee) Thanks, Cyberbeat

Re: Review Request: Add support for mpris2 in nowlistening-plugin

2012-05-30 Thread cyberbeat
ris." and not > > "org.mpris.MediaPlayer". Now I am in doubt if this line should also be > > "org.mpris." or the other line should be "org.mpris.MediaPlayer". I am not > > an expert in mpris so I do not know each one should be used here.

Re: Review Request: Add support for mpris2 in nowlistening-plugin

2012-05-31 Thread cyberbeat
/kdenetwork/kopete/plugins/nowlistening/nowlisteningprefs.ui 1297322 Diff: http://svn.reviewboard.kde.org/r/6960/diff/ Testing --- works for me (banshee) Thanks, Cyberbeat ___ kopete-devel mailing list kopete-devel@kde.org https://mail.kde.org

Re: Review Request: Add support for mpris2 in nowlistening-plugin

2012-05-31 Thread cyberbeat
/kopete/plugins/nowlistening/nowlisteningprefs.ui 1297322 Diff: http://svn.reviewboard.kde.org/r/6960/diff/ Testing --- works for me (banshee) Thanks, Cyberbeat ___ kopete-devel mailing list kopete-devel@kde.org https://mail.kde.org/mailman

Re: Review Request: Add support for mpris2 in nowlistening-plugin

2012-05-31 Thread cyberbeat
rent commits so it will be easier if they were in > > different reviews. If you don't mind, I would leave it here, but I would make the two different commits to svn (for my luck the changesets are distinct). Is there a possibility to track different changes in svn without having

Review Request: Fix a bug in kopete nowlistening preferences kcm

2012-06-06 Thread cyberbeat
ing/nowlisteningpreferences.cpp 1298638 /trunk/KDE/kdenetwork/kopete/plugins/nowlistening/nowlisteningprefs.ui 1298638 Diff: http://svn.reviewboard.kde.org/r/6977/diff/ Testing --- works for me Thanks, Cyberbeat ___ kopete-devel mailing list kopete-de

Review Request: New kopete history plugin based on sqlite

2012-06-24 Thread cyberbeat
hink it is possible to use both plugins parallel, although I would like to see this plugin to replace the old one in longer term. On import nothing is deleted. Thanks, Cyberbeat ___ kopete-devel mailing list kopete-devel@kde.org https://mail.kde.org/mailma

Re: Review Request: New kopete history plugin based on sqlite

2012-06-24 Thread cyberbeat
and all these clients receive the same message? Currently I think I only log plain text, but I also have imported html-messages in my history, which are stored in the sqlite db now, and are correctly displayed. - Cyberbeat --- Thi

Re: Review Request: New kopete history plugin based on sqlite

2012-06-24 Thread cyberbeat
HTML messages? > > > > What about adding code for importing history from other IM clients? Has > > this plugin some interface for it? > > Two years ago I wrote small tool which convert IM history from Nokia N900 > > (RTCOM Maemo 5) to Kopete xml logs. Maybe it will be good

Re: Review Request: New kopete history plugin based on sqlite

2012-06-30 Thread cyberbeat
veral days now, and successfully imported my complete pidgin and old kopete history (some megabytes since 2006). I think it is possible to use both plugins parallel, although I would like to see this plugin to replace the old one in longer term. On import nothing is deleted. Thanks,

Re: Review Request: New kopete history plugin based on sqlite

2012-06-30 Thread cyberbeat
HTML messages? > > > > What about adding code for importing history from other IM clients? Has > > this plugin some interface for it? > > Two years ago I wrote small tool which convert IM history from Nokia N900 > > (RTCOM Maemo 5) to Kopete xml logs. Maybe it will be good

Re: Review Request: Fix a bug in kopete nowlistening preferences kcm

2012-11-11 Thread cyberbeat
trunk tomorrow - Cyberbeat On June 6, 2012, 2:35 p.m., Cyberbeat wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > http://svn.reviewboa

Re: Review Request: New kopete history plugin based on sqlite

2013-01-10 Thread cyberbeat
HTML messages? > > > > What about adding code for importing history from other IM clients? Has > > this plugin some interface for it? > > Two years ago I wrote small tool which convert IM history from Nokia N900 > > (RTCOM Maemo 5) to Kopete xml logs. Maybe it will be good

Re: Review Request 6977: Fix a bug in kopete nowlistening preferences kcm

2013-03-08 Thread cyberbeat
> On Nov. 11, 2012, 10:01 a.m., Cyberbeat wrote: > > if noone speaks against, then I'll commit this fix to trunk tomorrow > > Pali Rohár wrote: > Hi, patch looks ok. Did you see any reported bug at bugzilla? > > Pali Rohár wrote: > Hi, did you commited

Re: Review Request 7069: SSL support for oscar protocol (ICQ)

2013-03-23 Thread cyberbeat
--- This is an automatically generated e-mail. To reply, visit: http://svn.reviewboard.kde.org/r/7069/#review11046 --- I tested with ICQ and it works as expected :-) - Cyberbeat On

Re: Review Request 6998: New kopete history plugin based on sqlite

2013-05-12 Thread cyberbeat
HTML messages? > > > > What about adding code for importing history from other IM clients? Has > > this plugin some interface for it? > > Two years ago I wrote small tool which convert IM history from Nokia N900 > > (RTCOM Maemo 5) to Kopete xml logs. Maybe it will be good

Re: Moving KDE Telepathy to kdenetwork

2015-02-06 Thread cyberbeat
> Not being a IM user myself, how does KTP compare to kopete feature wise? I can list some (important for me) features, that are missing in ktp (correct me, if I missed something): - edit contact names and images, and group contacts (for example same people with different IM-accounts with dif

Re: GSoC Idea - Better history plugin (Joshua Joseph)

2015-03-11 Thread cyberbeat
Hi, I think a database approach is better than xml storage. My improved plugin http://kde-apps.org/content/show.php/Improved+Kopete+History+Plugin?content=154660 has noticable better speed for history search (I have big chat logs from many years + many protocols - about 40 MB), has improved im

Re: KDE-SoC Kopete IRC Protocol

2016-03-21 Thread cyberbeat
Hi, I would recommend to take a look at http://communi.github.io/ for an advanced and stable qt-irc-library. Volker > > On Thursday 17 March 2016 14:39:06 Narek Babajanyan wrote: >> Greetings everyone, >> >> I'm writing to express my interest in participating in Kopete IRC >> plugin developme

Re: Suggestions on porting process of plugins and protocols

2016-07-03 Thread cyberbeat
Hi, I wrote the history2 plugin long ago. Here a more complete explanation why I wrote it: > This is a copy of the old history plugin, but with so many changes, that I > created it as a new one "history2". > > Most important changes: > > - based on sqlite3 instead of xml-files > > - import hi