> On Nov. 15, 2011, 7:07 p.m., Frank Schaefer wrote: > > /trunk/KDE/kdenetwork/kopete/protocols/jabber/jabberbasecontact.cpp, line > > 115 > > <http://svn.reviewboard.kde.org/r/6823/diff/1/?file=47214#file47214line115> > > > > Ohh come on, just adding a "false && " is definitely not the the right > > way to fix this bug. You will have to soent a few minutes more if you want > > to fix it ! > > > > If there is a valid nickname, then metaContact()->customDisplayName() > > != item.name() should be false, right ? > > > > > >
I did not mean this patch to be committed this way. I only would like to discuss, if this block of code should be deleted. For testing this is the most easy way to reach this. I don't understand what you mean with this condition "metaContact()->customDisplayName() != item.name()", can you explain more? - Cyberbeat ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://svn.reviewboard.kde.org/r/6823/#review10470 ----------------------------------------------------------- On Nov. 8, 2011, 7:55 p.m., Cyberbeat wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://svn.reviewboard.kde.org/r/6823/ > ----------------------------------------------------------- > > (Updated Nov. 8, 2011, 7:55 p.m.) > > > Review request for Kopete. > > > Description > ------- > > This patch fixes the bug, that the jabber protocol overwrites manually given > nicknames each time kopete connects. > > > This addresses bug https://bugs.kde.org/show_bug.cgi?id=274175. > > https://bugs.kde.org/show_bug.cgi?id=https://bugs.kde.org/show_bug.cgi?id=274175 > > > Diffs > ----- > > /trunk/KDE/kdenetwork/kopete/protocols/jabber/jabberbasecontact.cpp 1263246 > > Diff: http://svn.reviewboard.kde.org/r/6823/diff/diff > > > Testing > ------- > > I used kopete several weeks with icq, jabber, msn protocol together with my > patch, and did not notice any problems. The wrong behaviour is fixed. > > > Thanks, > > Cyberbeat > >
_______________________________________________ kopete-devel mailing list kopete-devel@kde.org https://mail.kde.org/mailman/listinfo/kopete-devel
