> On May 31, 2012, 12:01 a.m., Lamarque Souza wrote: > >
Thanks for the quick review. I'll fix the other issues soon. Do you also experience, that you cannot choose in nowlistening preferences the media-player, when you do not modify the checkbox "use special mediaplayer.."? I fixed that by using a klistwidget instead of k3listbox. KCMModule seems to not recognizes changes on k3listbox-selections. > On May 31, 2012, 12:01 a.m., Lamarque Souza wrote: > > /trunk/KDE/kdenetwork/kopete/plugins/nowlistening/nlmpris2.cpp, line 61 > > <http://svn.reviewboard.kde.org/r/6960/diff/1/?file=48034#file48034line61> > > > > This implementation is basically a copy of the mpris plugin replacing > > the dbus service and interface names. In the original mpris implementation > > this line search for the string "org.mpris." and not > > "org.mpris.MediaPlayer". Now I am in doubt if this line should also be > > "org.mpris." or the other line should be "org.mpris.MediaPlayer". I am not > > an expert in mpris so I do not know each one should be used here. I think the original Implementation is not good, because it will also find mpris2 Interface, but cannot use it. - Cyberbeat ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://svn.reviewboard.kde.org/r/6960/#review10807 ----------------------------------------------------------- On May 30, 2012, 11:23 p.m., Cyberbeat wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://svn.reviewboard.kde.org/r/6960/ > ----------------------------------------------------------- > > (Updated May 30, 2012, 11:23 p.m.) > > > Review request for Kopete. > > > Description > ------- > > Add support for mpris2 in nowlistening-plugin > > > Diffs > ----- > > /trunk/KDE/kdenetwork/kopete/plugins/nowlistening/CMakeLists.txt 1297322 > /trunk/KDE/kdenetwork/kopete/plugins/nowlistening/nlmpris2.h PRE-CREATION > /trunk/KDE/kdenetwork/kopete/plugins/nowlistening/nlmpris2.cpp PRE-CREATION > /trunk/KDE/kdenetwork/kopete/plugins/nowlistening/nowlisteningplugin.cpp > 1297322 > > /trunk/KDE/kdenetwork/kopete/plugins/nowlistening/nowlisteningpreferences.cpp > 1297322 > > Diff: http://svn.reviewboard.kde.org/r/6960/diff/ > > > Testing > ------- > > works for me (banshee) > > > Thanks, > > Cyberbeat > >
_______________________________________________ kopete-devel mailing list kopete-devel@kde.org https://mail.kde.org/mailman/listinfo/kopete-devel
