----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://svn.reviewboard.kde.org/r/5629/#review8161 -----------------------------------------------------------
Works here (patched my statistics plugin in 4.5 branch with your patch). Thanks for your work, the plugin gets more usable now. - Cyberbeat On 2010-10-14 14:44:26, Luca Tettamanti wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://svn.reviewboard.kde.org/r/5629/ > ----------------------------------------------------------- > > (Updated 2010-10-14 14:44:26) > > > Review request for Kopete. > > > Summary > ------- > > Statistics: batch status updated on exit into a single transaction. > Upon exit Kopete will update the online status of all the contacts to > "Unknown"; this triggers an INSERT for each contact into the > statistics DB which - with the default auto-commit behaviour - results in a > fsync of the DB. > A micro-benchmark shows that 500 (about the size of my contact list) INSERTs > take about 45 seconds on a not-so-crappy SATA disk, while the same amount of > INSERTs batched into a single transaction take around 250ms. > > > Diffs > ----- > > trunk/KDE/kdenetwork/kopete/plugins/statistics/statisticsdb.h 1185866 > trunk/KDE/kdenetwork/kopete/plugins/statistics/statisticsdb.cpp 1185866 > trunk/KDE/kdenetwork/kopete/plugins/statistics/statisticsplugin.h 1185866 > trunk/KDE/kdenetwork/kopete/plugins/statistics/statisticsplugin.cpp 1185866 > > Diff: http://svn.reviewboard.kde.org/r/5629/diff > > > Testing > ------- > > Shutdown and check that the expected data is in the DB. > > > Thanks, > > Luca > >
_______________________________________________ kopete-devel mailing list kopete-devel@kde.org https://mail.kde.org/mailman/listinfo/kopete-devel
