> On Nov. 9, 2011, 3:01 p.m., Pali Rohár wrote: > > Your patch disable updating nickname of all contacts from jabber server. > > This is bad because some people want to autoupdate new nicknames from > > server. > > Instead totally disabling this functions, it should be configurable (in > > jabber account settings dialog). > > Ralf Jung wrote: > Actually, Kopete already has a per-contact setting saying whether the > local or remote name should be used. The code should adhere to that setting. > > Btw, you filled the "Bugs" field in the request incorrectly. It must > contain just the bug ID, not the whole URL.
I don't think, that I disable updating of nicknames of contacts from jabber server. To explain the problem from the GUI perspective: - Right-Click a metacontact and choose its "properties" - There you can choose, where to take it's displayname from, there are 3 possibilities: a) take displayname from adressebook (KABC) b) take displayname from a protocol (you can choose, which) c) define a custom displayname (which really should NEVER be overwritten by some protocols!) The displayname for contacts should only be updated from server for case b), which is the standard. For my test-contact I have chosen a custom displayname c) This displayname is overwritten each time I connect to the jabber server. This can be considered as a bug. More technically from the code perspective: In kopetemetacontact.cpp there is a method "displayName()", which is used in the contact list, and which returns the displayname from the configured ressource (a,b or c from above). Standard ressource is b). The member-variable "displayname" represents the "custom display name", which is also only returned, if c) is the ressource. If I understood something wrong, please explain to me :-) - Cyberbeat ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://svn.reviewboard.kde.org/r/6823/#review10461 ----------------------------------------------------------- On Nov. 8, 2011, 7:55 p.m., Cyberbeat wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://svn.reviewboard.kde.org/r/6823/ > ----------------------------------------------------------- > > (Updated Nov. 8, 2011, 7:55 p.m.) > > > Review request for Kopete. > > > Description > ------- > > This patch fixes the bug, that the jabber protocol overwrites manually given > nicknames each time kopete connects. > > > This addresses bug https://bugs.kde.org/show_bug.cgi?id=274175. > > https://bugs.kde.org/show_bug.cgi?id=https://bugs.kde.org/show_bug.cgi?id=274175 > > > Diffs > ----- > > /trunk/KDE/kdenetwork/kopete/protocols/jabber/jabberbasecontact.cpp 1263246 > > Diff: http://svn.reviewboard.kde.org/r/6823/diff/diff > > > Testing > ------- > > I used kopete several weeks with icq, jabber, msn protocol together with my > patch, and did not notice any problems. The wrong behaviour is fixed. > > > Thanks, > > Cyberbeat > >
_______________________________________________ kopete-devel mailing list kopete-devel@kde.org https://mail.kde.org/mailman/listinfo/kopete-devel
