Re: Review Request 125527: Add mimeTypes() to KPluginMetaData

-- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/125527/#review88915 --- On Oct. 6, 2015, 12:42 p.m., Alex Richardson wrote: > > ---

Review Request 126196: Fix regression caused by RR 125527

eae91881bafc93b047b81a2b21634223dd5d89f4 Diff: https://git.reviewboard.kde.org/r/126196/diff/ Testing --- compiles, tests pass Thanks, Alex Richardson ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks

Re: Review Request 126196: Fix regression caused by RR 125527

marked as submitted. Review request for KDE Frameworks and Jarosław Staniek. Changes --- Submitted with commit 78d740aece90b676086412f977d4cd691791bd8f by Alex Richardson to branch master. Repository: kcoreaddons Description --- Make sure that applications using

Re: Review Request 126320: Read KPluginMetada's property X-Plasma-ComponentTypes as a stringlist

) <https://git.reviewboard.kde.org/r/126320/#comment61223> readStringList() is static so KPluginMetaData:: is probably the better way to call it - Alex Richardson On Dec. 11, 2015, 6:48 p.m., Martin Klapetek wrote: > > ---

Re: Review Request 126320: Read KPluginMetada's property X-Plasma-ComponentTypes as a stringlist

tps://git.reviewboard.kde.org/r/126320/#comment61224> This should probably also be changed to QStringList? - Alex Richardson On Dec. 11, 2015, 6:48 p.m., Martin Klapetek wrote: > > --- > This is an automatically generated e

Re: Review Request 126339: remove kdewin dependency

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/126339/#review89464 --- Ship it! Looks good to me - Alex Richardson On Dec. 14

Review Request 126343: KPluginMetaData: Add fields used by KAboutData and introduce conversion function

/r/126193/ Thanks, Alex Richardson ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Review Request 126324: [MSWin/OS X] save and restore window geometry instead of only size (WIP/Suggestion)

> On Dec. 14, 2015, 11:47 a.m., Marco Martin wrote: > > src/gui/CMakeLists.txt, line 22 > > > > > > we really can't add a dependency to QWidgets here. > > depending on qwidgets will make many potential interes

Re: Review Request 126348: Make it possible to provide the metadata in json

od to me other than this one issue src/kpackage/private/packagejobthread.cpp (line 143) <https://git.reviewboard.kde.org/r/126348/#comment61242> I think it would be better if this code was added to the KPluginMetaData ctor (in an `if (path.endswith(".json"))` branch. - Ale

Re: Review Request 126366: Make KPluginMetaData constructible from a json path.

to make sure we don't break this in future. - Alex Richardson On Dec. 15, 2015, 3:27 p.m., Aleix Pol Gonzalez wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard

Re: Review Request 126348: Make it possible to provide the metadata in json

tps://git.reviewboard.kde.org/r/126348/#comment61280> no longer required, right? src/kpackage/package.cpp (line 916) <https://git.reviewboard.kde.org/r/126348/#comment61281> `path.endsWith("/metadata.desktop") || path.endsWith("/metadata.json")`? QRegExp seems like overkil

Re: Review Request 126397: [xcb] Safety check whether we have a QApplication in mapViewport

tps://git.reviewboard.kde.org/r/126397/#comment61407> qobject_cast? - Alex Richardson On Dec. 17, 2015, 9:21 a.m., Martin Gräßlin wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://git.rev

Re: Review Request 126409: Fix use-after-free in .desktop file parser

t.reviewboard.kde.org/r/126409/ > --- > > (Updated Dec. 18, 2015, 12:49 a.m.) > > > Review request for KDE Frameworks and Alex Richardson. > > > Repository: kcoreaddons > > > Description > --- > > Patch to fix a use-after-free issue in > kcoreaddons/src

Re: Review Request 126409: Fix use-after-free in .desktop file parser

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/126409/#review89808 --- Ship it! Ship It! - Alex Richardson On Dec. 18, 2015, 3

Re: Review Request 126343: KPluginMetaData: Add fields used by KAboutData and introduce conversion function

in okular: https://git.reviewboard.kde.org/r/126193/ Thanks, Alex Richardson ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Review Request 126455: Add mutex round static QRegExp usage in KShorturifilter

internally](http://code.woboq.org/qt5/qtbase/src/corelib/tools/qregularexpression.cpp.html#_ZN25QRegularExpressionPrivate14compilePatternEv) and is the replacement for QRegExp - Alex Richardson On Dec. 21, 2015, 4:22 p.m., David Edmundson wrote

Re: Review Request 126343: KPluginMetaData: Add fields used by KAboutData and introduce conversion function

marked as submitted. Review request for KDE Frameworks. Changes --- Submitted with commit 218084df9f5266306045fc6876e8f0a6886808dd by Alex Richardson to branch master. Repository: kcoreaddons Description --- Add KPluginMetaData::translators() and KAboutPerson::fromJson() Plugins

Re: Review Request 125869: Convert all io slave .protocol data to json and embed it.

into implementing the translations then. - Alex Richardson On Dec. 27, 2015, 5:14 p.m., Christoph Cullmann wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard

Re: Review Request 125869: Convert all io slave .protocol data to json and embed it.

: https://svn.reviewboard.kde.org/r/7154/ - Alex Richardson On Dec. 28, 2015, 7:25 p.m., Christoph Cullmann wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.

Re: Review Request 126618: Make CMake macro kcoreaddons_desktop_to_json() work on windows.

od to me otherwise as it will still check the same directories change behaviour on Linux. Only minor issue is that the error message is a little bit confusing now. - Alex Richardson On Jan. 3, 2016, 1:22 p.m., Kåre Särs wrote: > > --- >

Re: Review Request 126618: Make CMake macro kcoreaddons_desktop_to_json() work on windows.

> On Jan. 3, 2016, 3:22 p.m., Alex Richardson wrote: > > According to the documentation AppLocalDataLocation is the following: > > "C:/Users//AppData/Local/", "C:/ProgramData/", > > "", "/data" > > > > In which direct

Re: Review Request 126618: Make CMake macro kcoreaddons_desktop_to_json() work on windows.

> On Jan. 3, 2016, 3:22 p.m., Alex Richardson wrote: > > According to the documentation AppLocalDataLocation is the following: > > "C:/Users//AppData/Local/", "C:/ProgramData/", > > "", "/data" > > > > In which direct

Re: Review Request 126618: Make CMake macro kcoreaddons_desktop_to_json() work on windows.

> On Jan. 3, 2016, 3:22 p.m., Alex Richardson wrote: > > According to the documentation AppLocalDataLocation is the following: > > "C:/Users//AppData/Local/", "C:/ProgramData/", > > "", "/data" > > > > In which direct

Re: Review Request 121672: Properly convert .desktop files that have an associated servicetype

t.cpp 64373d5be930426dd8a1f8e455e33c411a4795fd src/lib/plugin/desktopfileparser.cpp b1b5440b48e4fd412932a7d7e794d641b1406699 Diff: https://git.reviewboard.kde.org/r/121672/diff/ Testing --- Unit test works Thanks, Alex Richardson ___ Kde-frameworks-devel ma

Re: Review Request 125048: Use JSON files directly instead of kcoreaddons_desktop_to_json()

> src/kpasswdserver/kpasswdserver.desktop > bc788e5665e3d9d43309da241c3a3f5ac3cd0fc9 > src/kpasswdserver/kpasswdserver.json PRE-CREATION > src/kssld/CMakeLists.txt bf6970c2741a6edd01e36b86744d643e70046889 > src/kssld/kssld.desktop 86581b208ffc8

Review Request 126813: Fix build with older polkit

--- Seems like the function exists, but the header declaration is missing Diffs - core/polkitqt1-subject.cpp ecb4c0e216d5bacf5dff5cf100611b941d3e8fbd Diff: https://git.reviewboard.kde.org/r/126813/diff/ Testing --- compiles now Thanks, Alex Richardson

Review Request 126831: WIP: Fix QFileDialog::openUrl() for remote files

eApplication::notifyInternal2 qcoreapplication.cpp1013 0x7fce748cf642 16 QCoreApplication::sendSpontaneousEvent qcoreapplication.h 230 0x7fce7575e226 17 QApplicationPrivate::sendMouseEvent qapplication.cpp2765 0x7fce75757997 18 QWidgetWindow

Re: Review Request 126831: WIP: Fix QFileDialog::openUrl() for remote files

32700x7fce75758fdf 15 QCoreApplication::notifyInternal2 qcoreapplication.cpp1013 0x7fce748cf642 16 QCoreApplication::sendSpontaneousEvent qcoreapplication.h 230 0x7fce7575e226 17 QApplicationPrivate::sendMouseEvent qapplication.cpp2765 0x7

Re: Review Request 126740: Add a script for optimizing svgs

shFAQ/001) optimize.svg.sh (line 16) <https://git.reviewboard.kde.org/r/126740/#comment62491> Here an everywhere else $v -> "$v" https://github.com/koalaman/shellcheck/wiki/SC2086 optimize.svg.sh (line 20) <https://git.reviewboard.kde.org/r/126740/#comment62490&g

Re: Review Request 126813: Fix build with older polkit

core/polkitqt1-subject.h 03028f636d7efc154138821419a704b661a7aeac core/polkitqt1-subject.cpp ecb4c0e216d5bacf5dff5cf100611b941d3e8fbd polkitqt1-config.h.cmake PRE-CREATION Diff: https://git.reviewboard.kde.org/r/126813/diff/ Testing --- compiles now Thanks, Alex Richa

Re: Review Request 126831: WIP: Fix QFileDialog::openUrl() for remote files

plication::notifyqapplication.cpp32700x7fce75758fdf 15 QCoreApplication::notifyInternal2 qcoreapplication.cpp1013 0x7fce748cf642 16 QCoreApplication::sendSpontaneousEvent qcoreapplication.h 230 0x7fce7575e226 1

Review Request 126880: Fix QFileDialog::openUrl() for remote files

stent directory to be selected. BUG: 345253 Supersedes https://git.reviewboard.kde.org/r/126831/ Diffs - src/platformtheme/kdeplatformfiledialoghelper.cpp 11e7efbb66948da40bf19f430f8020f95d0233f8 Diff: https://git.reviewboard.kde.org/r/126880/diff/ Testing --- Thanks, Alex Richa

Re: Review Request 126876: Fix QFileDialog::openUrl() for remote files

- On Jan. 24, 2016, 9:19 p.m., Kåre Särs wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/126876/ > --

Re: Review Request 126940: Move .protocol files of all io slaves bundled in kio to JSON meta data

) <https://git.reviewboard.kde.org/r/126940/#comment62873> embed - Alex Richardson On Jan. 31, 2016, 3:41 p.m., Christoph Cullmann wrote: > > --- > This is an automatically generated e-mail. To reply,

Re: Review Request 126876: Fix QFileDialog::openUrl() for remote files

short case at the top. src/platformtheme/kdeplatformfiledialoghelper.cpp (line 202) <https://git.reviewboard.kde.org/r/126876/#comment62983> Maybe also pass `QUrl::StripTrailingSlash` here? - Alex Richardson On Feb. 14, 2016, 6:25 a.m., Kåre Särs

Re: Review Request 126813: Fix build with older polkit

marked as submitted. Review request for KDE Frameworks. Changes --- Submitted with commit 15c7867e88c5278f61896b5531ac2b544add8220 by Alex Richardson to branch master. Repository: polkit-qt-1 Description --- Seems like the function exists, but the header declaration is missing

Re: Review Request 127205: Add stubs to allow compilation on Android.

mail. To reply, visit: > https://git.reviewboard.kde.org/r/127205/ > --- > > (Updated Feb. 28, 2016, 10:14 a.m.) > > > Review request for KDE Frameworks, Aleix Pol Gonzalez and Alex Richardson. > > > Repository: kcoreaddons > &g

Re: Review Request 127205: Add stubs to allow compilation on Android.

ns to macros, but I don't really mind. src/lib/util/kuser_unix.cpp (line 68) <https://git.reviewboard.kde.org/r/127205/#comment63467> I'd change this to `__BIONIC__` too - Alex Richardson On March 1, 2016, 9:38 p.m., Andrea

Re: Review Request 127205: Add stubs to allow compilation on Android.

/kuser_unix.cpp (line 38) <https://git.reviewboard.kde.org/r/127205/#comment63616> I'd say these should be static inline so that the compiler doesn't need to emit a copy of the function in the library. - Alex Richardson On March 2, 2016, 8:18 p.m., Andreas Cor

Re: Review Request 126618: Make CMake macro kcoreaddons_desktop_to_json() work on windows.

tps://git.reviewboard.kde.org/r/126618/#comment63632> Use KDE_INSTALL_FULL_KSERVICETYPES5DIR instead of prepending CMAKE_INSTALL_PREFIX to the relative path. - Alex Richardson On March 8, 2016, 8:35 p.m., Kåre Särs wrote: > > ---

Re: Review Request 127514: Skip category test if no restriction is set.

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/127514/#review94223 --- Ship it! Ship It! - Alex Richardson On April 3, 2016

Re: Review Request 111938: Allow installing both qca2 and qca3

Sorry for the late reply, I was away last week. Are there any more steps I should perform to ensure this works fine for everyone? Thanks, Alex Am Montag, 9. September 2013, 15:21:03 schrieb Ivan Romanov: > > On Sept. 1, 2013, 11:16 p.m., David Faure wrote: > > > Looks fine to me. > > > > Ivan

Re: [Kde-hardware-devel] libnm-qt Qt5 port: -fPIC or fPIE needed?

Am Donnerstag, 10. Oktober 2013, 00:11:45 schrieb Sebastian Kügler: > On Wednesday, October 09, 2013 18:14:10 Daniel Nicoletti wrote: > > I have added this to some of my qt5 projects and it worked: > > > > add_definitions(-fPIC) > > Thanks Daniel, that helps. :) > > > 2013/10/9 Sebastian Kügler

Review Request 121672: Properly convert .desktop files that have an associated servicetype

r.cpp b1b5440b48e4fd412932a7d7e794d641b1406699 Diff: https://git.reviewboard.kde.org/r/121672/diff/ Testing --- Unit test works Thanks, Alex Richardson ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frame

Re: Review Request 121672: Properly convert .desktop files that have an associated servicetype

e caching again... - Alex --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/121672/#review72590 --- On Dez. 26, 2014, 5:21 na

Review Request 121737: KPluginInfo: Fix properties not being copied from KService::Ptr

reads X-Kded-* in https://git.reviewboard.kde.org/r/121315/ instead of reading the default value. Thanks, Alex Richardson ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Review Request 121315: Allow using kded modules with JSON metadata

/121315/diff/ Testing --- everything seems to work correctly. No plugins are converted yet so they are all still loaded from .desktop files Thanks, Alex Richardson ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https

Re: Review Request 121315: Allow using kded modules with JSON metadata

t page I should add it to I can write a little bit on the wiki. - Alex --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/121315/#review72335 ------

Re: Review Request 121737: KPluginInfo: Fix properties not being copied from KService::Ptr

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/121737/#review72724 --- On Dez. 29, 2014, 5:51 nachm., Alex Richardson wrote: > >

Re: Review Request 121737: KPluginInfo: Fix properties not being copied from KService::Ptr

> On Dez. 29, 2014, 5:56 nachm., David Faure wrote: > > propertyNames() includes the common stuff like Name, Comment, etc. > > > > So maybe this removes the need for the code that follows? Or at least a > > good part of it? > > Alex Richardson wrote: >

Re: Review Request 121737: KPluginInfo: Fix properties not being copied from KService::Ptr

/kplugininfo.cpp aa5d26386eb17a7e552b29c8fa7961d68b16 Diff: https://git.reviewboard.kde.org/r/121737/diff/ Testing --- KDED now correctly reads X-Kded-* in https://git.reviewboard.kde.org/r/121315/ instead of reading the default value. Thanks, Alex Richardson

Re: Review Request 121737: KPluginInfo: Fix properties not being copied from KService::Ptr

o.cpp aa5d26386eb17a7e552b29c8fa7961d68b16 Diff: https://git.reviewboard.kde.org/r/121737/diff/ Testing --- KDED now correctly reads X-Kded-* in https://git.reviewboard.kde.org/r/121315/ instead of reading the default value. Thanks, Alex Richa

Re: Review Request 121495: Fix build if the X11 headers are not located in /usr/include

://git.reviewboard.kde.org/r/121495/diff/ Testing --- Thanks, Alex Richardson ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Review Request 121496: Fix build if the X11 headers are not located in /usr/include

/121496/diff/ Testing --- Thanks, Alex Richardson ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Review Request 121672: Properly convert .desktop files that have an associated servicetype

mail. To reply, visit: https://git.reviewboard.kde.org/r/121672/#review73501 ------- On Dec. 26, 2014, 5:21 p.m., Alex Richardson wrote: > > --- > This is an automa

Re: Review Request 121922: support stringlists as properties

tps://git.reviewboard.kde.org/r/121922/#comment51247> AFAIK escaping ; or , with a \ should be allowed: see KConfigGroupPrivate::deserializeList() - Alex Richardson On Jan. 8, 2015, 3:34 p.m., Marco Martin wrote: > > --- > This is an automatica

Re: Review Request 121949: Add name of consumer to kservice_desktop_to_json() deprecation warning.

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/121949/#review73608 --- Ship it! Nice! - Alex Richardson On Jan. 9, 2015, 3:41

Re: Review Request 121737: KPluginInfo: Fix properties not being copied from KService::Ptr

35e09fa49603a3c9fd5b534cacf46c18c848eaf4 Diff: https://git.reviewboard.kde.org/r/121737/diff/ Testing --- KDED now correctly reads X-Kded-* in https://git.reviewboard.kde.org/r/121315/ instead of reading the default value. Thanks, Alex Richardson

Review Request 122096: Fix build if epoxy headers are not installed to the default include dir

Description --- Fix build if epoxy headers are installed to the default include dir Diffs - src/qmlcontrols/kquickcontrolsaddons/CMakeLists.txt ce5091e5ff0911d5bf511973cacbcbcfd90e1774 Diff: https://git.reviewboard.kde.org/r/122096/diff/ Testing --- compiles now Thanks, Alex

Re: Review Request 122096: Fix build if epoxy headers are not installed to the default include dir

://git.reviewboard.kde.org/r/122096/diff/ Testing --- compiles now Thanks, Alex Richardson ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Review Request 121737: KPluginInfo: Fix properties not being copied from KService::Ptr

-Kded-* in https://git.reviewboard.kde.org/r/121315/ instead of reading the default value. Thanks, Alex Richardson ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Review Request 121737: KPluginInfo: Fix properties not being copied from KService::Ptr

ugininfo.cpp 35e09fa49603a3c9fd5b534cacf46c18c848eaf4 > > Diff: https://git.reviewboard.kde.org/r/121737/diff/ > > > Testing > --- > > KDED now correctly reads X-Kded-* in > https://git.reviewboard.kde.org/r/121315/ instead of reading the default > value. &

Re: Review Request 120833: Handle absolute paths without extension in KPluginLoader::findPlugin()

d this be done in Qt instead? Diffs - autotests/kpluginloadertest.cpp 3ded0ebca2e0fd20e09bf6e4eca152d13ac11f46 src/lib/plugin/kpluginloader.cpp 802ef843bca4526cc9a4ee6780e8125453786b12 Diff: https://git.reviewboard.kde.org/r/120833/diff/ Testing --- Unit test passes Than

Re: Review Request 121737: KPluginInfo: Fix properties not being copied from KService::Ptr

correctly reads X-Kded-* in https://git.reviewboard.kde.org/r/121315/ instead of reading the default value. Thanks, Alex Richardson ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks

Review Request 122401: KPluginInfo: delegate to KPluginMetaData for reading the .desktop files

://git.reviewboard.kde.org/r/122401/diff/ Testing --- unit tests pass Thanks, Alex Richardson ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Review Request 121315: Allow using kded modules with JSON metadata

a91a94ce1e68032156eb070bdb1e722410d44b64 Diff: https://git.reviewboard.kde.org/r/121315/diff/ Testing --- everything seems to work correctly. No plugins are converted yet so they are all still loaded from .desktop files Thanks, Alex Richardson ___ Kde-frameworks-devel

Re: Review Request 122401: KPluginInfo: delegate to KPluginMetaData for reading the .desktop files

src/services/kplugininfo.cpp 6785de63f67e5d8f1af49396478acf67ed16a933 Diff: https://git.reviewboard.kde.org/r/122401/diff/ Testing --- unit tests pass Thanks, Alex Richardson ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org

Re: Review Request 122514: Make it possible to interpret properties from plugins that expose properties correctly in the json

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/122514/#review75895 --- Ship it! Ship It! - Alex Richardson On Feb. 11, 2015, 5

Re: Review Request 122498: Register with dbus to wake up KRun, and unregister then

g/r/122498/#comment52504> This will always be true, it should be #if Same with the other checks - Alex Richardson On Feb. 9, 2015, 11:04 vorm., Martin Klapetek wrote: > > --- > This is an automatically generated e

Re: Review Request 122619: [KPluginMetaData] Add support for Hidden key

to add it. - Alex Richardson On Feb. 18, 2015, 9:44 a.m., Sebastian Kügler wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.

Re: Review Request 121218: Allow using new style connect syntax with KStandardAction::create()

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/121218/#review76681 --- Ping? - Alex Richardson On Dez. 24, 2014, 1:23 nachm

Re: Review Request 121283: Allow using new style connect in KActionCollection::add[Action]()

: https://git.reviewboard.kde.org/r/121283/diff/ Testing --- Thanks, Alex Richardson ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Review Request 121283: Allow using new style connect in KActionCollection::add[Action]()

--- Thanks, Alex Richardson ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Review Request 121317: Add JSON metadata to the kded modules

/diff/ Testing --- the converted modules can be loaded Thanks, Alex Richardson ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Review Request 122733: Fix path traversal checks in KPackage

e451412fa02c88113aa4c7bbca2dcda3432b2b02 Diff: https://git.reviewboard.kde.org/r/122733/diff/ Testing --- Files inside the package are now found although the install location contains a symlink Thanks, Alex Richardson ___ Kde-frameworks-devel mailing list Kde

Review Request 122732: Add std::function overloads for KServiceTypeTrader

/ Testing --- Unit tests pass There are still some more classes that use the string based checks, I'll add a std::function overload to them as well once this has been approved. Thanks, Alex Richardson ___ Kde-frameworks-devel mailing list Kde-frame

Re: Review Request 122732: Add std::function overloads for KServiceTypeTrader

tps://git.reviewboard.kde.org/r/122732/#comment52817> I'll update this to use a lambda src/services/kservicetypetrader.h <https://git.reviewboard.kde.org/r/122732/#comment52818> This section can probably be deleted - Alex Richardson On Feb. 26, 2015, 7:44 nachm., Alex

Re: Review Request 121317: Add JSON metadata to the kded modules

r/121317/#review76698 --- On Feb. 26, 2015, 6:53 p.m., Alex Richardson wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https:/

Re: Review Request 121317: Add JSON metadata to the kded modules

7bd34cc1286acb48e2e0060d97b7fad4cd0a4388 Diff: https://git.reviewboard.kde.org/r/121317/diff/ Testing --- the converted modules can be loaded Thanks, Alex Richardson ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde

Re: Review Request 122733: Fix path traversal checks in KPackage

eb4a09b987970e89f28587426b21d63731634087 src/kpackage/private/package_p.h e451412fa02c88113aa4c7bbca2dcda3432b2b02 Diff: https://git.reviewboard.kde.org/r/122733/diff/ Testing --- Files inside the package are now found although the install location contains a symlink Thanks, Alex

Re: Review Request 121317: Add JSON metadata to the kded modules

/kpasswdserver.cpp 7bd34cc1286acb48e2e0060d97b7fad4cd0a4388 Diff: https://git.reviewboard.kde.org/r/121317/diff/ Testing --- the converted modules can be loaded Thanks, Alex Richardson ___ Kde-frameworks-devel mailing list Kde-frameworks-devel

Review Request 122795: Fix crashes when attempting to load invalid package

122795/diff/ Testing --- no longer crashes, prints an error message instead Thanks, Alex Richardson ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Review Request 122796: Print a warning message when loading an invalid KDeclarative::QmlObject

Description --- Print a warning message when loading an invalid KDeclarative::QmlObject Diffs - src/kdeclarative/qmlobject.cpp 00478b469159dfdee3a05a9aa833bfe615e861e6 Diff: https://git.reviewboard.kde.org/r/122796/diff/ Testing --- Thanks, Alex Richardson

Re: Review Request 122795: Fix crashes when attempting to load invalid package

March 3, 2015, 7:32 p.m., Alex Richardson wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/122795/ > --- >

Re: Review Request 122733: Fix path traversal checks in KPackage

it.reviewboard.kde.org/r/122733/#review77011 --- On March 3, 2015, 5:53 p.m., Alex Richardson wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > http

Review Request 123131: Port kio_man away from kdelibs4support

d like some feedback. Thanks, Alex Richardson ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Review Request 123131: Port kio_man away from kdelibs4support

rated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/123131/#review78048 ------- On März 25, 2015, 9:17 nachm., Alex Richardson wrote: > > --- > This is a

Re: Review Request 123131: Port kio_man away from kdelibs4support

as it previously returned the full list. > > Nick Shaforostoff wrote: > please see > https://projects.kde.org/projects/kde/kdesdk/lokalize/repository/revisions/master/entry/src/common/languagelistmodel.cpp > for the ways to get a list of all languages (there is a KDE-way and Q

Re: Review Request 123298: Add option to show metadata of an .so file to desktoptojson

don't think we need to add it here. Not sure when it was introduced, but Qt 5.5 definitively has it - Alex Richardson On April 8, 2015, 4:17 p.m., Sebastian Kügler wrote: > > --- > This is an automatically generated e-

Re: Review Request 123397: Generalize the creation of KPluginLoader-based plugins

27;t looked into that yet). - Alex Richardson On April 17, 2015, 3:53 p.m., Aleix Pol Gonzalez wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://git.revie

Re: Review Request 123402: Moves away from KService

> On April 17, 2015, 5:52 p.m., Vishesh Handa wrote: > > src/widgets/actions.cpp, line 34 > > > > > > If you want you can also change this to the new for syntax. But make sure that `personPluginList` is const, si

Re: Review Request 123397: Generalize the creation of KPluginLoader-based plugins

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/123397/#review79260 --- Ship it! Ship It! - Alex Richardson On April 17, 2015, 3

Re: Review Request 123479: Adapt to Qt 5.6 changes and prevent nullbytes in QStrings.

tps://git.reviewboard.kde.org/r/123479/#comment54265> Why this manual loop instead of strlen()? Does that mean that null characters in the middle are valid? Or, more likely, this reverse loop is an optimization? If so I would add a comment since it wasn't obvious to me straight away. - Alex Rich

Re: Review Request 123479: Adapt to Qt 5.6 changes and prevent nullbytes in QStrings.

> On April 24, 2015, 12:33 a.m., Alex Richardson wrote: > > src/lib/io/kdirwatch.cpp, line 303 > > <https://git.reviewboard.kde.org/r/123479/diff/2/?file=362725#file362725line303> > > > > Why this manual loop instead of strlen()? Does that mean that null

Re: Review Request 123542: [runtime] Move platform specific code into plugins

lication::platformName(); interface->setRegistry(parent); return interface; } } } } ``` - Alex Richardson On April 28, 2015, 3:13 p.m., Martin Gräßlin wrote: > > -

Re: Review Request 123556: KPackage::findPackages with a filter callback

tps://git.reviewboard.kde.org/r/123556/#comment54542> This will crash if there is no filter. `if (!filter || filter(plugin))` should work. - Alex Richardson On April 29, 2015, 1:12 p.m., Marco Martin wrote: > > ---

Re: Review Request 123669: Add KPluginLoader::findPluginsById convenience API

ID? src/lib/plugin/kpluginloader.cpp (line 278) <https://git.reviewboard.kde.org/r/123669/#comment54900> QVector< KPluginMetaData > -> QVector - Alex Richardson On May 7, 2015, 12:21 a.m., Sebastian Kügler wrote: > >

Re: Review Request 123669: Add KPluginLoader::findPluginsById convenience API

> On May 7, 2015, 8:24 a.m., Alex Richardson wrote: > > Seems like this is duplicated in a few places already so I agree we should > > add it. But won't most users of the API want only a single plugin returned? > > Maybe also add a function `KPluginMetaData > &g

Re: Review Request 123595: Fix KUser test for Mac.

> On May 6, 2015, 5:40 p.m., René J.V. Bertin wrote: > > I'm not sure, after reading http://pig.made-it.com/uidgid.html > > > > also: > > > > ``` > > > id nobody > > uid=4294967294(nobody) gid=4294967294(nobody) > > groups=4294967294(nobody),12(everyone),61(localaccounts),402(com.apple.sharepo

Re: Review Request 123857: Fix crash after a user has launched kbuildsycoca as root.

tps://git.reviewboard.kde.org/r/123857/#comment55309> `#if Q_OS_UNIX`? Don't think Windows has getuid(). - Alex Richardson On May 20, 2015, 7:33 p.m., David Edmundson wrote: > > --- > This is an automatically generated e-m

  1   2   >