> On April 24, 2015, 12:33 a.m., Alex Richardson wrote:
> > src/lib/io/kdirwatch.cpp, line 303
> > <https://git.reviewboard.kde.org/r/123479/diff/2/?file=362725#file362725line303>
> >
> > Why this manual loop instead of strlen()? Does that mean that null
> > characters in the middle are valid? Or, more likely, this reverse loop is
> > an optimization? If so I would add a comment since it wasn't obvious to me
> > straight away.
Maybe this here is easier to read?
if (cpath.endsWith('\0')) {
cpath.resize(cpath.lastIndexOf('\0'));
}
- Alex
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/123479/#review79415
-----------------------------------------------------------
On April 23, 2015, 6:19 p.m., Milian Wolff wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/123479/
> -----------------------------------------------------------
>
> (Updated April 23, 2015, 6:19 p.m.)
>
>
> Review request for KDE Frameworks, David Faure, Marc Mutz, and Volker Krause.
>
>
> Repository: kcoreaddons
>
>
> Description
> -------
>
> The len in inotify_event includes nulls of the name. To prevent
> them from being included in the QString/QByteArray we must filter
> them manually with a recent Qt 5 dev build now. See also:
>
> https://codereview.qt-project.org/#/c/106473/
>
> REVIEW: 123479
>
>
> Diffs
> -----
>
> autotests/kdirwatch_unittest.cpp 83b5b410e987fb45a08f8251ec65496c8074b077
> src/lib/io/kdirwatch.cpp a75fae012c59021996b46845db2e97abb5526930
>
> Diff: https://git.reviewboard.kde.org/r/123479/diff/
>
>
> Testing
> -------
>
> I used the test and looked at the output and also ran it against a patched
> qtbase with this:
>
> https://paste.kde.org/pmoue241d
>
>
> Thanks,
>
> Milian Wolff
>
>
_______________________________________________
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
