----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/123857/#review80677 -----------------------------------------------------------
src/kbuildsycoca/kbuildsycoca.cpp (line 426) <https://git.reviewboard.kde.org/r/123857/#comment55309> `#if Q_OS_UNIX`? Don't think Windows has getuid(). - Alex Richardson On May 20, 2015, 7:33 p.m., David Edmundson wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/123857/ > ----------------------------------------------------------- > > (Updated May 20, 2015, 7:33 p.m.) > > > Review request for KDE Frameworks. > > > Repository: kservice > > > Description > ------- > > 3 commits fixing; a crash, what caused the crash, and why we weren't auto > recovering from it. > > QFile::open() will return a Read/Write error on failed access, > PermissionsError is only in the result of a setPermissions call. > > CCBUG: 342438 > > If running as root, keep file ownership the same as the original file we're > replacing. > > $HOME is often preserved as root, making us write cache files in the > user's home directory. > > CCBUG: 342438 > > Guard against being unable to open stream > > This can happen if we are unable to open the database when a > notifyDatabaseChanged signal is emitted. > Other places guard also against this eventuality. > > BUG: 342438 > > > Diffs > ----- > > src/kbuildsycoca/kbuildsycoca.cpp d14f1f950cdb0d8c9fefbce2a4740f211d3d97a1 > src/services/kservicegroupfactory.cpp > 8cfc6c6670d3b87e8ed6bdfe4aeac947846afc18 > > Diff: https://git.reviewboard.kde.org/r/123857/diff/ > > > Testing > ------- > > > Thanks, > > David Edmundson > >
_______________________________________________ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
