> On Dez. 29, 2014, 5:56 nachm., David Faure wrote: > > propertyNames() includes the common stuff like Name, Comment, etc. > > > > So maybe this removes the need for the code that follows? Or at least a > > good part of it?
Yeah we probably don't want those properties, do you think letting KPluginInfo access the QVariantMap in KServicePrivate is a better idea? I.e. `json = QJsonObject::fromVariantMap(service->d->m_mapProps)` That would be more efficient and skip all those standard .desktop properties. - Alex ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/121737/#review72724 ----------------------------------------------------------- On Dez. 29, 2014, 5:51 nachm., Alex Richardson wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/121737/ > ----------------------------------------------------------- > > (Updated Dez. 29, 2014, 5:51 nachm.) > > > Review request for KDE Frameworks and David Faure. > > > Repository: kservice > > > Description > ------- > > This should fix property() returning empty QVariants even if it > existed in the .desktop file > > > Diffs > ----- > > src/services/kplugininfo.cpp aa5d26386eb17a7e552b29c8fa66667961d68b16 > > Diff: https://git.reviewboard.kde.org/r/121737/diff/ > > > Testing > ------- > > KDED now correctly reads X-Kded-* in > https://git.reviewboard.kde.org/r/121315/ instead of reading the default > value. > > > Thanks, > > Alex Richardson > >
_______________________________________________ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
