> On Feb. 27, 2015, 7:41 a.m., David Faure wrote: > > Oops, what happened here? Did I forget to review this? Having json metadata > > for all kded modules sounds like a great idea (especially since kiod > > requires that, so if some move later to kiod, it will have to be done).
I thought this is not needed after kiod has been introduced. Are some of the modules here still kded only? - Alex ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/121317/#review76698 ----------------------------------------------------------- On Feb. 26, 2015, 6:53 p.m., Alex Richardson wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/121317/ > ----------------------------------------------------------- > > (Updated Feb. 26, 2015, 6:53 p.m.) > > > Review request for KDE Frameworks, David Faure and Sebastian Kügler. > > > Repository: kio > > > Description > ------- > > Add JSON metadata to the kded modules > > > Diffs > ----- > > src/kssld/kssld.cpp e3e503af996b411325fab10eb9b3daf5d9617bae > src/kssld/CMakeLists.txt 564602ca73a849758906639b5f07665c995c9a21 > src/kpasswdserver/kpasswdserver.cpp > 7bd34cc1286acb48e2e0060d97b7fad4cd0a4388 > src/kpasswdserver/CMakeLists.txt 21e5c2d17358b3d1233c753d15284cdc790423e0 > src/kpac/proxyscout.cpp 375f77503272e700929433c44086f4e213502c6e > src/kpac/CMakeLists.txt 7e6ce1f6cdb992b2ce45ab895aea72df24955fe2 > src/kioexec/main.cpp f0e282394c4f65df0bf52141290d37ba6b32ad8c > src/ioslaves/http/kcookiejar/kcookieserver.cpp > c441496dff316d4e94a4cccdfd46615cd76a7238 > src/ioslaves/http/kcookiejar/CMakeLists.txt > 890a35bcc24ca043844257f3d2cdd0941ddd1d17 > > Diff: https://git.reviewboard.kde.org/r/121317/diff/ > > > Testing > ------- > > the converted modules can be loaded > > > Thanks, > > Alex Richardson > >
_______________________________________________ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
