> On Jan. 10, 2016, 7:04 p.m., David Faure wrote: > > src/ioslaves/http/kcookiejar/kcookiejar.json, line 96 > > <https://git.reviewboard.kde.org/r/125048/diff/1/?file=400284#file400284line96> > > > > Why was this set to false (and autoload to true) when the > > kcookiejar.desktop file had > > X-KDE-Kded-autoload=false > > X-KDE-Kded-load-on-demand=true > > ? > > > > I assume it wasn't intentional, but a copy/paste error?
Yes looks like it was a copy paste error. I feared it could be a bug in desktoptojson, but I just added a new unit test that shows that this is not the case. - Alex ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/125048/#review90842 ----------------------------------------------------------- On Sept. 8, 2015, 8:28 p.m., Alex Richardson wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/125048/ > ----------------------------------------------------------- > > (Updated Sept. 8, 2015, 8:28 p.m.) > > > Review request for KDE Frameworks and David Faure. > > > Repository: kio > > > Description > ------- > > Use JSON files directly instead of kcoreaddons_desktop_to_json() > > > Diffs > ----- > > src/ioslaves/http/kcookiejar/CMakeLists.txt > 7b4778d1f67c1ad9f9edcaa4692b39ee6fe3f365 > src/ioslaves/http/kcookiejar/kcookiejar.desktop > 3ea56abdc134cae22b69d7b7636ce6dd415a3d9b > src/ioslaves/http/kcookiejar/kcookiejar.json PRE-CREATION > src/kpac/CMakeLists.txt fc5989714480ca49b5bd72e1c7b458b26bd0d9bc > src/kpac/proxyscout.desktop a545f3d6ef2fd18b1a2c85ebff15c9f2513d87f1 > src/kpac/proxyscout.json PRE-CREATION > src/kpasswdserver/CMakeLists.txt 11c30201012fbe413ff58561b54255e88c2c55b9 > src/kpasswdserver/kpasswdserver.desktop > bc788e5665e3d9d43309da241c3a3f5ac3cd0fc9 > src/kpasswdserver/kpasswdserver.json PRE-CREATION > src/kssld/CMakeLists.txt bf6970c2741a6edd01e36b86744d643e70046889 > src/kssld/kssld.desktop 86581b208ffc89fa5235f9284395d9d7ccebc472 > src/kssld/kssld.json PRE-CREATION > > Diff: https://git.reviewboard.kde.org/r/125048/diff/ > > > Testing > ------- > > > Thanks, > > Alex Richardson > >
_______________________________________________ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
