Re: Splitting KGlobalAccel interface and runtime

2023-03-06 Thread Jeremy Whiting
Nevermind. rebuilt and everything seems to be working for now. On Mon, Mar 6, 2023 at 10:02 AM Jeremy Whiting wrote: > Was something decided about this? I ask because I went and built > frameworks kf6 over the weekend with kdesrc-build into /usr/local/ with my > existing arch package

Re: Splitting KGlobalAccel interface and runtime

2023-03-06 Thread Jeremy Whiting
Was something decided about this? I ask because I went and built frameworks kf6 over the weekend with kdesrc-build into /usr/local/ with my existing arch packages in /usr, etc. and afterwards the kf5 version of yakuake can no longer receive keyboard shortcuts (to hide/show, etc.) It's entirely poss

D15481: Fix 'Impossible to use knsrc file for uploads from non standard location'

2018-09-13 Thread Jeremy Whiting
whiting accepted this revision. whiting added a comment. This revision is now accepted and ready to land. Looks good to me. Thanks for doing that fix. REPOSITORY R304 KNewStuff BRANCH master REVISION DETAIL https://phabricator.kde.org/D15481 To: habacker, whiting Cc: whiting, kde-fram

D7968: Forward QComboBox signals instead of QComboBox lineedit signals

2018-02-14 Thread Jeremy Whiting
whiting added a comment. Hey all, this change breaks Kompare https://bugs.kde.org/show_bug.cgi?id=390024 which watches a KUrlRequester's textChanged signal to update a button's enabled state. We are not seeing the textChanged signal on the KUrlRequester anymore when programatically setting

Re: Review Request 129257: [KNewStuff] Make it possible to query installed entries

2016-10-25 Thread Jeremy Whiting
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/129257/#review100273 --- Ship it! Ship It! - Jeremy Whiting On Oct. 24, 2016

Re: Review Request 128814: Add Qt5Network as a public dependency.

2016-09-01 Thread Jeremy Whiting
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/128814/#review98825 --- Ship it! Ship It! - Jeremy Whiting On Sept. 1, 2016

Re: Review Request 128740: uncompress archives in subfolders

2016-08-23 Thread Jeremy Whiting
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/128740/#review98570 --- Ship it! Ship It! - Jeremy Whiting On Aug. 23, 2016, 8

Re: Review Request 128219: No longer allow installing to generic data folder because of security hole.

2016-08-15 Thread Jeremy Whiting
marked as submitted. Review request for KDE Frameworks, David Faure and Richard Moore. Changes --- Submitted with commit 9746ff5553db0f3e869b0a9970e1304554e6f7fe by Jeremy Whiting to branch master. Repository: knewstuff Description --- When an application uses TargetDir=/ or

Re: Review Request 128219: No longer allow installing to generic data folder because of security hole.

2016-08-12 Thread Jeremy Whiting
the chosen location. Diffs (updated) - src/core/installation.cpp a027418 Diff: https://git.reviewboard.kde.org/r/128219/diff/ Testing --- No testing done yet, will write a unit test of some kind if this is the right direction. Thanks, Jeremy Whiting

Re: Review Request 128451: KNewFileMenu: fix creating symlinks with a relative target.

2016-07-21 Thread Jeremy Whiting
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/128451/#review97731 --- Ship it! Ship It! - Jeremy Whiting On July 21, 2016, 3

Re: Review Request 128494: KPropertiesDialog: simplify button box usage, fix behavior on Esc

2016-07-21 Thread Jeremy Whiting
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/128494/#review97728 --- Ship it! Ship It! - Jeremy Whiting On July 21, 2016, 3

Re: Review Request 128219: No longer allow installing to generic data folder because of security hole.

2016-06-29 Thread Jeremy Whiting
which would create > > problems. > > - "//" > > - "./" > > - "../etc" > > - and so on > > > > But this is a setting written by the app developer, not by the person > > uploading knewstuff data, so we can assume no m

Re: Review Request 128317: Make the download dialog fail when *all* categories are missing, not just one

2016-06-29 Thread Jeremy Whiting
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/128317/#review96956 --- Ship it! Ship It! - Jeremy Whiting On June 29, 2016, 5

Re: Review Request 128219: No longer allow installing to generic data folder because of security hole.

2016-06-17 Thread Jeremy Whiting
ser if they want to tweak the .knsrc files by hand to introduce a security vulnerability. Though if they wanted to do that there are much easier ways to do it. - Jeremy --- This is an automatically generated e-mail. To re

Review Request 128219: No longer allow installing to generic data folder because of security hole.

2016-06-16 Thread Jeremy Whiting
- No testing done yet, will write a unit test of some kind if this is the right direction. Thanks, Jeremy Whiting ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Review Request 128057: Don't initialize KNS3::DownloadManager with the wrong categories

2016-05-31 Thread Jeremy Whiting
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/128057/#review96108 --- Ship it! Ship It! - Jeremy Whiting On May 30, 2016, 9

Re: Review Request 127997: Extend KNS3::Entry public API

2016-05-26 Thread Jeremy Whiting
g. If the former, it looks good to me ship it. - Jeremy Whiting On May 24, 2016, 5:25 a.m., Aleix Pol Gonzalez wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard

Re: Review Request 127900: Fix redirection of absolut Urls

2016-05-12 Thread Jeremy Whiting
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/127900/#review95440 --- Ship it! Ship It! - Jeremy Whiting On May 12, 2016, 11

Re: Review Request 127887: Improve usage of Qt APIs

2016-05-12 Thread Jeremy Whiting
. - Jeremy Whiting On May 11, 2016, 5:01 p.m., Aleix Pol Gonzalez wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.

Re: Review Request 126948: Simplify attica plugin look-up and initialization

2016-02-01 Thread Jeremy Whiting
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/126948/#review91908 --- Ship it! Ship It! - Jeremy Whiting On Feb. 1, 2016, 12

Re: Review Request 126039: When configfile is loaded from resource, do not issue file not found error

2015-12-08 Thread Jeremy Whiting
. - Jeremy Whiting On Nov. 12, 2015, 4:15 p.m., Andrew McCann wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.

Re: KNotifications filters

2015-12-07 Thread Jeremy Whiting
Yeah, that makes sense. Ok will do. On Sun, Dec 6, 2015 at 3:37 AM, David Faure wrote: > On Thursday 24 September 2015 20:35:24 Jeremy Whiting wrote: >> If so I guess the logical place for it would be a TTS group in >> kdeglobals, does that make sense? > > Stay away fro

Re: Maintenance of api.kde.org

2015-11-05 Thread Jeremy Whiting
Alex, Last time I checked api.kde.org was generated by scripts in the websites/quality-kde-org git repository. It includes instructions for installing it locally, though the instructions are a bit outdated. I think perl's setup scripts have changed since it was written since I needed to tweak the

Re: Review Request 125884: Set default value for WheelScrollLines

2015-11-01 Thread Jeremy Whiting
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/125884/#review87824 --- Ship it! Ship It! - Jeremy Whiting On Oct. 30, 2015, 3

Re: Review Request 125767: Make KConfigWidgets self contained, bundle the one global file in a resource

2015-10-25 Thread Jeremy Whiting
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/125767/#review87363 --- Ship it! Ship It! - Jeremy Whiting On Oct. 23, 2015, 12

Re: [KDE/Mac] Question about goal of Windows/Mac frameworks

2015-10-22 Thread Jeremy Whiting
Yeah, if we go that direction on mac it would be fine for bundled Qt, but not for shared Qt. It would make all applications that use qt5-mac or qt5-kde or whatnot use linuxy paths or not. It's a runtime switch, so not very helpful if you've installed stuff to linuxy paths and then let the user choo

Re: Review Request 125656: Drop empty files

2015-10-21 Thread Jeremy Whiting
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/125656/#review87199 --- Ship it! Ship It! - Jeremy Whiting On Oct. 21, 2015, 4:29

Re: Question about goal of Windows/Mac frameworks

2015-10-20 Thread Jeremy Whiting
Christoph, I'm not trying to argue against having applications come in complete bundles at all. That is a worthy goal also actually, it's just not the direction I was headed in. You've made a lot more progress in this regard than I had though tbh. I see the kdewin installer as something that went

Re: Question about goal of Windows/Mac frameworks

2015-10-20 Thread Jeremy Whiting
Christoph. I have had similar goals for a while, but haven't reached the point that I was having much success yet in that regard. One thing to keep in mind when developing installers, Qt Installer Framework. I did a quick test with attica on OS X I can put on reviewboard to see what you think. I a

Re: Policy for Dependencies

2015-10-14 Thread Jeremy Whiting
I'd like to weigh in a bit here too. I agree with Boud and Christoph, most users (developers of applications) of KF5 that aren't KDE community members will be building the frameworks themselves. At my last job we built Qt ourselves on all the platforms we targetted and shipped shared libraries with

Re: Review Request 125521: Added KDropWidgetDecorator copied from DropWidget in kile sources. Relicensed from GPL 2+ to LGPL 2+ with author's permission.

2015-10-04 Thread Jeremy Whiting
-- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/125521/#review86352 --- On Oct. 4, 2015, 1:43 p.m., Jeremy Whiting wrote: > > --

Re: KTabWidget vs QTabWidget

2015-10-04 Thread Jeremy Whiting
Thanks, First patch here: https://git.reviewboard.kde.org/r/125521/. After that I'll try using it in Kile and Okular, see how that goes. On Thu, Sep 24, 2015 at 11:47 PM, Michel Ludwig wrote: > > On 09/25/2015 01:57 AM, Jeremy Whiting wrote: >> >> Michel, >> &g

Re: Review Request 125521: Added KDropWidgetDecorator copied from DropWidget in kile sources. Relicensed from GPL 2+ to LGPL 2+ with author's permission.

2015-10-04 Thread Jeremy Whiting
the class though, will fix that and reupload. Thanks, Jeremy Whiting ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Review Request 125521: Added KDropWidgetDecorator copied from DropWidget in kile sources. Relicensed from GPL 2+ to LGPL 2+ with author's permission.

2015-10-04 Thread Jeremy Whiting
src/kdropwidgetdecorator.cpp PRE-CREATION Diff: https://git.reviewboard.kde.org/r/125521/diff/ Testing --- It builds, the headers I expect are in the right places, etc. I just noticed I'm not exporting the class though, will fix that and reupload. Thanks, Jere

KNotifications filters

2015-09-24 Thread Jeremy Whiting
Hey all, I've discussed this a bit with Eike previously, but thought I'd try a wider audience to get some more ideas. When we used to have kttsd/jovie it had the concept of filters that it would use for different applications speech to normalize what gets sent to the synthesizer. In this way notif

Re: KTabWidget vs QTabWidget

2015-09-24 Thread Jeremy Whiting
Michel, Would you mind if I move the DropWidget you wrote for kile into kwidgetsaddons and give it a name like KDropWidget and relicense it to LGPL v2+ ? On Thu, Sep 24, 2015 at 2:09 AM, Andreas Cord-Landwehr wrote: > On Wednesday, September 23, 2015 4:12:01 PM CEST Jeremy Whiting wr

Re: [KDE/Mac] [OS X] adding a link module to all KF5 targets

2015-09-24 Thread Jeremy Whiting
That does sound like a bit more interesting question. Browsing through http://lxr.kde.org/ident?_i=QStandardPaths&_remember=1 (quite a long list...) a couple of things come to mind. First anything that's using QStandardPaths isn't necessarily using any frameworks at all. Looking at http://agateau.c

Re: KTabWidget vs QTabWidget

2015-09-23 Thread Jeremy Whiting
Toscano wrote: > Jeremy Whiting ha scritto: >> In looking at what is using KTabWidget it seems there's a drop in >> replacement for what we are doing in >> http://lxr.kde.org/source/extragear/office/kile/src/kileviewmanager.h >> in DropWidget towards the bottom. Cou

Re: [KDE/Mac] [OS X] adding a link module to all KF5 targets

2015-09-23 Thread Jeremy Whiting
Rene, Back to your original question I don't think there is such a place, besides patching QtCore itself. Many of the frameworks and applications use KI18n, but some don't I don't think there's a common location that every application linking against KF5 libraries uses. BR, Jeremy On Wed, Sep 2

Re: KTabWidget vs QTabWidget

2015-09-22 Thread Jeremy Whiting
r and use it where old code was using KTabWidget? BR, Jeremy On Tue, Sep 22, 2015 at 12:47 AM, David Faure wrote: > On Monday 21 September 2015 20:16:01 Jeremy Whiting wrote: >> David, >> >> I've been considering what you mean. I think I understand, but wanted >>

Re: KTabWidget vs QTabWidget

2015-09-21 Thread Jeremy Whiting
they used to in KDELibs4 times. BR, Jeremy On Sat, Sep 19, 2015 at 8:49 AM, David Faure wrote: > On Friday 18 September 2015 18:46:24 Jeremy Whiting wrote: >> Hey all, >> >> In looking into fixing the remaining issues in Okular's frameworks >> branch I realized t

KTabWidget vs QTabWidget

2015-09-18 Thread Jeremy Whiting
Hey all, In looking into fixing the remaining issues in Okular's frameworks branch I realized that in part of the effort to port it away from KDELibs4Support it got some functionality removed. It was ported from KTabWidget to QTabWidget but QTabWidget doesn't seem to support drag and drop the way

Re: ksycoca and kbuildsycoca, the next step

2015-09-06 Thread Jeremy Whiting
That sounds like a good solution to all the problems you presented initially indeed. Nice work. On Sun, Sep 6, 2015 at 3:43 PM, David Faure wrote: > On Sunday 06 September 2015 13:52:37 David Faure wrote: >> >> Any idea on how to avoid cache-rebuild ping pong? >> >> I can only think of one cache

Re: Review Request 124872: Default to Breeze colors

2015-08-24 Thread Jeremy Whiting
> On Aug. 24, 2015, 12:13 a.m., Martin Gräßlin wrote: > > I must say I'm rather shocked at how this is implemented. Would it be > > possible to move the defaults into our QPT plugin, so that these defaults > > are only applied if running on a platform with our plugin, otherwise it > > picks Qt

Re: Review Request 124872: Default to Breeze colors

2015-08-21 Thread Jeremy Whiting
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/124872/#review84166 --- Ship it! Ship It! - Jeremy Whiting On Aug. 21, 2015, 3:35

Re: knotifications tier

2015-08-04 Thread Jeremy Whiting
It should be auto generated every evening. The code that generates it is in kde:websites/quality-kde-org git repo. I spent a bit of time looking into how it all works for a gardening project (that I never did blog about results, mostly because I didn't make any final conclusions). I set up a local

Re: Review Request 124156: KItemModels: new proxy KRearrangeColumnsProxyModel

2015-06-23 Thread Jeremy Whiting
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/124156/#review81703 --- Ship it! Ship It! - Jeremy Whiting On June 23, 2015, 5:33

Re: Notes to developers: what KAboutData::setApplicationData() is

2015-06-18 Thread Jeremy Whiting
Jaroslaw, On Thu, Jun 18, 2015 at 3:20 AM, Jaroslaw Staniek wrote: > Hi > If you look at apps ported to KF5, KAboutData::setApplicationData() is > used but there are also redundant lines in main(), at least these: > > app.setApplicationName(aboutData.componentName()); > app.setApplicationDisplayN

Re: Review Request 123692: autotests: Use QTEST_GUILESS_MAIN

2015-06-13 Thread Jeremy Whiting
make test fails. - Jeremy Whiting On May 8, 2015, 1:15 p.m., Heiko Becker wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://git.review

Re: Proposal: move KWalletManager inside KWallet framework

2015-05-26 Thread Jeremy Whiting
Then do like the rest of the projects do and branch 14.04 if that hasn't happened already... No? On Tue, May 26, 2015 at 3:56 PM, Valentin Rusu wrote: > * Albert Astals Cid [2015-05-26 23:52:18 +0200]: > >> El Dimarts, 26 de maig de 2015, a les 23:31:38, Valentin Rusu va escriure: >> > * Albert

Re: Review Request 123794: Implement "find previous" in KTextEdit.

2015-05-14 Thread Jeremy Whiting
, then unswitch directions. Looks good. - Jeremy Whiting On May 14, 2015, 3:59 p.m., David Faure wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.

Re: Review Request 123742: knewstuff: Add verbose ecm message when ECM isn't found.

2015-05-13 Thread Jeremy Whiting
marked as submitted. Review request for KDE Frameworks and Jeremy Whiting. Changes --- Submitted with commit 01c3f36cf657e0e7e68631e14f884de9a3b3ebcd by Jeremy Whiting to branch master. Repository: knewstuff Description --- Make ECM missing message explain a) what ECM is, and b

Re: Review Request 123742: knewstuff: Add verbose ecm message when ECM isn't found.

2015-05-13 Thread Jeremy Whiting
- Jeremy --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/123742/#review80299 --- On May 13, 2015, 7 a.m., Jeremy Whiting wrote: >

Re: Review Request 123742: knewstuff: Add verbose ecm message when ECM isn't found.

2015-05-13 Thread Jeremy Whiting
s an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/123742/#review80299 --- On May 13, 2015, 7 a.m., Jeremy Whiting wrote: > > --- > This is an

Re: Review Request 123742: knewstuff: Add verbose ecm message when ECM isn't found.

2015-05-13 Thread Jeremy Whiting
Jeremy Whiting. Changes --- Reordered lines as per Kevin's suggestion. I agree this looks a bit better. Repository: knewstuff Description --- Make ECM missing message explain a) what ECM is, and b) where to find it. Diffs (updated) - CMakeList

Re: Review Request 123742: knewstuff: Add verbose ecm message when ECM isn't found.

2015-05-12 Thread Jeremy Whiting
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/123742/#review80270 ----------- On May 12, 2015, 6:28 p.m., Jeremy Whiting wrote: > > -

Re: Review Request 123742: knewstuff: Add verbose ecm message when ECM isn't found.

2015-05-12 Thread Jeremy Whiting
Jeremy Whiting. Repository: knewstuff Description (updated) --- Make ECM missing message explain a) what ECM is, and b) where to find it. Diffs (updated) - CMakeLists.txt cb23ccb8a9b0421a554b41234c3d9ced3965d378 Diff: https://git.reviewboard.kde.org/r/123742/diff/ Testing

Re: Review Request 123742: knewstuff: Add verbose ecm message when ECM isn't found.

2015-05-12 Thread Jeremy Whiting
t.reviewboard.kde.org/r/123742/#review80264 ------- On May 12, 2015, 3:19 p.m., Jeremy Whiting wrote: > > --- > This is an automatically generated e-mail. To repl

Review Request 123742: knewstuff: Add verbose ecm message when ECM isn't found.

2015-05-12 Thread Jeremy Whiting
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/123742/ --- Review request for KDE Frameworks and Jeremy Whiting. Repository

Re: kbuildsycoca5 crashing

2015-05-10 Thread Jeremy Whiting
\o/ KService built with a downgraded (4.9.1) g++ works fine. Sorry for the noise. Should be able to detect this sort of problem quickly in the future though. I'll stick with non testing arch for the time being. On Sun, May 10, 2015 at 10:07 AM, Jeremy Whiting wrote: > I only built

Re: kbuildsycoca5 crashing

2015-05-10 Thread Jeremy Whiting
lease tuesday from within a plasma 5 session instead of this fallback gnome session :) (and have konversation running again also...) thanks, Jeremy On Sun, May 10, 2015 at 9:46 AM, Albert Astals Cid wrote: > El Diumenge, 10 de maig de 2015, a les 08:57:28, Jeremy Whiting va escriure: >>

Re: kbuildsycoca5 crashing

2015-05-10 Thread Jeremy Whiting
re one in particular I > should check? > > On Sun, May 10, 2015 at 8:45 AM, David Faure wrote: >> On Sunday 10 May 2015 08:24:48 Jeremy Whiting wrote: >>> Rebuilt kservice (and nuked my build folder and /usr/local just to be >>> doubly sure.) kbuildsycoca5 still crashes w

Re: kbuildsycoca5 crashing

2015-05-10 Thread Jeremy Whiting
n Sun, May 10, 2015 at 8:45 AM, David Faure wrote: > On Sunday 10 May 2015 08:24:48 Jeremy Whiting wrote: >> Rebuilt kservice (and nuked my build folder and /usr/local just to be >> doubly sure.) kbuildsycoca5 still crashes with this same backtrace, no >> idea why. Could it b

Re: kbuildsycoca5 crashing

2015-05-10 Thread Jeremy Whiting
, 2015 at 8:04 AM, David Faure wrote: > On Sunday 10 May 2015 07:49:48 Jeremy Whiting wrote: >> ==2883== Address 0x is not stack'd, malloc'd or (recently) free'd > > This must be a miscompilation, I see no other reason for the refcount of a > QByteArray t

Re: kbuildsycoca5 crashing

2015-05-10 Thread Jeremy Whiting
guess. BR, Jeremy On Sun, May 10, 2015 at 7:49 AM, Jeremy Whiting wrote: > Yep, it's Qt5. After rebuilding everything trying to log into a plasma > session I get "startkde: could not sync environment to dbus" in > .xsession-errors, not much before that besides a bad dbus c

Re: kbuildsycoca5 crashing

2015-05-10 Thread Jeremy Whiting
Yep, it's Qt5. After rebuilding everything trying to log into a plasma session I get "startkde: could not sync environment to dbus" in .xsession-errors, not much before that besides a bad dbus call. Seems very similar to https://bugzilla.redhat.com/show_bug.cgi?id=1191171 I've never thought valgri

Re: kbuildsycoca5 crashing

2015-05-10 Thread Jeremy Whiting
It sure isn't. I've also tried nuking ~/.cache/ksycoca5* and such. Same result. ~/.cache is owned by me and has decent permissions also. On Sun, May 10, 2015 at 6:21 AM, Bhushan Shah wrote: > On Sun, May 10, 2015 at 5:43 PM, Jeremy Whiting wrote: >> Somehow kbuildsycoca5 is c

kbuildsycoca5 crashing

2015-05-10 Thread Jeremy Whiting
Hey all, Somehow kbuildsycoca5 is crashing here lately. I nuked my whole kde prefix (/usr/local) and rebuilt with packaged qt from my distro (arch). But kbuildsycoca5 is crashing every time I run it with some issue in QByteArray. Has anyone seen this lately/before or know how I can get past it? On

Re: Versioning of Frameworks

2015-04-29 Thread Jeremy Whiting
Christian, David isn't the only one with these thoughts. I agree with everything he said, and was thinking about the dependency zoo also, but couldn't form the words until I read what he wrote. That's exactly what I was thinking. It would be like the old rpm dependency hell from early linux days a

Re: Review Request 123421: [KNewStuff] Use KDE_INSTALL_DATADIR_KF5 instead of DATA_INSTALL_DIR for future co-installability

2015-04-18 Thread Jeremy Whiting
KMoreTools) so I'll let him weigh in. It may require the users of KMoreTools to update their code I believe. - Jeremy Whiting On April 18, 2015, 1:45 p.m., Hrvoje Senjan wrote: > > --- > This is an automatically generated

Re: Review Request 123335: Fix native file dialogs from widgets QFileDialog

2015-04-16 Thread Jeremy Whiting
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/123335/#review79085 --- Ship it! Ship It! - Jeremy Whiting On April 12, 2015, 3

Re: Review Request 122910: Introduce KMoreTools

2015-04-15 Thread Jeremy Whiting
> On April 15, 2015, 2:39 p.m., Jeremy Whiting wrote: > > Ship It! > > Gregor Mi wrote: > > As KMoreTools is going to be part of KNewStuff it should be using > KNEWSTUFF_EXPORT not KSERVICE_EXPORT. > > The install dir now looks like this: > htt

Re: Review Request 122910: Introduce KMoreTools

2015-04-15 Thread Jeremy Whiting
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/122910/#review78995 --- Ship it! Ship It! - Jeremy Whiting On April 15, 2015, 2

Re: Review Request 122910: Introduce KMoreTools

2015-04-14 Thread Jeremy Whiting
using KNEWSTUFF_EXPORT not KSERVICE_EXPORT. I'd also prefer the classes to be separated into their own header files, but that's a style thing, up to you. - Jeremy Whiting On April 12, 2015, 5:54 a.m., Gregor Mi wrote: > >

Re: Review Request 123335: Fix native file dialogs from widgets QFileDialog

2015-04-12 Thread Jeremy Whiting
> On April 12, 2015, 10:43 a.m., Jeremy Whiting wrote: > > Looks good to me. The explanation makes sense also. I did see most dialogs > > working after Lukas' fix, but the one launched from chromium via kdialog > > still hung after that. This should fix that (I&#x

Re: Review Request 123335: Fix native file dialogs from widgets QFileDialog

2015-04-12 Thread Jeremy Whiting
most dialogs working after Lukas' fix, but the one launched from chromium via kdialog still hung after that. This should fix that (I'll test it later today) - Jeremy Whiting On April 12, 2015, 3:20 a.m., David Rosca wrote: > > --

Re: Jenkins CI help for compile failures!

2015-04-09 Thread Jeremy Whiting
kspeech is deprecated, we need to remove it's use in knights looks like. It's interface file never got released with kf5. On Thu, Apr 9, 2015 at 12:29 PM, Scarlett Clark wrote: > KF5 knights fails to compile with: > 23:47:49 make[2]: *** No rule to make target > '/srv/jenkins/install/ubuntu/x86_

Re: Review Request 123075: do not require X11 on Mac OS X

2015-03-19 Thread Jeremy Whiting
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/123075/#review3 --- Ship it! Ship It! - Jeremy Whiting On March 19, 2015, 4

Fwd: frameworkintegration QFileDialog bug

2015-03-17 Thread Jeremy Whiting
Adding frameworks list. -- Forwarded message -- From: Jeremy Whiting Date: Mon, Mar 16, 2015 at 8:57 PM Subject: frameworkintegration QFileDialog bug To: kdelibs Hey all, We have a strange bug in frameworkintegration https://bugs.kde.org/show_bug.cgi?id=334963 which really

Re: What's the point of tiers if we bend the definition of them?

2015-03-16 Thread Jeremy Whiting
+1 On Mon, Mar 16, 2015 at 4:16 PM, Albert Astals Cid wrote: > We have KPackage depending on kdoctools but since it's optional we pretend > it's not a real dependency and call KPackage tier2 > > What's in it for us other than lying to ourselves? What's so bad about > KPackage being tier 3? > > I

Re: Review Request 122918: revert 2ee76f0 to fix QtQuickControls

2015-03-15 Thread Jeremy Whiting
> On March 15, 2015, 2:21 a.m., Frederik Gladhorn wrote: > > Without testing anything, I think that this will break QWidget's file > > dialog when set to modal. Iirc this breaks for example the open dialogs in > > qt creator. Yeah, that's the wrong approach, though I'm not sure what the right

Re: Review Request 122954: Let KNotifications be useable w/o searching for private deps

2015-03-14 Thread Jeremy Whiting
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/122954/#review77479 --- Ship it! Ship It! - Jeremy Whiting On March 14, 2015, 1

Re: Review Request 122955: Let KNotifyConfig be useable w/o searching for private deps

2015-03-14 Thread Jeremy Whiting
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/122955/#review77478 --- Ship it! Ship It! - Jeremy Whiting On March 14, 2015, 1

Re: Review Request 122953: Let KNewStuff be useable w/o searching for private deps

2015-03-14 Thread Jeremy Whiting
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/122953/#review77476 --- Ship it! Ship It! - Jeremy Whiting On March 14, 2015, 1

Re: Review Request 122953: Let KNewStuff be useable w/o searching for private deps

2015-03-14 Thread Jeremy Whiting
ry to build with knewstuff and kio and karchive aren't present, it wont run properly. Is this to make stuff that uses knewstuff build when the dependencies are there, but their headers are missing or something? - Jeremy Whiting On March 14, 2015, 1:06 p.m., Hrvoje Se

Re: Review Request 120648: Encode the URIs which end up in DTD files

2015-02-28 Thread Jeremy Whiting
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/120648/#review76782 --- Ship it! Ship It! - Jeremy Whiting On Oct. 19, 2014, 6:12

Re: Review Request 120649: Encode the URIs which end up in DTD files

2015-02-28 Thread Jeremy Whiting
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/120649/#review76781 --- Ship it! Ship It! - Jeremy Whiting On Oct. 19, 2014, 6:13

Re: Review Request 122751: Let ecm_configure_package_config_file manage path variables.

2015-02-28 Thread Jeremy Whiting
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/122751/#review76758 --- Ship it! Ship It! - Jeremy Whiting On Feb. 28, 2015, 3:23

Re: Review Request 122554: knotifyconfig: Add optional dependency on QtSpeech to reenable speaking notifications.

2015-02-17 Thread Jeremy Whiting
anges aren't taking effect imediately yet. Thanks, Jeremy Whiting ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Review Request 122555: knotifications: Add optional dependency on Qt5TextToSpeech for speech notifications.

2015-02-17 Thread Jeremy Whiting
runtime isn't refreshing/reloading the config when it is changed. Otherwise this works fine when QtSpeech is available. QtSpeech is still in development, so this change is added as an optional dependency. Thanks, Jeremy Whiting ___ Kde-frame

Re: Review Request 122555: knotifications: Add optional dependency on Qt5TextToSpeech for speech notifications.

2015-02-13 Thread Jeremy Whiting
isn't refreshing/reloading the config when it is changed. Otherwise this works fine when QtSpeech is available. QtSpeech is still in development, so this change is added as an optional dependency. Thanks, Jeremy Whiting ___ Kde-frameworks-devel ma

Re: Review Request 122554: knotifyconfig: Add optional dependency on QtSpeech to reenable speaking notifications.

2015-02-13 Thread Jeremy Whiting
eason the changes aren't taking effect imediately yet. Thanks, Jeremy Whiting ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Review Request 122554: knotifyconfig: Add optional dependency on QtSpeech to reenable speaking notifications.

2015-02-13 Thread Jeremy Whiting
e-mail. To reply, visit: https://git.reviewboard.kde.org/r/122554/#review75983 --- On Feb. 12, 2015, 8:06 p.m., Jeremy Whiting wrote: > > --- > This is an automatically generated e-mail. To reply, vi

Re: Review Request 122555: knotifications: Add optional dependency on Qt5TextToSpeech for speech notifications.

2015-02-13 Thread Jeremy Whiting
To reply, visit: https://git.reviewboard.kde.org/r/122555/#review75986 ------- On Feb. 12, 2015, 8:11 p.m., Jeremy Whiting wrote: > > --- > This is an automaticall

Review Request 122555: knotifications: Add optional dependency on Qt5TextToSpeech for speech notifications.

2015-02-12 Thread Jeremy Whiting
t, so this change is added as an optional dependency. Thanks, Jeremy Whiting ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Review Request 122554: knotifyconfig: Add optional dependency on QtSpeech to reenable speaking notifications.

2015-02-12 Thread Jeremy Whiting
case). Similarly, after disabling this notification, messages are still spoken until restarting the application. I checked and the konversation.notifyrc file is getting updated, but for some reason the changes aren't taking effect imediately yet. Thanks, Jere

Re: OSX/CI: kde-baseapps fails to build on branch frameworks

2015-02-11 Thread Jeremy Whiting
Feb 2015, at 23:17 , Jeremy Whiting wrote: > > Exactly, whoever added that code either needs to find a Qt 5.3 way to do > the same, or bump the requirement. > > > who is in charge of kde-baseapps? > > I’d like to get this going on OSX with Qt 5.3.2 again, or at least see t

Re: OSX/CI: kde-baseapps fails to build on branch frameworks

2015-02-10 Thread Jeremy Whiting
Exactly, whoever added that code either needs to find a Qt 5.3 way to do the same, or bump the requirement. On Tue, Feb 10, 2015 at 3:15 PM, Marko Käning wrote: > Hi Jeremy, > > On 10 Feb 2015, at 23:10 , Jeremy Whiting wrote: > > Seems that's from Qt 5.4 "This enum w

Re: OSX/CI: kde-baseapps fails to build on branch frameworks

2015-02-10 Thread Jeremy Whiting
Seems that's from Qt 5.4 "This enum was introduced or modified in Qt 5.4." in the QUrl::UserInputResolutionOptions documentation. On Tue, Feb 10, 2015 at 3:07 PM, Marko Käning wrote: > To make kde-baseapps build again on OSX/CI I have removed poppler from its > dependencies in config/base/kf5-qt

Re: Fixing and regulating certain types of search fields across KF5 apps

2015-02-09 Thread Jeremy Whiting
Eike, On Mon, Feb 9, 2015 at 1:03 PM, Eike Hein wrote: > > Hi, > > we currently have numerous dynamic search fields across KDE > apps that, for performance reasons, disregard input shorter > than a particular QString::length(). Examples are KMail and > some things in KRunner. It's a common patte

  1   2   3   >