----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/122555/ -----------------------------------------------------------
(Updated Feb. 13, 2015, 4:01 p.m.) Review request for KDE Frameworks and Frederik Gladhorn. Changes ------- Fixed issues noted. Repository: knotifications Description ------- Add optional dependency on Qt5TextToSpeech for speech notifications. Diffs (updated) ----- CMakeLists.txt 208fd02153a0607e4cfbc02e4b289ef835cedbfd src/CMakeLists.txt 6a3d81707a0e27e2d7bbfbf7f3924852ab737bf9 src/knotification.h dc0c975e261f1a03b8b4875bc1069417cf8ea094 src/knotificationmanager.cpp affb6a673468bf6585cbda6fafdd008beb445cd9 src/knotifyconfig.cpp af6be92bd320eaa881d8420cadf175edf6bf41aa src/kstatusnotifieritem.h 74b97ba7c63d52cae8ee80326daa9f24ce03a331 src/notifybyktts.h 43756f776678bd7700a77a3357577363b36d2542 src/notifybyktts.cpp a2a15a9c77089527f54dfc63f13699d44336dda1 src/notifybytts.cpp PRE-CREATION Diff: https://git.reviewboard.kde.org/r/122555/diff/ Testing ------- As I said in the knotifyconfig review something at runtime isn't refreshing/reloading the config when it is changed. Otherwise this works fine when QtSpeech is available. QtSpeech is still in development, so this change is added as an optional dependency. Thanks, Jeremy Whiting
_______________________________________________ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
