----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/123692/#review81446 -----------------------------------------------------------
Ship it! This is making it run without a gui on linux fine. I also tested on OS X here, but the tests don't run here for some reason. It could be because it's creating .app files rather than directly creating a binary. If I run the test autotests/knewstuffauthortest.app/Contents/MacoOS/knewstuffauthortest it passes fine (even over ssh), but make test fails. - Jeremy Whiting On May 8, 2015, 1:15 p.m., Heiko Becker wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/123692/ > ----------------------------------------------------------- > > (Updated May 8, 2015, 1:15 p.m.) > > > Review request for KDE Frameworks and Jeremy Whiting. > > > Repository: knewstuff > > > Description > ------- > > The tests still work fine with it, allowing them to run without a > display server. > > > Diffs > ----- > > autotests/knewstuffauthortest.cpp 5ca7c4903e90a5b8bf377c3c12d5bbe7c0623002 > autotests/knewstuffentrytest.cpp 7862ebbbf7c6a913cb4d6d0b70b2edf151ec6327 > > Diff: https://git.reviewboard.kde.org/r/123692/diff/ > > > Testing > ------- > > Built and ran the tests successfully. > > > Thanks, > > Heiko Becker > >
_______________________________________________ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
