> On May 12, 2015, 7:41 p.m., Aleix Pol Gonzalez wrote: > > +1 > > > > I'd like to know other people's opinion on this, as this should end up on > > most frameworks. > > Personally I'm unsure that showing the url will enlighten people, but it's > > better that than the terribly verbose and useless cmake errors.
It also shows the description and Extra cmake modules is much easier to Google than ecm. I have a script here to do this for all frameworks if we get a few more +1's - Jeremy ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/123742/#review80270 ----------------------------------------------------------- On May 12, 2015, 6:28 p.m., Jeremy Whiting wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/123742/ > ----------------------------------------------------------- > > (Updated May 12, 2015, 6:28 p.m.) > > > Review request for KDE Frameworks and Jeremy Whiting. > > > Repository: knewstuff > > > Description > ------- > > Make ECM missing message explain a) what ECM is, and b) where to find it. > > > Diffs > ----- > > CMakeLists.txt cb23ccb8a9b0421a554b41234c3d9ced3965d378 > > Diff: https://git.reviewboard.kde.org/r/123742/diff/ > > > Testing > ------- > > KNewStuff (and any other framework we add these changes to) now reports the > ECM url and name when it isn't found at cmake time. > > > Thanks, > > Jeremy Whiting > >
_______________________________________________ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
