----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/125656/#review87199 -----------------------------------------------------------
Ship it! Ship It! - Jeremy Whiting On Oct. 21, 2015, 4:29 a.m., Maximiliano Curia wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/125656/ > ----------------------------------------------------------- > > (Updated Oct. 21, 2015, 4:29 a.m.) > > > Review request for KDE Frameworks and Jeremy Whiting. > > > Repository: knewstuff > > > Description > ------- > > Currently the file src/core/upload.cpp is under a LGPL-2 only license, and > shipping the corresponding full license is required. Which is incompatible > with the current frameworks policy. The mentioned file and the private header > src/core/upload_p.h are currently "empty", as they contain only commented out > functions. And these files are not part of the API, so it's safe to drop them. > > > Diffs > ----- > > src/core/upload.cpp 486129b55bb108f965050ecc25df7e6d98bebb9e > src/core/upload_p.h 4fa38689f64a0dec94666962a7541dd3d6086482 > > Diff: https://git.reviewboard.kde.org/r/125656/diff/ > > > Testing > ------- > > > Thanks, > > Maximiliano Curia > >
_______________________________________________ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
