> On May 13, 2015, 7:10 a.m., Aleix Pol Gonzalez wrote:
> > CMakeLists.txt, line 8
> > <https://git.reviewboard.kde.org/r/123742/diff/3/?file=368712#file368712line8>
> >
> > I insist, feature_sumary goes at the bottom. (and is already there) Is
> > it needed to have it twice?
>
> Jeremy Whiting wrote:
> Yes, otherwise we only get the generic cmake failure. Actually, let me
> check... Maybe it only means we get a bunch of failures for the include calls
> in addition to the verbose ECM message.
Nope. If we don't add the extra feature_summary before we start including other
stuff it looks like this with ECM missing which defeats the purpose of this
change imo:
CMake Warning at CMakeLists.txt:7 (find_package):
Could not find a package configuration file provided by "ECM" (requested
version 5.10.0) with any of the following names:
ECMConfig.cmake
ecm-config.cmake
Add the installation prefix of "ECM" to CMAKE_PREFIX_PATH or set "ECM_DIR"
to a directory containing one of the above files. If "ECM" provides a
separate development package or SDK, be sure it has been installed.
CMake Error at CMakeLists.txt:12 (include):
include could not find load file:
ECMSetupVersion
CMake Error at CMakeLists.txt:13 (include):
include could not find load file:
ECMGenerateHeaders
CMake Error at CMakeLists.txt:14 (include):
include could not find load file:
ECMPackageConfigHelpers
CMake Error at CMakeLists.txt:15 (include):
include could not find load file:
KDEInstallDirs
CMake Error at CMakeLists.txt:16 (include):
include could not find load file:
KDEFrameworkCompilerSettings
CMake Error at CMakeLists.txt:17 (include):
include could not find load file:
KDECMakeSettings
CMake Error at CMakeLists.txt:21 (ecm_setup_version):
Unknown CMake command "ecm_setup_version".
-- Configuring incomplete, errors occurred!
See also "/home/jeremy/attica/build/CMakeFiles/CMakeOutput.log".
- Jeremy
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/123742/#review80299
-----------------------------------------------------------
On May 13, 2015, 7 a.m., Jeremy Whiting wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/123742/
> -----------------------------------------------------------
>
> (Updated May 13, 2015, 7 a.m.)
>
>
> Review request for KDE Frameworks and Jeremy Whiting.
>
>
> Repository: knewstuff
>
>
> Description
> -------
>
> Make ECM missing message explain a) what ECM is, and b) where to find it.
>
>
> Diffs
> -----
>
> CMakeLists.txt cb23ccb8a9b0421a554b41234c3d9ced3965d378
>
> Diff: https://git.reviewboard.kde.org/r/123742/diff/
>
>
> Testing
> -------
>
> KNewStuff (and any other framework we add these changes to) now reports the
> ECM url and name when it isn't found at cmake time.
>
>
> Thanks,
>
> Jeremy Whiting
>
>
_______________________________________________
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
