D4716: Add some more directives to MIPS assembler highlighting

arichardson added a comment. Sorry, was busy with other stuff so completely forgot about this. I'll update this soon. REPOSITORY R216 Syntax Highlighting REVISION DETAIL https://phabricator.kde.org/D4716 To: arichardson, dhaumann, vkrause Cc: kwrite-devel, kde-frameworks-devel, hase, mi

D15479: fix for macOS

arichardson accepted this revision. arichardson added a comment. This revision is now accepted and ready to land. I can confirm that this fixes the build for me. REPOSITORY R272 KDNSSD REVISION DETAIL https://phabricator.kde.org/D15479 To: yurikoles, arichardson Cc: arichardson, yurikole

D14722: KPluginMetaData: convert empty string to empty stringlist.

arichardson accepted this revision. arichardson added a comment. This revision is now accepted and ready to land. LGTM REPOSITORY R244 KCoreAddons BRANCH convert_empty_string_to_stringlist REVISION DETAIL https://phabricator.kde.org/D14722 To: dfaure, apol, mpyne, davidedmundson, aric

D4716: Add some more directives to MIPS assembler highlighting

arichardson updated this revision to Diff 30212. arichardson marked 2 inline comments as done. arichardson added a comment. address comments will try to add tests soon REPOSITORY R216 Syntax Highlighting CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D4716?vs=11618&id=30212 BRAN

D7236: DesktopFileParser: add fallback lookup in ":/kservicetypes5/*"

arichardson accepted this revision. arichardson added a comment. This revision is now accepted and ready to land. Looks good to me. Test would be great but the patch is pretty trivial so not really needed. REPOSITORY R244 KCoreAddons BRANCH master REVISION DETAIL https://phabricator

D7170: Fix errorneous whitespace handling in Desktop Entry parsing from DesktopFileParser

arichardson added a comment. Looks good to me. Using a regex engine for this seems like overkill but I guess compared to the I/O overhead of reading the desktop file it shouldn't matter. REPOSITORY R244 KCoreAddons REVISION DETAIL https://phabricator.kde.org/D7170 To: mpyne, #framework

D6180: Makefile: Remove invalid keyword entries in makefile.xml

arichardson accepted this revision. arichardson added a comment. This revision is now accepted and ready to land. Looks good to me! I forgot to remove these when I commited the bmake support. REPOSITORY R216 Syntax Highlighting REVISION DETAIL https://phabricator.kde.org/D6180 To: orgads

[Differential] [Request, 255 lines] D4716: Add some more directives to MIPS assembler highlighting

arichardson created this revision. Restricted Application added a project: Frameworks. Restricted Application added a subscriber: Frameworks. REVISION SUMMARY Add a few 64-bit MIPS instruction mnemonics Add c-preprocessor.xml highlighting file to be included Extracted and slightly modi

Re: Review Request 122732: Add std::function overloads for KServiceTypeTrader

290e44e9161c8db47278543714426fdd3b5a87af Diff: https://git.reviewboard.kde.org/r/122732/diff/ Testing --- Unit tests pass There are still some more classes that use the string based checks, I'll add a std::function overload to them as well once this has been approved. Thanks, Alex Richardson

Re: Review Request 121283: Allow using new style connect in KActionCollection::add[Action]()

marked as submitted. Review request for KDE Frameworks, David Faure and Nicolás Alvarez. Changes --- Submitted with commit 538a66fdab8194e860b98f0276f2b4e257e60507 by Albert Astals Cid on behalf of Alex Richardson to branch master. Repository: kxmlgui Description --- Allow using

Re: Review Request 122796: Print a warning message when loading an invalid KDeclarative::QmlObject

/122796/diff/ Testing --- Thanks, Alex Richardson

Re: Review Request 128944: Reduce temporary allocations in the DesktopFileParser

> On Sept. 19, 2016, 9:08 p.m., Alex Richardson wrote: > > src/lib/plugin/desktopfileparser.cpp, line 478 > > <https://git.reviewboard.kde.org/r/128944/diff/1/?file=477140#file477140line478> > > > > If I read this correctly we no longer handle leading/traili

Re: Review Request 128944: Reduce temporary allocations in the DesktopFileParser

that both are of type QString - Alex Richardson On Sept. 19, 2016, 4:20 p.m., Aleix Pol Gonzalez wrote: > > --- > This is an automatically generated e-mail. To reply, visit: >

Re: Review Request 126880: Fix QFileDialog::openUrl() for remote files

https://git.reviewboard.kde.org/r/126880/diff/ Testing --- Thanks, Alex Richardson ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Review Request 121218: Allow using new style connect syntax with KStandardAction::create()

rdaction.h d511778b7a24b1ec2e546949dab21f1ec2fea96f src/kstandardaction.cpp e5bea7965032355501b4c238e37abcc0f883c0b7 Diff: https://git.reviewboard.kde.org/r/121218/diff/ Testing --- The newly added unit test passes Thanks, Alex Richardson ___ Kde-frameworks-dev

Re: Review Request 121218: Allow using new style connect syntax with KStandardAction::create()

ex --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/121218/#review78527 --- On Dec. 24, 2014, 1:23 p.m., Alex Richardson wrote: > > ---

Re: Review Request 127514: Skip category test if no restriction is set.

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/127514/#review94223 --- Ship it! Ship It! - Alex Richardson On April 3, 2016

Re: Review Request 126618: Make CMake macro kcoreaddons_desktop_to_json() work on windows.

tps://git.reviewboard.kde.org/r/126618/#comment63632> Use KDE_INSTALL_FULL_KSERVICETYPES5DIR instead of prepending CMAKE_INSTALL_PREFIX to the relative path. - Alex Richardson On March 8, 2016, 8:35 p.m., Kåre Särs wrote: > > ---

Re: Review Request 127205: Add stubs to allow compilation on Android.

/kuser_unix.cpp (line 38) <https://git.reviewboard.kde.org/r/127205/#comment63616> I'd say these should be static inline so that the compiler doesn't need to emit a copy of the function in the library. - Alex Richardson On March 2, 2016, 8:18 p.m., Andreas Cor

Re: Review Request 127205: Add stubs to allow compilation on Android.

ns to macros, but I don't really mind. src/lib/util/kuser_unix.cpp (line 68) <https://git.reviewboard.kde.org/r/127205/#comment63467> I'd change this to `__BIONIC__` too - Alex Richardson On March 1, 2016, 9:38 p.m., Andrea

Re: Review Request 127205: Add stubs to allow compilation on Android.

mail. To reply, visit: > https://git.reviewboard.kde.org/r/127205/ > --- > > (Updated Feb. 28, 2016, 10:14 a.m.) > > > Review request for KDE Frameworks, Aleix Pol Gonzalez and Alex Richardson. > > > Repository: kcoreaddons > &g

Re: Review Request 126813: Fix build with older polkit

marked as submitted. Review request for KDE Frameworks. Changes --- Submitted with commit 15c7867e88c5278f61896b5531ac2b544add8220 by Alex Richardson to branch master. Repository: polkit-qt-1 Description --- Seems like the function exists, but the header declaration is missing

Re: Review Request 126876: Fix QFileDialog::openUrl() for remote files

short case at the top. src/platformtheme/kdeplatformfiledialoghelper.cpp (line 202) <https://git.reviewboard.kde.org/r/126876/#comment62983> Maybe also pass `QUrl::StripTrailingSlash` here? - Alex Richardson On Feb. 14, 2016, 6:25 a.m., Kåre Särs

Re: Review Request 126940: Move .protocol files of all io slaves bundled in kio to JSON meta data

) <https://git.reviewboard.kde.org/r/126940/#comment62873> embed - Alex Richardson On Jan. 31, 2016, 3:41 p.m., Christoph Cullmann wrote: > > --- > This is an automatically generated e-mail. To reply,

Re: Review Request 126876: Fix QFileDialog::openUrl() for remote files

- On Jan. 24, 2016, 9:19 p.m., Kåre Särs wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/126876/ > --

Review Request 126880: Fix QFileDialog::openUrl() for remote files

stent directory to be selected. BUG: 345253 Supersedes https://git.reviewboard.kde.org/r/126831/ Diffs - src/platformtheme/kdeplatformfiledialoghelper.cpp 11e7efbb66948da40bf19f430f8020f95d0233f8 Diff: https://git.reviewboard.kde.org/r/126880/diff/ Testing --- Thanks, Alex Richa

Re: Review Request 126831: WIP: Fix QFileDialog::openUrl() for remote files

plication::notifyqapplication.cpp32700x7fce75758fdf 15 QCoreApplication::notifyInternal2 qcoreapplication.cpp1013 0x7fce748cf642 16 QCoreApplication::sendSpontaneousEvent qcoreapplication.h 230 0x7fce7575e226 1

Re: Review Request 126813: Fix build with older polkit

core/polkitqt1-subject.h 03028f636d7efc154138821419a704b661a7aeac core/polkitqt1-subject.cpp ecb4c0e216d5bacf5dff5cf100611b941d3e8fbd polkitqt1-config.h.cmake PRE-CREATION Diff: https://git.reviewboard.kde.org/r/126813/diff/ Testing --- compiles now Thanks, Alex Richa

Re: Review Request 126740: Add a script for optimizing svgs

shFAQ/001) optimize.svg.sh (line 16) <https://git.reviewboard.kde.org/r/126740/#comment62491> Here an everywhere else $v -> "$v" https://github.com/koalaman/shellcheck/wiki/SC2086 optimize.svg.sh (line 20) <https://git.reviewboard.kde.org/r/126740/#comment62490&g

Re: Review Request 126831: WIP: Fix QFileDialog::openUrl() for remote files

32700x7fce75758fdf 15 QCoreApplication::notifyInternal2 qcoreapplication.cpp1013 0x7fce748cf642 16 QCoreApplication::sendSpontaneousEvent qcoreapplication.h 230 0x7fce7575e226 17 QApplicationPrivate::sendMouseEvent qapplication.cpp2765 0x7

Review Request 126831: WIP: Fix QFileDialog::openUrl() for remote files

eApplication::notifyInternal2 qcoreapplication.cpp1013 0x7fce748cf642 16 QCoreApplication::sendSpontaneousEvent qcoreapplication.h 230 0x7fce7575e226 17 QApplicationPrivate::sendMouseEvent qapplication.cpp2765 0x7fce75757997 18 QWidgetWindow

Review Request 126813: Fix build with older polkit

--- Seems like the function exists, but the header declaration is missing Diffs - core/polkitqt1-subject.cpp ecb4c0e216d5bacf5dff5cf100611b941d3e8fbd Diff: https://git.reviewboard.kde.org/r/126813/diff/ Testing --- compiles now Thanks, Alex Richardson

Re: Review Request 125048: Use JSON files directly instead of kcoreaddons_desktop_to_json()

> src/kpasswdserver/kpasswdserver.desktop > bc788e5665e3d9d43309da241c3a3f5ac3cd0fc9 > src/kpasswdserver/kpasswdserver.json PRE-CREATION > src/kssld/CMakeLists.txt bf6970c2741a6edd01e36b86744d643e70046889 > src/kssld/kssld.desktop 86581b208ffc8

Re: Review Request 121672: Properly convert .desktop files that have an associated servicetype

t.cpp 64373d5be930426dd8a1f8e455e33c411a4795fd src/lib/plugin/desktopfileparser.cpp b1b5440b48e4fd412932a7d7e794d641b1406699 Diff: https://git.reviewboard.kde.org/r/121672/diff/ Testing --- Unit test works Thanks, Alex Richardson ___ Kde-frameworks-devel ma

Re: Review Request 126618: Make CMake macro kcoreaddons_desktop_to_json() work on windows.

> On Jan. 3, 2016, 3:22 p.m., Alex Richardson wrote: > > According to the documentation AppLocalDataLocation is the following: > > "C:/Users//AppData/Local/", "C:/ProgramData/", > > "", "/data" > > > > In which direct

Re: Review Request 126618: Make CMake macro kcoreaddons_desktop_to_json() work on windows.

> On Jan. 3, 2016, 3:22 p.m., Alex Richardson wrote: > > According to the documentation AppLocalDataLocation is the following: > > "C:/Users//AppData/Local/", "C:/ProgramData/", > > "", "/data" > > > > In which direct

Re: Review Request 126618: Make CMake macro kcoreaddons_desktop_to_json() work on windows.

> On Jan. 3, 2016, 3:22 p.m., Alex Richardson wrote: > > According to the documentation AppLocalDataLocation is the following: > > "C:/Users//AppData/Local/", "C:/ProgramData/", > > "", "/data" > > > > In which direct

Re: Review Request 126618: Make CMake macro kcoreaddons_desktop_to_json() work on windows.

od to me otherwise as it will still check the same directories change behaviour on Linux. Only minor issue is that the error message is a little bit confusing now. - Alex Richardson On Jan. 3, 2016, 1:22 p.m., Kåre Särs wrote: > > --- >

Re: Review Request 125869: Convert all io slave .protocol data to json and embed it.

: https://svn.reviewboard.kde.org/r/7154/ - Alex Richardson On Dec. 28, 2015, 7:25 p.m., Christoph Cullmann wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.

Re: Review Request 125869: Convert all io slave .protocol data to json and embed it.

into implementing the translations then. - Alex Richardson On Dec. 27, 2015, 5:14 p.m., Christoph Cullmann wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard

Re: Review Request 126343: KPluginMetaData: Add fields used by KAboutData and introduce conversion function

marked as submitted. Review request for KDE Frameworks. Changes --- Submitted with commit 218084df9f5266306045fc6876e8f0a6886808dd by Alex Richardson to branch master. Repository: kcoreaddons Description --- Add KPluginMetaData::translators() and KAboutPerson::fromJson() Plugins

Re: Review Request 126455: Add mutex round static QRegExp usage in KShorturifilter

internally](http://code.woboq.org/qt5/qtbase/src/corelib/tools/qregularexpression.cpp.html#_ZN25QRegularExpressionPrivate14compilePatternEv) and is the replacement for QRegExp - Alex Richardson On Dec. 21, 2015, 4:22 p.m., David Edmundson wrote

Re: Review Request 126343: KPluginMetaData: Add fields used by KAboutData and introduce conversion function

in okular: https://git.reviewboard.kde.org/r/126193/ Thanks, Alex Richardson ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Review Request 126409: Fix use-after-free in .desktop file parser

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/126409/#review89808 --- Ship it! Ship It! - Alex Richardson On Dec. 18, 2015, 3

Re: Review Request 126409: Fix use-after-free in .desktop file parser

t.reviewboard.kde.org/r/126409/ > --- > > (Updated Dec. 18, 2015, 12:49 a.m.) > > > Review request for KDE Frameworks and Alex Richardson. > > > Repository: kcoreaddons > > > Description > --- > > Patch to fix a use-after-free issue in > kcoreaddons/src

Re: Review Request 126397: [xcb] Safety check whether we have a QApplication in mapViewport

tps://git.reviewboard.kde.org/r/126397/#comment61407> qobject_cast? - Alex Richardson On Dec. 17, 2015, 9:21 a.m., Martin Gräßlin wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://git.rev

Re: Review Request 126348: Make it possible to provide the metadata in json

tps://git.reviewboard.kde.org/r/126348/#comment61280> no longer required, right? src/kpackage/package.cpp (line 916) <https://git.reviewboard.kde.org/r/126348/#comment61281> `path.endsWith("/metadata.desktop") || path.endsWith("/metadata.json")`? QRegExp seems like overkil

Re: Review Request 126366: Make KPluginMetaData constructible from a json path.

to make sure we don't break this in future. - Alex Richardson On Dec. 15, 2015, 3:27 p.m., Aleix Pol Gonzalez wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard

Re: Review Request 126348: Make it possible to provide the metadata in json

od to me other than this one issue src/kpackage/private/packagejobthread.cpp (line 143) <https://git.reviewboard.kde.org/r/126348/#comment61242> I think it would be better if this code was added to the KPluginMetaData ctor (in an `if (path.endswith(".json"))` branch. - Ale

Re: Review Request 126324: [MSWin/OS X] save and restore window geometry instead of only size (WIP/Suggestion)

> On Dec. 14, 2015, 11:47 a.m., Marco Martin wrote: > > src/gui/CMakeLists.txt, line 22 > > > > > > we really can't add a dependency to QWidgets here. > > depending on qwidgets will make many potential interes

Review Request 126343: KPluginMetaData: Add fields used by KAboutData and introduce conversion function

/r/126193/ Thanks, Alex Richardson ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Review Request 126339: remove kdewin dependency

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/126339/#review89464 --- Ship it! Looks good to me - Alex Richardson On Dec. 14

Re: Review Request 126320: Read KPluginMetada's property X-Plasma-ComponentTypes as a stringlist

tps://git.reviewboard.kde.org/r/126320/#comment61224> This should probably also be changed to QStringList? - Alex Richardson On Dec. 11, 2015, 6:48 p.m., Martin Klapetek wrote: > > --- > This is an automatically generated e

Re: Review Request 126320: Read KPluginMetada's property X-Plasma-ComponentTypes as a stringlist

) <https://git.reviewboard.kde.org/r/126320/#comment61223> readStringList() is static so KPluginMetaData:: is probably the better way to call it - Alex Richardson On Dec. 11, 2015, 6:48 p.m., Martin Klapetek wrote: > > ---

Re: Review Request 126196: Fix regression caused by RR 125527

marked as submitted. Review request for KDE Frameworks and Jarosław Staniek. Changes --- Submitted with commit 78d740aece90b676086412f977d4cd691791bd8f by Alex Richardson to branch master. Repository: kcoreaddons Description --- Make sure that applications using

Review Request 126196: Fix regression caused by RR 125527

eae91881bafc93b047b81a2b21634223dd5d89f4 Diff: https://git.reviewboard.kde.org/r/126196/diff/ Testing --- compiles, tests pass Thanks, Alex Richardson ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks

Re: Review Request 125527: Add mimeTypes() to KPluginMetaData

-- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/125527/#review88915 --- On Oct. 6, 2015, 12:42 p.m., Alex Richardson wrote: > > ---

Re: Review Request 125869: Convert all io slave .protocol data to json and embed it.

--- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/125869/ > --- > > (Updated Nov. 1, 2015, 6:13 p.m.) > > > Review request for KDE Frame

Re: Review Request 125830: Read protocol info from plugin metadata

} // add to cache, skip double entries if (!m_cache.contains(it.key())) { m_cache.insert(it.key(), new KProtocolInfoPrivate(it.key(), slavePath, protocol)); } } ``` - Alex Richardson On Oct.

Re: Review Request 125797: protocoltojson application

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/125797/#review87527 --- Ship it! - Alex Richardson On Oct. 26, 2015, 5:03 p.m

Re: Review Request 125797: protocoltojson application

> On Oct. 26, 2015, 5:27 p.m., Alex Richardson wrote: > > The protocoltojson program will have to read the plugin metadata.json file > > to insert the "KDE-KIO-Protocols" to that json file as it is not possible > > to embed more than one JSON file into a Qt

Re: Review Request 125797: protocoltojson application

ry so that we don't increase the build time. - Alex Richardson On Oct. 26, 2015, 5:03 p.m., Christoph Cullmann wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://git.r

Re: Review Request 125797: protocoltojson application

> On Oct. 25, 2015, 9:32 p.m., Christoph Cullmann wrote: > > I think one needs to add a outer scope with some "KIO-Protocol-Info" or so > > key to be able to check if we have valid data inside a lib. > > But I am not sure how to name that. > > Alex Merry wrote: > How about "KDE-KIO-Protocol

Re: Review Request 125750: Reduce some allocations

7;\' Looks I didn't test escaped values if the tests still pass... - Alex Richardson On Oct. 22, 2015, 2:20 p.m., Aleix Pol Gonzalez wrote: > > --- > This is an automatically generat

Re: Review Request 125262: Parse ServiceType files when reading .desktop files

marked as submitted. Review request for KDE Frameworks, David Faure and Sebastian Kügler. Changes --- Submitted with commit e3b1d023dcf2c10f5b4feb4eb1973bcc0fbdb954 by Alex Richardson to branch master. Repository: kcoreaddons Description --- Parse ServiceType files when reading

Re: Review Request 125262: Parse ServiceType files when reading .desktop files

ata.h 59b6a9db0811d24c9ad8a3e86212ea50b9cd95ce src/lib/plugin/kpluginmetadata.cpp f7942b1aef3f165c0fab2a0cb4422422342e5f8d Diff: https://git.reviewboard.kde.org/r/125262/diff/ Testing --- Added some unit test and they pass Thanks, Alex Richa

Re: Review Request 125263: Adapt KPluginInfo to introduction of KPluginMetaData::mimeTypes()

marked as submitted. Review request for KDE Frameworks, David Faure and Sebastian Kügler. Changes --- Submitted with commit 3cc94ba4df468433e96d4c2ce6d945db920d1246 by Alex Richardson to branch master. Repository: kservice Description --- Keep MIME types separate when converting

Re: Review Request 125527: Add mimeTypes() to KPluginMetaData

marked as submitted. Review request for KDE Frameworks, David Faure and Sebastian Kügler. Changes --- Submitted with commit 0e73135459d3d9088702d9ec4f4b4b4ffd527024 by Alex Richardson to branch master. Repository: kcoreaddons Description --- When loading a .desktop file this will

Review Request 125527: Add mimeTypes() to KPluginMetaData

perty Requires https://git.reviewboard.kde.org/r/125263/ to ensure that there are no regressions Thanks, Alex Richardson ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Review Request 125261: Add mimeTypes() to KPluginMetaData

ar to new Plugin loading. Could also be used by KDevelop instead of the custom X-KDevelop-SupportedMimeTypes property Requires https://git.reviewboard.kde.org/r/125263/ to ensure that there are no regressions Thanks, Alex Richardson ___ Kde-frame

Re: Review Request 125262: Parse service type files when loading from .desktop

pfileparser.cpp 0b03eb154deb58840c91c12658780c0d492b593c src/lib/plugin/kpluginmetadata.h 183b0d0583259f7ed74e97858a68c5c388fd0a9a src/lib/plugin/kpluginmetadata.cpp b13d6dd52827cc03d9473600aa4d2bab8a95a1d4 Diff: https://git.reviewboard.kde.org/r/125262/diff/ Testing --- Added some unit test and they pass

Re: Review Request 125262: Parse service type files when loading from .desktop

tically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/125262/#review85502 ------- On Sept. 17, 2015, 12:37 a.m., Alex Richardson wrote: > > --- &g

Re: Review Request 125261: Add mimeTypes() to KPluginMetaData

n't notice. Possibly it should output a warning in that case? - Alex --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/125261/#review85519 -----

Re: Review Request 125261: Add mimeTypes() to KPluginMetaData

so be used by KDevelop instead of the custom X-KDevelop-SupportedMimeTypes property Requires https://git.reviewboard.kde.org/r/125263/ to ensure that there are no regressions Thanks, Alex Richardson ___ Kde-frameworks-devel mailing list Kde-frameworks-

Review Request 125263: Adapt KPluginInfo to introduction of KPluginMetaData::mimeTypes()

://git.reviewboard.kde.org/r/125263/diff/ Testing --- new + old unit tests pass Thanks, Alex Richardson ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Review Request 125261: Add mimeTypes() to KPluginMetaData

f the custom X-KDevelop-SupportedMimeTypes property Thanks, Alex Richardson ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Review Request 125261: Add mimeTypes() to KPluginMetaData

c/lib/plugin/kpluginmetadata.cpp b13d6dd52827cc03d9473600aa4d2bab8a95a1d4 Diff: https://git.reviewboard.kde.org/r/125261/diff/ Testing --- Thanks, Alex Richardson ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org

Review Request 125262: Parse service type files when loading from .desktop

src/lib/plugin/kpluginmetadata.h 183b0d0583259f7ed74e97858a68c5c388fd0a9a src/lib/plugin/kpluginmetadata.cpp b13d6dd52827cc03d9473600aa4d2bab8a95a1d4 Diff: https://git.reviewboard.kde.org/r/125262/diff/ Testing --- Added some unit test and they pass Thanks,

Re: Review Request 125048: Use JSON files directly instead of kcoreaddons_desktop_to_json()

marked as submitted. Review request for KDE Frameworks and David Faure. Changes --- Submitted with commit 6db255388532a4fd0788aa971c83798e1849d479 by Alex Richardson to branch master. Repository: kio Description --- Use JSON files directly instead of kcoreaddons_desktop_to_json

Re: Review Request 125048: Use JSON files directly instead of kcoreaddons_desktop_to_json()

> On Sept. 4, 2015, 3:56 p.m., David Faure wrote: > > Wasn't the reason for desktop files that we have infrastructure for > > translating desktop files but not json files? > > > > (I could be wrong, of course). > > Alex Richardson wrote: > I thoug

Re: Review Request 125048: Use JSON files directly instead of kcoreaddons_desktop_to_json()

es are also translated. - Alex --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/125048/#review84831 --- On Sept. 4, 2015,

Review Request 125048: Use JSON files directly instead of kcoreaddons_desktop_to_json()

-CREATION Diff: https://git.reviewboard.kde.org/r/125048/diff/ Testing --- Thanks, Alex Richardson ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Review Request 124904: Make KDE_FORK_SLAVES work under Windows

tps://git.reviewboard.kde.org/r/124904/#comment58378> Unrelated but while you're touching this code maybe change this to qEnvironmentVariableIsSet(). More efficient and easier to understand - Alex Richardson On Aug. 24, 2015, 2:11 p.m., Kevin

Re: Review Request 124281: Remove KService and KIconThemes usage from KNotifications

t directory will be searched." `QList plugins = KPluginLoader::instantiatePlugins("knotification/notifyplugins", nullptr, this);` - Alex Richardson On July 7, 2015, 8 p.m., Martin Klapetek wrote: > > --- >

Re: Review Request 124281: Remove KService and KIconThemes usage from KNotifications

ment56571> nullptr? or Q_NULLPTR if that's not allowed. Would make it explicit that it's a pointer. - Alex Richardson On July 7, 2015, 3:42 p.m., Martin Klapetek wrote: > > --- > This is an automatically generated e

Re: Review Request 124118: Make it possible to use KCoreAddons's desktoptojson in cross-compiled environments

tps://git.reviewboard.kde.org/r/124118/#comment55894> I have no experience with cross compiling, but shouldn't this be `if(NOT ...)` as now the test will only be compiled when crosscompiling? - Alex Richardson On June 18, 2015, 2:39 a.m., Aleix Pol Gon

Re: Review Request 124066: Recognize X-KDE-FormFactor as stringlist

> This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/124066/ > --- > > (Updated June 11, 2015, 5:16 a.m.) > > > Review request for KDE Frameworks, Alex Richardson a

Re: Review Request 124032: Do not try to complete users and assert when prepend is non-empty.

> On June 6, 2015, 10:07 p.m., David Faure wrote: > > The test doesn't check that user completion still works though? (in the > > case where it's expected, ~foo). > > > > I'm curious btw, why did it crash/assert? > > > > Finally I wonder why this didn't happen in kdelibs4, but ok, the code has

Re: Review Request 123940: Use KPluginLoader::factory() when loading KIO::DndPopupMenuPlugin

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/123940/#review80959 --- Ship it! Ship It! - Alex Richardson On May 29, 2015, 11

Re: Review Request 123857: Fix crash after a user has launched kbuildsycoca as root.

tps://git.reviewboard.kde.org/r/123857/#comment55309> `#if Q_OS_UNIX`? Don't think Windows has getuid(). - Alex Richardson On May 20, 2015, 7:33 p.m., David Edmundson wrote: > > --- > This is an automatically generated e-m

Re: Review Request 123595: Fix KUser test for Mac.

> On May 6, 2015, 5:40 p.m., René J.V. Bertin wrote: > > I'm not sure, after reading http://pig.made-it.com/uidgid.html > > > > also: > > > > ``` > > > id nobody > > uid=4294967294(nobody) gid=4294967294(nobody) > > groups=4294967294(nobody),12(everyone),61(localaccounts),402(com.apple.sharepo

Re: Review Request 123669: Add KPluginLoader::findPluginsById convenience API

> On May 7, 2015, 8:24 a.m., Alex Richardson wrote: > > Seems like this is duplicated in a few places already so I agree we should > > add it. But won't most users of the API want only a single plugin returned? > > Maybe also add a function `KPluginMetaData > &g

Re: Review Request 123669: Add KPluginLoader::findPluginsById convenience API

ID? src/lib/plugin/kpluginloader.cpp (line 278) <https://git.reviewboard.kde.org/r/123669/#comment54900> QVector< KPluginMetaData > -> QVector - Alex Richardson On May 7, 2015, 12:21 a.m., Sebastian Kügler wrote: > >

Re: Review Request 123556: KPackage::findPackages with a filter callback

tps://git.reviewboard.kde.org/r/123556/#comment54542> This will crash if there is no filter. `if (!filter || filter(plugin))` should work. - Alex Richardson On April 29, 2015, 1:12 p.m., Marco Martin wrote: > > ---

Re: Review Request 123542: [runtime] Move platform specific code into plugins

lication::platformName(); interface->setRegistry(parent); return interface; } } } } ``` - Alex Richardson On April 28, 2015, 3:13 p.m., Martin Gräßlin wrote: > > -

Re: Review Request 123479: Adapt to Qt 5.6 changes and prevent nullbytes in QStrings.

> On April 24, 2015, 12:33 a.m., Alex Richardson wrote: > > src/lib/io/kdirwatch.cpp, line 303 > > <https://git.reviewboard.kde.org/r/123479/diff/2/?file=362725#file362725line303> > > > > Why this manual loop instead of strlen()? Does that mean that null

Re: Review Request 123479: Adapt to Qt 5.6 changes and prevent nullbytes in QStrings.

tps://git.reviewboard.kde.org/r/123479/#comment54265> Why this manual loop instead of strlen()? Does that mean that null characters in the middle are valid? Or, more likely, this reverse loop is an optimization? If so I would add a comment since it wasn't obvious to me straight away. - Alex Rich

Re: Review Request 123397: Generalize the creation of KPluginLoader-based plugins

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/123397/#review79260 --- Ship it! Ship It! - Alex Richardson On April 17, 2015, 3

Re: Review Request 123402: Moves away from KService

> On April 17, 2015, 5:52 p.m., Vishesh Handa wrote: > > src/widgets/actions.cpp, line 34 > > > > > > If you want you can also change this to the new for syntax. But make sure that `personPluginList` is const, si

Re: Review Request 123397: Generalize the creation of KPluginLoader-based plugins

27;t looked into that yet). - Alex Richardson On April 17, 2015, 3:53 p.m., Aleix Pol Gonzalez wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://git.revie

  1   2   >