> On Sept. 16, 2015, 10:44 p.m., Sebastian Kügler wrote: > > autotests/kpluginmetadatatest.cpp, line 110 > > <https://git.reviewboard.kde.org/r/125261/diff/1/?file=404287#file404287line110> > > > > Should be a list, so enclosed with [ ]. > > > > In the header docs, you also say "string", so maybe I'm overlooking > > something?
You're right, it should be a list. `KPluginMetaData::readStringList()` treats a single string as a list with one element so this does not cause an error and I didn't notice. Possibly it should output a warning in that case? - Alex ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/125261/#review85519 ----------------------------------------------------------- On Sept. 16, 2015, 5:53 p.m., Alex Richardson wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/125261/ > ----------------------------------------------------------- > > (Updated Sept. 16, 2015, 5:53 p.m.) > > > Review request for KDE Frameworks, David Faure and Sebastian Kügler. > > > Repository: kcoreaddons > > > Description > ------- > > When loading a .desktop file this will parse the XDG MimeType= key > > Contrary to KService we don't merge these with ServiceTypes but rather > have them as a separate property. > > > Diffs > ----- > > autotests/data/fakeplugin.desktop 2e186869bf0cb39277ca3f9d2e8603d64d0223c6 > autotests/kpluginmetadatatest.cpp 3af5e1b842b0bc231a5ac001112e141f751d2ff5 > src/lib/plugin/desktopfileparser.h 98d47ddf0f877c4a25928026b3d5fe169cfc9e75 > src/lib/plugin/desktopfileparser.cpp > 0b03eb154deb58840c91c12658780c0d492b593c > src/lib/plugin/kpluginmetadata.h 183b0d0583259f7ed74e97858a68c5c388fd0a9a > src/lib/plugin/kpluginmetadata.cpp b13d6dd52827cc03d9473600aa4d2bab8a95a1d4 > > Diff: https://git.reviewboard.kde.org/r/125261/diff/ > > > Testing > ------- > > Used this for a WIP port of Okular to new Plugin loading. Could also be used > by KDevelop instead of the custom X-KDevelop-SupportedMimeTypes property > > Requires https://git.reviewboard.kde.org/r/125263/ to ensure that there are > no regressions > > > Thanks, > > Alex Richardson > >
_______________________________________________ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
