----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/124904/#review84309 -----------------------------------------------------------
Looks good to me src/core/slave.cpp (line 88) <https://git.reviewboard.kde.org/r/124904/#comment58378> Unrelated but while you're touching this code maybe change this to qEnvironmentVariableIsSet(). More efficient and easier to understand - Alex Richardson On Aug. 24, 2015, 2:11 p.m., Kevin Funk wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/124904/ > ----------------------------------------------------------- > > (Updated Aug. 24, 2015, 2:11 p.m.) > > > Review request for KDE Frameworks, David Faure and Boudewijn Rempt. > > > Repository: kio > > > Description > ------- > > Make KDE_FORK_SLAVES work under Windows > > > Diffs > ----- > > src/core/slave.cpp 62455c1db471aa3fc1273b1bb398fbc183ddca1f > > Diff: https://git.reviewboard.kde.org/r/124904/diff/ > > > Testing > ------- > > > Thanks, > > Kevin Funk > >
_______________________________________________ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
