Re: Review Request 124904: Make KDE_FORK_SLAVES work under Windows

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/124904/#review84318 --- Ship it! Ship It! - David Faure On Aug. 24, 2015, 1:11 p.m

Re: Review Request 124902: Delay starting kglobalaccel5 till it's needed

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/124902/ --- (Updated Aug. 25, 2015, 5:58 a.m.) Status -- This change has been ma

Re: Review Request 124315: Change keyboard shortcut to avoid conflict with "next tab"

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/124315/ --- (Updated Aug. 25, 2015, 3 a.m.) Status -- This change has been marke

Re: Review Request 124904: Make KDE_FORK_SLAVES work under Windows

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/124904/#review84309 --- Looks good to me src/core/slave.cpp (line 88)

Jenkins-kde-ci: kxmlgui master stable-kf5-qt5 » Linux,gcc - Build # 19 - Fixed!

GENERAL INFO BUILD SUCCESS Build URL: https://build.kde.org/job/kxmlgui%20master%20stable-kf5-qt5/PLATFORM=Linux,compiler=gcc/19/ Project: PLATFORM=Linux,compiler=gcc Date of build: Mon, 24 Aug 2015 22:31:42 + Build duration: 3 min 26 sec CHANGE SET No changes JUNIT RESULTS Name:

Jenkins-kde-ci: kxmlgui master stable-kf5-qt5 » Linux,gcc - Build # 19 - Fixed!

GENERAL INFO BUILD SUCCESS Build URL: https://build.kde.org/job/kxmlgui%20master%20stable-kf5-qt5/PLATFORM=Linux,compiler=gcc/19/ Project: PLATFORM=Linux,compiler=gcc Date of build: Mon, 24 Aug 2015 22:31:42 + Build duration: 3 min 26 sec CHANGE SET No changes JUNIT RESULTS Name:

Jenkins-kde-ci: kxmlgui master stable-kf5-qt5 » Linux,gcc - Build # 18 - Failure!

GENERAL INFO BUILD FAILURE Build URL: https://build.kde.org/job/kxmlgui%20master%20stable-kf5-qt5/PLATFORM=Linux,compiler=gcc/18/ Project: PLATFORM=Linux,compiler=gcc Date of build: Mon, 24 Aug 2015 22:10:35 + Build duration: 3 min 2 sec CHANGE SET Revision bede4e5440c04f4c690a76967ebd755d3

Re: Review Request 124884: Fix KSwitchLangaugeDialog

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/124884/ --- (Updated Aug. 24, 2015, 10:10 p.m.) Status -- This change has been m

Re: Review Request 124884: Fix KSwitchLangaugeDialog

> On ago. 24, 2015, 8:16 a.m., David Faure wrote: > > Minor suggestions, feel free to ignore if no time. > > > > I wonder though, Qt returning ca-ES from uiLanguages and ca_ES from > > QLocale, wouldn't that be a bug in Qt? It's not a bug per se but just Qt being not very smart and using names

Re: Review Request 120443: Add ctags configuration option to highlighting

El Dilluns, 24 d'agost de 2015, a les 12:48:30, Dominik Haumann va escriure: > On Mon, Aug 24, 2015 at 10:16 AM, David Faure wrote: > > On Sunday 23 August 2015 12:19:10 Dominik Haumann wrote: > >> Are there still parts in this patch that are relevant? If so, can you > >> update the patch to refle

Re: Review Request 124887: Also propagate window titles for folder-only file dialogs.

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/124887/ --- (Updated Aug. 24, 2015, 5:10 p.m.) Status -- This change has been ma

Re: Review Request 124902: Delay starting kglobalaccel5 till it's needed

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/124902/#review84290 --- Ship it! Ship It! - Milian Wolff On Aug. 24, 2015, 12:59 p

Re: ksycoca improvements (Re: assert in kservicetypefactory.cpp)

On Monday 24 August 2015 15:34:27 Milian Wolff wrote: > On Monday, August 24, 2015 2:48:14 PM CEST David Faure wrote: > > On Monday 24 August 2015 13:04:24 Milian Wolff wrote: > > > [QK]LockFile was too unreliable on linux > > > > That sounds like judging QLockFile based on how badly KLockFile wo

Re: Review Request 124905: Win: Hide console window for binaries in LIBEXEC

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/124905/ --- (Updated Aug. 24, 2015, 1:36 p.m.) Review request for KDE Frameworks, Dav

Re: Review Request 124905: Make KDE_FORK_SLAVES work under Windows

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/124905/ --- (Updated Aug. 24, 2015, 1:35 p.m.) Review request for KDE Frameworks, Dav

Re: ksycoca improvements (Re: assert in kservicetypefactory.cpp)

On Monday, August 24, 2015 2:48:14 PM CEST David Faure wrote: > On Monday 24 August 2015 13:04:24 Milian Wolff wrote: > > [QK]LockFile was too unreliable on linux > > That sounds like judging QLockFile based on how badly KLockFile worked :) > > IOW, it doesn't sound like you actually tried Qt5's

Review Request 124905: Make KDE_FORK_SLAVES work under Windows

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/124905/ --- Review request for KDE Frameworks, David Faure and Boudewijn Rempt. Repos

Re: Review Request 124904: Make KDE_FORK_SLAVES work under Windows

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/124904/ --- (Updated Aug. 24, 2015, 1:11 p.m.) Review request for KDE Frameworks, Dav

Re: Review Request 124872: Default to Breeze colors

> On Aug. 24, 2015, 12:13 a.m., Martin Gräßlin wrote: > > I must say I'm rather shocked at how this is implemented. Would it be > > possible to move the defaults into our QPT plugin, so that these defaults > > are only applied if running on a platform with our plugin, otherwise it > > picks Qt

Review Request 124904: Make KDE_FORK_SLAVES work under Windows

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/124904/ --- Review request for KDE Frameworks, David Faure and Boudewijn Rempt. Repos

Re: Review Request 124902: Delay starting kglobalaccel5 till it's needed

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/124902/ --- (Updated Aug. 24, 2015, 2:59 p.m.) Review request for KDE Frameworks and

Re: ksycoca improvements (Re: assert in kservicetypefactory.cpp)

On Monday 24 August 2015 13:04:24 Milian Wolff wrote: > [QK]LockFile was too unreliable on linux That sounds like judging QLockFile based on how badly KLockFile worked :) IOW, it doesn't sound like you actually tried Qt5's QLockFile. Anyhow, if DBus works, DBus works. I just wanted to avoid FUD

Re: Review Request 124876: KSycoca: check timestamps and run kbuildsycoca if needed. No kded needed anymore.

> On Aug. 24, 2015, 12:07 p.m., Kevin Funk wrote: > > Still runs kbuildsycoca5 for me(?) > > > > ``` > > [3796] kf5.kservice.sycoca: Trying to open ksycoca from > > "C:/Users/kfunk/AppData/Local/cache/ksycoca5" > > [3796] checking file timestamps > > [3796] timestamps check ok > > [3796] Emitti

Re: Review Request 124896: Fix bad behavior / running OOM on Windows

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/124896/ --- (Updated Aug. 24, 2015, 12:37 p.m.) Status -- This change has been m

Re: Review Request 124902: Delay starting kglobalaccel5 till it's needed

> On Aug. 24, 2015, 11:52 a.m., Kevin Funk wrote: > > src/kglobalaccel.cpp, line 97 > > > > > > Indeed. Just move into iface()? > > Martin Gräßlin wrote: > it's also used for setting up the QDBusServiceWatche

Re: Review Request 124876: KSycoca: check timestamps and run kbuildsycoca if needed. No kded needed anymore.

> On Aug. 24, 2015, 12:15 p.m., Kevin Funk wrote: > > More context: > > > > ``` > > [5748] klauncher not running... launching kdeinit > > [6344] kf5.kinit.klauncher: LAUNCHER_OK > > [2892] Could not find drkonqi at Z:/kderoot/bin/drkonqi > > [2892] QObject::connect: No such signal UrlHandler::de

Re: Review Request 124876: KSycoca: check timestamps and run kbuildsycoca if needed. No kded needed anymore.

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/124876/#review84272 --- More context: ``` [5748] klauncher not running... launching k

Re: Review Request 124902: Delay starting kglobalaccel5 till it's needed

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/124902/ --- (Updated Aug. 24, 2015, 2:13 p.m.) Review request for KDE Frameworks and

Re: Review Request 124876: KSycoca: check timestamps and run kbuildsycoca if needed. No kded needed anymore.

> On Aug. 24, 2015, 12:07 p.m., Kevin Funk wrote: > > Still runs kbuildsycoca5 for me(?) > > > > ``` > > [3796] kf5.kservice.sycoca: Trying to open ksycoca from > > "C:/Users/kfunk/AppData/Local/cache/ksycoca5" > > [3796] checking file timestamps > > [3796] timestamps check ok > > [3796] Emitti

Re: Review Request 124876: KSycoca: check timestamps and run kbuildsycoca if needed. No kded needed anymore.

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/124876/#review84269 --- Still runs kbuildsycoca5 for me(?) ``` [3796] kf5.kservice.sy

Re: Review Request 124902: Delay starting kglobalaccel5 till it's needed

> On Aug. 24, 2015, 1:52 p.m., Kevin Funk wrote: > > src/kglobalaccel.cpp, line 97 > > > > > > Indeed. Just move into iface()? it's also used for setting up the QDBusServiceWatcher in the KGlobalAccelPrivate cto

Re: Review Request 124902: Delay starting kglobalaccel5 till it's needed

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/124902/#review84267 --- Ship it! src/kglobalaccel.cpp (line 97)

Re: Review Request 124902: Delay starting kglobalaccel5 till it's needed

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/124902/#review84266 --- Can confirm. With that patch kglobalaccel5 is no longer starte

Re: Review Request 124902: Delay starting kglobalaccel5 till it's needed

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/124902/#review84264 --- src/kglobalaccel.cpp (line 97)

Re: ksycoca improvements (Re: assert in kservicetypefactory.cpp)

On Monday, August 24, 2015 11:08:08 AM CEST Martin Graesslin wrote: > > > I think that kglobalaccel5 is invoked as soon as KXmlGui gets involved > > > (which KDevelop makes use of). > > > > > > Code in kxmlgui.git somewhat agrees: There are references to > > > KGlobalAccel::self() in, which will i

Review Request 124902: Delay starting kglobalaccel5 till it's needed

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/124902/ --- Review request for KDE Frameworks and Kevin Funk. Repository: kglobalacce

Re: ksycoca improvements (Re: assert in kservicetypefactory.cpp)

On Monday, August 24, 2015 1:03:22 AM CEST Kevin Funk wrote: > On Saturday 22 August 2015 11:34:38 David Faure wrote: > > On Wednesday 19 August 2015 09:08:35 Boudewijn Rempt wrote: > > > A windows or osx application for the masses must: > > > * not have any pre or post install procedures > > > * n

Re: Review Request 120443: Add ctags configuration option to highlighting

On Mon, Aug 24, 2015 at 10:16 AM, David Faure wrote: > On Sunday 23 August 2015 12:19:10 Dominik Haumann wrote: >> >> Are there still parts in this patch that are relevant? If so, can you update >> the patch to reflect it? Otherwise, please discard it (we can't do this, >> unfortunaltely, Review

Re: Review Request 124846: i18n: Fix untranslatable string

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/124846/#review84260 --- Ship it! Ship It! - Sebastian Kügler On Aug. 24, 2015, 10:

Review Request 124846: i18n: Fix untranslatable string

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/124846/ --- Review request for KDE Frameworks and Ivan Čukić. Repository: kactivities

Re: ksycoca improvements (Re: assert in kservicetypefactory.cpp)

On Monday, August 24, 2015 10:58:30 AM CEST Martin Graesslin wrote: > On Monday, August 24, 2015 10:39:57 AM CEST you wrote: > > On Monday 24 August 2015 10:00:43 Martin Gräßlin wrote: > > > Am 2015-08-24 01:03, schrieb Kevin Funk: > > > > Right now whenever I start kdevelop I get the following dae

Re: ksycoca improvements (Re: assert in kservicetypefactory.cpp)

On Monday, August 24, 2015 10:39:57 AM CEST you wrote: > On Monday 24 August 2015 10:00:43 Martin Gräßlin wrote: > > Am 2015-08-24 01:03, schrieb Kevin Funk: > > > Right now whenever I start kdevelop I get the following daemons up and > > > running > > > on Windows: > > > - dbus-daemon > > > - kded

Re: Review Request 124896: Fix bad behavior / running OOM on Windows

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/124896/#review84255 --- Ship it! and that really fixes the OOM issue? did that alloca

Re: ksycoca improvements (Re: assert in kservicetypefactory.cpp)

On Monday 24 August 2015 10:00:43 Martin Gräßlin wrote: > Am 2015-08-24 01:03, schrieb Kevin Funk: > > Right now whenever I start kdevelop I get the following daemons up and > > running > > on Windows: > > - dbus-daemon > > - kded5 > > - kglobalaccel5 > > - kioslave > > - klauncher > > KGlobalAcce

Re: Review Request 124896: Fix bad behavior / running OOM on Windows

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/124896/ --- (Updated Aug. 24, 2015, 8:27 a.m.) Review request for KDE Frameworks. B

Review Request 124896: Fix bad behavior / running OOM on Windows

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/124896/ --- Review request for KDE Frameworks. Repository: kcompletion Description

Re: Review Request 120443: Add ctags configuration option to highlighting

On Sunday 23 August 2015 12:19:10 Dominik Haumann wrote: > > Are there still parts in this patch that are relevant? If so, can you update > the patch to reflect it? Otherwise, please discard it (we can't do this, > unfortunaltely, ReviewBoard is missing a "Reject" button) :-) Sysadmins and myse

Re: Review Request 124884: Fix KSwitchLangaugeDialog

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/124884/#review84251 --- Ship it! Minor suggestions, feel free to ignore if no time.

Re: Review Request 124887: Also propagate window titles for folder-only file dialogs.

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/124887/#review84250 --- Ship it! - David Faure On Aug. 23, 2015, 9:14 a.m., Volker

Re: ksycoca improvements (Re: assert in kservicetypefactory.cpp)

On Monday 24 August 2015 01:03:22 Kevin Funk wrote: > On Saturday 22 August 2015 11:34:38 David Faure wrote: > > On Wednesday 19 August 2015 09:08:35 Boudewijn Rempt wrote: > > > A windows or osx application for the masses must: > > > * not have any pre or post install procedures > > > * not start

Re: ksycoca improvements (Re: assert in kservicetypefactory.cpp)

Am 2015-08-24 01:03, schrieb Kevin Funk: Right now whenever I start kdevelop I get the following daemons up and running on Windows: - dbus-daemon - kded5 - kglobalaccel5 - kioslave - klauncher KGlobalAccel should only be started if there is something trying to interact with KGlobalAccel (it's