El Dilluns, 24 d'agost de 2015, a les 12:48:30, Dominik Haumann va escriure: > On Mon, Aug 24, 2015 at 10:16 AM, David Faure <fa...@kde.org> wrote: > > On Sunday 23 August 2015 12:19:10 Dominik Haumann wrote: > >> Are there still parts in this patch that are relevant? If so, can you > >> update the patch to reflect it? Otherwise, please discard it (we can't > >> do this, unfortunaltely, ReviewBoard is missing a "Reject" button) :-)> > > Sysadmins and myself (and maybe other people) can discard other people's > > RR. > In fact, I can do this, too (someone gave me the karma). But then we get > IIRC a mail from the original submitter, saying the ReviewRequest was > discarded. It's not saying that it was Dominik who discarded it, iirc. So > even the original submitter might wonder why a mail in his name was sent. > > So to not scare contributors away, I'd prefer they close it > themselves, or we add a > proper way to reject patches.
Just add a comment on the top where it says reason to be closed and you say "Closed by admin because XYZ". Cheers, Albert > > Or do I miss something? :-) > > Dominik > _______________________________________________ > Kde-frameworks-devel mailing list > Kde-frameworks-devel@kde.org > https://mail.kde.org/mailman/listinfo/kde-frameworks-devel _______________________________________________ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
