----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/124896/#review84255 -----------------------------------------------------------
Ship it! and that really fixes the OOM issue? did that allocator put values in there that overflowed? anyhow, lgtm if it fixes the warnings alone - Milian Wolff On Aug. 24, 2015, 8:27 a.m., Kevin Funk wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/124896/ > ----------------------------------------------------------- > > (Updated Aug. 24, 2015, 8:27 a.m.) > > > Review request for KDE Frameworks. > > > Bugs: 345860 > https://bugs.kde.org/show_bug.cgi?id=345860 > > > Repository: kcompletion > > > Description > ------- > > Fix bad behavior / running OOM on Windows > > When testing KDevelop on Windows we sometimes experienced excessive use > of memory (> 2 gigs of RAM allocated). This patch appears to fix the > issue. > > Compiler warnings didn't sound promising either: > Z:\kderoot\download\git\kcompletion\src\kzoneallocator.cpp(129): > warning C4319: '~': zero extending 'unsigned long' to 'quintptr' of > greater size > Z:\kderoot\download\git\kcompletion\src\kzoneallocator.cpp(206): > warning C4319: '~': zero extending 'unsigned long' to 'quintptr' of > greater size > Z:\kderoot\download\git\kcompletion\src\kzoneallocator.cpp(256): > warning C4267: '+=': conversion from 'size_t' to 'unsigned long', > possible loss of data > > BUG: 345860 > > > Diffs > ----- > > src/kzoneallocator.cpp 2ab9bb021ff09445f291f69ecc3f6facde7eed22 > > Diff: https://git.reviewboard.kde.org/r/124896/diff/ > > > Testing > ------- > > > Thanks, > > Kevin Funk > >
_______________________________________________ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
