----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/124884/#review84251 -----------------------------------------------------------
Ship it! Minor suggestions, feel free to ignore if no time. I wonder though, Qt returning ca-ES from uiLanguages and ca_ES from QLocale, wouldn't that be a bug in Qt? src/kswitchlanguagedialog_p.cpp (line 335) <https://git.reviewboard.kde.org/r/124884/#comment58341> double lookup, you could call indexOf, store it, compare with -1. But OK I guess this isn't performance-critical code ;) src/kswitchlanguagedialog_p.cpp (line 370) <https://git.reviewboard.kde.org/r/124884/#comment58342> ... and that language code massaging could even be extracted into a small static function, to avoid duplication - David Faure On Aug. 22, 2015, 11:26 p.m., Albert Astals Cid wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/124884/ > ----------------------------------------------------------- > > (Updated Aug. 22, 2015, 11:26 p.m.) > > > Review request for KDE Frameworks. > > > Repository: kxmlgui > > > Description > ------- > > QLocale and us don't always agree on how to call things, for example we call > our translation "ca" while QLocale gives us "ca_ES" in locale::name so we > need to strip the _ in some cases. > > To make things funnier, QLocale::uiLanguages actually returns ca-ES so we > first turn all the - to _ > > > Diffs > ----- > > src/kswitchlanguagedialog_p.cpp 2ae4b0b > > Diff: https://git.reviewboard.kde.org/r/124884/diff/ > > > Testing > ------- > > tested rsibreak, works + See screenshots > > > File Attachments > ---------------- > > Before > > https://git.reviewboard.kde.org/media/uploaded/files/2015/08/22/79c70322-b55d-4940-a167-b98309eaa6ec__before.png > After > > https://git.reviewboard.kde.org/media/uploaded/files/2015/08/22/f3eae50b-53a1-4836-809d-ede574c80690__after.png > > > Thanks, > > Albert Astals Cid > >
_______________________________________________ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
