Re: Review Request 115248: Add runtime detection to KXMessages

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115248/ --- (Updated Feb. 1, 2014, 7:42 a.m.) Status -- This change has been mar

Re: Review Request 115248: Add runtime detection to KXMessages

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115248/#review48734 --- This review has been submitted with commit 6f0d8141132e675eb3

Re: Review Request 115230: Add platform check to KSelectionOwner and KSelectionWatcher

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115230/ --- (Updated Feb. 1, 2014, 7:41 a.m.) Status -- This change has been mar

Re: Review Request 115230: Add platform check to KSelectionOwner and KSelectionWatcher

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115230/#review48733 --- This review has been submitted with commit 77f8148cea518bc580

Re: Review Request 115251: Add better runtime detection for X11 usage in KStartupInfo

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115251/ --- (Updated Feb. 1, 2014, 8:40 a.m.) Review request for KDE Frameworks. Ch

Re: Review Request 115292: Do Configure Checks in the Correct Language

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115292/ --- (Updated Feb. 1, 2014, 3:39 a.m.) Status -- This change has been mar

Re: Review Request 115417: Remove the Check for freeaddrinfo

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115417/#review48731 --- This review has been submitted with commit eb56f7c36187725b05

Re: Review Request 115417: Remove the Check for freeaddrinfo

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115417/ --- (Updated Feb. 1, 2014, 3:39 a.m.) Status -- This change has been mar

Re: Review Request 115292: Do Configure Checks in the Correct Language

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115292/#review48732 --- This review has been submitted with commit 2134d30671c5cfd8da

Review Request 115419: Split KCompletionMatches declaration from kcompletion.h into own header file

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115419/ --- Review request for KDE Frameworks. Repository: kcompletion Description

Re: Review Request 115292: Do Configure Checks in the Correct Language

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115292/#review48730 --- Ship it! OK, works fine with CMake 2.8.12.0 - Alex Merry O

Jenkins build is back to normal : kcompletion_master_qt5 #19

See ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Build failed in Jenkins: kcompletion_master_qt5 #18

See Changes: [davidgiloliva] Split KCompletionBase class from kcompletion.h -- [...truncated 48 lines...] -- Detecting C compiler ABI info -- Detecting C compiler ABI info - done -- Check for wor

Re: Review Request 115394: Split KCompletionBase from kcompletion.h

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115394/ --- (Updated Jan. 31, 2014, 10:53 p.m.) Status -- This change has been m

Re: Review Request 115394: Split KCompletionBase from kcompletion.h

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115394/#review48729 --- This review has been submitted with commit 8d09dc6b245f83650c

Review Request 115418: Hide private methods of KCompletion into d-pointer

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115418/ --- Review request for KDE Frameworks. Repository: kcompletion Description

Re: Review Request 115417: Remove the Check for freeaddrinfo

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115417/#review48728 --- Ship it! Ship It! - Alex Merry On Jan. 31, 2014, 10:02 p.m

Re: Review Request 115417: Remove the Check for freeaddrinfo

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115417/ --- (Updated Jan. 31, 2014, 10:02 p.m.) Review request for KDE Frameworks and

Review Request 115417: Remove the Check for freeaddrinfo

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115417/ --- Review request for KDE Frameworks and Alex Merry. Repository: kde4support

Re: Review Request 115292: Do Configure Checks in the Correct Language

> On Jan. 31, 2014, 6:31 p.m., Alex Merry wrote: > > src/ConfigureChecks.cmake, line 68 > > > > > > I believe this isn't even used any more > > David Narváez wrote: > It doesn't look like it is used, let me k

Re: Review Request 115292: Do Configure Checks in the Correct Language

> On Jan. 31, 2014, 6:31 p.m., Alex Merry wrote: > > src/ConfigureChecks.cmake, lines 87-88 > > > > > > Is this LANGUAGE stuff a cmake 3 feature, because it does not appear to > > exist in cmake 2.8.12 > > David

Re: Review Request 115077: Rename Macros in KF5DocTools to KDE5_

> On Jan. 31, 2014, 6:21 p.m., Alex Merry wrote: > > If this review is obsolete, can you discard it, please? > > David Narváez wrote: > I'm waiting for an answer to my question above. I would go with Luigi's suggestion. If we determine later that it might be useful beyond KDocTools, we ca

Re: Review Request 115292: Do Configure Checks in the Correct Language

> On Jan. 31, 2014, 6:31 p.m., Alex Merry wrote: > > src/ConfigureChecks.cmake, line 68 > > > > > > I believe this isn't even used any more It doesn't look like it is used, let me know if you want me to drop this

Re: Review Request 115292: Do Configure Checks in the Correct Language

> On Jan. 31, 2014, 6:31 p.m., Alex Merry wrote: > > src/ConfigureChecks.cmake, lines 87-88 > > > > > > Is this LANGUAGE stuff a cmake 3 feature, because it does not appear to > > exist in cmake 2.8.12 $ cmake

Re: Review Request 115077: Rename Macros in KF5DocTools to KDE5_

> On Jan. 31, 2014, 6:21 p.m., Alex Merry wrote: > > If this review is obsolete, can you discard it, please? I'm waiting for an answer to my question above. - David --- This is an automatically generated e-mail. To reply, visit: https:/

Re: Review Request 115230: Add platform check to KSelectionOwner and KSelectionWatcher

> On Jan. 31, 2014, 6:48 p.m., Alex Merry wrote: > > Looks like it should be functionally equivalent to the old code (in the > > presence of X11). > > > > The only thing that gives me pause is explicitly checking the platform > > plugin name (rather than, say, using the method from QX11Extras)

Re: Review Request 115251: Add better runtime detection for X11 usage in KStartupInfo

> On Jan. 31, 2014, 8:45 p.m., Alex Merry wrote: > > src/kstartupinfo.cpp, lines 458-480 > > > > > > Surely we shouldn't be using KXMessages if we don't have X11? > > > > (Also applies to the next bunch

Re: Review Request 115230: Add platform check to KSelectionOwner and KSelectionWatcher

> On Jan. 31, 2014, 7:48 p.m., Alex Merry wrote: > > Looks like it should be functionally equivalent to the old code (in the > > presence of X11). > > > > The only thing that gives me pause is explicitly checking the platform > > plugin name (rather than, say, using the method from QX11Extras)

Re: Review Request 115251: Add better runtime detection for X11 usage in KStartupInfo

> On Jan. 31, 2014, 9:45 p.m., Alex Merry wrote: > > src/kstartupinfo.cpp, lines 458-480 > > > > > > Surely we shouldn't be using KXMessages if we don't have X11? > > > > (Also applies to the next bunch

Re: Review Request 115230: Add platform check to KSelectionOwner and KSelectionWatcher

> On Jan. 31, 2014, 6:48 p.m., Alex Merry wrote: > > Looks like it should be functionally equivalent to the old code (in the > > presence of X11). > > > > The only thing that gives me pause is explicitly checking the platform > > plugin name (rather than, say, using the method from QX11Extras)

Re: Review Request 115415: Allow kpac_proxyscout to be built again

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115415/#review48716 --- Ship it! - Alex Merry On Jan. 31, 2014, 5:57 p.m., Michael

Re: Review Request 115387: rename dbus interface file for kinit

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115387/#review48715 --- Is there a corresponding RR for kde-workspace? - Alex Merry

Re: Review Request 115251: Add better runtime detection for X11 usage in KStartupInfo

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115251/#review48713 --- src/kstartupinfo.cpp

Re: Review Request 115225: Add runtime platform support to KWindowInfo

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115225/#review48712 --- Ship it! I'm not a huge fan of the dark templating magic, and

Re: Review Request 115370: Fix apidox, fix code style and delete useless includes in KComboBox (KCompletion)

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115370/#review48708 --- Comments on the dox changes below. Please make the changes to

Re: Review Request 115416: Improve knewstuff dependencies

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115416/#review48709 --- Ship it! Ship It! - Jeremy Whiting On Jan. 31, 2014, 11:49

Re: Review Request 115344: With MSVC M_PI only gets defined if _USE_MATH_DEFINES is defined

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115344/#review48707 --- Ship it! Can you include a link to http://msdn.microsoft.com/

Re: Review Request 115343: Fix msvc build of solid

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115343/#review48706 --- src/solid/networking_win.cpp

Re: Review Request 115336: Change syntax of kservice_desktop_to_json

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115336/#review48705 --- Ship it! There was an optional jsonfile argument; I guess you

Re: Review Request 115325: Improve documentation of KWindowInfo

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115325/#review48701 --- I got fed up of making "As above" issues; the comments about o

Re: Review Request 115230: Add platform check to KSelectionOwner and KSelectionWatcher

> On Jan. 31, 2014, 7:48 p.m., Alex Merry wrote: > > Looks like it should be functionally equivalent to the old code (in the > > presence of X11). > > > > The only thing that gives me pause is explicitly checking the platform > > plugin name (rather than, say, using the method from QX11Extras)

Review Request 115416: Improve knewstuff dependencies

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115416/ --- Review request for KDE Frameworks and Jeremy Whiting. Repository: knewstu

Re: Review Request 115230: Add platform check to KSelectionOwner and KSelectionWatcher

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115230/#review48700 --- Ship it! Looks like it should be functionally equivalent to t

Re: Review Request 115248: Add runtime detection to KXMessages

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115248/#review48699 --- Ship it! Ship It! - Alex Merry On Jan. 27, 2014, 8:43 a.m.

Re: Review Request 114989: kapidox and other components from frameworks should use kde5-config instead of kde4-config, remove kde4 references

> On Jan. 27, 2014, 7:39 a.m., Kevin Ottens wrote: > > src/doxygen-preprocess-kcfg.sh, line 5 > > > > > > Should indeed just say kconfig_compiler. Any progress on this? As Kévin said, the $kcfg_compiler variable

Re: Review Request 115292: Do Configure Checks in the Correct Language

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115292/#review48694 --- I'm slightly ambivilent about this, on the basis that my view

Re: Review Request 115077: Rename Macros in KF5DocTools to KDE5_

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115077/#review48693 --- If this review is obsolete, can you discard it, please? - Ale

Re: Review Request 114987: khtml and other components from frameworks should use kde5_install , remove kde4 refs

> On Jan. 13, 2014, 11:54 a.m., Alex Merry wrote: > > Does kde5_install_icons even exist? I can't find its definition in > > extra-cmake-modules. > > > > You say you've done no testing; surely you should at least have tried a > > fresh configure, compile and install of khtml? > > Alex Merry

Re: Review Request 114991: I think frameworks 5 should use kde5 based emoticons ? , though i am not sure changing it now would make any sense o_O ? would leave up to reviewers

> On Jan. 13, 2014, 12:15 p.m., Alex Merry wrote: > > Currently, it is still "kde4"; it is tied to kde-runtime/pics/emoticons. I > > think that directory needs to be merged into the kemoticons framework, and > > then this line needs to match the installation location of that emoticons > > the

Re: Review Request 114260: Port mouse dataengine

> On Dec. 8, 2013, 12:08 p.m., Bhushan Shah wrote: > > plasma/generic/dataengines/mouse/mouseengine.cpp, line 34 > > > > > > You should call init() here. Have a look at > > http://community.kde.org/Plasma/Porting

Re: Review Request 114990: removing kde4 references from kauth

> On Jan. 13, 2014, 12:09 p.m., Alex Merry wrote: > > src/kauthactionreply.h, line 173 > > > > > > I'm sure no such macro exists. Have a look in > > kauth/cmake/KF5AuthMacros.cmake for what it should become. A

Review Request 115415: Allow kpac_proxyscout to be built again

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115415/ --- Review request for KDE Frameworks and David Faure. Repository: kio Desc

Re: Review Request 115411: Remove obsolete CMake code from pre-splitting

On 31/01/14 15:39, Aleix Pol Gonzalez wrote: > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/115411/ > > > Ship it! > > I think we should agree on doing this for all frameworks, actually. > > All this checking if it's being built out of kdelibs

Re: Review Request 115411: Remove obsolete CMake code from pre-splitting

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115411/ --- (Updated Jan. 31, 2014, 5:35 p.m.) Status -- This change has been ma

Re: Review Request 115411: Remove obsolete CMake code from pre-splitting

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115411/#review48683 --- This review has been submitted with commit bcd8e339e51b23c13a

Jenkins build is back to normal : ktexteditor_master_qt5 #184

See ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Build failed in Jenkins: ktexteditor_master_qt5 #183

See -- Started by remote host 127.0.0.1 with note: Triggered by commit Building remotely on LinuxSlave - 3 in workspace Running Prebuild steps [ktex

Re: Change the ML default reply-to address

On Thursday, 2014-01-30, 13:55:21, Alex Merry wrote: > On 30/01/14 13:50, Aurélien Gâteau wrote: > > You can avoid this (on the receiving side) by editing your personal > > mailing list settings. Quoting mailman settings page: > > > > """ > > Avoid duplicate copies of messages? > > > > When you a

Re: Review Request 115411: Remove obsolete CMake code from pre-splitting

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115411/#review48682 --- Ship it! I think we should agree on doing this for all framew

Re: Review Request 115387: rename dbus interface file for kinit

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115387/#review48681 --- Looks good FWIW. - Michael Palimaka On Jan. 29, 2014, 4:27

Re: Review Request 115404: Improve dependencies

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115404/ --- (Updated Jan. 31, 2014, 2:48 p.m.) Status -- This change has been ma

Re: Review Request 115404: Improve dependencies

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115404/#review48680 --- This review has been submitted with commit a37b40b972c253b178

Re: Review Request 115394: Split KCompletionBase from kcompletion.h

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115394/#review48678 --- Ship it! Had to redo the changes in kcompletion.h because of

Re: Transitive dependency checks

On 01/31/2014 04:56 AM, Alex Merry wrote: > On 30/01/14 16:12, Aurélien Gâteau wrote: >> The issue only occurred with CMake 2.8.12 when building kdelibs as a >> whole. It is no longer a problem now that the repositories have been >> split. Therefore, I think you can go on and remove those dependenc

Re: Review Request 115412: Fix linking against KWindowSystem

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115412/ --- (Updated Jan. 31, 2014, 1:27 p.m.) Status -- This change has been ma

Re: Review Request 115412: Fix linking against KWindowSystem

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115412/#review48677 --- This review has been submitted with commit fd1fa3e206b7783c61

Re: Review Request 115412: Fix linking against KWindowSystem

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115412/#review48676 --- Ship it! Looks valid to me - Martin Gräßlin On Jan. 31, 20

Re: Review Request 115404: Improve dependencies

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115404/#review48675 --- Ship it! Checked with CMake 2.8.12.0 - still works fine. - A

Re: Review Request 115137: Provide information about the active screen in KWindowSystem

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115137/ --- (Updated Jan. 31, 2014, 2:01 p.m.) Review request for KDE Frameworks, kde

Review Request 115412: Fix linking against KWindowSystem

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115412/ --- Review request for KDE Frameworks. Repository: kwindowsystem Descriptio

Re: Review Request 115411: Remove obsolete CMake code from pre-splitting

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115411/ --- (Updated Jan. 31, 2014, 12:03 p.m.) Review request for KDE Frameworks and

Review Request 115411: Remove obsolete CMake code from pre-splitting

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115411/ --- Review request for KDE Frameworks and Chusslove Illich. Repository: ki18n

Re: Review Request 115251: Add better runtime detection for X11 usage in KStartupInfo

> On Jan. 30, 2014, 3:49 p.m., David Edmundson wrote: > > src/kstartupinfo.cpp, line 1068 > > > > > > Does this need a runtime check? no that should be fine. The Qt method delegates to nativeResourceForScreen i