> On Jan. 31, 2014, 6:31 p.m., Alex Merry wrote: > > src/ConfigureChecks.cmake, line 68 > > <https://git.reviewboard.kde.org/r/115292/diff/1/?file=240431#file240431line68> > > > > I believe this isn't even used any more
It doesn't look like it is used, let me know if you want me to drop this call $ grep -R FREEADDRINFO * src/ConfigureChecks.cmake:check_cxx_symbol_exists(freeaddrinfo "sys/types.h;sys/socket.h;netdb.h" HAVE_FREEADDRINFO) - David ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115292/#review48694 ----------------------------------------------------------- On Jan. 24, 2014, 1:55 p.m., David Narváez wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/115292/ > ----------------------------------------------------------- > > (Updated Jan. 24, 2014, 1:55 p.m.) > > > Review request for KDE Frameworks and Alex Merry. > > > Repository: kde4support > > > Description > ------- > > A recent change in ECM revealed an issue with ConfigureChecks.cmake, where > the check_symbol_exist calls would use the C compiler (with CFLAGS) and the > compilation would happen in C++ (with CXXFLAGS). This change ports all checks > to CXX where possible. > > > Diffs > ----- > > src/ConfigureChecks.cmake 7c8951f > > Diff: https://git.reviewboard.kde.org/r/115292/diff/ > > > Testing > ------- > > 1. Refreshed builds for ECM and KDE4Support, both building OK > 2. $ grep HAVE_GETADDRINFO src/config-network.h > #define HAVE_GETADDRINFO 1 > > > Thanks, > > David Narváez > >
_______________________________________________ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
