----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115344/#review48707 -----------------------------------------------------------
Ship it! Can you include a link to http://msdn.microsoft.com/en-us/library/4hwaceh6.aspx in the comment? - Alex Merry On Jan. 27, 2014, 10:22 p.m., Alexander Richardson wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/115344/ > ----------------------------------------------------------- > > (Updated Jan. 27, 2014, 10:22 p.m.) > > > Review request for KDE Frameworks. > > > Repository: kunitconversion > > > Description > ------- > > With MSVC M_PI only gets defined if _USE_MATH_DEFINES is defined > > Is it okay to put the define in the source file, or should I rather put it in > the CMake code? > > > Diffs > ----- > > src/CMakeLists.txt aefd6abe964d19177a3514f9c01022141af0425b > > Diff: https://git.reviewboard.kde.org/r/115344/diff/ > > > Testing > ------- > > didn't compile before, does now > > > Thanks, > > Alexander Richardson > >
_______________________________________________ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
