----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115404/#review48680 -----------------------------------------------------------
This review has been submitted with commit a37b40b972c253b178dfb3b2a8cd20342babcc6f by Michael Palimaka to branch master. - Commit Hook On Jan. 30, 2014, 5:32 p.m., Michael Palimaka wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/115404/ > ----------------------------------------------------------- > > (Updated Jan. 30, 2014, 5:32 p.m.) > > > Review request for KDE Frameworks. > > > Repository: kemoticons > > > Description > ------- > > - Remove transitive dependencies as per mailing list > - Add missing KF5Config dependency > - QtGui is used rather than QtWidgets by the framework. > - QtWidgets is only used for tests > > > Diffs > ----- > > tests/CMakeLists.txt a3016c172f18559a98771c9d7da53cfdc758adad > src/core/CMakeLists.txt 9bc9a1c1a995f488185dfd19ef25bcc1f9e8a483 > KF5EmoticonsConfig.cmake.in 9b0efbc99cfed73c13e49c940cd5607afba85f07 > CMakeLists.txt a48d111c59aa42d5b0b85aa959e5cf10e7b974b0 > > Diff: https://git.reviewboard.kde.org/r/115404/diff/ > > > Testing > ------- > > Builds. Inspected source to verify changes. > > > Thanks, > > Michael Palimaka > >
_______________________________________________ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
