> On Jan. 13, 2014, 12:15 p.m., Alex Merry wrote: > > Currently, it is still "kde4"; it is tied to kde-runtime/pics/emoticons. I > > think that directory needs to be merged into the kemoticons framework, and > > then this line needs to match the installation location of that emoticons > > theme. > > > > Do you think you could make a review request for that?
Actually, I think this should probably eventually become "oxygen", but that depends on what happens to the emoticon theme in kde-runtime. Can you discard this for now, and it can be revisited when that is dealt with? - Alex ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/114991/#review47311 ----------------------------------------------------------- On Jan. 12, 2014, 8:22 p.m., Siddharth Sharma wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/114991/ > ----------------------------------------------------------- > > (Updated Jan. 12, 2014, 8:22 p.m.) > > > Review request for KDE Frameworks. > > > Repository: kemoticons > > > Description > ------- > > I think frameworks 5 should use kde5 based emoticons ? , though i am not sure > changing it now would make any sense o_O ? would leave up to reviewers > > > Diffs > ----- > > src/core/kemoticons.cpp bc72e16 > > Diff: https://git.reviewboard.kde.org/r/114991/diff/ > > > Testing > ------- > > none > > > Thanks, > > Siddharth Sharma > >
_______________________________________________ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
