----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115292/#review48694 -----------------------------------------------------------
I'm slightly ambivilent about this, on the basis that my view of kde4support is largely "if it ain't broke, don't fix it", but OTOH it does make sense to do these checks in the language they will be used in. There are a whole bunch of other checks in that file that are still being done in C, though (and I suspect some of the check_function_exists calls should really be check_symbol_exists). src/ConfigureChecks.cmake <https://git.reviewboard.kde.org/r/115292/#comment34367> I believe this isn't even used any more src/ConfigureChecks.cmake <https://git.reviewboard.kde.org/r/115292/#comment34368> Is this LANGUAGE stuff a cmake 3 feature, because it does not appear to exist in cmake 2.8.12 src/ConfigureChecks.cmake <https://git.reviewboard.kde.org/r/115292/#comment34369> This one doesn't even have an argument to LANGUAGE; but CheckPrototypeExists actually already checks using C++ - Alex Merry On Jan. 24, 2014, 1:55 p.m., David Narváez wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/115292/ > ----------------------------------------------------------- > > (Updated Jan. 24, 2014, 1:55 p.m.) > > > Review request for KDE Frameworks and Alex Merry. > > > Repository: kde4support > > > Description > ------- > > A recent change in ECM revealed an issue with ConfigureChecks.cmake, where > the check_symbol_exist calls would use the C compiler (with CFLAGS) and the > compilation would happen in C++ (with CXXFLAGS). This change ports all checks > to CXX where possible. > > > Diffs > ----- > > src/ConfigureChecks.cmake 7c8951f > > Diff: https://git.reviewboard.kde.org/r/115292/diff/ > > > Testing > ------- > > 1. Refreshed builds for ECM and KDE4Support, both building OK > 2. $ grep HAVE_GETADDRINFO src/config-network.h > #define HAVE_GETADDRINFO 1 > > > Thanks, > > David Narváez > >
_______________________________________________ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
