[GitHub] [kafka] huxihx opened a new pull request #9203: MINOR: Fix typo in LeaderEpochFileCacheTest

2020-08-19 Thread GitBox
huxihx opened a new pull request #9203: URL: https://github.com/apache/kafka/pull/9203 *More detailed description of your change, if necessary. The PR title and PR message become the squashed commit message, so use a separate comment to ping reviewers.* *Summary of te

[GitHub] [kafka] huxihx commented on pull request #9203: MINOR: Fix typo in LeaderEpochFileCacheTest

2020-08-20 Thread GitBox
huxihx commented on pull request #9203: URL: https://github.com/apache/kafka/pull/9203#issuecomment-677386992 @abbccdda Please review this minor patch. Thanks. This is an automated message from the Apache Git Service. To resp

[GitHub] [kafka] mimaison commented on pull request #9136: KAFKA-10211: Add DirectoryConfigProvider

2020-08-20 Thread GitBox
mimaison commented on pull request #9136: URL: https://github.com/apache/kafka/pull/9136#issuecomment-677487738 @tombentley The change looks good to me but there's a checkstyle issue: ``` [ant:checkstyle] [ERROR] /Users/mickael/github-ws/kafka/clients/src/test/java/org/apache/kafka/co

[GitHub] [kafka] jeqo commented on pull request #9137: KAFKA-9929: Support reverse iterator on KeyValueStore

2020-08-20 Thread GitBox
jeqo commented on pull request #9137: URL: https://github.com/apache/kafka/pull/9137#issuecomment-677489429 @vvcephei thanks for your feedback! Inverting flag actually make things more readable. Changing to `forward` and `if (forward) {} else {}`. -

[GitHub] [kafka] rondagostino commented on pull request #9199: KAFKA-10418: alter topic configs via kafka-topics error text

2020-08-20 Thread GitBox
rondagostino commented on pull request #9199: URL: https://github.com/apache/kafka/pull/9199#issuecomment-677671036 Actually, it turns out that the ability to use `kafka-configs --bootstrap-server` was only added in 2.5. So this could be backported to 2.5 and 2.6 (not all the way back to

[GitHub] [kafka] dongjinleekr commented on pull request #9189: KAFKA-10407: Have KafkaLog4jAppender support `linger.ms` and `batch.size`

2020-08-20 Thread GitBox
dongjinleekr commented on pull request #9189: URL: https://github.com/apache/kafka/pull/9189#issuecomment-677677152 Congratulations, @huxihx! :smile: If you have some time, please have a look at the related issue: https://github.com/apache/kafka/pull/7898 cc/ @omkreddy -

[GitHub] [kafka] omkreddy merged pull request #9203: MINOR: Fix typo in LeaderEpochFileCacheTest

2020-08-20 Thread GitBox
omkreddy merged pull request #9203: URL: https://github.com/apache/kafka/pull/9203 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to t

[GitHub] [kafka] iprithv opened a new pull request #9204: KAFKA-6181 Examining log messages with {{--deep-iteration}} should show superset of fields

2020-08-20 Thread GitBox
iprithv opened a new pull request #9204: URL: https://github.com/apache/kafka/pull/9204 adding missing fields for --deep-iteration log messages. Missing fields include : partitionLeaderEpoch, baseSequence, lastSequence, etc.,

[GitHub] [kafka] iprithv commented on pull request #9204: KAFKA-6181 Examining log messages with {{--deep-iteration}} should show superset of fields

2020-08-20 Thread GitBox
iprithv commented on pull request #9204: URL: https://github.com/apache/kafka/pull/9204#issuecomment-677733815 please review this @mjsax This is an automated message from the Apache Git Service. To respond to the message, pl

[GitHub] [kafka] iprithv edited a comment on pull request #9204: KAFKA-6181 Examining log messages with {{--deep-iteration}} should show superset of fields

2020-08-20 Thread GitBox
iprithv edited a comment on pull request #9204: URL: https://github.com/apache/kafka/pull/9204#issuecomment-677733815 please review this @mjsax Thanks This is an automated message from the Apache Git Service. To respond to th

[GitHub] [kafka] mumrah commented on a change in pull request #9100: Add AlterISR RPC and use it for ISR modifications

2020-08-20 Thread GitBox
mumrah commented on a change in pull request #9100: URL: https://github.com/apache/kafka/pull/9100#discussion_r474070847 ## File path: core/src/main/scala/kafka/server/AlterIsrChannelManager.scala ## @@ -0,0 +1,132 @@ +package kafka.server + +import java.util +import java.util.

[GitHub] [kafka] mumrah commented on a change in pull request #9100: Add AlterISR RPC and use it for ISR modifications

2020-08-20 Thread GitBox
mumrah commented on a change in pull request #9100: URL: https://github.com/apache/kafka/pull/9100#discussion_r474070847 ## File path: core/src/main/scala/kafka/server/AlterIsrChannelManager.scala ## @@ -0,0 +1,132 @@ +package kafka.server + +import java.util +import java.util.

[GitHub] [kafka] bbejeck commented on pull request #9099: KAFKA-6733: Printing additional ConsumerRecord fields in DefaultMessageFormatter

2020-08-20 Thread GitBox
bbejeck commented on pull request #9099: URL: https://github.com/apache/kafka/pull/9099#issuecomment-677743288 Ok to test This is an automated message from the Apache Git Service. To respond to the message, please log on to G

[GitHub] [kafka] soenkeliebau commented on pull request #8399: KAFKA-3720: Change TimeoutException to BufferExhaustedException when no memory can be allocated for a record within max.block.ms

2020-08-20 Thread GitBox
soenkeliebau commented on pull request #8399: URL: https://github.com/apache/kafka/pull/8399#issuecomment-677744802 @ijuma apologies for the delayed response I did indeed open that [pull request ](https://github.com/apache/kafka/pull/8464) and an accompanying [issue](https://issues.

[GitHub] [kafka] tomjiang1987 closed pull request #953: In daemon mode,redirect stdout to /dev/null

2020-08-20 Thread GitBox
tomjiang1987 closed pull request #953: URL: https://github.com/apache/kafka/pull/953 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to

[GitHub] [kafka] mumrah commented on a change in pull request #9100: Add AlterISR RPC and use it for ISR modifications

2020-08-20 Thread GitBox
mumrah commented on a change in pull request #9100: URL: https://github.com/apache/kafka/pull/9100#discussion_r474070847 ## File path: core/src/main/scala/kafka/server/AlterIsrChannelManager.scala ## @@ -0,0 +1,132 @@ +package kafka.server + +import java.util +import java.util.

[GitHub] [kafka] mumrah commented on a change in pull request #9100: Add AlterISR RPC and use it for ISR modifications

2020-08-20 Thread GitBox
mumrah commented on a change in pull request #9100: URL: https://github.com/apache/kafka/pull/9100#discussion_r474106591 ## File path: core/src/main/scala/kafka/server/AlterIsrChannelManager.scala ## @@ -0,0 +1,132 @@ +package kafka.server + +import java.util +import java.util.

[GitHub] [kafka] mumrah commented on a change in pull request #9100: Add AlterISR RPC and use it for ISR modifications

2020-08-20 Thread GitBox
mumrah commented on a change in pull request #9100: URL: https://github.com/apache/kafka/pull/9100#discussion_r474106591 ## File path: core/src/main/scala/kafka/server/AlterIsrChannelManager.scala ## @@ -0,0 +1,132 @@ +package kafka.server + +import java.util +import java.util.

[GitHub] [kafka] hachikuji commented on pull request #9112: KAFKA-10312 Fix error code returned by getPartitionMetadata

2020-08-20 Thread GitBox
hachikuji commented on pull request #9112: URL: https://github.com/apache/kafka/pull/9112#issuecomment-677786670 retest this please This is an automated message from the Apache Git Service. To respond to the message, please l

[GitHub] [kafka] guozhangwang commented on pull request #9177: KAFKA-9924: Add RocksDB metric num-entries-active-mem-table

2020-08-20 Thread GitBox
guozhangwang commented on pull request #9177: URL: https://github.com/apache/kafka/pull/9177#issuecomment-677836579 LGTM. Leaving to @vvcephei for final review and merge. I think it is okay to not bookkeep the thread id and always rely on currentThread() assuming only one thread woul

[GitHub] [kafka] vvcephei commented on pull request #9148: KAFKA-10379: Implement the KIP-478 StreamBuilder#addGlobalStore()

2020-08-20 Thread GitBox
vvcephei commented on pull request #9148: URL: https://github.com/apache/kafka/pull/9148#issuecomment-677844729 Thanks @abbccdda ! This is an automated message from the Apache Git Service. To respond to the message, please lo

[GitHub] [kafka] vvcephei merged pull request #9148: KAFKA-10379: Implement the KIP-478 StreamBuilder#addGlobalStore()

2020-08-20 Thread GitBox
vvcephei merged pull request #9148: URL: https://github.com/apache/kafka/pull/9148 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to t

[GitHub] [kafka] ableegoldman commented on a change in pull request #9137: KAFKA-9929: Support reverse iterator on KeyValueStore

2020-08-20 Thread GitBox
ableegoldman commented on a change in pull request #9137: URL: https://github.com/apache/kafka/pull/9137#discussion_r474213204 ## File path: streams/src/main/java/org/apache/kafka/streams/state/internals/RocksDBPrefixIterator.java ## @@ -1,54 +0,0 @@ -/* - * Licensed to the Ap

[GitHub] [kafka] ableegoldman commented on pull request #9191: [WIP] KAFKA-10355: PoC

2020-08-20 Thread GitBox
ableegoldman commented on pull request #9191: URL: https://github.com/apache/kafka/pull/9191#issuecomment-677852192 Tests didn't run, possible checkstyle issue? Results already cleaned up unfortunately This is an automated m

[GitHub] [kafka] rondagostino commented on a change in pull request #9032: KAFKA-10259: KIP-554 Broker-side SCRAM Config API

2020-08-20 Thread GitBox
rondagostino commented on a change in pull request #9032: URL: https://github.com/apache/kafka/pull/9032#discussion_r474226011 ## File path: clients/src/main/java/org/apache/kafka/clients/admin/Admin.java ## @@ -1214,6 +1215,64 @@ default AlterClientQuotasResult alterClientQuo

[GitHub] [kafka] rondagostino commented on a change in pull request #9032: KAFKA-10259: KIP-554 Broker-side SCRAM Config API

2020-08-20 Thread GitBox
rondagostino commented on a change in pull request #9032: URL: https://github.com/apache/kafka/pull/9032#discussion_r474236159 ## File path: clients/src/main/java/org/apache/kafka/clients/admin/DescribeUserScramCredentialsResult.java ## @@ -0,0 +1,50 @@ +/* + * Licensed to the

[GitHub] [kafka] michael-carter-instaclustr commented on pull request #8844: KAFKA-9887 fix failed task or connector count on startup failure

2020-08-20 Thread GitBox
michael-carter-instaclustr commented on pull request #8844: URL: https://github.com/apache/kafka/pull/8844#issuecomment-677909122 What do you think @kkonstantine ? Is this something you could look at? This is an automated me

[GitHub] [kafka] bbejeck commented on pull request #8955: KAFKA-10020: Create a new version of a scala Serdes without name clash (KIP-616)

2020-08-20 Thread GitBox
bbejeck commented on pull request #8955: URL: https://github.com/apache/kafka/pull/8955#issuecomment-677930002 Ok to test This is an automated message from the Apache Git Service. To respond to the message, please log on to G

[GitHub] [kafka] mjsax commented on pull request #9156: KAFKA-10077: Filter downstream of state-store results in spurious tombstones

2020-08-20 Thread GitBox
mjsax commented on pull request #9156: URL: https://github.com/apache/kafka/pull/9156#issuecomment-677982605 > Where as previously the user could choose to 'fix' the bad semantics by manually calling enableSendingOldValues themselves, if they cared. That is not entirely correct. `ena

[GitHub] [kafka] mjsax commented on a change in pull request #9156: KAFKA-10077: Filter downstream of state-store results in spurious tombstones

2020-08-20 Thread GitBox
mjsax commented on a change in pull request #9156: URL: https://github.com/apache/kafka/pull/9156#discussion_r474353504 ## File path: streams/src/main/java/org/apache/kafka/streams/kstream/internals/KTableImpl.java ## @@ -203,6 +203,10 @@ public String queryableStoreName() {

[GitHub] [kafka] mjsax commented on a change in pull request #9156: KAFKA-10077: Filter downstream of state-store results in spurious tombstones

2020-08-20 Thread GitBox
mjsax commented on a change in pull request #9156: URL: https://github.com/apache/kafka/pull/9156#discussion_r474353890 ## File path: streams/src/test/java/org/apache/kafka/streams/StreamsBuilderTest.java ## @@ -123,7 +123,7 @@ public void shouldAllowJoinMaterializedFilteredKT

[GitHub] [kafka] mjsax commented on a change in pull request #9156: KAFKA-10077: Filter downstream of state-store results in spurious tombstones

2020-08-20 Thread GitBox
mjsax commented on a change in pull request #9156: URL: https://github.com/apache/kafka/pull/9156#discussion_r474361586 ## File path: streams/src/test/java/org/apache/kafka/streams/StreamsBuilderTest.java ## @@ -123,7 +123,7 @@ public void shouldAllowJoinMaterializedFilteredKT

[GitHub] [kafka] cmccabe commented on a change in pull request #9032: KAFKA-10259: KIP-554 Broker-side SCRAM Config API

2020-08-20 Thread GitBox
cmccabe commented on a change in pull request #9032: URL: https://github.com/apache/kafka/pull/9032#discussion_r474416243 ## File path: clients/src/main/java/org/apache/kafka/clients/admin/DescribeUserScramCredentialsResult.java ## @@ -0,0 +1,50 @@ +/* + * Licensed to the Apac

[GitHub] [kafka] cmccabe commented on a change in pull request #9032: KAFKA-10259: KIP-554 Broker-side SCRAM Config API

2020-08-20 Thread GitBox
cmccabe commented on a change in pull request #9032: URL: https://github.com/apache/kafka/pull/9032#discussion_r474416682 ## File path: clients/src/main/java/org/apache/kafka/clients/admin/UserScramCredentialsDescription.java ## @@ -0,0 +1,92 @@ +/* + * Licensed to the Apache

[GitHub] [kafka] cmccabe commented on pull request #9199: KAFKA-10418: alter topic configs via kafka-topics error text

2020-08-20 Thread GitBox
cmccabe commented on pull request #9199: URL: https://github.com/apache/kafka/pull/9199#issuecomment-678066207 Thanks, @rondagostino. I think it's OK to just have in trunk for now. We already did a 2.6 release and this is not a critical fix, just a help text change. But if someone

[GitHub] [kafka] cmccabe merged pull request #9199: KAFKA-10418: alter topic configs via kafka-topics error text

2020-08-20 Thread GitBox
cmccabe merged pull request #9199: URL: https://github.com/apache/kafka/pull/9199 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to th

[GitHub] [kafka] cadonna commented on pull request #9191: [WIP] KAFKA-10355: PoC

2020-08-20 Thread GitBox
cadonna commented on pull request #9191: URL: https://github.com/apache/kafka/pull/9191#issuecomment-678074158 @ableegoldman Yes, you are right there were checkstyle issues. Will fix them. This is an automated message from th

[GitHub] [kafka] cadonna commented on pull request #9177: KAFKA-9924: Add RocksDB metric num-entries-active-mem-table

2020-08-20 Thread GitBox
cadonna commented on pull request #9177: URL: https://github.com/apache/kafka/pull/9177#issuecomment-678074413 Retest this, please This is an automated message from the Apache Git Service. To respond to the message, please lo

[GitHub] [kafka] cadonna commented on pull request #9177: KAFKA-9924: Add RocksDB metric num-entries-active-mem-table

2020-08-20 Thread GitBox
cadonna commented on pull request #9177: URL: https://github.com/apache/kafka/pull/9177#issuecomment-678074711 test this please This is an automated message from the Apache Git Service. To respond to the message, please log o

[GitHub] [kafka] cadonna commented on pull request #9177: KAFKA-9924: Add RocksDB metric num-entries-active-mem-table

2020-08-20 Thread GitBox
cadonna commented on pull request #9177: URL: https://github.com/apache/kafka/pull/9177#issuecomment-678075020 ok to test This is an automated message from the Apache Git Service. To respond to the message, please log on to G

[GitHub] [kafka] cadonna commented on pull request #9177: KAFKA-9924: Add RocksDB metric num-entries-active-mem-table

2020-08-20 Thread GitBox
cadonna commented on pull request #9177: URL: https://github.com/apache/kafka/pull/9177#issuecomment-678075215 test this please This is an automated message from the Apache Git Service. To respond to the message, please log o

[GitHub] [kafka] tombentley commented on pull request #9136: KAFKA-10211: Add DirectoryConfigProvider

2020-08-21 Thread GitBox
tombentley commented on pull request #9136: URL: https://github.com/apache/kafka/pull/9136#issuecomment-678105023 @mimaison fixed. This is an automated message from the Apache Git Service. To respond to the message, please lo

[GitHub] [kafka] mimaison commented on pull request #9136: KAFKA-10211: Add DirectoryConfigProvider

2020-08-21 Thread GitBox
mimaison commented on pull request #9136: URL: https://github.com/apache/kafka/pull/9136#issuecomment-678131966 ok to test This is an automated message from the Apache Git Service. To respond to the message, please log on to

[GitHub] [kafka] mimaison commented on pull request #9136: KAFKA-10211: Add DirectoryConfigProvider

2020-08-21 Thread GitBox
mimaison commented on pull request #9136: URL: https://github.com/apache/kafka/pull/9136#issuecomment-678132390 ok to test This is an automated message from the Apache Git Service. To respond to the message, please log on to

[GitHub] [kafka] mimaison commented on pull request #9136: KAFKA-10211: Add DirectoryConfigProvider

2020-08-21 Thread GitBox
mimaison commented on pull request #9136: URL: https://github.com/apache/kafka/pull/9136#issuecomment-678140872 retest this please This is an automated message from the Apache Git Service. To respond to the message, please lo

[GitHub] [kafka] cadonna commented on pull request #9177: KAFKA-9924: Add RocksDB metric num-entries-active-mem-table

2020-08-21 Thread GitBox
cadonna commented on pull request #9177: URL: https://github.com/apache/kafka/pull/9177#issuecomment-678269275 test this please This is an automated message from the Apache Git Service. To respond to the message, please log o

[GitHub] [kafka] mumrah merged pull request #7222: KAFKA-8806 Reduce calls to validateOffsetsIfNeeded

2020-08-21 Thread GitBox
mumrah merged pull request #7222: URL: https://github.com/apache/kafka/pull/7222 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the

[GitHub] [kafka] jolshan opened a new pull request #9205: MINOR: Fix typo in example

2020-08-21 Thread GitBox
jolshan opened a new pull request #9205: URL: https://github.com/apache/kafka/pull/9205 The ducker-ak test example includes a file path that does not exist. I fixed to be the correct path. This is an automated message from t

[GitHub] [kafka] ableegoldman commented on pull request #8834: MINOR: Do not disable heartbeat during Rebalance

2020-08-21 Thread GitBox
ableegoldman commented on pull request #8834: URL: https://github.com/apache/kafka/pull/8834#issuecomment-678432871 Hey @guozhangwang , any progress on this? This is an automated message from the Apache Git Service. To respon

[GitHub] [kafka] omkreddy merged pull request #9205: MINOR: Fix typo in example

2020-08-21 Thread GitBox
omkreddy merged pull request #9205: URL: https://github.com/apache/kafka/pull/9205 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to t

[GitHub] [kafka] mjsax commented on pull request #9204: KAFKA-6181 Examining log messages with {{--deep-iteration}} should show superset of fields

2020-08-21 Thread GitBox
mjsax commented on pull request #9204: URL: https://github.com/apache/kafka/pull/9204#issuecomment-678445541 Call for review @hachikuji @cmccabe (seem to be an easy one) This is an automated message from the Apache Git Servic

[GitHub] [kafka] mjsax commented on a change in pull request #9121: KAFKA-10351: add tests for IOExceptions for GlobalStateManagerImpl/OffsetCheckpoint

2020-08-21 Thread GitBox
mjsax commented on a change in pull request #9121: URL: https://github.com/apache/kafka/pull/9121#discussion_r474877105 ## File path: streams/src/test/java/org/apache/kafka/streams/processor/internals/GlobalStateManagerImplTest.java ## @@ -180,6 +183,27 @@ public void shouldRe

[GitHub] [kafka] mjsax commented on pull request #9064: KAFKA-10205: Documentation and handling of non deterministic Topologies

2020-08-21 Thread GitBox
mjsax commented on pull request #9064: URL: https://github.com/apache/kafka/pull/9064#issuecomment-678450380 Retest this please. This is an automated message from the Apache Git Service. To respond to the message, please log

[GitHub] [kafka] mjsax commented on a change in pull request #9000: KAFKA-10036 Improve handling and documentation of Suppliers

2020-08-21 Thread GitBox
mjsax commented on a change in pull request #9000: URL: https://github.com/apache/kafka/pull/9000#discussion_r474886689 ## File path: streams/src/test/java/org/apache/kafka/streams/processor/internals/InternalTopologyBuilderTest.java ## @@ -175,6 +177,12 @@ public void testAdd

[GitHub] [kafka] mjsax commented on a change in pull request #9000: KAFKA-10036 Improve handling and documentation of Suppliers

2020-08-21 Thread GitBox
mjsax commented on a change in pull request #9000: URL: https://github.com/apache/kafka/pull/9000#discussion_r474887535 ## File path: streams/src/test/java/org/apache/kafka/streams/kstream/internals/KStreamImplTest.java ## @@ -1865,6 +1865,17 @@ public void shouldNotAllowNull

[GitHub] [kafka] mjsax commented on pull request #9000: KAFKA-10036 Improve handling and documentation of Suppliers

2020-08-21 Thread GitBox
mjsax commented on pull request #9000: URL: https://github.com/apache/kafka/pull/9000#issuecomment-678452210 Retest this please. This is an automated message from the Apache Git Service. To respond to the message, please log

[GitHub] [kafka] abbccdda commented on pull request #9161: KAFKA-10385 - Remove no print stat when on detailed stat mode on Consumer Perf

2020-08-21 Thread GitBox
abbccdda commented on pull request #9161: URL: https://github.com/apache/kafka/pull/9161#issuecomment-678454054 @ijuma Do we have any possible dependency on the consumer performance stats? I personally think the change is safe, just want to double check. --

[GitHub] [kafka] abbccdda commented on a change in pull request #9102: KAFKA-10326 Both serializer and deserializer should be able to see th…

2020-08-21 Thread GitBox
abbccdda commented on a change in pull request #9102: URL: https://github.com/apache/kafka/pull/9102#discussion_r474892245 ## File path: clients/src/test/java/org/apache/kafka/clients/consumer/KafkaConsumerTest.java ## @@ -2511,4 +2511,39 @@ public void testEnforceRebalanceTr

[GitHub] [kafka] mjsax commented on pull request #9186: KAFKA-10277: Allow null keys with non-null mappedKey in KStreamKGlobalTable join

2020-08-21 Thread GitBox
mjsax commented on pull request #9186: URL: https://github.com/apache/kafka/pull/9186#issuecomment-678455265 Thanks for the PR @JoelWee -- Not exactly sure what NPE test you have in mind, but feel free to add a new test class `src/test/java/org/apache/kafka/streams/kstream/internals/KStrea

[GitHub] [kafka] mjsax commented on pull request #9186: KAFKA-10277: Allow null keys with non-null mappedKey in KStreamKGlobalTable join

2020-08-21 Thread GitBox
mjsax commented on pull request #9186: URL: https://github.com/apache/kafka/pull/9186#issuecomment-678455951 @ableegoldman Can you help to review? This is an automated message from the Apache Git Service. To respond to the me

[GitHub] [kafka] mjsax merged pull request #9028: KAFKA-10035: Safer conversion of consumer timeout parameters

2020-08-21 Thread GitBox
mjsax merged pull request #9028: URL: https://github.com/apache/kafka/pull/9028 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the

[GitHub] [kafka] mjsax commented on pull request #9028: KAFKA-10035: Safer conversion of consumer timeout parameters

2020-08-21 Thread GitBox
mjsax commented on pull request #9028: URL: https://github.com/apache/kafka/pull/9028#issuecomment-678457711 Thanks for the patch @serjchebotarev! Merged to `trunk`. This is an automated message from the Apache Git Service. T

[GitHub] [kafka] vvcephei commented on a change in pull request #8955: KAFKA-10020: Create a new version of a scala Serdes without name clash (KIP-616)

2020-08-21 Thread GitBox
vvcephei commented on a change in pull request #8955: URL: https://github.com/apache/kafka/pull/8955#discussion_r474898311 ## File path: streams/streams-scala/src/main/scala/org/apache/kafka/streams/scala/Serdes.scala ## @@ -24,6 +24,7 @@ import java.util import org.apache.ka

[GitHub] [kafka] mjsax merged pull request #9146: KAFKA-10316 Updated Kafka Streams upgrade-guide.html

2020-08-21 Thread GitBox
mjsax merged pull request #9146: URL: https://github.com/apache/kafka/pull/9146 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the

[GitHub] [kafka] mjsax commented on pull request #9146: KAFKA-10316 Updated Kafka Streams upgrade-guide.html

2020-08-21 Thread GitBox
mjsax commented on pull request #9146: URL: https://github.com/apache/kafka/pull/9146#issuecomment-678459181 Thanks for the PR @johnthotekat! -- Merged to `trunk`. Congrats to completing KIP-648. This is an automated m

[GitHub] [kafka] mumrah commented on a change in pull request #9100: Add AlterISR RPC and use it for ISR modifications

2020-08-21 Thread GitBox
mumrah commented on a change in pull request #9100: URL: https://github.com/apache/kafka/pull/9100#discussion_r474930329 ## File path: core/src/main/scala/kafka/server/AlterIsrChannelManager.scala ## @@ -0,0 +1,132 @@ +package kafka.server + +import java.util +import java.util.

[GitHub] [kafka] mumrah commented on a change in pull request #9100: Add AlterISR RPC and use it for ISR modifications

2020-08-21 Thread GitBox
mumrah commented on a change in pull request #9100: URL: https://github.com/apache/kafka/pull/9100#discussion_r474934833 ## File path: core/src/main/scala/kafka/server/AlterIsrChannelManager.scala ## @@ -0,0 +1,132 @@ +package kafka.server + +import java.util +import java.util.

[GitHub] [kafka] ableegoldman commented on a change in pull request #9186: KAFKA-10277: Allow null keys with non-null mappedKey in KStreamKGlobalTable join

2020-08-21 Thread GitBox
ableegoldman commented on a change in pull request #9186: URL: https://github.com/apache/kafka/pull/9186#discussion_r474931289 ## File path: streams/src/main/java/org/apache/kafka/streams/kstream/internals/KStreamKTableJoinProcessor.java ## @@ -58,29 +60,46 @@ public void init

[GitHub] [kafka] soarez commented on a change in pull request #9000: KAFKA-10036 Improve handling and documentation of Suppliers

2020-08-21 Thread GitBox
soarez commented on a change in pull request #9000: URL: https://github.com/apache/kafka/pull/9000#discussion_r474950526 ## File path: streams/src/test/java/org/apache/kafka/streams/kstream/internals/KStreamImplTest.java ## @@ -1865,6 +1865,17 @@ public void shouldNotAllowNul

[GitHub] [kafka] rondagostino commented on a change in pull request #9032: KAFKA-10259: KIP-554 Broker-side SCRAM Config API

2020-08-21 Thread GitBox
rondagostino commented on a change in pull request #9032: URL: https://github.com/apache/kafka/pull/9032#discussion_r474950597 ## File path: clients/src/main/java/org/apache/kafka/clients/admin/DescribeUserScramCredentialsResult.java ## @@ -0,0 +1,50 @@ +/* + * Licensed to the

[GitHub] [kafka] mumrah commented on a change in pull request #9100: Add AlterISR RPC and use it for ISR modifications

2020-08-21 Thread GitBox
mumrah commented on a change in pull request #9100: URL: https://github.com/apache/kafka/pull/9100#discussion_r474934833 ## File path: core/src/main/scala/kafka/server/AlterIsrChannelManager.scala ## @@ -0,0 +1,132 @@ +package kafka.server + +import java.util +import java.util.

[GitHub] [kafka] mumrah commented on a change in pull request #9100: Add AlterISR RPC and use it for ISR modifications

2020-08-21 Thread GitBox
mumrah commented on a change in pull request #9100: URL: https://github.com/apache/kafka/pull/9100#discussion_r474959176 ## File path: core/src/main/scala/kafka/server/AlterIsrChannelManager.scala ## @@ -0,0 +1,132 @@ +package kafka.server + +import java.util +import java.util.

[GitHub] [kafka] ableegoldman commented on a change in pull request #9039: KAFKA-5636: SlidingWindows (KIP-450)

2020-08-21 Thread GitBox
ableegoldman commented on a change in pull request #9039: URL: https://github.com/apache/kafka/pull/9039#discussion_r474966465 ## File path: streams/src/test/java/org/apache/kafka/streams/kstream/internals/KStreamSlidingWindowAggregateTest.java ## @@ -0,0 +1,579 @@ +/* + * Lic

[GitHub] [kafka] ableegoldman commented on a change in pull request #9039: KAFKA-5636: SlidingWindows (KIP-450)

2020-08-21 Thread GitBox
ableegoldman commented on a change in pull request #9039: URL: https://github.com/apache/kafka/pull/9039#discussion_r474977836 ## File path: streams/src/test/java/org/apache/kafka/streams/kstream/internals/KStreamSlidingWindowAggregateTest.java ## @@ -0,0 +1,579 @@ +/* + * Lic

[GitHub] [kafka] abbccdda commented on a change in pull request #8846: KAFKA-9800: [KIP-580] Client Exponential Backoff Implementation

2020-08-21 Thread GitBox
abbccdda commented on a change in pull request #8846: URL: https://github.com/apache/kafka/pull/8846#discussion_r474843042 ## File path: clients/src/main/java/org/apache/kafka/clients/CommonClientConfigs.java ## @@ -84,6 +84,14 @@ public static final String RETRY_BACKOF

[GitHub] [kafka] ableegoldman commented on a change in pull request #9138: KAFKA-9929: Support backward iterator on WindowStore

2020-08-21 Thread GitBox
ableegoldman commented on a change in pull request #9138: URL: https://github.com/apache/kafka/pull/9138#discussion_r475014135 ## File path: streams/src/main/java/org/apache/kafka/streams/state/internals/AbstractRocksDBSegmentedBytesStore.java ## @@ -72,22 +86,40 @@

[GitHub] [kafka] vvcephei commented on pull request #9137: KAFKA-9929: Support reverse iterator on KeyValueStore

2020-08-21 Thread GitBox
vvcephei commented on pull request #9137: URL: https://github.com/apache/kafka/pull/9137#issuecomment-678575081 It looks like java 14 only failed while attempting to download some docs from Oracle, and java 8 failed on this unrelated test: `org.apache.kafka.clients.admin.KafkaAdminClientTe

[GitHub] [kafka] vvcephei merged pull request #9137: KAFKA-9929: Support reverse iterator on KeyValueStore

2020-08-21 Thread GitBox
vvcephei merged pull request #9137: URL: https://github.com/apache/kafka/pull/9137 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to t

[GitHub] [kafka] chia7712 commented on a change in pull request #9102: KAFKA-10326 Both serializer and deserializer should be able to see th…

2020-08-21 Thread GitBox
chia7712 commented on a change in pull request #9102: URL: https://github.com/apache/kafka/pull/9102#discussion_r475041700 ## File path: clients/src/test/java/org/apache/kafka/clients/consumer/KafkaConsumerTest.java ## @@ -2511,4 +2511,39 @@ public void testEnforceRebalanceTr

[GitHub] [kafka] chia7712 commented on pull request #9182: KAFKA-10403 Replace scala collection by java collection in generating…

2020-08-21 Thread GitBox
chia7712 commented on pull request #9182: URL: https://github.com/apache/kafka/pull/9182#issuecomment-678589736 failed tests pass on my local This is an automated message from the Apache Git Service. To respond to the message

[GitHub] [kafka] chia7712 commented on pull request #9162: MINOR: refactor Log to get rid of "return" in nested anonymous function

2020-08-21 Thread GitBox
chia7712 commented on pull request #9162: URL: https://github.com/apache/kafka/pull/9162#issuecomment-678590561 ```testMetadataRetries``` is traced by #9091 This is an automated message from the Apache Git Service. To respond

[GitHub] [kafka] chia7712 edited a comment on pull request #9162: MINOR: refactor Log to get rid of "return" in nested anonymous function

2020-08-21 Thread GitBox
chia7712 edited a comment on pull request #9162: URL: https://github.com/apache/kafka/pull/9162#issuecomment-678590561 ```testMetadataRetries``` is traced by #9091 ```DynamicConnectionQuotaTest.testDynamicListenerConnectionCreationRateQuota``` pass on my local

[GitHub] [kafka] ijuma commented on pull request #9202: KAFKA-10401: Fix the currentStateTimeStamp doesn't get set correctly

2020-08-21 Thread GitBox
ijuma commented on pull request #9202: URL: https://github.com/apache/kafka/pull/9202#issuecomment-678594470 ok to test This is an automated message from the Apache Git Service. To respond to the message, please log on to Git

[GitHub] [kafka] ijuma commented on a change in pull request #9202: KAFKA-10401: Fix the currentStateTimeStamp doesn't get set correctly

2020-08-21 Thread GitBox
ijuma commented on a change in pull request #9202: URL: https://github.com/apache/kafka/pull/9202#discussion_r475046516 ## File path: core/src/main/scala/kafka/coordinator/group/GroupMetadataManager.scala ## @@ -1401,16 +1401,17 @@ object GroupMetadataManager { val vers

[GitHub] [kafka] chia7712 opened a new pull request #9206: MINOR: rewrite zipWithIndex by normal foreach to refrain unnecessary …

2020-08-22 Thread GitBox
chia7712 opened a new pull request #9206: URL: https://github.com/apache/kafka/pull/9206 steal some memory back from hot method :) ### Committer Checklist (excluded from commit message) - [ ] Verify design and implementation - [ ] Verify test coverage and CI build status

[GitHub] [kafka] khaireddine120 opened a new pull request #9207: Minor remove semicolon

2020-08-22 Thread GitBox
khaireddine120 opened a new pull request #9207: URL: https://github.com/apache/kafka/pull/9207 *More detailed description of your change, if necessary. The PR title and PR message become the squashed commit message, so use a separate comment to ping reviewers.* *Summary of te

[GitHub] [kafka] khaireddine120 opened a new pull request #9208: Minor init singleton list

2020-08-22 Thread GitBox
khaireddine120 opened a new pull request #9208: URL: https://github.com/apache/kafka/pull/9208 *More detailed description of your change, if necessary. The PR title and PR message become the squashed commit message, so use a separate comment to ping reviewers.* *Summary of te

[GitHub] [kafka] khaireddine120 opened a new pull request #9209: Minor enhance copy array

2020-08-22 Thread GitBox
khaireddine120 opened a new pull request #9209: URL: https://github.com/apache/kafka/pull/9209 *More detailed description of your change, if necessary. The PR title and PR message become the squashed commit message, so use a separate comment to ping reviewers.* *Summary of te

[GitHub] [kafka] ivandasch commented on a change in pull request #9196: [WIP] KAFKA-10402: Upgrade system tests to python3

2020-08-22 Thread GitBox
ivandasch commented on a change in pull request #9196: URL: https://github.com/apache/kafka/pull/9196#discussion_r475086470 ## File path: tests/kafkatest/benchmarks/core/benchmark_test.py ## @@ -88,7 +88,7 @@ def test_producer_throughput(self, acks, topic, num_producers=1, mes

[GitHub] [kafka] ivandasch commented on a change in pull request #9196: [WIP] KAFKA-10402: Upgrade system tests to python3

2020-08-22 Thread GitBox
ivandasch commented on a change in pull request #9196: URL: https://github.com/apache/kafka/pull/9196#discussion_r475088577 ## File path: tests/kafkatest/version.py ## @@ -49,6 +49,34 @@ def __str__(self): else: return LooseVersion.__str__(self) +def

[GitHub] [kafka] badaiaqrandista commented on pull request #9099: KAFKA-6733: Printing additional ConsumerRecord fields in DefaultMessageFormatter

2020-08-22 Thread GitBox
badaiaqrandista commented on pull request #9099: URL: https://github.com/apache/kafka/pull/9099#issuecomment-678641314 @bbejeck Thank you for including the changes in the test. I've fixed the errors found by the test. Please test again.

[GitHub] [kafka] mimaison commented on pull request #9136: KAFKA-10211: Add DirectoryConfigProvider

2020-08-22 Thread GitBox
mimaison commented on pull request #9136: URL: https://github.com/apache/kafka/pull/9136#issuecomment-678651902 Test failures are not related, merging This is an automated message from the Apache Git Service. To respond to th

[GitHub] [kafka] mimaison merged pull request #9136: KAFKA-10211: Add DirectoryConfigProvider

2020-08-22 Thread GitBox
mimaison merged pull request #9136: URL: https://github.com/apache/kafka/pull/9136 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to t

[GitHub] [kafka] mimaison merged pull request #9131: KAFKA-10367: Allow running the Streams demo app with a config file

2020-08-22 Thread GitBox
mimaison merged pull request #9131: URL: https://github.com/apache/kafka/pull/9131 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to t

[GitHub] [kafka] lbradstreet commented on a change in pull request #9129: MINOR: Update jmh to 1.24 for async profiler support

2020-08-22 Thread GitBox
lbradstreet commented on a change in pull request #9129: URL: https://github.com/apache/kafka/pull/9129#discussion_r475106000 ## File path: README.md ## @@ -199,6 +199,27 @@ You can run spotbugs using: The spotbugs warnings will be found in `reports/spotbugs/main.html` and `r

[GitHub] [kafka] lbradstreet commented on pull request #9129: MINOR: Update jmh to 1.24 for async profiler support

2020-08-22 Thread GitBox
lbradstreet commented on pull request #9129: URL: https://github.com/apache/kafka/pull/9129#issuecomment-678660654 @ijuma the text mode output here looks good however it would be good to include instructions for producing an svg flamegraph if possible. Do you know if we can do that?

[GitHub] [kafka] ijuma commented on pull request #9206: MINOR: rewrite zipWithIndex by normal foreach to refrain unnecessary …

2020-08-22 Thread GitBox
ijuma commented on pull request #9206: URL: https://github.com/apache/kafka/pull/9206#issuecomment-678662885 @chia7712 Do you have any data on the improvement this achieves? This is an automated message from the Apache Git Se

[GitHub] [kafka] ijuma commented on pull request #9206: MINOR: rewrite zipWithIndex by normal foreach to refrain unnecessary …

2020-08-22 Thread GitBox
ijuma commented on pull request #9206: URL: https://github.com/apache/kafka/pull/9206#issuecomment-678663003 Generally, the tuples allocated here (if not elided by the optimizer) would be pretty tiny compared to allocating the buffers for the record batches. --

[GitHub] [kafka] ijuma commented on pull request #9200: MINOR: mirror integration tests should not call System.exit

2020-08-22 Thread GitBox
ijuma commented on pull request #9200: URL: https://github.com/apache/kafka/pull/9200#issuecomment-678666729 Ok to test This is an automated message from the Apache Git Service. To respond to the message, please log on to Git

[GitHub] [kafka] ivandasch commented on a change in pull request #9196: [WIP] KAFKA-10402: Upgrade system tests to python3

2020-08-22 Thread GitBox
ivandasch commented on a change in pull request #9196: URL: https://github.com/apache/kafka/pull/9196#discussion_r475086583 ## File path: tests/kafkatest/services/monitor/http.py ## @@ -154,7 +154,7 @@ def do_POST(self): name = raw_metric['name'] group

<    10   11   12   13   14   15   16   17   18   19   >