mjsax commented on a change in pull request #9000: URL: https://github.com/apache/kafka/pull/9000#discussion_r474887535
########## File path: streams/src/test/java/org/apache/kafka/streams/kstream/internals/KStreamImplTest.java ########## @@ -1865,6 +1865,17 @@ public void shouldNotAllowNullNamedOnTransformWithStoreName() { assertThat(exception.getMessage(), equalTo("named can't be null")); } + @Test + public void shouldNotAllowBadTransformerSupplierOnFlatTransform() { Review comment: Yes, those suppliers must return a new instance on `get()`, too, so the new check should be done for them as well. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org