[GitHub] [kafka] mjsax commented on a change in pull request #9156: KAFKA-10077: Filter downstream of state-store results in spurious tombstones

[GitBox]

mjsax commented on a change in pull request #9156:
URL: https://github.com/apache/kafka/pull/9156#discussion_r474361586



##########
File path: 
streams/src/test/java/org/apache/kafka/streams/StreamsBuilderTest.java
##########
@@ -123,7 +123,7 @@ public void shouldAllowJoinMaterializedFilteredKTable() {
 
         assertThat(
             topology.stateStores().size(),
-            equalTo(1));
+            equalTo(2));

Review comment:
       The issue seems to be this line: 
https://github.com/apache/kafka/blob/trunk/streams/src/main/java/org/apache/kafka/streams/kstream/internals/KTableSource.java#L67
   
   In a source-KTable, if we enable sending old values we force an 
materialization. I guess, we should have this materialization optional?
   
   I would recommend to rename `enableSendingOldValues()` to 
`maybeEnableSendingOldValues(final boolean forceMaterialization)` or similar?
   
   \cc @guozhangwang WDYT?




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org