mjsax commented on pull request #9156: URL: https://github.com/apache/kafka/pull/9156#issuecomment-677982605
> Where as previously the user could choose to 'fix' the bad semantics by manually calling enableSendingOldValues themselves, if they cared. That is not entirely correct. `enableSendingOldValues` is _not_ part of the public `KTable` interface but only a method of the internal `KTableImpl` class. Thus, users don't not really have the ability to enable it. > Might it be better to only enable the sending of old values if the source table is already materialized? This seems to be the "right" fix from my point of view. Note, that people can force an upstream materialization via `Materialized.as()`, and thus the impact is quite clear and it's public API that allows user to opt-in for this optimization. (When we discussed in person, I alway assumed we would implement it this way). -- Doing it this way is also a non-breaking change and thus no backward compatibility concern raise. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
